Re: [PATCH v5 08/25] dt-bindings: clock: mediatek: Add MT8189 system/base clocks and resets

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `if` conditional block checking `compatible` strings in `mediatek,mt8186-clock.yaml` is missing the `contains:` keyword, which causes the condition to always fail.
--

--- Patch [8]: [PATCH v5 08/25] dt-bindings: clock: mediatek: Add MT8189 system/base clocks and resets ---
commit 58f0ae2ed060320d3d6921afeb65e04b05e09665
Author: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>

dt-bindings: clock: mediatek: Add MT8189 system/base clocks and resets

This commit adds compatible strings and binding headers for the system and 
base clock controllers, as well as reset controllers for the MediaTek MT8189 
SoC. It also adds compatibles for frequency hopping and spread spectrum 
clock functionality.

> diff --git a/Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml b/Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml
> index ab9f8cb7dd6ee..380dab8f4e983 100644
> --- a/Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml
[ ... ]
> @@ -133,6 +146,8 @@ allOf:
>              - mediatek,mt8188-imgsys1-dip-nr
>              - mediatek,mt8188-imgsys1-dip-top
>              - mediatek,mt8188-ipesys
> +            - mediatek,mt8189-ufscfg-ao
> +            - mediatek,mt8189-ufscfg-pdn

[Severity: Medium]
Is the conditional block wrapping this list missing a `contains:` keyword 
before the `enum:`?

Because `compatible` strings are arrays in the device tree, comparing them 
directly to a scalar string list using `enum:` will always evaluate to false. 

As a result, the requirement for `#reset-cells` will not be enforced for 
these newly added hardware variants, allowing incomplete device tree nodes 
to silently pass schema validation.

>      then:
>        required:
>          - '#reset-cells'

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260801-mt8189-clocks-system-base-v5-0-ac4410697cc2@collabora.com?part=8