* [PATCH 01/28] dt-bindings: phy: qcom: Describe QMP USB and UFS PHY vdda-phy/vdda-pll voltages
2026-08-03 6:33 [PATCH 00/28] arm64: dts: qcom: Fix swapped QMP PHY vdda-phy/vdda-pll supplies Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:33 ` Manivannan Sadhasivam via B4 Relay
2026-08-04 8:36 ` Krzysztof Kozlowski
2026-08-03 6:34 ` [PATCH 02/28] arm64: dts: qcom: sc8280xp-blackrock: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies Manivannan Sadhasivam via B4 Relay
` (27 subsequent siblings)
28 siblings, 1 reply; 48+ messages in thread
From: Manivannan Sadhasivam via B4 Relay @ 2026-08-03 6:33 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Krzysztof Kozlowski, Manivannan Sadhasivam,
Manivannan Sadhasivam
From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
The vdda-phy and vdda-pll supplies of the QMP USB and UFS PHYs are
frequently swapped in devicetrees, as the naming does not make clear
which supply expects which voltage. Document that vdda-phy is around
0.8V and vdda-pll is around 1.2V, with the exact voltage varying per
SoC, so that the correct supplies can be assigned.
Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Assisted-by: Claude:opus-4-8
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
---
.../devicetree/bindings/phy/qcom,msm8998-qmp-usb3-phy.yaml | 10 ++++++++--
.../devicetree/bindings/phy/qcom,qcs615-qmp-usb3dp-phy.yaml | 10 ++++++++--
.../devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml | 12 +++++++++---
.../bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml | 12 +++++++++---
.../bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml | 10 ++++++++--
5 files changed, 42 insertions(+), 12 deletions(-)
diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8998-qmp-usb3-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8998-qmp-usb3-phy.yaml
index 1636285fbe53..4cbcf54aef2c 100644
--- a/Documentation/devicetree/bindings/phy/qcom,msm8998-qmp-usb3-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,msm8998-qmp-usb3-phy.yaml
@@ -39,9 +39,15 @@ properties:
- const: phy
- const: phy_phy
- vdda-phy-supply: true
+ vdda-phy-supply:
+ description:
+ Supply for the PHY, typically around 0.8V, though the exact voltage
+ varies per SoC.
- vdda-pll-supply: true
+ vdda-pll-supply:
+ description:
+ Supply for the PLL, typically around 1.2V, though the exact voltage
+ varies per SoC.
"#clock-cells":
const: 0
diff --git a/Documentation/devicetree/bindings/phy/qcom,qcs615-qmp-usb3dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qcs615-qmp-usb3dp-phy.yaml
index efb465c71c1b..9dbe49afaa6c 100644
--- a/Documentation/devicetree/bindings/phy/qcom,qcs615-qmp-usb3dp-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,qcs615-qmp-usb3dp-phy.yaml
@@ -40,9 +40,15 @@ properties:
- const: phy_phy
- const: dp_phy
- vdda-phy-supply: true
+ vdda-phy-supply:
+ description:
+ Supply for the PHY, typically around 0.8V, though the exact voltage
+ varies per SoC.
- vdda-pll-supply: true
+ vdda-pll-supply:
+ description:
+ Supply for the PLL, typically around 1.2V, though the exact voltage
+ varies per SoC.
"#clock-cells":
const: 1
diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
index b2c5c9a375a3..968a700d2a55 100644
--- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml
@@ -81,9 +81,15 @@ properties:
items:
- const: ufsphy
- vdda-phy-supply: true
-
- vdda-pll-supply: true
+ vdda-phy-supply:
+ description:
+ Supply for the PHY, typically around 0.8V, though the exact voltage
+ varies per SoC.
+
+ vdda-pll-supply:
+ description:
+ Supply for the PLL, typically around 1.2V, though the exact voltage
+ varies per SoC.
"#clock-cells":
const: 1
diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
index 01342823e57f..532afa116ba0 100644
--- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
@@ -64,9 +64,15 @@ properties:
- const: phy
- const: phy_phy
- vdda-phy-supply: true
-
- vdda-pll-supply: true
+ vdda-phy-supply:
+ description:
+ Supply for the PHY, typically around 0.8V, though the exact voltage
+ varies per SoC.
+
+ vdda-pll-supply:
+ description:
+ Supply for the PLL, typically around 1.2V, though the exact voltage
+ varies per SoC.
refgen-supply: true
diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
index 4eff92343ce4..865395fe1416 100644
--- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
@@ -69,9 +69,15 @@ properties:
- const: phy
- const: common
- vdda-phy-supply: true
+ vdda-phy-supply:
+ description:
+ Supply for the PHY, typically around 0.8V, though the exact voltage
+ varies per SoC.
- vdda-pll-supply: true
+ vdda-pll-supply:
+ description:
+ Supply for the PLL, typically around 1.2V, though the exact voltage
+ varies per SoC.
refgen-supply: true
--
2.43.0
^ permalink raw reply related [flat|nested] 48+ messages in thread* Re: [PATCH 01/28] dt-bindings: phy: qcom: Describe QMP USB and UFS PHY vdda-phy/vdda-pll voltages
2026-08-03 6:33 ` [PATCH 01/28] dt-bindings: phy: qcom: Describe QMP USB and UFS PHY vdda-phy/vdda-pll voltages Manivannan Sadhasivam via B4 Relay
@ 2026-08-04 8:36 ` Krzysztof Kozlowski
0 siblings, 0 replies; 48+ messages in thread
From: Krzysztof Kozlowski @ 2026-08-04 8:36 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Konrad Dybcio, linux-arm-msm, devicetree,
linux-kernel, Krzysztof Kozlowski, Manivannan Sadhasivam
On Mon, Aug 03, 2026 at 08:33:59AM +0200, Manivannan Sadhasivam wrote:
> The vdda-phy and vdda-pll supplies of the QMP USB and UFS PHYs are
> frequently swapped in devicetrees, as the naming does not make clear
> which supply expects which voltage. Document that vdda-phy is around
> 0.8V and vdda-pll is around 1.2V, with the exact voltage varying per
> SoC, so that the correct supplies can be assigned.
>
> Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Assisted-by: Claude:opus-4-8
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
> ---
> .../devicetree/bindings/phy/qcom,msm8998-qmp-usb3-phy.yaml | 10 ++++++++--
> .../devicetree/bindings/phy/qcom,qcs615-qmp-usb3dp-phy.yaml | 10 ++++++++--
> .../devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml | 12 +++++++++---
> .../bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml | 12 +++++++++---
> .../bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml | 10 ++++++++--
> 5 files changed, 42 insertions(+), 12 deletions(-)
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 02/28] arm64: dts: qcom: sc8280xp-blackrock: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:33 [PATCH 00/28] arm64: dts: qcom: Fix swapped QMP PHY vdda-phy/vdda-pll supplies Manivannan Sadhasivam via B4 Relay
2026-08-03 6:33 ` [PATCH 01/28] dt-bindings: phy: qcom: Describe QMP USB and UFS PHY vdda-phy/vdda-pll voltages Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:34 ` Manivannan Sadhasivam via B4 Relay
2026-08-03 6:44 ` sashiko-bot
2026-08-03 6:34 ` [PATCH 03/28] arm64: dts: qcom: sa8540p: " Manivannan Sadhasivam via B4 Relay
` (26 subsequent siblings)
28 siblings, 1 reply; 48+ messages in thread
From: Manivannan Sadhasivam via B4 Relay @ 2026-08-03 6:34 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Krzysztof Kozlowski, Manivannan Sadhasivam,
Manivannan Sadhasivam
From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
The QMP PHY expects the vdda-phy supply to be around 0.88V and the
vdda-pll supply to be 1.2V. But these two supplies are swapped for the
USB QMP PHYs on this board, feeding 1.2V to vdda-phy and 0.9V to
vdda-pll.
Fix it by swapping the two supplies back.
Fixes: 16a7fed11714 ("arm64: dts: qcom: sc8280xp-blackrock: dt definition for WDK2023")
Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Assisted-by: Claude:opus-4-8
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/sc8280xp-microsoft-blackrock.dts | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-blackrock.dts b/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-blackrock.dts
index 125af356e24b..4e74eda7405f 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-blackrock.dts
+++ b/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-blackrock.dts
@@ -1003,8 +1003,8 @@ &usb_0_hsphy {
};
&usb_0_qmpphy {
- vdda-phy-supply = <&vreg_l4d>;
- vdda-pll-supply = <&vreg_l9d>;
+ vdda-phy-supply = <&vreg_l9d>;
+ vdda-pll-supply = <&vreg_l4d>;
orientation-switch;
@@ -1040,8 +1040,8 @@ &usb_1_hsphy {
};
&usb_1_qmpphy {
- vdda-phy-supply = <&vreg_l3b>;
- vdda-pll-supply = <&vreg_l4b>;
+ vdda-phy-supply = <&vreg_l4b>;
+ vdda-pll-supply = <&vreg_l3b>;
orientation-switch;
--
2.43.0
^ permalink raw reply related [flat|nested] 48+ messages in thread* Re: [PATCH 02/28] arm64: dts: qcom: sc8280xp-blackrock: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:34 ` [PATCH 02/28] arm64: dts: qcom: sc8280xp-blackrock: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:44 ` sashiko-bot
0 siblings, 0 replies; 48+ messages in thread
From: sashiko-bot @ 2026-08-03 6:44 UTC (permalink / raw)
To: Manivannan Sadhasivam; +Cc: robh, conor+dt, devicetree
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] The DP and PCIe QMP PHYs in the blackrock device tree suffer from the same swapped voltage supply bug that the commit fixes for the USB PHYs.
--
--- Patch [2]: [PATCH 02/28] arm64: dts: qcom: sc8280xp-blackrock: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies ---
commit 2ff4552e01c34fa2dc6f9a24da3173abd76e8b38
Author: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
arm64: dts: qcom: sc8280xp-blackrock: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
The QMP PHY expects the vdda-phy supply to be around 0.88V and the
vdda-pll supply to be 1.2V. But these two supplies are swapped for the
USB QMP PHYs on this board, feeding 1.2V to vdda-phy and 0.9V to
vdda-pll. This commit fixes the issue by swapping the two supplies back.
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-blackrock.dts b/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-blackrock.dts
> index 125af356e24b9..4e74eda7405f3 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-blackrock.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-blackrock.dts
[ ... ]
> @@ -1040,8 +1040,8 @@ &usb_1_hsphy {
> };
>
> &usb_1_qmpphy {
> - vdda-phy-supply = <&vreg_l3b>;
> - vdda-pll-supply = <&vreg_l4b>;
> + vdda-phy-supply = <&vreg_l4b>;
> + vdda-pll-supply = <&vreg_l3b>;
>
> orientation-switch;
>
[Severity: High]
This is a pre-existing issue, but it looks like the DP and PCIe QMP PHYs in
this file suffer from the same swapped voltage supply bug.
For example, in the mdss0_dp2_phy node, vreg_l3b (1.2V) is used for vdda-phy
and vreg_l6b (0.88V) is used for vdda-pll:
vdda-phy-supply = <&vreg_l3b>;
vdda-pll-supply = <&vreg_l6b>;
Similarly, the pcie2a_phy and pcie4_phy nodes both incorrectly use vreg_l4d
(1.2V) for vdda-phy and vreg_l6d (0.88V) for vdda-pll:
vdda-phy-supply = <&vreg_l4d>;
vdda-pll-supply = <&vreg_l6d>;
Operating these PHYs with the swapped voltages might cause hardware
instability or functional failures. Should these nodes also be updated to
fix the swapped supplies?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260803-phy-supply-fix-v1-0-5880630cde3e@oss.qualcomm.com?part=2
^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 03/28] arm64: dts: qcom: sa8540p: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:33 [PATCH 00/28] arm64: dts: qcom: Fix swapped QMP PHY vdda-phy/vdda-pll supplies Manivannan Sadhasivam via B4 Relay
2026-08-03 6:33 ` [PATCH 01/28] dt-bindings: phy: qcom: Describe QMP USB and UFS PHY vdda-phy/vdda-pll voltages Manivannan Sadhasivam via B4 Relay
2026-08-03 6:34 ` [PATCH 02/28] arm64: dts: qcom: sc8280xp-blackrock: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:34 ` Manivannan Sadhasivam via B4 Relay
2026-08-03 6:46 ` sashiko-bot
2026-08-03 6:34 ` [PATCH 04/28] arm64: dts: qcom: sdm845: " Manivannan Sadhasivam via B4 Relay
` (25 subsequent siblings)
28 siblings, 1 reply; 48+ messages in thread
From: Manivannan Sadhasivam via B4 Relay @ 2026-08-03 6:34 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Krzysztof Kozlowski, Manivannan Sadhasivam,
Manivannan Sadhasivam
From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
The QMP PHY expects the vdda-phy supply to be around 0.88V and the
vdda-pll supply to be 1.2V. But these two supplies are swapped for the
USB QMP PHYs on these boards, feeding 1.2V to vdda-phy and 0.9V to
vdda-pll.
Fix it by swapping the two supplies back.
Fixes: 519183af39b2 ("arm64: dts: qcom: add SA8540P and ADP")
Fixes: 6be310347c9c ("arm64: dts: qcom: add SA8540P ride(Qdrive-3)")
Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Assisted-by: Claude:opus-4-8
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/sa8295p-adp.dts | 16 ++++++++--------
arch/arm64/boot/dts/qcom/sa8540p-ride.dts | 8 ++++----
2 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sa8295p-adp.dts b/arch/arm64/boot/dts/qcom/sa8295p-adp.dts
index d28d69162427..7178ae087038 100644
--- a/arch/arm64/boot/dts/qcom/sa8295p-adp.dts
+++ b/arch/arm64/boot/dts/qcom/sa8295p-adp.dts
@@ -604,8 +604,8 @@ &usb_0_hsphy {
};
&usb_0_qmpphy {
- vdda-phy-supply = <&vreg_l3a>;
- vdda-pll-supply = <&vreg_l5a>;
+ vdda-phy-supply = <&vreg_l5a>;
+ vdda-pll-supply = <&vreg_l3a>;
status = "okay";
};
@@ -628,8 +628,8 @@ &usb_1_hsphy {
};
&usb_1_qmpphy {
- vdda-phy-supply = <&vreg_l4c>;
- vdda-pll-supply = <&vreg_l1c>;
+ vdda-phy-supply = <&vreg_l1c>;
+ vdda-pll-supply = <&vreg_l4c>;
status = "okay";
};
@@ -671,15 +671,15 @@ &usb_2_hsphy3 {
};
&usb_2_qmpphy0 {
- vdda-phy-supply = <&vreg_l3a>;
- vdda-pll-supply = <&vreg_l5a>;
+ vdda-phy-supply = <&vreg_l5a>;
+ vdda-pll-supply = <&vreg_l3a>;
status = "okay";
};
&usb_2_qmpphy1 {
- vdda-phy-supply = <&vreg_l3a>;
- vdda-pll-supply = <&vreg_l5a>;
+ vdda-phy-supply = <&vreg_l5a>;
+ vdda-pll-supply = <&vreg_l3a>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts
index 44177e9b64b5..df40c44c447e 100644
--- a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts
+++ b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts
@@ -478,8 +478,8 @@ &usb_0_hsphy {
};
&usb_0_qmpphy {
- vdda-phy-supply = <&vreg_l3a>;
- vdda-pll-supply = <&vreg_l5a>;
+ vdda-phy-supply = <&vreg_l5a>;
+ vdda-pll-supply = <&vreg_l3a>;
status = "okay";
};
@@ -493,8 +493,8 @@ &usb_2_hsphy0 {
};
&usb_2_qmpphy0 {
- vdda-phy-supply = <&vreg_l3a>;
- vdda-pll-supply = <&vreg_l5a>;
+ vdda-phy-supply = <&vreg_l5a>;
+ vdda-pll-supply = <&vreg_l3a>;
status = "okay";
};
--
2.43.0
^ permalink raw reply related [flat|nested] 48+ messages in thread* Re: [PATCH 03/28] arm64: dts: qcom: sa8540p: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:34 ` [PATCH 03/28] arm64: dts: qcom: sa8540p: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:46 ` sashiko-bot
0 siblings, 0 replies; 48+ messages in thread
From: sashiko-bot @ 2026-08-03 6:46 UTC (permalink / raw)
To: Manivannan Sadhasivam; +Cc: robh, devicetree, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] Swapped PHY and PLL regulator supplies in additional Qualcomm boards missed by patch series.
--
--- Patch [3]: [PATCH 03/28] arm64: dts: qcom: sa8540p: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies ---
commit f7f68ce606103ed03353b8e43b7fb5b5dfb4a92b
Author: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
arm64: dts: qcom: sa8540p: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
The QMP PHY expects the vdda-phy supply to be around 0.88V and the vdda-pll
supply to be 1.2V. This patch fixes an issue where these two supplies were
swapped for the USB QMP PHYs on SA8540P and SA8295P boards.
> diff --git a/arch/arm64/boot/dts/qcom/sa8295p-adp.dts b/arch/arm64/boot/dts/qcom/sa8295p-adp.dts
> index d28d691624279..7178ae087038c 100644
> --- a/arch/arm64/boot/dts/qcom/sa8295p-adp.dts
> +++ b/arch/arm64/boot/dts/qcom/sa8295p-adp.dts
> @@ -604,8 +604,8 @@ &usb_0_hsphy {
> };
>
> &usb_0_qmpphy {
> - vdda-phy-supply = <&vreg_l3a>;
> - vdda-pll-supply = <&vreg_l5a>;
> + vdda-phy-supply = <&vreg_l5a>;
> + vdda-pll-supply = <&vreg_l3a>;
[Severity: High]
This isn't a bug introduced by this patch, but while reviewing this fix I
noticed that identical swapped PHY and PLL supplies seem to exist in other
Qualcomm boards missed by this patch series.
For instance, in arch/arm64/boot/dts/qcom/sc8280xp-microsoft-blackrock.dts
for pcie2a_phy and pcie4_phy:
&pcie2a_phy {
vdda-phy-supply = <&vreg_l4d>;
vdda-pll-supply = <&vreg_l6d>;
Here 1.2V (vreg_l4d) is fed to the 0.88V vdda-phy rail and 0.88V (vreg_l6d) is
fed to the 1.2V vdda-pll rail.
Similarly, in arch/arm64/boot/dts/qcom/lemans-evk.dts (usb_0_qmpphy) and
arch/arm64/boot/dts/qcom/lemans-ride-common.dtsi (usb_0_qmpphy and
usb_1_qmpphy):
&usb_0_qmpphy {
vdda-phy-supply = <&vreg_l1c>;
vdda-pll-supply = <&vreg_l7a>;
This also mistakenly feeds 1.2V to the 0.88V rail and 0.88V to the 1.2V rail
during device probe at boot.
Are these additional nodes also causing a deterministic overvoltage on the PHY
circuitry that risks hardware damage, and should they be fixed as well?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260803-phy-supply-fix-v1-0-5880630cde3e@oss.qualcomm.com?part=3
^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 04/28] arm64: dts: qcom: sdm845: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:33 [PATCH 00/28] arm64: dts: qcom: Fix swapped QMP PHY vdda-phy/vdda-pll supplies Manivannan Sadhasivam via B4 Relay
` (2 preceding siblings ...)
2026-08-03 6:34 ` [PATCH 03/28] arm64: dts: qcom: sa8540p: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:34 ` Manivannan Sadhasivam via B4 Relay
2026-08-03 6:43 ` sashiko-bot
2026-08-03 6:34 ` [PATCH 05/28] arm64: dts: qcom: sdm850: " Manivannan Sadhasivam via B4 Relay
` (24 subsequent siblings)
28 siblings, 1 reply; 48+ messages in thread
From: Manivannan Sadhasivam via B4 Relay @ 2026-08-03 6:34 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Krzysztof Kozlowski, Manivannan Sadhasivam,
Manivannan Sadhasivam
From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
The QMP PHY expects the vdda-phy supply to be around 0.88V and the
vdda-pll supply to be 1.2V. But these two supplies are swapped for the
USB QMP PHYs on these boards, feeding 1.2V to vdda-phy and 0.88V to
vdda-pll.
Fix it by swapping the two supplies back.
Fixes: 3f72e2d3e682 ("arm64: dts: qcom: Add Dragonboard 845c")
Fixes: a678adbf2d22 ("arm64: dts: qcom: Add support for Pixel 3 and Pixel 3 XL")
Fixes: 28ae8aa3923c ("arm64: dts: qcom: add device tree for LG G7 and LG V35")
Fixes: cfe10d38aa1a ("arm64: dts: qcom: sdm845-mtp: Add nodes for USB")
Fixes: d711b22eee55 ("arm64: dts: qcom: starqltechn: add initial device tree for starqltechn")
Fixes: 45882459159d ("arm64: dts: qcom: sdm845: add device tree for SHIFT6mq")
Fixes: dd6459a0890a ("arm64: dts: qcom: split beryllium dts into common dtsi and tianma dts")
Fixes: be497abe19bf ("arm64: dts: qcom: Add support for Xiaomi Mi Mix2s")
Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Assisted-by: Claude:opus-4-8
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 8 ++++----
arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi | 4 ++--
arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 4 ++--
arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 8 ++++----
arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts | 4 ++--
arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 4 ++--
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 4 ++--
arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts | 4 ++--
8 files changed, 20 insertions(+), 20 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
index 02416812b6a7..846138149b2c 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
@@ -1121,8 +1121,8 @@ &usb_1_hsphy {
&usb_1_qmpphy {
status = "okay";
- vdda-phy-supply = <&vreg_l26a_1p2>;
- vdda-pll-supply = <&vreg_l1a_0p875>;
+ vdda-phy-supply = <&vreg_l1a_0p875>;
+ vdda-pll-supply = <&vreg_l26a_1p2>;
};
&usb_2 {
@@ -1147,8 +1147,8 @@ &usb_2_hsphy {
&usb_2_qmpphy {
status = "okay";
- vdda-phy-supply = <&vreg_l26a_1p2>;
- vdda-pll-supply = <&vreg_l1a_0p875>;
+ vdda-phy-supply = <&vreg_l1a_0p875>;
+ vdda-pll-supply = <&vreg_l26a_1p2>;
};
&ufs_mem_hc {
diff --git a/arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi
index b2dc0327dff8..ebeebbde6405 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi
@@ -571,8 +571,8 @@ &usb_1_hsphy {
};
&usb_1_qmpphy {
- vdda-phy-supply = <&vreg_l26a_1p2>;
- vdda-pll-supply = <&vreg_l1a_0p875>;
+ vdda-phy-supply = <&vreg_l1a_0p875>;
+ vdda-pll-supply = <&vreg_l26a_1p2>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
index e0c3566761bf..c14b4b3d9a3c 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
@@ -677,8 +677,8 @@ &usb_1_hsphy {
};
&usb_1_qmpphy {
- vdda-phy-supply = <&vdda_usb1_ss_1p2>;
- vdda-pll-supply = <&vdda_usb1_ss_core>;
+ vdda-phy-supply = <&vdda_usb1_ss_core>;
+ vdda-pll-supply = <&vdda_usb1_ss_1p2>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
index 091568642faa..00ea30afc9f6 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
@@ -729,8 +729,8 @@ &usb_1_hsphy {
&usb_1_qmpphy {
status = "okay";
- vdda-phy-supply = <&vdda_usb1_ss_1p2>;
- vdda-pll-supply = <&vdda_usb1_ss_core>;
+ vdda-phy-supply = <&vdda_usb1_ss_core>;
+ vdda-pll-supply = <&vdda_usb1_ss_1p2>;
};
&usb_2 {
@@ -761,8 +761,8 @@ &usb_2_hsphy {
&usb_2_qmpphy {
status = "okay";
- vdda-phy-supply = <&vdda_usb2_ss_1p2>;
- vdda-pll-supply = <&vdda_usb2_ss_core>;
+ vdda-phy-supply = <&vdda_usb2_ss_core>;
+ vdda-pll-supply = <&vdda_usb2_ss_1p2>;
};
&venus {
diff --git a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
index 0d915ecb0444..cd735417addd 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts
@@ -949,8 +949,8 @@ &usb_1_hsphy {
};
&usb_1_qmpphy {
- vdda-phy-supply = <&vdda_usb1_ss_1p2>;
- vdda-pll-supply = <&vdda_usb1_ss_core>;
+ vdda-phy-supply = <&vdda_usb1_ss_core>;
+ vdda-pll-supply = <&vdda_usb1_ss_1p2>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
index f21b914f22b5..ca503af9b832 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
@@ -876,8 +876,8 @@ &usb_1_hsphy {
&usb_1_qmpphy {
status = "okay";
- vdda-phy-supply = <&vreg_l26a_1p2>;
- vdda-pll-supply = <&vreg_l1a_0p875>;
+ vdda-phy-supply = <&vreg_l1a_0p875>;
+ vdda-pll-supply = <&vreg_l26a_1p2>;
};
&venus {
diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
index 54e58ca04693..710b296e4964 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi
@@ -645,8 +645,8 @@ &usb_1_hsphy {
&usb_1_qmpphy {
status = "okay";
- vdda-phy-supply = <&vreg_l26a_1p2>;
- vdda-pll-supply = <&vreg_l1a_0p875>;
+ vdda-phy-supply = <&vreg_l1a_0p875>;
+ vdda-pll-supply = <&vreg_l26a_1p2>;
};
&venus {
diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
index a44d6e776c82..cce7348e583a 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
@@ -668,8 +668,8 @@ &usb_1_hsphy {
};
&usb_1_qmpphy {
- vdda-pll-supply = <&vreg_l1a_0p875>;
- vdda-phy-supply = <&vreg_l26a_1p2>;
+ vdda-pll-supply = <&vreg_l26a_1p2>;
+ vdda-phy-supply = <&vreg_l1a_0p875>;
status = "okay";
};
--
2.43.0
^ permalink raw reply related [flat|nested] 48+ messages in thread* Re: [PATCH 04/28] arm64: dts: qcom: sdm845: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:34 ` [PATCH 04/28] arm64: dts: qcom: sdm845: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:43 ` sashiko-bot
0 siblings, 0 replies; 48+ messages in thread
From: sashiko-bot @ 2026-08-03 6:43 UTC (permalink / raw)
To: Manivannan Sadhasivam; +Cc: robh, conor+dt, devicetree
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] The patch fixes swapped `vdda-phy` and `vdda-pll` supplies for USB QMP PHYs on SDM845 boards but overlooks SDM850 boards, which suffer from the exact same hardware misconfiguration.
--
--- Patch [4]: [PATCH 04/28] arm64: dts: qcom: sdm845: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies ---
commit bbec7ae85a9540fb8dbd59aa76f0e1c5b71911a4
Author: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
arm64: dts: qcom: sdm845: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
This commit swaps the vdda-phy and vdda-pll supplies back to their proper
voltage levels for USB QMP PHYs on various SDM845 boards. It corrects a
misconfiguration where the PHY was incorrectly fed 1.2V and the PLL was
fed 0.88V.
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> index 02416812b6a7f..846138149b2cd 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> @@ -1121,8 +1121,8 @@ &usb_1_hsphy {
> &usb_1_qmpphy {
> status = "okay";
>
> - vdda-phy-supply = <&vreg_l26a_1p2>;
> - vdda-pll-supply = <&vreg_l1a_0p875>;
> + vdda-phy-supply = <&vreg_l1a_0p875>;
> + vdda-pll-supply = <&vreg_l26a_1p2>;
[Severity: High]
This isn't a bug introduced by this patch, but this patch appears to miss the
identical sibling SDM850 platforms, leaving their PHYs operating with inverted
voltage supplies. Should the SDM850 boards also be updated to prevent hardware
stability issues?
For example, on the Huawei Matebook E 2019
(arch/arm64/boot/dts/qcom/sdm850-huawei-matebook-e-2019.dts), the primary and
secondary USB QMP PHYs still have their supplies swapped:
&usb_1_qmpphy {
...
vdda-phy-supply = <&vdda_usb1_ss_1p2>;
vdda-pll-supply = <&vdda_usb1_ss_core>;
};
&usb_2_qmpphy {
...
vdda-phy-supply = <&vdda_usb2_ss_1p2>;
vdda-pll-supply = <&vdda_usb2_ss_core>;
};
The same misconfiguration is present in sdm850-lenovo-yoga-c630.dts and
sdm850-samsung-w737.dts. Does this leave the vdda-phy logic on these boards
overvolted by ~36% (1.2V instead of 0.88V) and the analog PLL undervolted
(0.88V instead of 1.2V)? Could this lead to decreased hardware stability,
PLL unlock issues, or long-term degradation of the silicon?
> };
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260803-phy-supply-fix-v1-0-5880630cde3e@oss.qualcomm.com?part=4
^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 05/28] arm64: dts: qcom: sdm850: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:33 [PATCH 00/28] arm64: dts: qcom: Fix swapped QMP PHY vdda-phy/vdda-pll supplies Manivannan Sadhasivam via B4 Relay
` (3 preceding siblings ...)
2026-08-03 6:34 ` [PATCH 04/28] arm64: dts: qcom: sdm845: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:34 ` Manivannan Sadhasivam via B4 Relay
2026-08-03 6:44 ` sashiko-bot
2026-08-03 6:34 ` [PATCH 06/28] arm64: dts: qcom: sm8150: " Manivannan Sadhasivam via B4 Relay
` (23 subsequent siblings)
28 siblings, 1 reply; 48+ messages in thread
From: Manivannan Sadhasivam via B4 Relay @ 2026-08-03 6:34 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Krzysztof Kozlowski, Manivannan Sadhasivam,
Manivannan Sadhasivam
From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
The QMP PHY expects the vdda-phy supply to be around 0.88V and the
vdda-pll supply to be 1.2V. But these two supplies are swapped for the
USB QMP PHYs on these boards, feeding 1.2V to vdda-phy and 0.88V to
vdda-pll.
Fix it by swapping the two supplies back.
Fixes: aab69794b55d ("arm64: dts: qcom: Add support for Huawei MateBook E 2019")
Fixes: 44acee207844 ("arm64: dts: qcom: Add Lenovo Yoga C630")
Fixes: d4b341269efb ("arm64: dts: qcom: Add support for Samsung Galaxy Book2")
Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Assisted-by: Claude:opus-4-8
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/sdm850-huawei-matebook-e-2019.dts | 8 ++++----
arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 8 ++++----
arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts | 8 ++++----
3 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm850-huawei-matebook-e-2019.dts b/arch/arm64/boot/dts/qcom/sdm850-huawei-matebook-e-2019.dts
index f04865381870..a4339b562b60 100644
--- a/arch/arm64/boot/dts/qcom/sdm850-huawei-matebook-e-2019.dts
+++ b/arch/arm64/boot/dts/qcom/sdm850-huawei-matebook-e-2019.dts
@@ -872,8 +872,8 @@ &usb_1_hsphy {
};
&usb_1_qmpphy {
- vdda-phy-supply = <&vdda_usb1_ss_1p2>;
- vdda-pll-supply = <&vdda_usb1_ss_core>;
+ vdda-phy-supply = <&vdda_usb1_ss_core>;
+ vdda-pll-supply = <&vdda_usb1_ss_1p2>;
status = "okay";
};
@@ -898,8 +898,8 @@ &usb_2_hsphy {
};
&usb_2_qmpphy {
- vdda-phy-supply = <&vdda_usb2_ss_1p2>;
- vdda-pll-supply = <&vdda_usb2_ss_core>;
+ vdda-phy-supply = <&vdda_usb2_ss_core>;
+ vdda-pll-supply = <&vdda_usb2_ss_1p2>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
index e41200839dbe..d8cb3e5d8d07 100644
--- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
+++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
@@ -860,8 +860,8 @@ &usb_1_hsphy {
&usb_1_qmpphy {
status = "okay";
- vdda-phy-supply = <&vdda_usb1_ss_1p2>;
- vdda-pll-supply = <&vdda_usb1_ss_core>;
+ vdda-phy-supply = <&vdda_usb1_ss_core>;
+ vdda-pll-supply = <&vdda_usb1_ss_1p2>;
};
&usb_1_qmpphy_out {
@@ -953,8 +953,8 @@ &usb_2_hsphy {
&usb_2_qmpphy {
status = "okay";
- vdda-phy-supply = <&vdda_usb2_ss_1p2>;
- vdda-pll-supply = <&vdda_usb2_ss_core>;
+ vdda-phy-supply = <&vdda_usb2_ss_core>;
+ vdda-pll-supply = <&vdda_usb2_ss_1p2>;
};
&venus {
diff --git a/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts b/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts
index a676d3ea01b9..b7a1e2317fc2 100644
--- a/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts
+++ b/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts
@@ -609,8 +609,8 @@ &usb_1_hsphy {
&usb_1_qmpphy {
status = "okay";
- vdda-phy-supply = <&vdda_usb1_ss_1p2>;
- vdda-pll-supply = <&vdda_usb1_ss_core>;
+ vdda-phy-supply = <&vdda_usb1_ss_core>;
+ vdda-pll-supply = <&vdda_usb1_ss_1p2>;
};
&usb_2 {
@@ -635,8 +635,8 @@ &usb_2_hsphy {
&usb_2_qmpphy {
status = "okay";
- vdda-phy-supply = <&vdda_usb2_ss_1p2>;
- vdda-pll-supply = <&vdda_usb2_ss_core>;
+ vdda-phy-supply = <&vdda_usb2_ss_core>;
+ vdda-pll-supply = <&vdda_usb2_ss_1p2>;
};
&venus {
--
2.43.0
^ permalink raw reply related [flat|nested] 48+ messages in thread* Re: [PATCH 05/28] arm64: dts: qcom: sdm850: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:34 ` [PATCH 05/28] arm64: dts: qcom: sdm850: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:44 ` sashiko-bot
0 siblings, 0 replies; 48+ messages in thread
From: sashiko-bot @ 2026-08-03 6:44 UTC (permalink / raw)
To: Manivannan Sadhasivam; +Cc: devicetree, robh, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] Incomplete fix: QMP USB PHY vdda-phy and vdda-pll supplies remain swapped on SC7180 and SC7280 boards.
--
--- Patch [5]: [PATCH 05/28] arm64: dts: qcom: sdm850: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies ---
commit 65f1a14faee30f3ce9d68212652a11c2bcb4b004
Author: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
arm64: dts: qcom: sdm850: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
This commit resolves swapped vdda-phy and vdda-pll supplies for USB QMP PHYs
on several sdm850 boards. It ensures the vdda-phy receives the expected 0.88V
instead of 1.2V, and the vdda-pll receives 1.2V instead of 0.88V.
> The QMP PHY expects the vdda-phy supply to be around 0.88V and the
> vdda-pll supply to be 1.2V. But these two supplies are swapped for the
> USB QMP PHYs on these boards, feeding 1.2V to vdda-phy and 0.88V to
> vdda-pll.
>
> Fix it by swapping the two supplies back.
[Severity: High]
This isn't a bug introduced by this patch, but it appears the identical
configuration remains swapped on other boards, such as SC7180 and SC7280.
For example, in arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi:
vdda-phy-supply = <&vdda_usb_ss_dp_1p2>;
vdda-pll-supply = <&vdda_usb_ss_dp_core>;
And similarly in arch/arm64/boot/dts/qcom/sc7280-idp.dtsi:
vdda-phy-supply = <&vreg_l6b_1p2>;
vdda-pll-supply = <&vreg_l1b_0p8>;
Since vdda-phy receives 1.2V and vdda-pll receives 0.88V/0.9V on these pins,
could this cause hardware damage over time or prevent the USB PHY from locking
on these systems as well? Should these other boards be included in this fix?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260803-phy-supply-fix-v1-0-5880630cde3e@oss.qualcomm.com?part=5
^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 06/28] arm64: dts: qcom: sm8150: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:33 [PATCH 00/28] arm64: dts: qcom: Fix swapped QMP PHY vdda-phy/vdda-pll supplies Manivannan Sadhasivam via B4 Relay
` (4 preceding siblings ...)
2026-08-03 6:34 ` [PATCH 05/28] arm64: dts: qcom: sdm850: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:34 ` Manivannan Sadhasivam via B4 Relay
2026-08-03 6:42 ` sashiko-bot
2026-08-03 6:34 ` [PATCH 07/28] arm64: dts: qcom: sm8250: " Manivannan Sadhasivam via B4 Relay
` (22 subsequent siblings)
28 siblings, 1 reply; 48+ messages in thread
From: Manivannan Sadhasivam via B4 Relay @ 2026-08-03 6:34 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Krzysztof Kozlowski, Manivannan Sadhasivam,
Manivannan Sadhasivam
From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
The QMP PHY expects the vdda-phy supply to be around 0.88V and the
vdda-pll supply to be 1.2V. But these two supplies are swapped for the
USB QMP PHYs on these boards, feeding 1.2V to vdda-phy and 0.88V to
vdda-pll.
Fix it by swapping the two supplies back.
Fixes: 0ab1b2d10afe ("arm64: dts: qcom: add sm8150 hdk dts")
Fixes: b33d2868e8d3 ("arm64: dts: qcom: sm8150: Add USB and PHY device nodes")
Fixes: d1f781db47a8 ("arm64: dts: qcom: add initial device-tree for Microsoft Surface Duo")
Fixes: d0a6ce59ea4e ("arm64: dts: qcom: sm8150: Add support for SONY Xperia 1 / 5 (Kumano platform)")
Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Assisted-by: Claude:opus-4-8
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/sm8150-hdk.dts | 8 ++++----
arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts | 4 ++--
arch/arm64/boot/dts/qcom/sm8150-mtp.dts | 4 ++--
arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi | 4 ++--
4 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8150-hdk.dts b/arch/arm64/boot/dts/qcom/sm8150-hdk.dts
index 8fb04ce72f91..cdced5c848d3 100644
--- a/arch/arm64/boot/dts/qcom/sm8150-hdk.dts
+++ b/arch/arm64/boot/dts/qcom/sm8150-hdk.dts
@@ -801,8 +801,8 @@ &usb_2_hsphy {
&usb_1_qmpphy {
status = "okay";
- vdda-phy-supply = <&vreg_l3c_1p2>;
- vdda-pll-supply = <&vreg_l18a_0p8>;
+ vdda-phy-supply = <&vreg_l18a_0p8>;
+ vdda-pll-supply = <&vreg_l3c_1p2>;
orientation-switch;
};
@@ -812,8 +812,8 @@ &usb_1_qmpphy_out {
&usb_2_qmpphy {
status = "okay";
- vdda-phy-supply = <&vreg_l3c_1p2>;
- vdda-pll-supply = <&vreg_l5a_0p875>;
+ vdda-phy-supply = <&vreg_l5a_0p875>;
+ vdda-pll-supply = <&vreg_l3c_1p2>;
};
&usb_1 {
diff --git a/arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts b/arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts
index 835ef929ff2d..f37e11bde067 100644
--- a/arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts
+++ b/arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts
@@ -520,8 +520,8 @@ &usb_1_hsphy {
&usb_1_qmpphy {
status = "okay";
- vdda-phy-supply = <&vreg_l3c_1p2>;
- vdda-pll-supply = <&vdda_usb_ss_dp_core_1>;
+ vdda-phy-supply = <&vdda_usb_ss_dp_core_1>;
+ vdda-pll-supply = <&vreg_l3c_1p2>;
};
&usb_1 {
diff --git a/arch/arm64/boot/dts/qcom/sm8150-mtp.dts b/arch/arm64/boot/dts/qcom/sm8150-mtp.dts
index 0f2d511624a8..6a6564d8d7f7 100644
--- a/arch/arm64/boot/dts/qcom/sm8150-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sm8150-mtp.dts
@@ -438,8 +438,8 @@ &usb_1_hsphy {
&usb_1_qmpphy {
status = "okay";
- vdda-phy-supply = <&vreg_l3c_1p2>;
- vdda-pll-supply = <&vdda_usb_ss_dp_core_1>;
+ vdda-phy-supply = <&vdda_usb_ss_dp_core_1>;
+ vdda-pll-supply = <&vreg_l3c_1p2>;
};
&usb_1 {
diff --git a/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi b/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi
index 70fd6455518b..6c2e2bf869d0 100644
--- a/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi
@@ -869,6 +869,6 @@ &usb_1_hsphy {
&usb_1_qmpphy {
status = "okay";
- vdda-phy-supply = <&vreg_l3c_1p2>;
- vdda-pll-supply = <&vreg_l18a_0p8>;
+ vdda-phy-supply = <&vreg_l18a_0p8>;
+ vdda-pll-supply = <&vreg_l3c_1p2>;
};
--
2.43.0
^ permalink raw reply related [flat|nested] 48+ messages in thread* Re: [PATCH 06/28] arm64: dts: qcom: sm8150: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:34 ` [PATCH 06/28] arm64: dts: qcom: sm8150: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:42 ` sashiko-bot
0 siblings, 0 replies; 48+ messages in thread
From: sashiko-bot @ 2026-08-03 6:42 UTC (permalink / raw)
To: Manivannan Sadhasivam; +Cc: robh, devicetree, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] Incomplete fix: Swapped QMP PHY voltage supplies remain in sa8155p-adp.dts
--
--- Patch [6]: [PATCH 06/28] arm64: dts: qcom: sm8150: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies ---
commit ebfb4d71483e3fc04d67c48f9f15befd5ec2bbed
Author: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
arm64: dts: qcom: sm8150: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
This commit fixes an issue where the 1.2V and 0.88V supplies were swapped
for the USB QMP PHYs on several SM8150 boards. It restores the correct
voltages by feeding 0.88V to vdda-phy and 1.2V to vdda-pll.
> The QMP PHY expects the vdda-phy supply to be around 0.88V and the
> vdda-pll supply to be 1.2V. But these two supplies are swapped for the
> USB QMP PHYs on these boards, feeding 1.2V to vdda-phy and 0.88V to
> vdda-pll.
>
> Fix it by swapping the two supplies back.
[Severity: High]
This is a pre-existing issue, but since this patch fixes swapped QMP PHY
supplies across SM8150 boards, does it miss the SA8155P automotive variant?
Looking at the existing arch/arm64/boot/dts/qcom/sa8155p-adp.dts, ufs_mem_phy
and usb_2_qmpphy still retain the swapped supplies:
arch/arm64/boot/dts/qcom/sa8155p-adp.dts:ufs_mem_phy {
...
vdda-phy-supply = <&vreg_l8c_1p2>;
vdda-pll-supply = <&vreg_l5a_0p88>;
};
arch/arm64/boot/dts/qcom/sa8155p-adp.dts:usb_2_qmpphy {
...
vdda-phy-supply = <&vreg_l8c_1p2>;
vdda-pll-supply = <&vdda_usb_ss_dp_core_1>;
};
(Where vdda_usb_ss_dp_core_1 is an alias for the 0.88V regulator
vreg_l5a_0p88).
Should these nodes in sa8155p-adp.dts also be updated to prevent overvoltage
degradation on this board?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260803-phy-supply-fix-v1-0-5880630cde3e@oss.qualcomm.com?part=6
^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 07/28] arm64: dts: qcom: sm8250: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:33 [PATCH 00/28] arm64: dts: qcom: Fix swapped QMP PHY vdda-phy/vdda-pll supplies Manivannan Sadhasivam via B4 Relay
` (5 preceding siblings ...)
2026-08-03 6:34 ` [PATCH 06/28] arm64: dts: qcom: sm8150: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:34 ` Manivannan Sadhasivam via B4 Relay
2026-08-03 6:34 ` [PATCH 08/28] arm64: dts: qcom: sm8350: " Manivannan Sadhasivam via B4 Relay
` (21 subsequent siblings)
28 siblings, 0 replies; 48+ messages in thread
From: Manivannan Sadhasivam via B4 Relay @ 2026-08-03 6:34 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Krzysztof Kozlowski, Manivannan Sadhasivam,
Manivannan Sadhasivam
From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
The QMP PHY expects the vdda-phy supply to be around 0.88V and the
vdda-pll supply to be 1.2V. But these two supplies are swapped for the
USB QMP PHYs on these boards, feeding 1.2V to vdda-phy and 0.9V to
vdda-pll.
Fix it by swapping the two supplies back.
Fixes: 91ed0e90fc49 ("arm64: dts: qcom: add sm8250 hdk dts")
Fixes: 221f0ef37f55 ("arm64: dts: sm8250-mtp: enable USB host nodes")
Fixes: 69cdb97ef652 ("arm64: dts: qcom: sm8250: Add support for SONY Xperia 1 II / 5 II (Edo platform)")
Fixes: 264beb3cbd0d ("arm64: dts: qcom: sm8250-xiaomi-pipa: Add initial device tree")
Fixes: 52c90664f122 ("arm64: dts: qcom: qrb5165-rb5: Add USB support")
Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Assisted-by: Claude:opus-4-8
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 8 ++++----
arch/arm64/boot/dts/qcom/sm8250-hdk.dts | 8 ++++----
arch/arm64/boot/dts/qcom/sm8250-mtp.dts | 8 ++++----
arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi | 4 ++--
arch/arm64/boot/dts/qcom/sm8250-xiaomi-pipa.dts | 4 ++--
5 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
index 690b484352ed..d6af679abe1a 100644
--- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
+++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
@@ -1424,8 +1424,8 @@ &usb_1_hsphy {
&usb_1_qmpphy {
status = "okay";
- vdda-phy-supply = <&vreg_l9a_1p2>;
- vdda-pll-supply = <&vreg_l18a_0p92>;
+ vdda-phy-supply = <&vreg_l18a_0p92>;
+ vdda-pll-supply = <&vreg_l9a_1p2>;
};
&usb_1_qmpphy_out {
@@ -1451,8 +1451,8 @@ &usb_2_hsphy {
&usb_2_qmpphy {
status = "okay";
- vdda-phy-supply = <&vreg_l9a_1p2>;
- vdda-pll-supply = <&vreg_l18a_0p92>;
+ vdda-phy-supply = <&vreg_l18a_0p92>;
+ vdda-pll-supply = <&vreg_l9a_1p2>;
};
&vamacro {
diff --git a/arch/arm64/boot/dts/qcom/sm8250-hdk.dts b/arch/arm64/boot/dts/qcom/sm8250-hdk.dts
index 3ea9d2b1a7d5..c1c673086df5 100644
--- a/arch/arm64/boot/dts/qcom/sm8250-hdk.dts
+++ b/arch/arm64/boot/dts/qcom/sm8250-hdk.dts
@@ -438,14 +438,14 @@ &usb_2_hsphy {
&usb_1_qmpphy {
status = "okay";
- vdda-phy-supply = <&vreg_l9a_1p2>;
- vdda-pll-supply = <&vreg_l18a_0p92>;
+ vdda-phy-supply = <&vreg_l18a_0p92>;
+ vdda-pll-supply = <&vreg_l9a_1p2>;
};
&usb_2_qmpphy {
status = "okay";
- vdda-phy-supply = <&vreg_l9a_1p2>;
- vdda-pll-supply = <&vreg_l18a_0p92>;
+ vdda-phy-supply = <&vreg_l18a_0p92>;
+ vdda-pll-supply = <&vreg_l9a_1p2>;
};
&usb_1 {
diff --git a/arch/arm64/boot/dts/qcom/sm8250-mtp.dts b/arch/arm64/boot/dts/qcom/sm8250-mtp.dts
index 51779b99176d..14c8ca602110 100644
--- a/arch/arm64/boot/dts/qcom/sm8250-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sm8250-mtp.dts
@@ -862,8 +862,8 @@ &usb_1_hsphy {
&usb_1_qmpphy {
status = "okay";
- vdda-phy-supply = <&vreg_l9a_1p2>;
- vdda-pll-supply = <&vreg_l18a_0p9>;
+ vdda-phy-supply = <&vreg_l18a_0p9>;
+ vdda-pll-supply = <&vreg_l9a_1p2>;
};
&usb_2 {
@@ -885,8 +885,8 @@ &usb_2_hsphy {
&usb_2_qmpphy {
status = "okay";
- vdda-phy-supply = <&vreg_l9a_1p2>;
- vdda-pll-supply = <&vreg_l18a_0p9>;
+ vdda-phy-supply = <&vreg_l18a_0p9>;
+ vdda-pll-supply = <&vreg_l9a_1p2>;
};
&venus {
diff --git a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
index d8289b2698f3..51c0caaf4ea1 100644
--- a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi
@@ -715,8 +715,8 @@ &usb_1_hsphy {
&usb_1_qmpphy {
status = "okay";
- vdda-phy-supply = <&vreg_l9a_1p2>;
- vdda-pll-supply = <&vreg_l18a_0p9>;
+ vdda-phy-supply = <&vreg_l18a_0p9>;
+ vdda-pll-supply = <&vreg_l9a_1p2>;
};
&venus {
diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-pipa.dts b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-pipa.dts
index 078ba13f8762..f11e4e244dff 100644
--- a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-pipa.dts
+++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-pipa.dts
@@ -515,8 +515,8 @@ &usb_1_hsphy {
&usb_1_qmpphy {
status = "okay";
- vdda-phy-supply = <&vreg_l9a_1p2>;
- vdda-pll-supply = <&vreg_l18a_0p9>;
+ vdda-phy-supply = <&vreg_l18a_0p9>;
+ vdda-pll-supply = <&vreg_l9a_1p2>;
};
&ufs_mem_hc {
--
2.43.0
^ permalink raw reply related [flat|nested] 48+ messages in thread* [PATCH 08/28] arm64: dts: qcom: sm8350: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:33 [PATCH 00/28] arm64: dts: qcom: Fix swapped QMP PHY vdda-phy/vdda-pll supplies Manivannan Sadhasivam via B4 Relay
` (6 preceding siblings ...)
2026-08-03 6:34 ` [PATCH 07/28] arm64: dts: qcom: sm8250: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:34 ` Manivannan Sadhasivam via B4 Relay
2026-08-03 6:51 ` sashiko-bot
2026-08-03 6:34 ` [PATCH 09/28] arm64: dts: qcom: sm8450: " Manivannan Sadhasivam via B4 Relay
` (20 subsequent siblings)
28 siblings, 1 reply; 48+ messages in thread
From: Manivannan Sadhasivam via B4 Relay @ 2026-08-03 6:34 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Krzysztof Kozlowski, Manivannan Sadhasivam,
Manivannan Sadhasivam
From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
The QMP PHY expects the vdda-phy supply to be around 0.88V and the
vdda-pll supply to be 1.2V. But these two supplies are swapped for the
USB QMP PHYs on these boards, feeding 1.2V to vdda-phy and 0.88V to
vdda-pll.
Fix it by swapping the two supplies back.
Fixes: 9208c19f2124 ("arm64: dts: qcom: Introduce SM8350 HDK")
Fixes: c16160cfa565 ("arm64: dts: qcom: add minimal DTS for Microsoft Surface Duo 2")
Fixes: 054b40a6111f ("arm64: dts: qcom: sm8350-mtp: enable USB nodes")
Fixes: 5a077120bcf6 ("arm64: dts: qcom: sm8350-sagami: Wire up USB regulators and fix USB3")
Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Assisted-by: Claude:opus-4-8
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 8 ++++----
arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts | 8 ++++----
arch/arm64/boot/dts/qcom/sm8350-mtp.dts | 8 ++++----
arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi | 4 ++--
4 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
index 5f975d009465..b43dbb5921b1 100644
--- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
+++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
@@ -860,8 +860,8 @@ &usb_1_hsphy {
&usb_1_qmpphy {
status = "okay";
- vdda-phy-supply = <&vreg_l6b_1p2>;
- vdda-pll-supply = <&vreg_l1b_0p88>;
+ vdda-phy-supply = <&vreg_l1b_0p88>;
+ vdda-pll-supply = <&vreg_l6b_1p2>;
};
&usb_1_qmpphy_out {
@@ -890,8 +890,8 @@ &usb_2_hsphy {
&usb_2_qmpphy {
status = "okay";
- vdda-phy-supply = <&vreg_l6b_1p2>;
- vdda-pll-supply = <&vreg_l5b_0p88>;
+ vdda-phy-supply = <&vreg_l5b_0p88>;
+ vdda-pll-supply = <&vreg_l6b_1p2>;
};
/* PINCTRL - additions to nodes defined in sm8350.dtsi */
diff --git a/arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts b/arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts
index 3bd5e57cbcda..57bb8c322e8b 100644
--- a/arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts
+++ b/arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts
@@ -358,8 +358,8 @@ &usb_1_hsphy {
&usb_1_qmpphy {
status = "okay";
- vdda-phy-supply = <&vreg_l6b_1p2>;
- vdda-pll-supply = <&vreg_l1b_0p88>;
+ vdda-phy-supply = <&vreg_l1b_0p88>;
+ vdda-pll-supply = <&vreg_l6b_1p2>;
};
&usb_2 {
@@ -377,6 +377,6 @@ &usb_2_hsphy {
&usb_2_qmpphy {
status = "okay";
- vdda-phy-supply = <&vreg_l6b_1p2>;
- vdda-pll-supply = <&vreg_l5b_0p88>;
+ vdda-phy-supply = <&vreg_l5b_0p88>;
+ vdda-pll-supply = <&vreg_l6b_1p2>;
};
diff --git a/arch/arm64/boot/dts/qcom/sm8350-mtp.dts b/arch/arm64/boot/dts/qcom/sm8350-mtp.dts
index 8bee57f3b25a..859985e561aa 100644
--- a/arch/arm64/boot/dts/qcom/sm8350-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sm8350-mtp.dts
@@ -354,8 +354,8 @@ &usb_1_hsphy {
&usb_1_qmpphy {
status = "okay";
- vdda-phy-supply = <&vreg_l6b_1p2>;
- vdda-pll-supply = <&vreg_l1b_0p88>;
+ vdda-phy-supply = <&vreg_l1b_0p88>;
+ vdda-pll-supply = <&vreg_l6b_1p2>;
};
&usb_2 {
@@ -373,8 +373,8 @@ &usb_2_hsphy {
&usb_2_qmpphy {
status = "okay";
- vdda-phy-supply = <&vreg_l6b_1p2>;
- vdda-pll-supply = <&vreg_l5b_0p88>;
+ vdda-phy-supply = <&vreg_l5b_0p88>;
+ vdda-pll-supply = <&vreg_l6b_1p2>;
};
&ipa {
diff --git a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
index 7ae1eb0a7cce..1f9d094fee8f 100644
--- a/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami.dtsi
@@ -917,6 +917,6 @@ &usb_1_hsphy {
&usb_1_qmpphy {
status = "okay";
- vdda-phy-supply = <&pm8350_l6>;
- vdda-pll-supply = <&pm8350_l1>;
+ vdda-phy-supply = <&pm8350_l1>;
+ vdda-pll-supply = <&pm8350_l6>;
};
--
2.43.0
^ permalink raw reply related [flat|nested] 48+ messages in thread* Re: [PATCH 08/28] arm64: dts: qcom: sm8350: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:34 ` [PATCH 08/28] arm64: dts: qcom: sm8350: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:51 ` sashiko-bot
0 siblings, 0 replies; 48+ messages in thread
From: sashiko-bot @ 2026-08-03 6:51 UTC (permalink / raw)
To: Manivannan Sadhasivam; +Cc: robh, devicetree, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [Medium] Incomplete fix for swapped USB QMP PHY vdda-phy/vdda-pll supplies across the QCOM devicetrees. The same reversed regulator configuration remains unfixed in several other SoCs, notably SM8450, SM8550, and SM8650.
--
--- Patch [8]: [PATCH 08/28] arm64: dts: qcom: sm8350: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies ---
commit 2073beeb341c58218ee83d7e126de860cc972a2f
Author: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
arm64: dts: qcom: sm8350: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
The commit fixes a hardware configuration issue where the vdda-phy and
vdda-pll power supplies for the USB QMP PHY were swapped in SM8350
device trees. It corrects the assignments for the HDK, Surface Duo 2,
MTP, and Sagami boards so they receive the expected ~0.88V and 1.2V
respectively.
> diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
> index 5f975d0094658..b43dbb5921b18 100644
> --- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
> @@ -860,8 +860,8 @@ &usb_1_hsphy {
> &usb_1_qmpphy {
> status = "okay";
>
> - vdda-phy-supply = <&vreg_l6b_1p2>;
> - vdda-pll-supply = <&vreg_l1b_0p88>;
> + vdda-phy-supply = <&vreg_l1b_0p88>;
> + vdda-pll-supply = <&vreg_l6b_1p2>;
> };
[Severity: Medium]
This is a pre-existing issue, but it looks like the swapped regulator
assignments remain unfixed in several other device trees.
For example, in sm8450-hdk.dts, usb_1_qmpphy still has a 1.2V supply assigned
to vdda-phy-supply and a 0.91V supply to vdda-pll-supply:
arch/arm64/boot/dts/qcom/sm8450-hdk.dts:usb_1_qmpphy {
status = "okay";
vdda-phy-supply = <&vreg_l6b_1p2>;
vdda-pll-supply = <&vreg_l1b_0p91>;
};
The same uncorrected pattern appears in sm8550-hdk.dts and sm8650-hdk.dts
for usb_dp_qmpphy, as well as in sm8450-sony-xperia-nagara.dtsi.
Should these other device trees be updated in a follow-up patch to ensure
their PHYs receive the correct voltages?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260803-phy-supply-fix-v1-0-5880630cde3e@oss.qualcomm.com?part=8
^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 09/28] arm64: dts: qcom: sm8450: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:33 [PATCH 00/28] arm64: dts: qcom: Fix swapped QMP PHY vdda-phy/vdda-pll supplies Manivannan Sadhasivam via B4 Relay
` (7 preceding siblings ...)
2026-08-03 6:34 ` [PATCH 08/28] arm64: dts: qcom: sm8350: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:34 ` Manivannan Sadhasivam via B4 Relay
2026-08-03 6:43 ` sashiko-bot
2026-08-03 6:34 ` [PATCH 10/28] arm64: dts: qcom: sm8550: " Manivannan Sadhasivam via B4 Relay
` (19 subsequent siblings)
28 siblings, 1 reply; 48+ messages in thread
From: Manivannan Sadhasivam via B4 Relay @ 2026-08-03 6:34 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Krzysztof Kozlowski, Manivannan Sadhasivam,
Manivannan Sadhasivam
From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
The QMP PHY expects the vdda-phy supply to be around 0.88V and the
vdda-pll supply to be 1.2V. But these two supplies are swapped for the
USB QMP PHYs on these boards, feeding 1.2V to vdda-phy and 0.91V to
vdda-pll.
Fix it by swapping the two supplies back.
Fixes: 067b2b3616cd ("arm64: dts: qcom: Add SM8450 HDK DTS")
Fixes: 27a0d0b846d9 ("arm64: dts: qcom: sm8450-qrd: Enable USB nodes")
Fixes: 1620676b85f1 ("arm64: dts: qcom: sm8450-nagara: Separate out Nagara platform dtsi")
Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Assisted-by: Claude:opus-4-8
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 4 ++--
arch/arm64/boot/dts/qcom/sm8450-qrd.dts | 4 ++--
arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
index b37998cd9a2c..4ade28f40cae 100644
--- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
+++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
@@ -1214,8 +1214,8 @@ &usb_1_hsphy {
&usb_1_qmpphy {
status = "okay";
- vdda-phy-supply = <&vreg_l6b_1p2>;
- vdda-pll-supply = <&vreg_l1b_0p91>;
+ vdda-phy-supply = <&vreg_l1b_0p91>;
+ vdda-pll-supply = <&vreg_l6b_1p2>;
};
&usb_1_qmpphy_out {
diff --git a/arch/arm64/boot/dts/qcom/sm8450-qrd.dts b/arch/arm64/boot/dts/qcom/sm8450-qrd.dts
index 56db5f79f59d..4993059483e9 100644
--- a/arch/arm64/boot/dts/qcom/sm8450-qrd.dts
+++ b/arch/arm64/boot/dts/qcom/sm8450-qrd.dts
@@ -527,8 +527,8 @@ &usb_1_hsphy {
&usb_1_qmpphy {
status = "okay";
- vdda-phy-supply = <&vreg_l6b_1p2>;
- vdda-pll-supply = <&vreg_l1b_0p91>;
+ vdda-phy-supply = <&vreg_l1b_0p91>;
+ vdda-pll-supply = <&vreg_l6b_1p2>;
};
&usb_1_qmpphy_out {
diff --git a/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi b/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi
index 6bd315e10992..4fb5627d8126 100644
--- a/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi
@@ -793,7 +793,7 @@ &usb_1_hsphy {
};
&usb_1_qmpphy {
- vdda-phy-supply = <&pm8350_l6>;
- vdda-pll-supply = <&pm8350_l1>;
+ vdda-phy-supply = <&pm8350_l1>;
+ vdda-pll-supply = <&pm8350_l6>;
status = "okay";
};
--
2.43.0
^ permalink raw reply related [flat|nested] 48+ messages in thread* Re: [PATCH 09/28] arm64: dts: qcom: sm8450: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:34 ` [PATCH 09/28] arm64: dts: qcom: sm8450: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:43 ` sashiko-bot
0 siblings, 0 replies; 48+ messages in thread
From: sashiko-bot @ 2026-08-03 6:43 UTC (permalink / raw)
To: Manivannan Sadhasivam; +Cc: devicetree, conor+dt, robh
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] Incomplete fix: Swapped QMP PHY `vdda-phy` and `vdda-pll` supplies are also present on many other SoC platforms.
--
--- Patch [9]: [PATCH 09/28] arm64: dts: qcom: sm8450: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies ---
commit b676d59f3c957659ff365b6c3e896016ef8c4405
Author: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
arm64: dts: qcom: sm8450: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
This commit swaps back the vdda-phy and vdda-pll supplies for the sm8450
USB QMP PHYs. The supplies were previously swapped, feeding 1.2V to a 0.88V
line and 0.91V to a 1.2V line.
> diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> index b37998cd9a2c3..4ade28f40cae0 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
> @@ -1214,8 +1214,8 @@ &usb_1_hsphy {
> &usb_1_qmpphy {
> status = "okay";
>
> - vdda-phy-supply = <&vreg_l6b_1p2>;
> - vdda-pll-supply = <&vreg_l1b_0p91>;
> + vdda-phy-supply = <&vreg_l1b_0p91>;
> + vdda-pll-supply = <&vreg_l6b_1p2>;
[Severity: High]
This is a pre-existing issue, but does this same swapped regulator bug exist
in other board files that should also be addressed?
For instance, looking at arch/arm64/boot/dts/qcom/sc7280-idp.dtsi in &usb_1_qmpphy:
vdda-phy-supply = <&vreg_l6b_1p2>;
vdda-pll-supply = <&vreg_l1b_0p8>;
And similarly in arch/arm64/boot/dts/qcom/qcm6490-idp.dts in &usb_1_qmpphy:
vdda-phy-supply = <&vreg_l6b_1p2>;
vdda-pll-supply = <&vreg_l1b_0p912>;
Should these other boards also be included in this fix to prevent overvolting
the PHYs on those platforms?
> };
>
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260803-phy-supply-fix-v1-0-5880630cde3e@oss.qualcomm.com?part=9
^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 10/28] arm64: dts: qcom: sm8550: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:33 [PATCH 00/28] arm64: dts: qcom: Fix swapped QMP PHY vdda-phy/vdda-pll supplies Manivannan Sadhasivam via B4 Relay
` (8 preceding siblings ...)
2026-08-03 6:34 ` [PATCH 09/28] arm64: dts: qcom: sm8450: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:34 ` Manivannan Sadhasivam via B4 Relay
2026-08-03 6:41 ` sashiko-bot
2026-08-03 6:34 ` [PATCH 11/28] arm64: dts: qcom: qcs8550-aim300: " Manivannan Sadhasivam via B4 Relay
` (18 subsequent siblings)
28 siblings, 1 reply; 48+ messages in thread
From: Manivannan Sadhasivam via B4 Relay @ 2026-08-03 6:34 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Krzysztof Kozlowski, Manivannan Sadhasivam,
Manivannan Sadhasivam
From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
The QMP PHY expects the vdda-phy supply to be around 0.88V and the
vdda-pll supply to be 1.2V. But these two supplies are swapped for the
USB QMP PHYs on these boards, feeding 1.2V to vdda-phy and 0.88V to
vdda-pll.
Fix it by swapping the two supplies back.
Fixes: b5e25ded2721 ("arm64: dts: qcom: sm8550: add support for the SM8550-HDK board")
Fixes: 772e6bc4a0a9 ("arm64: dts: qcom: sm8550-mtp: Add USB PHYs and HC nodes")
Fixes: d228efe88469 ("arm64: dts: qcom: sm8550-qrd: add QRD8550")
Fixes: 39c596304e44 ("arm64: dts: qcom: Add SM8550 Xperia 1 V")
Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Assisted-by: Claude:opus-4-8
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/sm8550-hdk.dts | 4 ++--
arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 4 ++--
arch/arm64/boot/dts/qcom/sm8550-qrd.dts | 4 ++--
arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts | 4 ++--
4 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
index ee13e6136a82..25ff5e39dd34 100644
--- a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
+++ b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
@@ -1374,8 +1374,8 @@ &usb_1_hsphy {
};
&usb_dp_qmpphy {
- vdda-phy-supply = <&vreg_l3e_1p2>;
- vdda-pll-supply = <&vreg_l3f_0p88>;
+ vdda-phy-supply = <&vreg_l3f_0p88>;
+ vdda-pll-supply = <&vreg_l3e_1p2>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
index 5769be83cfbd..7c634572c6b7 100644
--- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
@@ -971,8 +971,8 @@ &usb_1_hsphy {
};
&usb_dp_qmpphy {
- vdda-phy-supply = <&vreg_l3e_1p2>;
- vdda-pll-supply = <&vreg_l3f_0p91>;
+ vdda-phy-supply = <&vreg_l3f_0p91>;
+ vdda-pll-supply = <&vreg_l3e_1p2>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
index 2fb2e0be5e4c..ceb5cd3c5bf3 100644
--- a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
+++ b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
@@ -1274,8 +1274,8 @@ &usb_1_hsphy {
};
&usb_dp_qmpphy {
- vdda-phy-supply = <&vreg_l3e_1p2>;
- vdda-pll-supply = <&vreg_l3f_0p88>;
+ vdda-phy-supply = <&vreg_l3f_0p88>;
+ vdda-pll-supply = <&vreg_l3e_1p2>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts b/arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts
index 0e6ed6fce614..367f6eae5e65 100644
--- a/arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts
+++ b/arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts
@@ -766,8 +766,8 @@ &usb_1_hsphy {
};
&usb_dp_qmpphy {
- vdda-phy-supply = <&pm8550vs_2_l3>;
- vdda-pll-supply = <&pm8550ve_l3>;
+ vdda-phy-supply = <&pm8550ve_l3>;
+ vdda-pll-supply = <&pm8550vs_2_l3>;
status = "okay";
};
--
2.43.0
^ permalink raw reply related [flat|nested] 48+ messages in thread* Re: [PATCH 10/28] arm64: dts: qcom: sm8550: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:34 ` [PATCH 10/28] arm64: dts: qcom: sm8550: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:41 ` sashiko-bot
0 siblings, 0 replies; 48+ messages in thread
From: sashiko-bot @ 2026-08-03 6:41 UTC (permalink / raw)
To: Manivannan Sadhasivam; +Cc: devicetree, robh, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] The patch series fixes swapped `vdda-phy-supply` and `vdda-pll-supply` regulators for several boards (e.g., sm8550), but misses identical swaps in other QMP PHY users across the tree (e.g., sm8650, sm8750, x1e80100).
--
--- Patch [10]: [PATCH 10/28] arm64: dts: qcom: sm8550: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies ---
commit c8c05b6ce3c72eb6b9fb37b78a8e1a5e58bf14e9
Author: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
arm64: dts: qcom: sm8550: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
This commit corrects the swapped vdda-phy and vdda-pll supplies for USB QMP
PHYs on several SM8550 boards. By swapping the regulators back, it ensures
the PHY receives the expected 0.88V instead of 1.2V, and the PLL receives
1.2V instead of 0.88V.
> diff --git a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
> index ee13e6136a825..25ff5e39dd346 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
> @@ -1374,8 +1374,8 @@ &usb_1_hsphy {
> };
>
> &usb_dp_qmpphy {
> - vdda-phy-supply = <&vreg_l3e_1p2>;
> - vdda-pll-supply = <&vreg_l3f_0p88>;
> + vdda-phy-supply = <&vreg_l3f_0p88>;
> + vdda-pll-supply = <&vreg_l3e_1p2>;
>
> status = "okay";
> };
[Severity: High]
This is a pre-existing issue, but does this same regulator swap bug affect
other boards across the tree?
Looking at other device trees, it appears the 1.2V and ~0.88V supplies
might still be swapped in several other QMP PHY configurations. For
example, in arch/arm64/boot/dts/qcom/sm8650-mtp.dts for usb_dp_qmpphy:
vdda-phy-supply = <&vreg_l3i_1p2>;
vdda-pll-supply = <&vreg_l3g_0p91>;
And similarly in arch/arm64/boot/dts/qcom/sm8750-mtp.dts:
vdda-phy-supply = <&vreg_l3g_1p2>;
vdda-pll-supply = <&vreg_l2d_0p88>;
Even the Snapdragon X Elite ecosystem seems to exhibit this pattern, such as
in arch/arm64/boot/dts/qcom/x1e80100-qcp.dts for usb_1_ss0_qmpphy:
vdda-phy-supply = <&vreg_l2j_1p2>;
vdda-pll-supply = <&vreg_l1j_0p8>;
Supplying 1.2V to the 0.88V PHY domain and 0.88V to the 1.2V PLL domain
might prevent the USB/DP PHY PLL from locking and risk hardware degradation
due to overvoltage on the PHY pins. Should these other boards be updated
with a similar fix?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260803-phy-supply-fix-v1-0-5880630cde3e@oss.qualcomm.com?part=10
^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 11/28] arm64: dts: qcom: qcs8550-aim300: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:33 [PATCH 00/28] arm64: dts: qcom: Fix swapped QMP PHY vdda-phy/vdda-pll supplies Manivannan Sadhasivam via B4 Relay
` (9 preceding siblings ...)
2026-08-03 6:34 ` [PATCH 10/28] arm64: dts: qcom: sm8550: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:34 ` Manivannan Sadhasivam via B4 Relay
2026-08-03 6:34 ` [PATCH 12/28] arm64: dts: qcom: qcm6490: " Manivannan Sadhasivam via B4 Relay
` (17 subsequent siblings)
28 siblings, 0 replies; 48+ messages in thread
From: Manivannan Sadhasivam via B4 Relay @ 2026-08-03 6:34 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Krzysztof Kozlowski, Manivannan Sadhasivam,
Manivannan Sadhasivam
From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
The QMP PHY expects the vdda-phy supply to be around 0.88V and the
vdda-pll supply to be 1.2V. But these two supplies are swapped for the
USB QMP PHY on this board, feeding 1.2V to vdda-phy and 0.88V to
vdda-pll.
Fix it by swapping the two supplies back.
Fixes: 0b12da4e28d8 ("arm64: dts: qcom: add base AIM300 dtsi")
Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Assisted-by: Claude:opus-4-8
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/qcs8550-aim300.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/qcs8550-aim300.dtsi b/arch/arm64/boot/dts/qcom/qcs8550-aim300.dtsi
index e6ebb643203b..ae301d78e071 100644
--- a/arch/arm64/boot/dts/qcom/qcs8550-aim300.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs8550-aim300.dtsi
@@ -412,8 +412,8 @@ &usb_1_hsphy {
};
&usb_dp_qmpphy {
- vdda-phy-supply = <&vreg_l3e_1p2>;
- vdda-pll-supply = <&vreg_l3f_0p88>;
+ vdda-phy-supply = <&vreg_l3f_0p88>;
+ vdda-pll-supply = <&vreg_l3e_1p2>;
};
&xo_board {
--
2.43.0
^ permalink raw reply related [flat|nested] 48+ messages in thread* [PATCH 12/28] arm64: dts: qcom: qcm6490: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:33 [PATCH 00/28] arm64: dts: qcom: Fix swapped QMP PHY vdda-phy/vdda-pll supplies Manivannan Sadhasivam via B4 Relay
` (10 preceding siblings ...)
2026-08-03 6:34 ` [PATCH 11/28] arm64: dts: qcom: qcs8550-aim300: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:34 ` Manivannan Sadhasivam via B4 Relay
2026-08-03 6:43 ` sashiko-bot
2026-08-04 13:24 ` Luca Weiss
2026-08-03 6:34 ` [PATCH 13/28] arm64: dts: qcom: qcs6490: " Manivannan Sadhasivam via B4 Relay
` (16 subsequent siblings)
28 siblings, 2 replies; 48+ messages in thread
From: Manivannan Sadhasivam via B4 Relay @ 2026-08-03 6:34 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Krzysztof Kozlowski, Manivannan Sadhasivam,
Manivannan Sadhasivam
From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
The QMP PHY expects the vdda-phy supply to be around 0.88V and the
vdda-pll supply to be 1.2V. But these two supplies are swapped for the
USB QMP PHYs on these boards, feeding 1.2V to vdda-phy and 0.9V to
vdda-pll.
Fix it by swapping the two supplies back.
Fixes: 9af6a9f32ad0 ("arm64: dts: qcom: Add base qcm6490 idp board dts")
Fixes: a319cf4a4b09 ("arm64: dts: qcom: qcm6490: Introduce the Particle Tachyon")
Fixes: eee9602ad649 ("arm64: dts: qcom: qcm6490: Add device-tree for Fairphone 5")
Fixes: 249666e34c24 ("arm64: dts: qcom: add QCM6490 SHIFTphone 8")
Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Assisted-by: Claude:opus-4-8
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 4 ++--
arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 4 ++--
arch/arm64/boot/dts/qcom/qcm6490-particle-tachyon.dts | 4 ++--
arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts | 4 ++--
4 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
index 04cb9230d29f..92a7d80b7fee 100644
--- a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
+++ b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
@@ -1502,8 +1502,8 @@ &usb_1_hsphy {
};
&usb_1_qmpphy {
- vdda-phy-supply = <&vreg_l6b>;
- vdda-pll-supply = <&vreg_l1b>;
+ vdda-phy-supply = <&vreg_l1b>;
+ vdda-pll-supply = <&vreg_l6b>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
index bdc02260f902..58cce89a0c1c 100644
--- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
+++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
@@ -1141,8 +1141,8 @@ &usb_1_hsphy {
};
&usb_1_qmpphy {
- vdda-phy-supply = <&vreg_l6b_1p2>;
- vdda-pll-supply = <&vreg_l1b_0p912>;
+ vdda-phy-supply = <&vreg_l1b_0p912>;
+ vdda-pll-supply = <&vreg_l6b_1p2>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/qcm6490-particle-tachyon.dts b/arch/arm64/boot/dts/qcom/qcm6490-particle-tachyon.dts
index bf18c4852081..17804de03e17 100644
--- a/arch/arm64/boot/dts/qcom/qcm6490-particle-tachyon.dts
+++ b/arch/arm64/boot/dts/qcom/qcm6490-particle-tachyon.dts
@@ -839,8 +839,8 @@ &usb_1_hsphy {
};
&usb_1_qmpphy {
- vdda-phy-supply = <&vreg_l6b_1p2>;
- vdda-pll-supply = <&vreg_l1b_0p912>;
+ vdda-phy-supply = <&vreg_l1b_0p912>;
+ vdda-pll-supply = <&vreg_l6b_1p2>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
index 797f37596bf1..cdaacc09f56c 100644
--- a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
+++ b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
@@ -976,8 +976,8 @@ &usb_1_hsphy {
};
&usb_1_qmpphy {
- vdda-phy-supply = <&vreg_l6b>;
- vdda-pll-supply = <&vreg_l1b>;
+ vdda-phy-supply = <&vreg_l1b>;
+ vdda-pll-supply = <&vreg_l6b>;
status = "okay";
};
--
2.43.0
^ permalink raw reply related [flat|nested] 48+ messages in thread* Re: [PATCH 12/28] arm64: dts: qcom: qcm6490: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:34 ` [PATCH 12/28] arm64: dts: qcom: qcm6490: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:43 ` sashiko-bot
2026-08-04 13:24 ` Luca Weiss
1 sibling, 0 replies; 48+ messages in thread
From: sashiko-bot @ 2026-08-03 6:43 UTC (permalink / raw)
To: Manivannan Sadhasivam; +Cc: devicetree, conor+dt, robh
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] The patch series corrects the swapped `vdda-phy` and `vdda-pll` supplies for several QCM6490 boards, but misses numerous other QCS6490, SC7280, and SC7180 boards that suffer from the exact same misconfiguration.
--
--- Patch [12]: [PATCH 12/28] arm64: dts: qcom: qcm6490: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies ---
commit 25fe3724f708ab3e601c6a304dd1dd8d5ed9eef1
Author: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
arm64: dts: qcom: qcm6490: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
This patch fixes the swapped vdda-phy and vdda-pll supplies for the USB QMP
PHYs on several QCM6490 boards. The QMP PHY expects 0.88V for vdda-phy and
1.2V for vdda-pll, but the device trees previously supplied 1.2V to vdda-phy
and 0.9V to vdda-pll.
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
> index 04cb9230d29fd..92a7d80b7fee6 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
> @@ -1502,8 +1502,8 @@ &usb_1_hsphy {
> };
>
> &usb_1_qmpphy {
> - vdda-phy-supply = <&vreg_l6b>;
> - vdda-pll-supply = <&vreg_l1b>;
> + vdda-phy-supply = <&vreg_l1b>;
> + vdda-pll-supply = <&vreg_l6b>;
[Severity: High]
This is a pre-existing issue, but while you are fixing these QCM6490 boards,
it looks like several other boards in the tree suffer from the exact same
swapped regulator configuration.
Should these boards be fixed as well to avoid over-volting the phy domains?
For example, in arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts:
&usb_1_qmpphy {
vdda-phy-supply = <&vreg_l6b_1p2>;
vdda-pll-supply = <&vreg_l1b_0p912>;
And similarly in SC7280 and SC7180 boards, such as
arch/arm64/boot/dts/qcom/sc7180-idp.dts:
&usb_1_qmpphy {
vdda-phy-supply = <&vreg_l3c_1p2>;
vdda-pll-supply = <&vreg_l4a_0p8>;
Other unpatched boards with the same misconfiguration in usb_1_qmpphy include:
- arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts
- arch/arm64/boot/dts/qcom/qcs6490-thundercomm-rubikpi3.dts
- arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
- arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts
- arch/arm64/boot/dts/qcom/sc7180-ecs-liva-qc710.dts
>
> status = "okay";
> };
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260803-phy-supply-fix-v1-0-5880630cde3e@oss.qualcomm.com?part=12
^ permalink raw reply [flat|nested] 48+ messages in thread* Re: [PATCH 12/28] arm64: dts: qcom: qcm6490: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:34 ` [PATCH 12/28] arm64: dts: qcom: qcm6490: " Manivannan Sadhasivam via B4 Relay
2026-08-03 6:43 ` sashiko-bot
@ 2026-08-04 13:24 ` Luca Weiss
1 sibling, 0 replies; 48+ messages in thread
From: Luca Weiss @ 2026-08-04 13:24 UTC (permalink / raw)
To: manivannan.sadhasivam, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Krzysztof Kozlowski, Manivannan Sadhasivam
On Mon Aug 3, 2026 at 8:34 AM CEST, Manivannan Sadhasivam via B4 Relay wrote:
> From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
>
> The QMP PHY expects the vdda-phy supply to be around 0.88V and the
> vdda-pll supply to be 1.2V. But these two supplies are swapped for the
> USB QMP PHYs on these boards, feeding 1.2V to vdda-phy and 0.9V to
> vdda-pll.
>
> Fix it by swapping the two supplies back.
>
> Fixes: 9af6a9f32ad0 ("arm64: dts: qcom: Add base qcm6490 idp board dts")
> Fixes: a319cf4a4b09 ("arm64: dts: qcom: qcm6490: Introduce the Particle Tachyon")
> Fixes: eee9602ad649 ("arm64: dts: qcom: qcm6490: Add device-tree for Fairphone 5")
> Fixes: 249666e34c24 ("arm64: dts: qcom: add QCM6490 SHIFTphone 8")
> Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Assisted-by: Claude:opus-4-8
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 4 ++--
> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 4 ++--
> arch/arm64/boot/dts/qcom/qcm6490-particle-tachyon.dts | 4 ++--
> arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts | 4 ++--
> 4 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
> index 04cb9230d29f..92a7d80b7fee 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
> @@ -1502,8 +1502,8 @@ &usb_1_hsphy {
> };
>
> &usb_1_qmpphy {
> - vdda-phy-supply = <&vreg_l6b>;
> - vdda-pll-supply = <&vreg_l1b>;
> + vdda-phy-supply = <&vreg_l1b>;
> + vdda-pll-supply = <&vreg_l6b>;
On Fairphone 5 the schematics show:
* VREG_L1B_0P912 <-> VDD_A_USBSSDP_0_CORE
* VREG_L6B_1P2 <-> VDD_A_USBSSDP_0_1P2
So with the updated bindings description, this makes it fairly clear
that l1b is vdda-phy-supply and l6b is vdda-pll-supply. I assume all
other kodiak boards are also wired up that way.
Reviewed-by: Luca Weiss <luca.weiss@fairphone.com>
Sidenote, you could squash the qcm6490, qcs6490 and sc7280 patches into
a single "kodiak" patch, but keeping them separate also works of course.
Regards
Luca
>
> status = "okay";
> };
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> index bdc02260f902..58cce89a0c1c 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> @@ -1141,8 +1141,8 @@ &usb_1_hsphy {
> };
>
> &usb_1_qmpphy {
> - vdda-phy-supply = <&vreg_l6b_1p2>;
> - vdda-pll-supply = <&vreg_l1b_0p912>;
> + vdda-phy-supply = <&vreg_l1b_0p912>;
> + vdda-pll-supply = <&vreg_l6b_1p2>;
>
> status = "okay";
> };
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-particle-tachyon.dts b/arch/arm64/boot/dts/qcom/qcm6490-particle-tachyon.dts
> index bf18c4852081..17804de03e17 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-particle-tachyon.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-particle-tachyon.dts
> @@ -839,8 +839,8 @@ &usb_1_hsphy {
> };
>
> &usb_1_qmpphy {
> - vdda-phy-supply = <&vreg_l6b_1p2>;
> - vdda-pll-supply = <&vreg_l1b_0p912>;
> + vdda-phy-supply = <&vreg_l1b_0p912>;
> + vdda-pll-supply = <&vreg_l6b_1p2>;
>
> status = "okay";
> };
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
> index 797f37596bf1..cdaacc09f56c 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
> @@ -976,8 +976,8 @@ &usb_1_hsphy {
> };
>
> &usb_1_qmpphy {
> - vdda-phy-supply = <&vreg_l6b>;
> - vdda-pll-supply = <&vreg_l1b>;
> + vdda-phy-supply = <&vreg_l1b>;
> + vdda-pll-supply = <&vreg_l6b>;
>
> status = "okay";
> };
^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 13/28] arm64: dts: qcom: qcs6490: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:33 [PATCH 00/28] arm64: dts: qcom: Fix swapped QMP PHY vdda-phy/vdda-pll supplies Manivannan Sadhasivam via B4 Relay
` (11 preceding siblings ...)
2026-08-03 6:34 ` [PATCH 12/28] arm64: dts: qcom: qcm6490: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:34 ` Manivannan Sadhasivam via B4 Relay
2026-08-03 6:46 ` sashiko-bot
2026-08-03 6:34 ` [PATCH 14/28] arm64: dts: qcom: sm7225-fairphone-fp4: " Manivannan Sadhasivam via B4 Relay
` (15 subsequent siblings)
28 siblings, 1 reply; 48+ messages in thread
From: Manivannan Sadhasivam via B4 Relay @ 2026-08-03 6:34 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Krzysztof Kozlowski, Manivannan Sadhasivam,
Manivannan Sadhasivam
From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
The QMP PHY expects the vdda-phy supply to be around 0.88V and the
vdda-pll supply to be 1.2V. But these two supplies are swapped for the
USB QMP PHYs on these boards, feeding 1.2V to vdda-phy and 0.9V to
vdda-pll.
Fix it by swapping the two supplies back.
Fixes: 04cf333afc75 ("arm64: dts: qcom: Add base qcs6490-rb3gen2 board dts")
Fixes: 1cde54c54b83 ("arm64: dts: qcom: qcs6490: Add Thundercomm AI Mini PC G1 IoT")
Fixes: f055a39f6874 ("arm64: dts: qcom: Add qcs6490-rubikpi3 board dts")
Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Assisted-by: Claude:opus-4-8
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 4 ++--
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts | 4 ++--
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-rubikpi3.dts | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
index 37a3b51323ce..8e200ba3711a 100644
--- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
+++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
@@ -1419,8 +1419,8 @@ &usb_1_hsphy {
};
&usb_1_qmpphy {
- vdda-phy-supply = <&vreg_l6b_1p2>;
- vdda-pll-supply = <&vreg_l1b_0p912>;
+ vdda-phy-supply = <&vreg_l1b_0p912>;
+ vdda-pll-supply = <&vreg_l6b_1p2>;
orientation-switch;
diff --git a/arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts b/arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts
index a5ad796cb65d..ae2cc2c2e701 100644
--- a/arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts
+++ b/arch/arm64/boot/dts/qcom/qcs6490-thundercomm-minipc-g1iot.dts
@@ -1059,8 +1059,8 @@ &usb_1_hsphy {
};
&usb_1_qmpphy {
- vdda-phy-supply = <&vreg_l6b_1p2>;
- vdda-pll-supply = <&vreg_l1b_0p912>;
+ vdda-phy-supply = <&vreg_l1b_0p912>;
+ vdda-pll-supply = <&vreg_l6b_1p2>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/qcs6490-thundercomm-rubikpi3.dts b/arch/arm64/boot/dts/qcom/qcs6490-thundercomm-rubikpi3.dts
index f47efca42d48..7336118ae7e3 100644
--- a/arch/arm64/boot/dts/qcom/qcs6490-thundercomm-rubikpi3.dts
+++ b/arch/arm64/boot/dts/qcom/qcs6490-thundercomm-rubikpi3.dts
@@ -1103,8 +1103,8 @@ &usb_1_hsphy {
};
&usb_1_qmpphy {
- vdda-phy-supply = <&vreg_l6b_1p2>;
- vdda-pll-supply = <&vreg_l1b_0p912>;
+ vdda-phy-supply = <&vreg_l1b_0p912>;
+ vdda-pll-supply = <&vreg_l6b_1p2>;
status = "okay";
};
--
2.43.0
^ permalink raw reply related [flat|nested] 48+ messages in thread* Re: [PATCH 13/28] arm64: dts: qcom: qcs6490: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:34 ` [PATCH 13/28] arm64: dts: qcom: qcs6490: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:46 ` sashiko-bot
0 siblings, 0 replies; 48+ messages in thread
From: sashiko-bot @ 2026-08-03 6:46 UTC (permalink / raw)
To: Manivannan Sadhasivam; +Cc: robh, conor+dt, devicetree
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] The patch series fixes swapped `vdda-phy` and `vdda-pll` supplies for the QMP USB PHY on various boards, but misses identical misconfigurations on other closely related boards such as SC7280, SC7180, and SM7225.
--
--- Patch [13]: [PATCH 13/28] arm64: dts: qcom: qcs6490: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies ---
commit 0c6d97f5f784273baeb5afe41418c7609191becd
Author: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
arm64: dts: qcom: qcs6490: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
This patch corrects the swapped vdda-phy and vdda-pll supplies for the USB QMP
PHY on QCS6490 boards.
> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> index 37a3b51323ce5..8e200ba3711ae 100644
> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> @@ -1419,8 +1419,8 @@ &usb_1_hsphy {
> };
>
> &usb_1_qmpphy {
> - vdda-phy-supply = <&vreg_l6b_1p2>;
> - vdda-pll-supply = <&vreg_l1b_0p912>;
> + vdda-phy-supply = <&vreg_l1b_0p912>;
> + vdda-pll-supply = <&vreg_l6b_1p2>;
[Severity: High]
This isn't a bug introduced by this patch, but since you are fixing the
swapped supplies here, should this fix also be applied to other closely
related boards that appear to have the exact same misconfiguration?
For example, in arch/arm64/boot/dts/qcom/sc7280-idp.dtsi:
&usb_1_qmpphy {
vdda-phy-supply = <&vreg_l6b_1p2>;
vdda-pll-supply = <&vreg_l1b_0p8>;
}
And in arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi:
&usb_1_qmpphy {
vdda-phy-supply = <&vdd_a_usbssdp_0_1p2>;
vdda-pll-supply = <&vdd_a_usbssdp_0_core>;
}
Similarly in arch/arm64/boot/dts/qcom/sc7180-ecs-liva-qc710.dts:
&usb_1_qmpphy {
vdda-phy-supply = <&vreg_l3c_1p2>;
vdda-pll-supply = <&vreg_l4a_0p8>;
}
>
> orientation-switch;
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260803-phy-supply-fix-v1-0-5880630cde3e@oss.qualcomm.com?part=13
^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 14/28] arm64: dts: qcom: sm7225-fairphone-fp4: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:33 [PATCH 00/28] arm64: dts: qcom: Fix swapped QMP PHY vdda-phy/vdda-pll supplies Manivannan Sadhasivam via B4 Relay
` (12 preceding siblings ...)
2026-08-03 6:34 ` [PATCH 13/28] arm64: dts: qcom: qcs6490: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:34 ` Manivannan Sadhasivam via B4 Relay
2026-08-04 13:26 ` Luca Weiss
2026-08-03 6:34 ` [PATCH 15/28] arm64: dts: qcom: sc7180: " Manivannan Sadhasivam via B4 Relay
` (14 subsequent siblings)
28 siblings, 1 reply; 48+ messages in thread
From: Manivannan Sadhasivam via B4 Relay @ 2026-08-03 6:34 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Krzysztof Kozlowski, Manivannan Sadhasivam,
Manivannan Sadhasivam
From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
The QMP PHY expects the vdda-phy supply to be around 0.88V and the
vdda-pll supply to be 1.2V. But these two supplies are swapped for the
USB QMP PHY on this board, feeding 1.2V to vdda-phy and 0.9V to
vdda-pll.
Fix it by swapping the two supplies back.
Fixes: 4cbea668767d ("arm64: dts: qcom: sm7225: Add device tree for Fairphone 4")
Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Assisted-by: Claude:opus-4-8
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
index 23f950067a08..bea82cbc2c88 100644
--- a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
+++ b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
@@ -1247,8 +1247,8 @@ &usb_1_hsphy {
};
&usb_1_qmpphy {
- vdda-phy-supply = <&vreg_l22a>;
- vdda-pll-supply = <&vreg_l16a>;
+ vdda-phy-supply = <&vreg_l16a>;
+ vdda-pll-supply = <&vreg_l22a>;
status = "okay";
};
--
2.43.0
^ permalink raw reply related [flat|nested] 48+ messages in thread* Re: [PATCH 14/28] arm64: dts: qcom: sm7225-fairphone-fp4: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:34 ` [PATCH 14/28] arm64: dts: qcom: sm7225-fairphone-fp4: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-04 13:26 ` Luca Weiss
0 siblings, 0 replies; 48+ messages in thread
From: Luca Weiss @ 2026-08-04 13:26 UTC (permalink / raw)
To: manivannan.sadhasivam, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Krzysztof Kozlowski, Manivannan Sadhasivam
On Mon Aug 3, 2026 at 8:34 AM CEST, Manivannan Sadhasivam via B4 Relay wrote:
> From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
>
> The QMP PHY expects the vdda-phy supply to be around 0.88V and the
> vdda-pll supply to be 1.2V. But these two supplies are swapped for the
> USB QMP PHY on this board, feeding 1.2V to vdda-phy and 0.9V to
> vdda-pll.
>
> Fix it by swapping the two supplies back.
>
> Fixes: 4cbea668767d ("arm64: dts: qcom: sm7225: Add device tree for Fairphone 4")
> Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Assisted-by: Claude:opus-4-8
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> index 23f950067a08..bea82cbc2c88 100644
> --- a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> +++ b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> @@ -1247,8 +1247,8 @@ &usb_1_hsphy {
> };
>
> &usb_1_qmpphy {
> - vdda-phy-supply = <&vreg_l22a>;
> - vdda-pll-supply = <&vreg_l16a>;
> + vdda-phy-supply = <&vreg_l16a>;
> + vdda-pll-supply = <&vreg_l22a>;
Schematics confirm:
* VREG_L16A_0P88 <-> VDD_A_USBSSDP_0P9
* VREG_L22A_1P2 <-> VDD_A_USBSSDP_1P2
So this also matches.
Reviewed-by: Luca Weiss <luca.weiss@fairphone.com>
>
> status = "okay";
> };
^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 15/28] arm64: dts: qcom: sc7180: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:33 [PATCH 00/28] arm64: dts: qcom: Fix swapped QMP PHY vdda-phy/vdda-pll supplies Manivannan Sadhasivam via B4 Relay
` (13 preceding siblings ...)
2026-08-03 6:34 ` [PATCH 14/28] arm64: dts: qcom: sm7225-fairphone-fp4: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:34 ` Manivannan Sadhasivam via B4 Relay
2026-08-03 6:34 ` [PATCH 16/28] arm64: dts: qcom: sc7280: " Manivannan Sadhasivam via B4 Relay
` (13 subsequent siblings)
28 siblings, 0 replies; 48+ messages in thread
From: Manivannan Sadhasivam via B4 Relay @ 2026-08-03 6:34 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Krzysztof Kozlowski, Manivannan Sadhasivam,
Manivannan Sadhasivam
From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
The QMP PHY expects the vdda-phy supply to be around 0.88V and the
vdda-pll supply to be 1.2V. But these two supplies are swapped for the
USB QMP PHYs on these boards, feeding 1.2V to vdda-phy and 0.9V to
vdda-pll.
Fix it by swapping the two supplies back.
Fixes: 0b766e7fe5a2 ("arm64: dts: qcom: sc7180: Add USB related nodes")
Fixes: 7ec3e67307f8 ("arm64: dts: qcom: sc7180-trogdor: add initial trogdor and lazor dt")
Fixes: 4a9f8f8f2ada ("arm64: dts: qcom: Add Acer Aspire 1")
Fixes: de8eed359759 ("arm64: dts: qcom: Add support for ECS LIVA QC710")
Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Assisted-by: Claude:opus-4-8
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts | 4 ++--
arch/arm64/boot/dts/qcom/sc7180-ecs-liva-qc710.dts | 4 ++--
arch/arm64/boot/dts/qcom/sc7180-idp.dts | 4 ++--
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 4 ++--
4 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts b/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts
index 1514da636269..d9c70897b6f1 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts
@@ -631,8 +631,8 @@ &usb_1_hsphy {
};
&usb_1_qmpphy {
- vdda-phy-supply = <&vreg_l3c_1p2>;
- vdda-pll-supply = <&vreg_l4a_0p8>;
+ vdda-phy-supply = <&vreg_l4a_0p8>;
+ vdda-pll-supply = <&vreg_l3c_1p2>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/sc7180-ecs-liva-qc710.dts b/arch/arm64/boot/dts/qcom/sc7180-ecs-liva-qc710.dts
index b84da371581b..3100fab18787 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-ecs-liva-qc710.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-ecs-liva-qc710.dts
@@ -563,8 +563,8 @@ &usb_1_hsphy {
};
&usb_1_qmpphy {
- vdda-phy-supply = <&vreg_l3c_1p2>;
- vdda-pll-supply = <&vreg_l4a_0p8>;
+ vdda-phy-supply = <&vreg_l4a_0p8>;
+ vdda-pll-supply = <&vreg_l3c_1p2>;
/delete-property/ mode-switch;
/delete-property/ orientation-switch;
diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
index 0bce3eefca2e..acfb9937651d 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
@@ -461,8 +461,8 @@ &usb_1_hsphy {
&usb_1_qmpphy {
status = "okay";
- vdda-phy-supply = <&vreg_l3c_1p2>;
- vdda-pll-supply = <&vreg_l4a_0p8>;
+ vdda-phy-supply = <&vreg_l4a_0p8>;
+ vdda-pll-supply = <&vreg_l3c_1p2>;
};
&venus {
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
index b398f69917f0..d31ffebe27c3 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
@@ -993,8 +993,8 @@ &usb_1_hsphy {
&usb_1_qmpphy {
status = "okay";
- vdda-phy-supply = <&vdda_usb_ss_dp_1p2>;
- vdda-pll-supply = <&vdda_usb_ss_dp_core>;
+ vdda-phy-supply = <&vdda_usb_ss_dp_core>;
+ vdda-pll-supply = <&vdda_usb_ss_dp_1p2>;
};
&venus {
--
2.43.0
^ permalink raw reply related [flat|nested] 48+ messages in thread* [PATCH 16/28] arm64: dts: qcom: sc7280: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:33 [PATCH 00/28] arm64: dts: qcom: Fix swapped QMP PHY vdda-phy/vdda-pll supplies Manivannan Sadhasivam via B4 Relay
` (14 preceding siblings ...)
2026-08-03 6:34 ` [PATCH 15/28] arm64: dts: qcom: sc7180: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:34 ` Manivannan Sadhasivam via B4 Relay
2026-08-03 6:34 ` [PATCH 17/28] arm64: dts: qcom: sc8180x: " Manivannan Sadhasivam via B4 Relay
` (12 subsequent siblings)
28 siblings, 0 replies; 48+ messages in thread
From: Manivannan Sadhasivam via B4 Relay @ 2026-08-03 6:34 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Krzysztof Kozlowski, Manivannan Sadhasivam,
Manivannan Sadhasivam
From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
The QMP PHY expects the vdda-phy supply to be around 0.88V and the
vdda-pll supply to be 1.2V. But these two supplies are swapped for the
USB QMP PHYs on these boards, feeding 1.2V to vdda-phy and 0.9V to
vdda-pll.
Fix it by swapping the two supplies back.
Fixes: 97a5b73b7058 ("arm64: dts: qcom: sc7280-idp: Add device tree files for IDP2")
Fixes: 116f7cc43d28 ("arm64: dts: qcom: sc7280: Add herobrine-r1")
Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Assisted-by: Claude:opus-4-8
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 4 ++--
arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
index 8cac4ce9c851..23ced0621c99 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
@@ -542,8 +542,8 @@ &usb_1_hsphy {
&usb_1_qmpphy {
status = "okay";
- vdda-phy-supply = <&vreg_l6b_1p2>;
- vdda-pll-supply = <&vreg_l1b_0p8>;
+ vdda-phy-supply = <&vreg_l1b_0p8>;
+ vdda-pll-supply = <&vreg_l6b_1p2>;
};
&uart7 {
diff --git a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
index 9ae9af40f4d2..264029ff3f90 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi
@@ -465,8 +465,8 @@ &usb_1_hsphy {
};
&usb_1_qmpphy {
- vdda-phy-supply = <&vdd_a_usbssdp_0_1p2>;
- vdda-pll-supply = <&vdd_a_usbssdp_0_core>;
+ vdda-phy-supply = <&vdd_a_usbssdp_0_core>;
+ vdda-pll-supply = <&vdd_a_usbssdp_0_1p2>;
};
&usb_2_hsphy {
--
2.43.0
^ permalink raw reply related [flat|nested] 48+ messages in thread* [PATCH 17/28] arm64: dts: qcom: sc8180x: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:33 [PATCH 00/28] arm64: dts: qcom: Fix swapped QMP PHY vdda-phy/vdda-pll supplies Manivannan Sadhasivam via B4 Relay
` (15 preceding siblings ...)
2026-08-03 6:34 ` [PATCH 16/28] arm64: dts: qcom: sc7280: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:34 ` Manivannan Sadhasivam via B4 Relay
2026-08-03 6:34 ` [PATCH 18/28] arm64: dts: qcom: hamoa: " Manivannan Sadhasivam via B4 Relay
` (11 subsequent siblings)
28 siblings, 0 replies; 48+ messages in thread
From: Manivannan Sadhasivam via B4 Relay @ 2026-08-03 6:34 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Krzysztof Kozlowski, Manivannan Sadhasivam,
Manivannan Sadhasivam
From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
The QMP PHY expects the vdda-phy supply to be around 0.88V and the
vdda-pll supply to be 1.2V. But these two supplies are swapped for the
USB QMP PHYs on these boards, feeding 1.2V to vdda-phy and 0.88V to
vdda-pll.
Fix it by swapping the two supplies back.
Fixes: 2ce38cc1e8fe ("arm64: dts: qcom: sc8180x: Introduce Primus")
Fixes: 20dea72a393c ("arm64: dts: qcom: sc8180x: Introduce Lenovo Flex 5G")
Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Assisted-by: Claude:opus-4-8
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts | 16 ++++++++--------
arch/arm64/boot/dts/qcom/sc8180x-primus.dts | 16 ++++++++--------
2 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
index d86a31ddede2..2e3ae73c6459 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
+++ b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
@@ -570,15 +570,15 @@ &usb_mp_hsphy1 {
};
&usb_mp_qmpphy0 {
- vdda-phy-supply = <&vreg_l3c_1p2>;
- vdda-pll-supply = <&vreg_l5e_0p88>;
+ vdda-phy-supply = <&vreg_l5e_0p88>;
+ vdda-pll-supply = <&vreg_l3c_1p2>;
status = "okay";
};
&usb_mp_qmpphy1 {
- vdda-phy-supply = <&vreg_l3c_1p2>;
- vdda-pll-supply = <&vreg_l5e_0p88>;
+ vdda-phy-supply = <&vreg_l5e_0p88>;
+ vdda-pll-supply = <&vreg_l3c_1p2>;
status = "okay";
};
@@ -592,8 +592,8 @@ &usb_prim_hsphy {
};
&usb_prim_qmpphy {
- vdda-phy-supply = <&vreg_l3c_1p2>;
- vdda-pll-supply = <&vreg_l5e_0p88>;
+ vdda-phy-supply = <&vreg_l5e_0p88>;
+ vdda-pll-supply = <&vreg_l3c_1p2>;
orientation-switch;
@@ -633,8 +633,8 @@ &usb_sec_hsphy {
};
&usb_sec_qmpphy {
- vdda-phy-supply = <&vreg_l3c_1p2>;
- vdda-pll-supply = <&vreg_l5e_0p88>;
+ vdda-phy-supply = <&vreg_l5e_0p88>;
+ vdda-pll-supply = <&vreg_l3c_1p2>;
orientation-switch;
diff --git a/arch/arm64/boot/dts/qcom/sc8180x-primus.dts b/arch/arm64/boot/dts/qcom/sc8180x-primus.dts
index aff398390eba..557358fbb5b3 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x-primus.dts
+++ b/arch/arm64/boot/dts/qcom/sc8180x-primus.dts
@@ -669,15 +669,15 @@ &usb_mp_hsphy1 {
};
&usb_mp_qmpphy0 {
- vdda-phy-supply = <&vreg_l3c_1p2>;
- vdda-pll-supply = <&vreg_l5e_0p88>;
+ vdda-phy-supply = <&vreg_l5e_0p88>;
+ vdda-pll-supply = <&vreg_l3c_1p2>;
status = "okay";
};
&usb_mp_qmpphy1 {
- vdda-phy-supply = <&vreg_l3c_1p2>;
- vdda-pll-supply = <&vreg_l5e_0p88>;
+ vdda-phy-supply = <&vreg_l5e_0p88>;
+ vdda-pll-supply = <&vreg_l3c_1p2>;
status = "okay";
};
@@ -691,8 +691,8 @@ &usb_prim_hsphy {
};
&usb_prim_qmpphy {
- vdda-phy-supply = <&vreg_l3c_1p2>;
- vdda-pll-supply = <&vreg_l5e_0p88>;
+ vdda-phy-supply = <&vreg_l5e_0p88>;
+ vdda-pll-supply = <&vreg_l3c_1p2>;
orientation-switch;
@@ -728,8 +728,8 @@ &usb_sec_hsphy {
};
&usb_sec_qmpphy {
- vdda-phy-supply = <&vreg_l3c_1p2>;
- vdda-pll-supply = <&vreg_l5e_0p88>;
+ vdda-phy-supply = <&vreg_l5e_0p88>;
+ vdda-pll-supply = <&vreg_l3c_1p2>;
orientation-switch;
--
2.43.0
^ permalink raw reply related [flat|nested] 48+ messages in thread* [PATCH 18/28] arm64: dts: qcom: hamoa: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:33 [PATCH 00/28] arm64: dts: qcom: Fix swapped QMP PHY vdda-phy/vdda-pll supplies Manivannan Sadhasivam via B4 Relay
` (16 preceding siblings ...)
2026-08-03 6:34 ` [PATCH 17/28] arm64: dts: qcom: sc8180x: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:34 ` Manivannan Sadhasivam via B4 Relay
2026-08-03 6:45 ` sashiko-bot
2026-08-03 6:34 ` [PATCH 19/28] arm64: dts: qcom: purwa: " Manivannan Sadhasivam via B4 Relay
` (10 subsequent siblings)
28 siblings, 1 reply; 48+ messages in thread
From: Manivannan Sadhasivam via B4 Relay @ 2026-08-03 6:34 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Krzysztof Kozlowski, Manivannan Sadhasivam,
Manivannan Sadhasivam
From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
The QMP PHY expects the vdda-phy supply to be around 0.88V and the
vdda-pll supply to be 1.2V. But these two supplies are swapped for the
USB QMP PHYs on these boards, feeding 1.2V to vdda-phy and 0.9V to
vdda-pll.
Fix it by swapping the two supplies back.
Fixes: 5098ae93ce44 ("arm64: dts: qcom: Add HAMOA-IOT-SOM platform")
Fixes: af241225893a ("arm64: dts: qcom: Add the Lenovo IdeaCentre Mini X")
Fixes: ae5cee8e7349 ("arm64: dts: qcom: x1e80100-crd: Fix USB PHYs regulators")
Fixes: 20676f7819d7 ("arm64: dts: qcom: x1e80100-qcp: Fix USB PHYs regulators")
Fixes: d0e2f8f62dff ("arm64: dts: qcom: Add device tree for ASUS Vivobook S 15")
Fixes: 6516961352a1 ("arm64: dts: qcom: Add support for X1-based Asus Zenbook A14")
Fixes: 45247fe17db2 ("arm64: dts: qcom: x1e80100: add Lenovo Thinkpad Yoga slim 7x devicetree")
Fixes: 6f18b8d4142c ("arm64: dts: qcom: x1e80100-hp-x14: dt for HP Omnibook X Laptop 14")
Fixes: 0d72ccaa1e84 ("arm64: dts: qcom: Add support for X1-based Surface Pro 11")
Fixes: 09d77be56093 ("arm64: dts: qcom: Add support for X1-based Surface Laptop 7 devices")
Fixes: 8cf65490cdb0 ("arm64: dts: qcom: Add dts for Medion SPRCHRGD 14 S1")
Fixes: f5b788d0e8cd ("arm64: dts: qcom: Add support for X1-based Dell XPS 13 9345")
Fixes: 7b8a31e82b87 ("arm64: dts: qcom: Add X1E001DE Snapdragon Devkit for Windows")
Fixes: 7d1cbe2f4985 ("arm64: dts: qcom: Add X1E78100 ThinkPad T14s Gen 6")
Fixes: e7733b42111c ("arm64: dts: qcom: Add support for Dell Inspiron 7441 / Latitude 7455")
Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Assisted-by: Claude:opus-4-8
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi | 20 ++++++++++----------
.../qcom/hamoa-lenovo-ideacentre-mini-01q8x10.dts | 20 ++++++++++----------
arch/arm64/boot/dts/qcom/x1-asus-vivobook-s15.dtsi | 20 ++++++++++----------
arch/arm64/boot/dts/qcom/x1-asus-zenbook-a14.dtsi | 20 ++++++++++----------
arch/arm64/boot/dts/qcom/x1-crd.dtsi | 20 ++++++++++----------
arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi | 16 ++++++++--------
arch/arm64/boot/dts/qcom/x1-hp-omnibook-x14.dtsi | 12 ++++++------
arch/arm64/boot/dts/qcom/x1-microsoft-denali.dtsi | 8 ++++----
arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 20 ++++++++++----------
.../boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi | 20 ++++++++++----------
.../arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts | 16 ++++++++--------
.../boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 12 ++++++------
.../boot/dts/qcom/x1e80100-medion-sprchrgd-14-s1.dts | 16 ++++++++--------
.../boot/dts/qcom/x1e80100-microsoft-romulus.dtsi | 16 ++++++++--------
arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 20 ++++++++++----------
15 files changed, 128 insertions(+), 128 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi b/arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi
index 9c5e77df0054..bc70fe5db96f 100644
--- a/arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi
+++ b/arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi
@@ -590,8 +590,8 @@ &usb_1_ss0_hsphy {
};
&usb_1_ss0_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l1j_0p8>;
+ vdda-phy-supply = <&vreg_l1j_0p8>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
status = "okay";
};
@@ -611,8 +611,8 @@ &usb_1_ss1_hsphy {
};
&usb_1_ss1_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l2d_0p9>;
+ vdda-phy-supply = <&vreg_l2d_0p9>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
status = "okay";
};
@@ -632,8 +632,8 @@ &usb_1_ss2_hsphy {
};
&usb_1_ss2_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l2d_0p9>;
+ vdda-phy-supply = <&vreg_l2d_0p9>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
status = "okay";
};
@@ -670,15 +670,15 @@ &usb_mp_hsphy1 {
};
&usb_mp_qmpphy0 {
- vdda-phy-supply = <&vreg_l3e_1p2>;
- vdda-pll-supply = <&vreg_l3c_0p8>;
+ vdda-phy-supply = <&vreg_l3c_0p8>;
+ vdda-pll-supply = <&vreg_l3e_1p2>;
status = "okay";
};
&usb_mp_qmpphy1 {
- vdda-phy-supply = <&vreg_l3e_1p2>;
- vdda-pll-supply = <&vreg_l3c_0p8>;
+ vdda-phy-supply = <&vreg_l3c_0p8>;
+ vdda-pll-supply = <&vreg_l3e_1p2>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/hamoa-lenovo-ideacentre-mini-01q8x10.dts b/arch/arm64/boot/dts/qcom/hamoa-lenovo-ideacentre-mini-01q8x10.dts
index bfb7cea56df9..284825008389 100644
--- a/arch/arm64/boot/dts/qcom/hamoa-lenovo-ideacentre-mini-01q8x10.dts
+++ b/arch/arm64/boot/dts/qcom/hamoa-lenovo-ideacentre-mini-01q8x10.dts
@@ -1101,8 +1101,8 @@ &usb_1_ss0_hsphy {
};
&usb_1_ss0_qmpphy {
- vdda-phy-supply = <&vreg_l2j>;
- vdda-pll-supply = <&vreg_l1j>;
+ vdda-phy-supply = <&vreg_l1j>;
+ vdda-pll-supply = <&vreg_l2j>;
status = "okay";
};
@@ -1112,8 +1112,8 @@ &usb_1_ss0_qmpphy_out {
};
&usb_1_ss1_qmpphy {
- vdda-phy-supply = <&vreg_l2j>;
- vdda-pll-supply = <&vreg_l2d>;
+ vdda-phy-supply = <&vreg_l2d>;
+ vdda-pll-supply = <&vreg_l2j>;
/delete-property/ mode-switch;
/delete-property/ orientation-switch;
@@ -1138,8 +1138,8 @@ usb_1_ss1_qmpphy_out_dp: endpoint@0 {
};
&usb_1_ss2_qmpphy {
- vdda-phy-supply = <&vreg_l2j>;
- vdda-pll-supply = <&vreg_l2d>;
+ vdda-phy-supply = <&vreg_l2d>;
+ vdda-pll-supply = <&vreg_l2j>;
/delete-property/ mode-switch;
/delete-property/ orientation-switch;
@@ -1186,15 +1186,15 @@ &usb_mp_hsphy1 {
};
&usb_mp_qmpphy0 {
- vdda-phy-supply = <&vreg_l3e>;
- vdda-pll-supply = <&vreg_l3c>;
+ vdda-phy-supply = <&vreg_l3c>;
+ vdda-pll-supply = <&vreg_l3e>;
status = "okay";
};
&usb_mp_qmpphy1 {
- vdda-phy-supply = <&vreg_l3e>;
- vdda-pll-supply = <&vreg_l3c>;
+ vdda-phy-supply = <&vreg_l3c>;
+ vdda-pll-supply = <&vreg_l3e>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/x1-asus-vivobook-s15.dtsi b/arch/arm64/boot/dts/qcom/x1-asus-vivobook-s15.dtsi
index 48c4ad648354..0dc7c1b5a14a 100644
--- a/arch/arm64/boot/dts/qcom/x1-asus-vivobook-s15.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1-asus-vivobook-s15.dtsi
@@ -1226,8 +1226,8 @@ &usb_1_ss0_hsphy {
};
&usb_1_ss0_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l1j_0p8>;
+ vdda-phy-supply = <&vreg_l1j_0p8>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
status = "okay";
};
@@ -1256,8 +1256,8 @@ &usb_1_ss1_hsphy {
};
&usb_1_ss1_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l2d_0p9>;
+ vdda-phy-supply = <&vreg_l2d_0p9>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
status = "okay";
};
@@ -1277,8 +1277,8 @@ &usb_1_ss1_qmpphy_out {
};
&usb_1_ss2_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l2d_0p9>;
+ vdda-phy-supply = <&vreg_l2d_0p9>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
/delete-property/ mode-switch;
/delete-property/ orientation-switch;
@@ -1342,15 +1342,15 @@ &usb_mp_hsphy1 {
};
&usb_mp_qmpphy0 {
- vdda-phy-supply = <&vreg_l3e_1p2>;
- vdda-pll-supply = <&vreg_l3c_0p8>;
+ vdda-phy-supply = <&vreg_l3c_0p8>;
+ vdda-pll-supply = <&vreg_l3e_1p2>;
status = "okay";
};
&usb_mp_qmpphy1 {
- vdda-phy-supply = <&vreg_l3e_1p2>;
- vdda-pll-supply = <&vreg_l3c_0p8>;
+ vdda-phy-supply = <&vreg_l3c_0p8>;
+ vdda-pll-supply = <&vreg_l3e_1p2>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/x1-asus-zenbook-a14.dtsi b/arch/arm64/boot/dts/qcom/x1-asus-zenbook-a14.dtsi
index 66d566808f58..59cbbfbce490 100644
--- a/arch/arm64/boot/dts/qcom/x1-asus-zenbook-a14.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1-asus-zenbook-a14.dtsi
@@ -1454,8 +1454,8 @@ &usb_1_ss0_hsphy {
};
&usb_1_ss0_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l1j_0p9>;
+ vdda-phy-supply = <&vreg_l1j_0p9>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
status = "okay";
};
@@ -1484,8 +1484,8 @@ &usb_1_ss1_hsphy {
};
&usb_1_ss1_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l2d_0p9>;
+ vdda-phy-supply = <&vreg_l2d_0p9>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
status = "okay";
};
@@ -1505,8 +1505,8 @@ &usb_1_ss1_qmpphy_out {
};
&usb_1_ss2_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l2d_0p9>;
+ vdda-phy-supply = <&vreg_l2d_0p9>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
/delete-property/ mode-switch;
/delete-property/ orientation-switch;
@@ -1551,15 +1551,15 @@ &usb_mp_hsphy1 {
};
&usb_mp_qmpphy0 {
- vdda-phy-supply = <&vreg_l3e_1p2>;
- vdda-pll-supply = <&vreg_l3c_0p9>;
+ vdda-phy-supply = <&vreg_l3c_0p9>;
+ vdda-pll-supply = <&vreg_l3e_1p2>;
status = "okay";
};
&usb_mp_qmpphy1 {
- vdda-phy-supply = <&vreg_l3e_1p2>;
- vdda-pll-supply = <&vreg_l3c_0p9>;
+ vdda-phy-supply = <&vreg_l3c_0p9>;
+ vdda-pll-supply = <&vreg_l3e_1p2>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/x1-crd.dtsi b/arch/arm64/boot/dts/qcom/x1-crd.dtsi
index a9c5c523575e..107fe2867e73 100644
--- a/arch/arm64/boot/dts/qcom/x1-crd.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1-crd.dtsi
@@ -1734,8 +1734,8 @@ &usb_1_ss0_hsphy {
};
&usb_1_ss0_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l1j_0p8>;
+ vdda-phy-supply = <&vreg_l1j_0p8>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
status = "okay";
};
@@ -1764,8 +1764,8 @@ &usb_1_ss1_hsphy {
};
&usb_1_ss1_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l2d_0p9>;
+ vdda-phy-supply = <&vreg_l2d_0p9>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
status = "okay";
};
@@ -1794,8 +1794,8 @@ &usb_1_ss2_hsphy {
};
&usb_1_ss2_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l2d_0p9>;
+ vdda-phy-supply = <&vreg_l2d_0p9>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
status = "okay";
};
@@ -1836,15 +1836,15 @@ &usb_mp_hsphy1 {
};
&usb_mp_qmpphy0 {
- vdda-phy-supply = <&vreg_l3e_1p2>;
- vdda-pll-supply = <&vreg_l3c_0p8>;
+ vdda-phy-supply = <&vreg_l3c_0p8>;
+ vdda-pll-supply = <&vreg_l3e_1p2>;
status = "okay";
};
&usb_mp_qmpphy1 {
- vdda-phy-supply = <&vreg_l3e_1p2>;
- vdda-pll-supply = <&vreg_l3c_0p8>;
+ vdda-phy-supply = <&vreg_l3c_0p8>;
+ vdda-pll-supply = <&vreg_l3e_1p2>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi b/arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi
index db291730130c..c7c793338699 100644
--- a/arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi
@@ -1568,8 +1568,8 @@ &usb_1_ss0_hsphy {
};
&usb_1_ss0_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l1j_0p8>;
+ vdda-phy-supply = <&vreg_l1j_0p8>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
status = "okay";
};
@@ -1598,8 +1598,8 @@ &usb_1_ss1_hsphy {
};
&usb_1_ss1_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l2d_0p9>;
+ vdda-phy-supply = <&vreg_l2d_0p9>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
status = "okay";
};
@@ -1637,8 +1637,8 @@ &usb_mp_hsphy0 {
};
&usb_mp_qmpphy0 {
- vdda-phy-supply = <&vreg_l3e_1p2>;
- vdda-pll-supply = <&vreg_l3c_0p8>;
+ vdda-phy-supply = <&vreg_l3c_0p8>;
+ vdda-pll-supply = <&vreg_l3e_1p2>;
status = "okay";
};
@@ -1651,8 +1651,8 @@ &usb_mp_hsphy1 {
};
&usb_mp_qmpphy1 {
- vdda-phy-supply = <&vreg_l3e_1p2>;
- vdda-pll-supply = <&vreg_l3c_0p8>;
+ vdda-phy-supply = <&vreg_l3c_0p8>;
+ vdda-pll-supply = <&vreg_l3e_1p2>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/x1-hp-omnibook-x14.dtsi b/arch/arm64/boot/dts/qcom/x1-hp-omnibook-x14.dtsi
index 02708f23a865..dba8cee43e29 100644
--- a/arch/arm64/boot/dts/qcom/x1-hp-omnibook-x14.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1-hp-omnibook-x14.dtsi
@@ -1466,8 +1466,8 @@ &usb_1_ss0_hsphy {
};
&usb_1_ss0_qmpphy {
- vdda-phy-supply = <&vreg_l3e_1p2>;
- vdda-pll-supply = <&vreg_l1j_0p8>;
+ vdda-phy-supply = <&vreg_l1j_0p8>;
+ vdda-pll-supply = <&vreg_l3e_1p2>;
status = "okay";
};
@@ -1496,8 +1496,8 @@ &usb_1_ss1_hsphy {
};
&usb_1_ss1_qmpphy {
- vdda-phy-supply = <&vreg_l3e_1p2>;
- vdda-pll-supply = <&vreg_l2d_0p9>;
+ vdda-phy-supply = <&vreg_l2d_0p9>;
+ vdda-pll-supply = <&vreg_l3e_1p2>;
status = "okay";
};
@@ -1533,8 +1533,8 @@ &usb_mp_hsphy0 {
};
&usb_mp_qmpphy0 {
- vdda-phy-supply = <&vreg_l3e_1p2>;
- vdda-pll-supply = <&vreg_l3c_0p8>;
+ vdda-phy-supply = <&vreg_l3c_0p8>;
+ vdda-pll-supply = <&vreg_l3e_1p2>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/x1-microsoft-denali.dtsi b/arch/arm64/boot/dts/qcom/x1-microsoft-denali.dtsi
index 7559557610ed..ce7d958ca687 100644
--- a/arch/arm64/boot/dts/qcom/x1-microsoft-denali.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1-microsoft-denali.dtsi
@@ -1268,8 +1268,8 @@ &usb_1_ss0_hsphy {
};
&usb_1_ss0_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l1j_0p8>;
+ vdda-phy-supply = <&vreg_l1j_0p8>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
status = "okay";
};
@@ -1298,8 +1298,8 @@ &usb_1_ss1_hsphy {
};
&usb_1_ss1_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l2d_0p9>;
+ vdda-phy-supply = <&vreg_l2d_0p9>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
index 2e38402e2c14..be1a8ac8c699 100644
--- a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
+++ b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
@@ -1382,8 +1382,8 @@ &usb_1_ss0_hsphy {
};
&usb_1_ss0_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l1j_0p8>;
+ vdda-phy-supply = <&vreg_l1j_0p8>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
status = "okay";
};
@@ -1413,8 +1413,8 @@ &usb_1_ss1_hsphy {
};
&usb_1_ss1_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l2d_0p9>;
+ vdda-phy-supply = <&vreg_l2d_0p9>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
status = "okay";
};
@@ -1443,8 +1443,8 @@ &usb_1_ss2_hsphy {
};
&usb_1_ss2_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l2d_0p9>;
+ vdda-phy-supply = <&vreg_l2d_0p9>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
status = "okay";
};
@@ -1486,15 +1486,15 @@ &usb_mp_hsphy1 {
};
&usb_mp_qmpphy0 {
- vdda-phy-supply = <&vreg_l3e_1p2>;
- vdda-pll-supply = <&vreg_l3c_0p8>;
+ vdda-phy-supply = <&vreg_l3c_0p8>;
+ vdda-pll-supply = <&vreg_l3e_1p2>;
status = "okay";
};
&usb_mp_qmpphy1 {
- vdda-phy-supply = <&vreg_l3e_1p2>;
- vdda-pll-supply = <&vreg_l3c_0p8>;
+ vdda-phy-supply = <&vreg_l3c_0p8>;
+ vdda-pll-supply = <&vreg_l3e_1p2>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi
index 5d49df41be02..0bee2a3d6e7a 100644
--- a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi
@@ -1601,8 +1601,8 @@ &usb_1_ss0_hsphy {
};
&usb_1_ss0_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l1j_0p8>;
+ vdda-phy-supply = <&vreg_l1j_0p8>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
status = "okay";
};
@@ -1631,8 +1631,8 @@ &usb_1_ss1_hsphy {
};
&usb_1_ss1_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l2d_0p9>;
+ vdda-phy-supply = <&vreg_l2d_0p9>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
status = "okay";
};
@@ -1652,8 +1652,8 @@ &usb_1_ss1_qmpphy_out {
};
&usb_1_ss2_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l2d_0p9>;
+ vdda-phy-supply = <&vreg_l2d_0p9>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
/delete-property/ mode-switch;
/delete-property/ orientation-switch;
@@ -1717,15 +1717,15 @@ &usb_mp_hsphy1 {
};
&usb_mp_qmpphy0 {
- vdda-phy-supply = <&vreg_l3e_1p2>;
- vdda-pll-supply = <&vreg_l3c_0p8>;
+ vdda-phy-supply = <&vreg_l3c_0p8>;
+ vdda-pll-supply = <&vreg_l3e_1p2>;
status = "okay";
};
&usb_mp_qmpphy1 {
- vdda-phy-supply = <&vreg_l3e_1p2>;
- vdda-pll-supply = <&vreg_l3c_0p8>;
+ vdda-phy-supply = <&vreg_l3c_0p8>;
+ vdda-pll-supply = <&vreg_l3e_1p2>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
index ce7b10ea89b6..2be5a37c00cc 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
@@ -1286,8 +1286,8 @@ &usb_1_ss0_hsphy {
};
&usb_1_ss0_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l1j_0p9>;
+ vdda-phy-supply = <&vreg_l1j_0p9>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
status = "okay";
};
@@ -1316,8 +1316,8 @@ &usb_1_ss1_hsphy {
};
&usb_1_ss1_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l2d_0p9>;
+ vdda-phy-supply = <&vreg_l2d_0p9>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
status = "okay";
};
@@ -1357,15 +1357,15 @@ &usb_mp_hsphy1 {
};
&usb_mp_qmpphy0 {
- vdda-phy-supply = <&vreg_l3e_1p2>;
- vdda-pll-supply = <&vreg_l3c_0p9>;
+ vdda-phy-supply = <&vreg_l3c_0p9>;
+ vdda-pll-supply = <&vreg_l3e_1p2>;
status = "okay";
};
&usb_mp_qmpphy1 {
- vdda-phy-supply = <&vreg_l3e_1p2>;
- vdda-pll-supply = <&vreg_l3c_0p9>;
+ vdda-phy-supply = <&vreg_l3c_0p9>;
+ vdda-pll-supply = <&vreg_l3e_1p2>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
index beb1475d7fa0..9eb2dfd99f20 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
@@ -1564,8 +1564,8 @@ &usb_1_ss0_hsphy {
};
&usb_1_ss0_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l1j_0p8>;
+ vdda-phy-supply = <&vreg_l1j_0p8>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
status = "okay";
};
@@ -1594,8 +1594,8 @@ &usb_1_ss1_hsphy {
};
&usb_1_ss1_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l2d_0p9>;
+ vdda-phy-supply = <&vreg_l2d_0p9>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
status = "okay";
};
@@ -1624,8 +1624,8 @@ &usb_1_ss2_hsphy {
};
&usb_1_ss2_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l2d_0p9>;
+ vdda-phy-supply = <&vreg_l2d_0p9>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-medion-sprchrgd-14-s1.dts b/arch/arm64/boot/dts/qcom/x1e80100-medion-sprchrgd-14-s1.dts
index f95b1f9f439d..e4a0b86847cd 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-medion-sprchrgd-14-s1.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-medion-sprchrgd-14-s1.dts
@@ -1407,8 +1407,8 @@ &usb_1_ss0_hsphy {
};
&usb_1_ss0_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l1j_0p9>;
+ vdda-phy-supply = <&vreg_l1j_0p9>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
status = "okay";
};
@@ -1428,8 +1428,8 @@ &usb_1_ss0_qmpphy_out {
};
&usb_1_ss2_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l2d_0p9>;
+ vdda-phy-supply = <&vreg_l2d_0p9>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
/delete-property/ mode-switch;
/delete-property/ orientation-switch;
@@ -1497,16 +1497,16 @@ &usb_mp_hsphy1 {
/* Right side USB-A (USB-SS 3) */
&usb_mp_qmpphy0 {
- vdda-phy-supply = <&vreg_l3e_1p2>;
- vdda-pll-supply = <&vreg_l3c_0p9>;
+ vdda-phy-supply = <&vreg_l3c_0p9>;
+ vdda-pll-supply = <&vreg_l3e_1p2>;
status = "okay";
};
/* Left side USB-A (USB-SS 4) */
&usb_mp_qmpphy1 {
- vdda-phy-supply = <&vreg_l3e_1p2>;
- vdda-pll-supply = <&vreg_l3c_0p9>;
+ vdda-phy-supply = <&vreg_l3c_0p9>;
+ vdda-pll-supply = <&vreg_l3e_1p2>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi b/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi
index 28342cb84ded..13d0f09e0c2a 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi
@@ -1491,8 +1491,8 @@ &usb_1_ss0_hsphy {
};
&usb_1_ss0_qmpphy {
- vdda-phy-supply = <&vreg_l2j>;
- vdda-pll-supply = <&vreg_l1j>;
+ vdda-phy-supply = <&vreg_l1j>;
+ vdda-pll-supply = <&vreg_l2j>;
status = "okay";
};
@@ -1521,8 +1521,8 @@ &usb_1_ss1_hsphy {
};
&usb_1_ss1_qmpphy {
- vdda-phy-supply = <&vreg_l2j>;
- vdda-pll-supply = <&vreg_l2d>;
+ vdda-phy-supply = <&vreg_l2d>;
+ vdda-pll-supply = <&vreg_l2j>;
status = "okay";
};
@@ -1565,15 +1565,15 @@ &usb_mp_hsphy1 {
};
&usb_mp_qmpphy0 {
- vdda-phy-supply = <&vreg_l3e>;
- vdda-pll-supply = <&vreg_l3c>;
+ vdda-phy-supply = <&vreg_l3c>;
+ vdda-pll-supply = <&vreg_l3e>;
status = "okay";
};
&usb_mp_qmpphy1 {
- vdda-phy-supply = <&vreg_l3e>;
- vdda-pll-supply = <&vreg_l3c>;
+ vdda-phy-supply = <&vreg_l3c>;
+ vdda-pll-supply = <&vreg_l3e>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
index 8afbac349cc9..78380fec8839 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
@@ -1416,8 +1416,8 @@ &usb_1_ss0_hsphy {
};
&usb_1_ss0_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l1j_0p8>;
+ vdda-phy-supply = <&vreg_l1j_0p8>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
status = "okay";
};
@@ -1446,8 +1446,8 @@ &usb_1_ss1_hsphy {
};
&usb_1_ss1_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l2d_0p9>;
+ vdda-phy-supply = <&vreg_l2d_0p9>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
status = "okay";
};
@@ -1476,8 +1476,8 @@ &usb_1_ss2_hsphy {
};
&usb_1_ss2_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l2d_0p9>;
+ vdda-phy-supply = <&vreg_l2d_0p9>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
status = "okay";
};
@@ -1519,15 +1519,15 @@ &usb_mp_hsphy1 {
};
&usb_mp_qmpphy0 {
- vdda-phy-supply = <&vreg_l3e_1p2>;
- vdda-pll-supply = <&vreg_l3c_0p8>;
+ vdda-phy-supply = <&vreg_l3c_0p8>;
+ vdda-pll-supply = <&vreg_l3e_1p2>;
status = "okay";
};
&usb_mp_qmpphy1 {
- vdda-phy-supply = <&vreg_l3e_1p2>;
- vdda-pll-supply = <&vreg_l3c_0p8>;
+ vdda-phy-supply = <&vreg_l3c_0p8>;
+ vdda-pll-supply = <&vreg_l3e_1p2>;
status = "okay";
};
--
2.43.0
^ permalink raw reply related [flat|nested] 48+ messages in thread* Re: [PATCH 18/28] arm64: dts: qcom: hamoa: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:34 ` [PATCH 18/28] arm64: dts: qcom: hamoa: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:45 ` sashiko-bot
0 siblings, 0 replies; 48+ messages in thread
From: sashiko-bot @ 2026-08-03 6:45 UTC (permalink / raw)
To: Manivannan Sadhasivam; +Cc: devicetree, robh, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] Incomplete fix: Snapdragon X Plus (purwa/x1p) boards were missed and continue to supply incorrect voltages to the USB QMP PHYs.
--
--- Patch [18]: [PATCH 18/28] arm64: dts: qcom: hamoa: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies ---
commit 56ae73fe6fa593d516dd7a86b9b535d8c22c1819
Author: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
arm64: dts: qcom: hamoa: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
This commit fixes an issue across multiple Snapdragon boards where the 1.2V
and 0.88V regulators for the USB QMP PHY were incorrectly swapped. The patch
swaps vdda-phy-supply and vdda-pll-supply back to their correct voltages for
the affected devices.
> diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi b/arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi
> index 9c5e77df00547..bc70fe5db96f5 100644
> --- a/arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi
> +++ b/arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi
> @@ -590,8 +590,8 @@ &usb_1_ss0_hsphy {
> };
>
> &usb_1_ss0_qmpphy {
> - vdda-phy-supply = <&vreg_l2j_1p2>;
> - vdda-pll-supply = <&vreg_l1j_0p8>;
> + vdda-phy-supply = <&vreg_l1j_0p8>;
> + vdda-pll-supply = <&vreg_l2j_1p2>;
>
> status = "okay";
> };
[Severity: High]
This is a pre-existing issue, but it looks like some Snapdragon X Plus (purwa/x1p)
boards were missed and continue to supply incorrect voltages to the USB QMP PHYs.
For example, in arch/arm64/boot/dts/qcom/purwa-iot-som.dtsi around line 586
for usb_1_ss0_qmpphy:
&usb_1_ss0_qmpphy {
vdda-phy-supply = <&vreg_l2j_1p2>;
vdda-pll-supply = <&vreg_l1j_0p8>;
And similarly in arch/arm64/boot/dts/qcom/x1p42100-lenovo-thinkbook-16.dts
around line 1590 for usb_1_ss0_qmpphy:
&usb_1_ss0_qmpphy {
vdda-phy-supply = <&vreg_l2j_1p2>;
vdda-pll-supply = <&vreg_l1j_0p8>;
Should these files be updated as well to prevent unconditionally feeding 1.2V
into the 0.88V PHY rails on those boards during boot?
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260803-phy-supply-fix-v1-0-5880630cde3e@oss.qualcomm.com?part=18
^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 19/28] arm64: dts: qcom: purwa: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:33 [PATCH 00/28] arm64: dts: qcom: Fix swapped QMP PHY vdda-phy/vdda-pll supplies Manivannan Sadhasivam via B4 Relay
` (17 preceding siblings ...)
2026-08-03 6:34 ` [PATCH 18/28] arm64: dts: qcom: hamoa: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:34 ` Manivannan Sadhasivam via B4 Relay
2026-08-03 6:34 ` [PATCH 20/28] arm64: dts: qcom: sm8650: " Manivannan Sadhasivam via B4 Relay
` (9 subsequent siblings)
28 siblings, 0 replies; 48+ messages in thread
From: Manivannan Sadhasivam via B4 Relay @ 2026-08-03 6:34 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Krzysztof Kozlowski, Manivannan Sadhasivam,
Manivannan Sadhasivam
From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
The QMP PHY expects the vdda-phy supply to be around 0.88V and the
vdda-pll supply to be 1.2V. But these two supplies are swapped for the
USB QMP PHYs on these boards, feeding 1.2V to vdda-phy and 0.9V to
vdda-pll.
Fix it by swapping the two supplies back.
Fixes: 64a0277c9876 ("arm64: dts: qcom: Add PURWA-IOT-SOM platform")
Fixes: d3f600dc452d ("arm64: dts: qcom: Add Lenovo ThinkBook 16 G7 QOY device tree")
Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Assisted-by: Claude:opus-4-8
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/purwa-iot-som.dtsi | 20 ++++++++++----------
.../boot/dts/qcom/x1p42100-lenovo-thinkbook-16.dts | 20 ++++++++++----------
2 files changed, 20 insertions(+), 20 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/purwa-iot-som.dtsi b/arch/arm64/boot/dts/qcom/purwa-iot-som.dtsi
index 394e65518ac5..50ea8a148ada 100644
--- a/arch/arm64/boot/dts/qcom/purwa-iot-som.dtsi
+++ b/arch/arm64/boot/dts/qcom/purwa-iot-som.dtsi
@@ -583,8 +583,8 @@ &usb_1_ss0_hsphy {
};
&usb_1_ss0_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l1j_0p8>;
+ vdda-phy-supply = <&vreg_l1j_0p8>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
status = "okay";
};
@@ -604,8 +604,8 @@ &usb_1_ss1_hsphy {
};
&usb_1_ss1_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l2d_0p9>;
+ vdda-phy-supply = <&vreg_l2d_0p9>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
status = "okay";
};
@@ -625,8 +625,8 @@ &usb_1_ss2_hsphy {
};
&usb_1_ss2_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l2d_0p9>;
+ vdda-phy-supply = <&vreg_l2d_0p9>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
status = "okay";
};
@@ -663,15 +663,15 @@ &usb_mp_hsphy1 {
};
&usb_mp_qmpphy0 {
- vdda-phy-supply = <&vreg_l3e_1p2>;
- vdda-pll-supply = <&vreg_l3c_0p8>;
+ vdda-phy-supply = <&vreg_l3c_0p8>;
+ vdda-pll-supply = <&vreg_l3e_1p2>;
status = "okay";
};
&usb_mp_qmpphy1 {
- vdda-phy-supply = <&vreg_l3e_1p2>;
- vdda-pll-supply = <&vreg_l3c_0p8>;
+ vdda-phy-supply = <&vreg_l3c_0p8>;
+ vdda-pll-supply = <&vreg_l3e_1p2>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/x1p42100-lenovo-thinkbook-16.dts b/arch/arm64/boot/dts/qcom/x1p42100-lenovo-thinkbook-16.dts
index 500809772097..913645bc3595 100644
--- a/arch/arm64/boot/dts/qcom/x1p42100-lenovo-thinkbook-16.dts
+++ b/arch/arm64/boot/dts/qcom/x1p42100-lenovo-thinkbook-16.dts
@@ -1561,8 +1561,8 @@ &usb_1_ss0_hsphy {
};
&usb_1_ss0_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l1j_0p8>;
+ vdda-phy-supply = <&vreg_l1j_0p8>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
status = "okay";
};
@@ -1591,8 +1591,8 @@ &usb_1_ss1_hsphy {
};
&usb_1_ss1_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l2d_0p9>;
+ vdda-phy-supply = <&vreg_l2d_0p9>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
status = "okay";
};
@@ -1631,8 +1631,8 @@ &usb_1_ss2_hsphy {
};
&usb_1_ss2_qmpphy {
- vdda-phy-supply = <&vreg_l2j_1p2>;
- vdda-pll-supply = <&vreg_l2d_0p9>;
+ vdda-phy-supply = <&vreg_l2d_0p9>;
+ vdda-pll-supply = <&vreg_l2j_1p2>;
/delete-property/ mode-switch;
/delete-property/ orientation-switch;
@@ -1685,8 +1685,8 @@ &usb_mp_hsphy0 {
};
&usb_mp_qmpphy0 {
- vdda-phy-supply = <&vreg_l3e_1p2>;
- vdda-pll-supply = <&vreg_l3c_0p8>;
+ vdda-phy-supply = <&vreg_l3c_0p8>;
+ vdda-pll-supply = <&vreg_l3e_1p2>;
status = "okay";
};
@@ -1701,8 +1701,8 @@ &usb_mp_hsphy1 {
};
&usb_mp_qmpphy1 {
- vdda-phy-supply = <&vreg_l3e_1p2>;
- vdda-pll-supply = <&vreg_l3c_0p8>;
+ vdda-phy-supply = <&vreg_l3c_0p8>;
+ vdda-pll-supply = <&vreg_l3e_1p2>;
status = "okay";
};
--
2.43.0
^ permalink raw reply related [flat|nested] 48+ messages in thread* [PATCH 20/28] arm64: dts: qcom: sm8650: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:33 [PATCH 00/28] arm64: dts: qcom: Fix swapped QMP PHY vdda-phy/vdda-pll supplies Manivannan Sadhasivam via B4 Relay
` (18 preceding siblings ...)
2026-08-03 6:34 ` [PATCH 19/28] arm64: dts: qcom: purwa: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:34 ` Manivannan Sadhasivam via B4 Relay
2026-08-03 6:34 ` [PATCH 21/28] arm64: dts: qcom: sm8750: " Manivannan Sadhasivam via B4 Relay
` (8 subsequent siblings)
28 siblings, 0 replies; 48+ messages in thread
From: Manivannan Sadhasivam via B4 Relay @ 2026-08-03 6:34 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Krzysztof Kozlowski, Manivannan Sadhasivam,
Manivannan Sadhasivam
From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
The QMP PHY expects the vdda-phy supply to be around 0.88V and the
vdda-pll supply to be 1.2V. But these two supplies are swapped for the
USB QMP PHYs on these boards, feeding 1.2V to vdda-phy and 0.88V to
vdda-pll.
Fix it by swapping the two supplies back.
Fixes: 6fbdb3c1fac7 ("arm64: dts: qcom: sm8650: add initial SM8650 MTP dts")
Fixes: a834911d50c1 ("arm64: dts: qcom: sm8650: add initial SM8650 QRD dts")
Fixes: 01061441029e ("arm64: dts: qcom: sm8650: add support for the SM8650-HDK board")
Fixes: df260487f33c ("arm64: dts: qcom: add basic devicetree for Ayaneo Pocket S2 gaming console")
Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Assisted-by: Claude:opus-4-8
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/sm8650-ayaneo-pocket-s2.dts | 4 ++--
arch/arm64/boot/dts/qcom/sm8650-hdk.dts | 4 ++--
arch/arm64/boot/dts/qcom/sm8650-mtp.dts | 4 ++--
arch/arm64/boot/dts/qcom/sm8650-qrd.dts | 4 ++--
4 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8650-ayaneo-pocket-s2.dts b/arch/arm64/boot/dts/qcom/sm8650-ayaneo-pocket-s2.dts
index 0dc994f4e48d..6ddf30ecabfe 100644
--- a/arch/arm64/boot/dts/qcom/sm8650-ayaneo-pocket-s2.dts
+++ b/arch/arm64/boot/dts/qcom/sm8650-ayaneo-pocket-s2.dts
@@ -1536,8 +1536,8 @@ &usb_1_hsphy {
};
&usb_dp_qmpphy {
- vdda-phy-supply = <&vreg_l3i_1p2>;
- vdda-pll-supply = <&vreg_l3g_0p91>;
+ vdda-phy-supply = <&vreg_l3g_0p91>;
+ vdda-pll-supply = <&vreg_l3i_1p2>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/sm8650-hdk.dts b/arch/arm64/boot/dts/qcom/sm8650-hdk.dts
index eabc828c05b4..865ee15be9e2 100644
--- a/arch/arm64/boot/dts/qcom/sm8650-hdk.dts
+++ b/arch/arm64/boot/dts/qcom/sm8650-hdk.dts
@@ -1338,8 +1338,8 @@ &usb_1_hsphy {
};
&usb_dp_qmpphy {
- vdda-phy-supply = <&vreg_l3i_1p2>;
- vdda-pll-supply = <&vreg_l3g_0p91>;
+ vdda-phy-supply = <&vreg_l3g_0p91>;
+ vdda-pll-supply = <&vreg_l3i_1p2>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/sm8650-mtp.dts b/arch/arm64/boot/dts/qcom/sm8650-mtp.dts
index dd6e33d2dc5d..26045430d34a 100644
--- a/arch/arm64/boot/dts/qcom/sm8650-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sm8650-mtp.dts
@@ -886,8 +886,8 @@ &usb_1_hsphy {
};
&usb_dp_qmpphy {
- vdda-phy-supply = <&vreg_l3i_1p2>;
- vdda-pll-supply = <&vreg_l3g_0p91>;
+ vdda-phy-supply = <&vreg_l3g_0p91>;
+ vdda-pll-supply = <&vreg_l3i_1p2>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/sm8650-qrd.dts b/arch/arm64/boot/dts/qcom/sm8650-qrd.dts
index a3982ae22929..c00e3ae208cd 100644
--- a/arch/arm64/boot/dts/qcom/sm8650-qrd.dts
+++ b/arch/arm64/boot/dts/qcom/sm8650-qrd.dts
@@ -1357,8 +1357,8 @@ &usb_1_hsphy {
};
&usb_dp_qmpphy {
- vdda-phy-supply = <&vreg_l3i_1p2>;
- vdda-pll-supply = <&vreg_l3g_0p91>;
+ vdda-phy-supply = <&vreg_l3g_0p91>;
+ vdda-pll-supply = <&vreg_l3i_1p2>;
status = "okay";
};
--
2.43.0
^ permalink raw reply related [flat|nested] 48+ messages in thread* [PATCH 21/28] arm64: dts: qcom: sm8750: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:33 [PATCH 00/28] arm64: dts: qcom: Fix swapped QMP PHY vdda-phy/vdda-pll supplies Manivannan Sadhasivam via B4 Relay
` (19 preceding siblings ...)
2026-08-03 6:34 ` [PATCH 20/28] arm64: dts: qcom: sm8650: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:34 ` Manivannan Sadhasivam via B4 Relay
2026-08-03 6:34 ` [PATCH 22/28] arm64: dts: qcom: sar2130p: " Manivannan Sadhasivam via B4 Relay
` (7 subsequent siblings)
28 siblings, 0 replies; 48+ messages in thread
From: Manivannan Sadhasivam via B4 Relay @ 2026-08-03 6:34 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Krzysztof Kozlowski, Manivannan Sadhasivam,
Manivannan Sadhasivam
From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
The QMP PHY expects the vdda-phy supply to be around 0.88V and the
vdda-pll supply to be 1.2V. But these two supplies are swapped for the
USB QMP PHYs on these boards, feeding 1.2V to vdda-phy and 0.88V to
vdda-pll.
Fix it by swapping the two supplies back.
Fixes: 2340f29e2b06 ("arm64: dts: qcom: sm8750: Add USB support for SM8750 MTP platform")
Fixes: 530f824a4e18 ("arm64: dts: qcom: sm8750: Add USB support for SM8750 QRD platform")
Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Assisted-by: Claude:opus-4-8
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 4 ++--
arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
index 3837f6785320..9b5fbc004df4 100644
--- a/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sm8750-mtp.dts
@@ -1404,8 +1404,8 @@ &usb {
};
&usb_dp_qmpphy {
- vdda-phy-supply = <&vreg_l3g_1p2>;
- vdda-pll-supply = <&vreg_l2d_0p88>;
+ vdda-phy-supply = <&vreg_l2d_0p88>;
+ vdda-pll-supply = <&vreg_l3g_1p2>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
index 801c46d55602..b56317cfa9fc 100644
--- a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
+++ b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
@@ -1132,8 +1132,8 @@ &usb {
};
&usb_dp_qmpphy {
- vdda-phy-supply = <&vreg_l3g_1p2>;
- vdda-pll-supply = <&vreg_l2d_0p88>;
+ vdda-phy-supply = <&vreg_l2d_0p88>;
+ vdda-pll-supply = <&vreg_l3g_1p2>;
status = "okay";
};
--
2.43.0
^ permalink raw reply related [flat|nested] 48+ messages in thread* [PATCH 22/28] arm64: dts: qcom: sar2130p: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:33 [PATCH 00/28] arm64: dts: qcom: Fix swapped QMP PHY vdda-phy/vdda-pll supplies Manivannan Sadhasivam via B4 Relay
` (20 preceding siblings ...)
2026-08-03 6:34 ` [PATCH 21/28] arm64: dts: qcom: sm8750: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:34 ` Manivannan Sadhasivam via B4 Relay
2026-08-03 6:34 ` [PATCH 23/28] arm64: dts: qcom: kaanapali: " Manivannan Sadhasivam via B4 Relay
` (6 subsequent siblings)
28 siblings, 0 replies; 48+ messages in thread
From: Manivannan Sadhasivam via B4 Relay @ 2026-08-03 6:34 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Krzysztof Kozlowski, Manivannan Sadhasivam,
Manivannan Sadhasivam
From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
The QMP PHY expects the vdda-phy supply to be around 0.88V and the
vdda-pll supply to be 1.2V. But these two supplies are swapped for the
USB QMP PHY on this board, feeding 1.2V to vdda-phy and 0.9V to
vdda-pll.
Fix it by swapping the two supplies back.
Fixes: 6339e41fa39b ("arm64: dts: qcom: sar2130p: add QAR2130P board file")
Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Assisted-by: Claude:opus-4-8
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/sar2130p-qar2130p.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sar2130p-qar2130p.dts b/arch/arm64/boot/dts/qcom/sar2130p-qar2130p.dts
index 74778a5b19ba..80428c0b3b4e 100644
--- a/arch/arm64/boot/dts/qcom/sar2130p-qar2130p.dts
+++ b/arch/arm64/boot/dts/qcom/sar2130p-qar2130p.dts
@@ -551,8 +551,8 @@ &usb_1_hsphy {
};
&usb_dp_qmpphy {
- vdda-phy-supply = <&vreg_l3a_1p2>;
- vdda-pll-supply = <&vreg_l1a_0p91>;
+ vdda-phy-supply = <&vreg_l1a_0p91>;
+ vdda-pll-supply = <&vreg_l3a_1p2>;
status = "okay";
};
--
2.43.0
^ permalink raw reply related [flat|nested] 48+ messages in thread* [PATCH 23/28] arm64: dts: qcom: kaanapali: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:33 [PATCH 00/28] arm64: dts: qcom: Fix swapped QMP PHY vdda-phy/vdda-pll supplies Manivannan Sadhasivam via B4 Relay
` (21 preceding siblings ...)
2026-08-03 6:34 ` [PATCH 22/28] arm64: dts: qcom: sar2130p: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:34 ` Manivannan Sadhasivam via B4 Relay
2026-08-03 6:34 ` [PATCH 24/28] arm64: dts: qcom: glymur: " Manivannan Sadhasivam via B4 Relay
` (5 subsequent siblings)
28 siblings, 0 replies; 48+ messages in thread
From: Manivannan Sadhasivam via B4 Relay @ 2026-08-03 6:34 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Krzysztof Kozlowski, Manivannan Sadhasivam,
Manivannan Sadhasivam
From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
The QMP PHY expects the vdda-phy supply to be around 0.88V and the
vdda-pll supply to be 1.2V. But these two supplies are swapped for the
USB QMP PHYs on these boards, feeding 1.2V to vdda-phy and 0.88V to
vdda-pll.
Fix it by swapping the two supplies back.
Fixes: b2f036a67580 ("arm64: dts: qcom: kaanpaali: Add USB support for MTP platform")
Fixes: 01d15f5f6996 ("arm64: dts: qcom: kaanpaali: Add USB support for QRD platform")
Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Assisted-by: Claude:opus-4-8
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/kaanapali-mtp.dts | 4 ++--
arch/arm64/boot/dts/qcom/kaanapali-qrd.dts | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts b/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts
index f9b5b5718b90..2c1ae40dc7ec 100644
--- a/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts
@@ -1343,8 +1343,8 @@ &usb_hsphy {
};
&usb_dp_qmpphy {
- vdda-phy-supply = <&vreg_l1d_1p2>;
- vdda-pll-supply = <&vreg_l4f_0p8>;
+ vdda-phy-supply = <&vreg_l4f_0p8>;
+ vdda-pll-supply = <&vreg_l1d_1p2>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/kaanapali-qrd.dts b/arch/arm64/boot/dts/qcom/kaanapali-qrd.dts
index 55d02219ef4e..28779698221d 100644
--- a/arch/arm64/boot/dts/qcom/kaanapali-qrd.dts
+++ b/arch/arm64/boot/dts/qcom/kaanapali-qrd.dts
@@ -838,8 +838,8 @@ &usb_hsphy {
};
&usb_dp_qmpphy {
- vdda-phy-supply = <&vreg_l1d_1p2>;
- vdda-pll-supply = <&vreg_l4f_0p8>;
+ vdda-phy-supply = <&vreg_l4f_0p8>;
+ vdda-pll-supply = <&vreg_l1d_1p2>;
status = "okay";
};
--
2.43.0
^ permalink raw reply related [flat|nested] 48+ messages in thread* [PATCH 24/28] arm64: dts: qcom: glymur: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:33 [PATCH 00/28] arm64: dts: qcom: Fix swapped QMP PHY vdda-phy/vdda-pll supplies Manivannan Sadhasivam via B4 Relay
` (22 preceding siblings ...)
2026-08-03 6:34 ` [PATCH 23/28] arm64: dts: qcom: kaanapali: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:34 ` Manivannan Sadhasivam via B4 Relay
2026-08-04 11:51 ` Abel Vesa
2026-08-03 6:34 ` [PATCH 25/28] arm64: dts: qcom: lemans: " Manivannan Sadhasivam via B4 Relay
` (4 subsequent siblings)
28 siblings, 1 reply; 48+ messages in thread
From: Manivannan Sadhasivam via B4 Relay @ 2026-08-03 6:34 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Krzysztof Kozlowski, Manivannan Sadhasivam,
Manivannan Sadhasivam
From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
The QMP PHY expects the vdda-phy supply to be the lower voltage (~0.8V)
and the vdda-pll supply to be the higher voltage (~1.2V), as used by the
DisplayPort QMP PHY on this SoC. But these two supplies are swapped for
the USB QMP PHYs on this board, feeding 1.2V to vdda-phy and 0.72V/0.83V
to vdda-pll.
Fix it by swapping the two supplies back.
Fixes: c8b63029455b ("arm64: dts: qcom: glymur-crd: Enable USB support")
Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Assisted-by: Claude:opus-4-8
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/glymur-crd.dts | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dts b/arch/arm64/boot/dts/qcom/glymur-crd.dts
index c98dfb3941fa..9d42bd858595 100644
--- a/arch/arm64/boot/dts/qcom/glymur-crd.dts
+++ b/arch/arm64/boot/dts/qcom/glymur-crd.dts
@@ -339,8 +339,8 @@ &usb_0_hsphy {
};
&usb_0_qmpphy {
- vdda-phy-supply = <&vreg_l4h_e0_1p2>;
- vdda-pll-supply = <&vreg_l3f_e0_0p72>;
+ vdda-phy-supply = <&vreg_l3f_e0_0p72>;
+ vdda-pll-supply = <&vreg_l4h_e0_1p2>;
refgen-supply = <&vreg_l2f_e0_0p82>;
status = "okay";
@@ -368,8 +368,8 @@ &usb_1_hsphy {
};
&usb_1_qmpphy {
- vdda-phy-supply = <&vreg_l4h_e0_1p2>;
- vdda-pll-supply = <&vreg_l1h_e0_0p89>;
+ vdda-phy-supply = <&vreg_l1h_e0_0p89>;
+ vdda-pll-supply = <&vreg_l4h_e0_1p2>;
refgen-supply = <&vreg_l2f_e0_0p82>;
status = "okay";
@@ -413,16 +413,16 @@ &usb_mp_hsphy1 {
};
&usb_mp_qmpphy0 {
- vdda-phy-supply = <&vreg_l4h_e0_1p2>;
- vdda-pll-supply = <&vreg_l2h_e0_0p72>;
+ vdda-phy-supply = <&vreg_l2h_e0_0p72>;
+ vdda-pll-supply = <&vreg_l4h_e0_1p2>;
refgen-supply = <&vreg_l4f_e1_1p08>;
status = "okay";
};
&usb_mp_qmpphy1 {
- vdda-phy-supply = <&vreg_l4h_e0_1p2>;
- vdda-pll-supply = <&vreg_l2h_e0_0p72>;
+ vdda-phy-supply = <&vreg_l2h_e0_0p72>;
+ vdda-pll-supply = <&vreg_l4h_e0_1p2>;
refgen-supply = <&vreg_l4f_e1_1p08>;
status = "okay";
--
2.43.0
^ permalink raw reply related [flat|nested] 48+ messages in thread* Re: [PATCH 24/28] arm64: dts: qcom: glymur: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:34 ` [PATCH 24/28] arm64: dts: qcom: glymur: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-04 11:51 ` Abel Vesa
0 siblings, 0 replies; 48+ messages in thread
From: Abel Vesa @ 2026-08-04 11:51 UTC (permalink / raw)
To: manivannan.sadhasivam
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Konrad Dybcio, linux-arm-msm, devicetree,
linux-kernel, Krzysztof Kozlowski, Krzysztof Kozlowski,
Manivannan Sadhasivam
On 26-08-03 08:34:22, Manivannan Sadhasivam via B4 Relay wrote:
> From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
>
> The QMP PHY expects the vdda-phy supply to be the lower voltage (~0.8V)
> and the vdda-pll supply to be the higher voltage (~1.2V), as used by the
> DisplayPort QMP PHY on this SoC. But these two supplies are swapped for
> the USB QMP PHYs on this board, feeding 1.2V to vdda-phy and 0.72V/0.83V
> to vdda-pll.
>
> Fix it by swapping the two supplies back.
>
> Fixes: c8b63029455b ("arm64: dts: qcom: glymur-crd: Enable USB support")
> Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Assisted-by: Claude:opus-4-8
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 25/28] arm64: dts: qcom: lemans: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:33 [PATCH 00/28] arm64: dts: qcom: Fix swapped QMP PHY vdda-phy/vdda-pll supplies Manivannan Sadhasivam via B4 Relay
` (23 preceding siblings ...)
2026-08-03 6:34 ` [PATCH 24/28] arm64: dts: qcom: glymur: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:34 ` Manivannan Sadhasivam via B4 Relay
2026-08-03 6:59 ` sashiko-bot
2026-08-03 6:34 ` [PATCH 26/28] arm64: dts: qcom: eliza-mtp: " Manivannan Sadhasivam via B4 Relay
` (3 subsequent siblings)
28 siblings, 1 reply; 48+ messages in thread
From: Manivannan Sadhasivam via B4 Relay @ 2026-08-03 6:34 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Krzysztof Kozlowski, Manivannan Sadhasivam,
Manivannan Sadhasivam
From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
The QMP PHY expects the vdda-phy supply to be the lower voltage (~0.8V)
and the vdda-pll supply to be the higher voltage (~1.2V), as used by the
PCIe and UFS QMP PHYs on this SoC. But these two supplies are swapped for
the USB QMP PHYs on these boards, feeding 1.14V to vdda-phy and 0.72V to
vdda-pll.
Fix it by swapping the two supplies back.
Fixes: 76326da895b8 ("arm64: dts: qcom: lemans: Refactor ride/ride-r3 boards based on daughter cards")
Fixes: 7bd68ef80661 ("arm64: dts: qcom: lemans-evk: Enable first USB controller in device mode")
Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Assisted-by: Claude:opus-4-8
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/lemans-evk.dts | 4 ++--
arch/arm64/boot/dts/qcom/lemans-ride-common.dtsi | 8 ++++----
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/lemans-evk.dts b/arch/arm64/boot/dts/qcom/lemans-evk.dts
index 34dfc8d22b6a..b835fce8b336 100644
--- a/arch/arm64/boot/dts/qcom/lemans-evk.dts
+++ b/arch/arm64/boot/dts/qcom/lemans-evk.dts
@@ -1008,8 +1008,8 @@ &usb_0_hsphy {
};
&usb_0_qmpphy {
- vdda-phy-supply = <&vreg_l1c>;
- vdda-pll-supply = <&vreg_l7a>;
+ vdda-phy-supply = <&vreg_l7a>;
+ vdda-pll-supply = <&vreg_l1c>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/lemans-ride-common.dtsi b/arch/arm64/boot/dts/qcom/lemans-ride-common.dtsi
index 40f88498999b..b2195fc03095 100644
--- a/arch/arm64/boot/dts/qcom/lemans-ride-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/lemans-ride-common.dtsi
@@ -1103,8 +1103,8 @@ &usb_0_hsphy {
};
&usb_0_qmpphy {
- vdda-phy-supply = <&vreg_l1c>;
- vdda-pll-supply = <&vreg_l7a>;
+ vdda-phy-supply = <&vreg_l7a>;
+ vdda-pll-supply = <&vreg_l1c>;
status = "okay";
};
@@ -1126,8 +1126,8 @@ &usb_1_hsphy {
};
&usb_1_qmpphy {
- vdda-phy-supply = <&vreg_l1c>;
- vdda-pll-supply = <&vreg_l7a>;
+ vdda-phy-supply = <&vreg_l7a>;
+ vdda-pll-supply = <&vreg_l1c>;
status = "okay";
};
--
2.43.0
^ permalink raw reply related [flat|nested] 48+ messages in thread* Re: [PATCH 25/28] arm64: dts: qcom: lemans: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:34 ` [PATCH 25/28] arm64: dts: qcom: lemans: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:59 ` sashiko-bot
0 siblings, 0 replies; 48+ messages in thread
From: sashiko-bot @ 2026-08-03 6:59 UTC (permalink / raw)
To: Manivannan Sadhasivam; +Cc: robh, conor+dt, devicetree
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The commit incorrectly swaps the `vdda-phy` and `vdda-pll` supplies for the USB QMP PHYs, violating the driver's load current expectations and risking PHY instability due to incorrect PMIC configuration.
--
--- Patch [25]: [PATCH 25/28] arm64: dts: qcom: lemans: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies ---
commit b0df92fb00420a27d33768ecf9f99505036be942
Author: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
arm64: dts: qcom: lemans: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
This commit swaps the vdda-phy and vdda-pll supplies for the USB QMP PHYs
on the Le Mans boards. The change ensures the lower voltage is mapped to
vdda-phy and the higher voltage to vdda-pll.
> diff --git a/arch/arm64/boot/dts/qcom/lemans-evk.dts b/arch/arm64/boot/dts/qcom/lemans-evk.dts
> index 34dfc8d22b6a5..b835fce8b336f 100644
> --- a/arch/arm64/boot/dts/qcom/lemans-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/lemans-evk.dts
> @@ -1008,8 +1008,8 @@ &usb_0_hsphy {
> };
>
> &usb_0_qmpphy {
> - vdda-phy-supply = <&vreg_l1c>;
> - vdda-pll-supply = <&vreg_l7a>;
> + vdda-phy-supply = <&vreg_l7a>;
> + vdda-pll-supply = <&vreg_l1c>;
[Severity: High]
Does swapping these supplies in the DT without updating the phy-qcom-qmp-usb
driver violate the driver's load current expectations?
The phy-qcom-qmp-usb driver fetches the regulators by name (vdda-phy and
vdda-pll) and applies hardcoded init_load_uA values (21.8mA and 36.0mA,
respectively).
Because the DT names are swapped by this change, the 0.8V regulator is
incorrectly provisioned with the 1.2V rail's load request (21.8mA) instead
of its required 36.0mA.
Could this under-provisioning cause the RPMh PMIC to place the LDO in Low
Power Mode (LPM), leading to voltage droop and USB link failures when the
hardware draws its required current?
>
> status = "okay";
> };
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260803-phy-supply-fix-v1-0-5880630cde3e@oss.qualcomm.com?part=25
^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 26/28] arm64: dts: qcom: eliza-mtp: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:33 [PATCH 00/28] arm64: dts: qcom: Fix swapped QMP PHY vdda-phy/vdda-pll supplies Manivannan Sadhasivam via B4 Relay
` (24 preceding siblings ...)
2026-08-03 6:34 ` [PATCH 25/28] arm64: dts: qcom: lemans: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:34 ` Manivannan Sadhasivam via B4 Relay
2026-08-04 11:51 ` Abel Vesa
2026-08-03 6:34 ` [PATCH 27/28] arm64: dts: qcom: sa8155p-adp: Fix swapped USB and UFS " Manivannan Sadhasivam via B4 Relay
` (2 subsequent siblings)
28 siblings, 1 reply; 48+ messages in thread
From: Manivannan Sadhasivam via B4 Relay @ 2026-08-03 6:34 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Krzysztof Kozlowski, Manivannan Sadhasivam,
Manivannan Sadhasivam
From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
The QMP PHY expects the vdda-phy supply to be the lower voltage (~0.8V)
and the vdda-pll supply to be the higher voltage (~1.2V), as used by the
UFS QMP PHY on this SoC. But these two supplies are swapped for the USB
QMP PHY on this board, feeding 1.15V to vdda-phy and 0.72V to vdda-pll.
Fix it by swapping the two supplies back.
Fixes: 49dab7311f57 ("arm64: dts: qcom: eliza-mtp: Enable USB and ADSP support")
Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Assisted-by: Claude:opus-4-8
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/eliza-mtp.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/eliza-mtp.dts b/arch/arm64/boot/dts/qcom/eliza-mtp.dts
index 1374afd9d14e..9d58ef20213a 100644
--- a/arch/arm64/boot/dts/qcom/eliza-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/eliza-mtp.dts
@@ -535,8 +535,8 @@ &usb {
};
&usb_dp_qmpphy {
- vdda-phy-supply = <&vreg_l3g>;
- vdda-pll-supply = <&vreg_l7k>;
+ vdda-phy-supply = <&vreg_l7k>;
+ vdda-pll-supply = <&vreg_l3g>;
status = "okay";
};
--
2.43.0
^ permalink raw reply related [flat|nested] 48+ messages in thread* Re: [PATCH 26/28] arm64: dts: qcom: eliza-mtp: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:34 ` [PATCH 26/28] arm64: dts: qcom: eliza-mtp: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-04 11:51 ` Abel Vesa
0 siblings, 0 replies; 48+ messages in thread
From: Abel Vesa @ 2026-08-04 11:51 UTC (permalink / raw)
To: manivannan.sadhasivam
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Konrad Dybcio, linux-arm-msm, devicetree,
linux-kernel, Krzysztof Kozlowski, Krzysztof Kozlowski,
Manivannan Sadhasivam
On 26-08-03 08:34:24, Manivannan Sadhasivam via B4 Relay wrote:
> From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
>
> The QMP PHY expects the vdda-phy supply to be the lower voltage (~0.8V)
> and the vdda-pll supply to be the higher voltage (~1.2V), as used by the
> UFS QMP PHY on this SoC. But these two supplies are swapped for the USB
> QMP PHY on this board, feeding 1.15V to vdda-phy and 0.72V to vdda-pll.
>
> Fix it by swapping the two supplies back.
>
> Fixes: 49dab7311f57 ("arm64: dts: qcom: eliza-mtp: Enable USB and ADSP support")
> Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Assisted-by: Claude:opus-4-8
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 27/28] arm64: dts: qcom: sa8155p-adp: Fix swapped USB and UFS QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:33 [PATCH 00/28] arm64: dts: qcom: Fix swapped QMP PHY vdda-phy/vdda-pll supplies Manivannan Sadhasivam via B4 Relay
` (25 preceding siblings ...)
2026-08-03 6:34 ` [PATCH 26/28] arm64: dts: qcom: eliza-mtp: " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:34 ` Manivannan Sadhasivam via B4 Relay
2026-08-03 6:34 ` [PATCH 28/28] arm64: dts: qcom: talos-evk: Fix swapped USB " Manivannan Sadhasivam via B4 Relay
2026-08-05 3:33 ` [PATCH 00/28] arm64: dts: qcom: Fix swapped " Bjorn Andersson
28 siblings, 0 replies; 48+ messages in thread
From: Manivannan Sadhasivam via B4 Relay @ 2026-08-03 6:34 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Krzysztof Kozlowski, Manivannan Sadhasivam,
Manivannan Sadhasivam
From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
The QMP PHY expects the vdda-phy supply to be around 0.88V and the
vdda-pll supply to be 1.2V. But these two supplies are swapped for the
USB and UFS QMP PHYs on this board, feeding 1.2V to vdda-phy and 0.9V to
vdda-pll.
Fix it by swapping the two supplies back.
Fixes: 12dd4ebda47a ("arm64: dts: qcom: Fix usb entries for SA8155p adp board")
Fixes: 5b85e8f2225c ("arm64: dts: qcom: sa8155p-adp: Add base dts file")
Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Assisted-by: Claude:opus-4-8
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
index 388d5ecee949..3e22ee8b5092 100644
--- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
+++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
@@ -428,8 +428,8 @@ &ufs_mem_hc {
&ufs_mem_phy {
status = "okay";
- vdda-phy-supply = <&vreg_l8c_1p2>;
- vdda-pll-supply = <&vreg_l5a_0p88>;
+ vdda-phy-supply = <&vreg_l5a_0p88>;
+ vdda-pll-supply = <&vreg_l8c_1p2>;
};
&usb_1 {
@@ -474,8 +474,8 @@ &usb_2_hsphy {
&usb_2_qmpphy {
status = "okay";
- vdda-phy-supply = <&vreg_l8c_1p2>;
- vdda-pll-supply = <&vdda_usb_ss_dp_core_1>;
+ vdda-phy-supply = <&vdda_usb_ss_dp_core_1>;
+ vdda-pll-supply = <&vreg_l8c_1p2>;
};
&pcie0 {
--
2.43.0
^ permalink raw reply related [flat|nested] 48+ messages in thread* [PATCH 28/28] arm64: dts: qcom: talos-evk: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:33 [PATCH 00/28] arm64: dts: qcom: Fix swapped QMP PHY vdda-phy/vdda-pll supplies Manivannan Sadhasivam via B4 Relay
` (26 preceding siblings ...)
2026-08-03 6:34 ` [PATCH 27/28] arm64: dts: qcom: sa8155p-adp: Fix swapped USB and UFS " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 6:34 ` Manivannan Sadhasivam via B4 Relay
2026-08-03 7:01 ` sashiko-bot
2026-08-05 3:33 ` [PATCH 00/28] arm64: dts: qcom: Fix swapped " Bjorn Andersson
28 siblings, 1 reply; 48+ messages in thread
From: Manivannan Sadhasivam via B4 Relay @ 2026-08-03 6:34 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Krzysztof Kozlowski, Manivannan Sadhasivam,
Manivannan Sadhasivam
From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
The QMP PHY expects the vdda-phy supply to be around 0.88V and the
vdda-pll supply to be 1.2V. But these two supplies are swapped for the
USB QMP PHY on this board, feeding 1.2V to vdda-phy and 0.9V to
vdda-pll.
Fix it by swapping the two supplies back.
Fixes: 0f9e6db8a223 ("arm64: dts: qcom: talos-evk: Add support for QCS615 talos evk board")
Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Assisted-by: Claude:opus-4-8
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/talos-evk-som.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi b/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
index 294354c034c3..6469c6fa9f63 100644
--- a/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
+++ b/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
@@ -589,8 +589,8 @@ &usb_qmpphy {
};
&usb_qmpphy_2 {
- vdda-phy-supply = <&vreg_l11a>;
- vdda-pll-supply = <&vreg_l5a>;
+ vdda-phy-supply = <&vreg_l5a>;
+ vdda-pll-supply = <&vreg_l11a>;
status = "okay";
};
--
2.43.0
^ permalink raw reply related [flat|nested] 48+ messages in thread* Re: [PATCH 28/28] arm64: dts: qcom: talos-evk: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:34 ` [PATCH 28/28] arm64: dts: qcom: talos-evk: Fix swapped USB " Manivannan Sadhasivam via B4 Relay
@ 2026-08-03 7:01 ` sashiko-bot
0 siblings, 0 replies; 48+ messages in thread
From: sashiko-bot @ 2026-08-03 7:01 UTC (permalink / raw)
To: Manivannan Sadhasivam; +Cc: conor+dt, devicetree, robh
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] This problem wasn't introduced by this patch, but the patch provides an incomplete fix that leaves several QMP PHYs incorrectly configured. The commit message states that the QMP PHY expects the `vdda-pll` supply to be 1.2V, and the patch correctly sets `usb_qmpphy_2` to use `vreg_l11a` (which is configured for 1.23V - 1.26V). However, it fails to fix `usb_qmpphy`, `ufs_mem_phy`, and `pcie_phy` in the same file (`talos-evk-som.dtsi`), all of which continue to use `vreg_l12a` (which is configured for 1.8V - 1.89V) for their PLL supply. Furthermore, the sibling board `qcs615-ride.dts` also leaves both `usb_qmpphy` and `usb_qmpphy_2` configured with `vreg_l12a` (1.8V). This leaves the remaining PHYs exposed to a significant overvoltage (1.8V instead of 1.2V).
--
--- Patch [28]: [PATCH 28/28] arm64: dts: qcom: talos-evk: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies ---
commit a8da26c25bde26c79bbdbc3a2692464d3f213cfd
Author: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
arm64: dts: qcom: talos-evk: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
This commit corrects the swapped vdda-phy and vdda-pll supplies for the USB
QMP PHY on the QCS615 Talos EVK board. The patch ensures the vdda-pll supply
is fed 1.2V instead of 0.9V.
> diff --git a/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi b/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
> index 294354c034c37..6469c6fa9f634 100644
> --- a/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
> +++ b/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
> @@ -589,8 +589,8 @@ &usb_qmpphy {
> };
>
> &usb_qmpphy_2 {
> - vdda-phy-supply = <&vreg_l11a>;
> - vdda-pll-supply = <&vreg_l5a>;
> + vdda-phy-supply = <&vreg_l5a>;
> + vdda-pll-supply = <&vreg_l11a>;
[Severity: High]
This isn't a bug introduced by this patch, but does this provide an
incomplete fix that leaves several other QMP PHYs incorrectly configured?
The commit message states that the QMP PHY expects the vdda-pll supply to
be 1.2V, and this patch updates usb_qmpphy_2 to use vreg_l11a (1.23V - 1.26V).
However, looking just above this block in talos-evk-som.dtsi, usb_qmpphy
still uses vreg_l12a (which is configured for 1.8V):
&usb_qmpphy {
vdda-phy-supply = <&vreg_l5a>;
vdda-pll-supply = <&vreg_l12a>;
Similarly, ufs_mem_phy and pcie_phy also continue to use vreg_l12a for their
vdda-pll-supply.
Additionally, the sibling reference board qcs615-ride.dts leaves both
usb_qmpphy and usb_qmpphy_2 configured with vreg_l12a (1.8V).
Since supplying 1.8V to a PLL expecting 1.2V could expose the PHYs to a
significant overvoltage, or alternatively undervolt usb_qmpphy_2 if the SoC
natively requires 1.8V, should the remaining PHYs and sibling boards
be updated to the correct voltage as well?
>
> status = "okay";
> };
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260803-phy-supply-fix-v1-0-5880630cde3e@oss.qualcomm.com?part=28
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 00/28] arm64: dts: qcom: Fix swapped QMP PHY vdda-phy/vdda-pll supplies
2026-08-03 6:33 [PATCH 00/28] arm64: dts: qcom: Fix swapped QMP PHY vdda-phy/vdda-pll supplies Manivannan Sadhasivam via B4 Relay
` (27 preceding siblings ...)
2026-08-03 6:34 ` [PATCH 28/28] arm64: dts: qcom: talos-evk: Fix swapped USB " Manivannan Sadhasivam via B4 Relay
@ 2026-08-05 3:33 ` Bjorn Andersson
28 siblings, 0 replies; 48+ messages in thread
From: Bjorn Andersson @ 2026-08-05 3:33 UTC (permalink / raw)
To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Manivannan Sadhasivam
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Krzysztof Kozlowski, Manivannan Sadhasivam
On Mon, 03 Aug 2026 08:33:58 +0200, Manivannan Sadhasivam wrote:
> The QMP PHY takes two analog supplies, vdda-phy and vdda-pll. By the
> hardware design, vdda-phy is the lower voltage rail (~0.8V) and vdda-pll
> is the higher voltage rail (~1.2V). This holds for every QMP PHY flavour
> (PCIe, UFS, DisplayPort and USB) on a given SoC.
>
> A large number of Qualcomm ARM64 boards have these two supplies swapped
> for their USB QMP PHYs, feeding the ~1.2V rail to vdda-phy and the ~0.8V
> rail to vdda-pll. One board, sa8155p-adp, has the same swap on its UFS
> QMP PHY as well. The PCIe and DisplayPort QMP PHYs on the same SoCs are
> wired correctly, which confirms the intended assignment. The PHYs happen
> to work with the supplies swapped as there was no ordering requirement and
> both supplies get enabled anyway. So this was never noticed and got copied
> from board to board.
>
> [...]
Applied, thanks!
[02/28] arm64: dts: qcom: sc8280xp-blackrock: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
commit: ff7155df9a9543af1eb9722563e6dcda33c1a97d
[03/28] arm64: dts: qcom: sa8540p: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
commit: 1960614611142e4b57f8a4e276f36ff8b6db2a1d
[04/28] arm64: dts: qcom: sdm845: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
commit: ce18e4c1cfc77c2eda5f0b9839edac1b0e929c54
[05/28] arm64: dts: qcom: sdm850: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
commit: ef7b567f54c72a91dec3fb0bd5d80b8e956f7cd8
[06/28] arm64: dts: qcom: sm8150: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
commit: 3a0c5af9fb0e835e90c4f2439dc4534301be8856
[07/28] arm64: dts: qcom: sm8250: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
commit: d57a10f2ebcf327bdecf8bb26e9f330b17b0b1a6
[08/28] arm64: dts: qcom: sm8350: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
commit: 65cd57115c379ff0d0a200ad5a857afb8042a63c
[09/28] arm64: dts: qcom: sm8450: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
commit: 6469731fb66f40ab873bf4c9fd97d295b390e87f
[10/28] arm64: dts: qcom: sm8550: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
commit: f35723d6b6a2f6d6fc3cf2fc3ff556436f76ebd4
[11/28] arm64: dts: qcom: qcs8550-aim300: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
commit: c0ea3b6339881c2a5fff0830557b1279d9681036
[12/28] arm64: dts: qcom: qcm6490: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
commit: f6a787a5e238599f3543c3dccf0abd6030dd48e3
[13/28] arm64: dts: qcom: qcs6490: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
commit: 83185fc5f51e7fa2d02f02e2504ad7b002c2d1d8
[14/28] arm64: dts: qcom: sm7225-fairphone-fp4: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
commit: a3b3a060b696d964c769a7d9dc5835c79e4fe964
[15/28] arm64: dts: qcom: sc7180: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
commit: 2c45c4df3079acba14920b14286cebfea24ec603
[16/28] arm64: dts: qcom: sc7280: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
commit: b3038aac412d14538f135e6509e657997fd6825d
[17/28] arm64: dts: qcom: sc8180x: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
commit: 8e1877c41c2ee4ad245e1c26c98f3b4cb2585162
[18/28] arm64: dts: qcom: hamoa: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
commit: 4458dcd38295c8bd13957637ba98132ba3f089b0
[19/28] arm64: dts: qcom: purwa: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
commit: 7c1d0ef2969e16a97bd03e8340f35a78c889120d
[20/28] arm64: dts: qcom: sm8650: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
commit: 464fba94ac2e35b336e19c34336a07946da7128f
[21/28] arm64: dts: qcom: sm8750: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
commit: 50c9658bc622888f9664a052fd98ef6026883ea5
[22/28] arm64: dts: qcom: sar2130p: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
commit: 9d883d21fc12c873eee2f864f706c38a289bef59
[23/28] arm64: dts: qcom: kaanapali: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
commit: c1dfdea72a9f59b1bdad64b8ec9f918b6c1a721f
[24/28] arm64: dts: qcom: glymur: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
commit: c3c6b388edba50aad0d41b0b2a5e50482e320611
[25/28] arm64: dts: qcom: lemans: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
commit: 932113c3c77814b4001ad37ea4383b93bc385284
[26/28] arm64: dts: qcom: eliza-mtp: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
commit: 6b1195eeb204b455973fb05e10563a63bdd71c57
[27/28] arm64: dts: qcom: sa8155p-adp: Fix swapped USB and UFS QMP PHY vdda-phy/vdda-pll supplies
commit: 3b50c16faa8452fd7ff021919c669c7b38227ca4
[28/28] arm64: dts: qcom: talos-evk: Fix swapped USB QMP PHY vdda-phy/vdda-pll supplies
commit: b426fedcef8c277574bd7beed0ae9d482c03605a
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 48+ messages in thread