Re: [PATCH v2 6/6] arm64: dts: qcom: qcs8300-ride: fix SerDes PHY regulator supplies

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] Incomplete device tree migration for SerDes PHY regulator supplies breaks Ethernet on Monaco Monza SOM.
--

--- Patch [6]: [PATCH v2 6/6] arm64: dts: qcom: qcs8300-ride: fix SerDes PHY regulator supplies ---
commit 8e38978ea8c058004487a19a9a664f9946b8306c
Author: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>

arm64: dts: qcom: qcs8300-ride: fix SerDes PHY regulator supplies

This commit fixes the SerDes PHY node in qcs8300-ride.dts by replacing the
single phy-supply property with the required vdda-0p9-supply and
vdda-1p2-supply properties. This ensures both the 1.2V and 0.9V rails are
properly provided to the PHY.

> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> index 1ff39530ea3de..76c34215dbdf0 100644
> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> @@ -702,7 +702,9 @@ &remoteproc_gpdsp {
>  };
>  
>  &serdes0 {
> -	phy-supply = <&vreg_l5a>;
> +	vdda-0p9-supply = <&vreg_l4a>;
> +	vdda-1p2-supply = <&vreg_l5a>;
> +
>  	status = "okay";
>  };

[Severity: High]
This isn't a bug introduced by this patch, but I noticed that another file in
the tree, arch/arm64/boot/dts/qcom/monaco-monza-som.dtsi, still has the exact
same configuration you are fixing here. It retains the deprecated phy-supply
property and lacks the required 0.9V rail:

&serdes0 {
	phy-supply = <&vreg_l5a>;

	status = "okay";
};

Since the PHY driver strictly expects the two named regulator supplies via
devm_regulator_bulk_get_const, won't leaving this old configuration break
Ethernet on the Monaco Monza SOM during boot by either failing to probe
or timing out on calibration? 

Should monaco-monza-som.dtsi be updated similarly in this patch or as a
follow-up in this series?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260804-b4-sgmiieth_serdes_regulator-v2-0-c4bc688177dd@oss.qualcomm.com?part=6