Re: [PATCH v2 1/6] dt-bindings: phy: qcom,sa8775p-dwmac-sgmii-phy: add named voltage rails and deprecate phy-supply

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The device tree binding deprecates `phy-supply` in favor of new named regulators `vdda-0p9-supply` and `vdda-1p2-supply`, but the driver (`phy-qcom-sgmii-eth.c`) was not updated to request or enable them. When device trees are updated to follow the new binding and drop the deprecated `phy-supply`, the PHY subsystem core (`phy-core.c`) will no longer find and enable the generic `phy` regulator, leaving the PHY unpowered.
--

--- Patch [1]: [PATCH v2 1/6] dt-bindings: phy: qcom,sa8775p-dwmac-sgmii-phy: add named voltage rails and deprecate phy-supply ---
commit 3cc6ac4d3b35571e8657dd8e304e3f7c33b822ec
Author: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>

dt-bindings: phy: qcom,sa8775p-dwmac-sgmii-phy: add named voltage rails and deprecate phy-supply

The Qualcomm SGMII SerDes PHY has two distinct voltage supply rails. This
commit deprecates the generic 'phy-supply' property and instead adds two
specific named supply properties.

> diff --git a/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
> index 90fc8c039219c..e573abcb937df 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,sa8775p-dwmac-sgmii-phy.yaml
> @@ -35,6 +35,17 @@ properties:
>    phy-supply:
>      description:
>        Phandle to a regulator that provides power to the PHY.
> +    deprecated: true
> +
> +  vdda-0p9-supply:
> +    description:
> +      Phandle to a 0.9V regulator supply to the PHY, which draws a peak
> +      current of 46 mA.
> +
> +  vdda-1p2-supply:
> +    description:
> +      Phandle to a 1.2V regulator supply to the PHY, which draws a peak
> +      current of 15 mA.

[Severity: High]
Does this change cause a functional regression when device trees are updated
to follow the new binding?

When device tree authors update their nodes to use vdda-0p9-supply and
vdda-1p2-supply instead of the deprecated phy-supply, it appears the
regulators will remain unpowered.

The PHY subsystem core (phy-core.c) looks for the generic phy-supply during
phy_create(). If it is missing from the device tree, the core will not
enable it.

At the same time, the corresponding driver does not seem to have been
updated to fetch and enable these new specific regulators:

drivers/phy/qualcomm/phy-qcom-sgmii-eth.c:qcom_dwmac_sgmii_phy_probe()

Should qcom_dwmac_sgmii_phy_probe() be updated alongside this binding to
request the new regulators (for example, using devm_regulator_bulk_get()),
so the PHY doesn't fail to initialize when phy-supply is omitted?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260804-b4-sgmiieth_serdes_regulator-v2-0-c4bc688177dd@oss.qualcomm.com?part=1