Re: [PATCH v2 3/6] arm64: dts: qcom: lemans-evk: fix SerDes PHY regulator supplies

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] Incomplete fix for SGMII SerDes PHY regulator supplies leaving downstream boards broken.
--

--- Patch [3]: [PATCH v2 3/6] arm64: dts: qcom: lemans-evk: fix SerDes PHY regulator supplies ---
commit 06c318320f4f12178e107aa08e3b5435de261d50
Author: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>

arm64: dts: qcom: lemans-evk: fix SerDes PHY regulator supplies

This commit fixes the SerDes PHY regulator supplies for the lemans-evk board
and its IFP mezzanine overlay. It replaces the incorrect phy-supply with
vdda-0p9-supply and vdda-1p2-supply.

[ ... ]

> diff --git a/arch/arm64/boot/dts/qcom/lemans-evk.dts b/arch/arm64/boot/dts/qcom/lemans-evk.dts
> index 0c53640c42a65..5c046b9bfb3cd 100644
> --- a/arch/arm64/boot/dts/qcom/lemans-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/lemans-evk.dts

[ ... ]

> @@ -978,7 +978,8 @@ &sdhc {
>  };
>  
>  &serdes0 {
> -	phy-supply = <&vreg_l5a>;
> +	vdda-0p9-supply = <&vreg_l4a>;
> +	vdda-1p2-supply = <&vreg_l1c>;

[Severity: High]
This isn't a bug introduced by this patch, but should this fix be applied to
other boards using this PHY?

It looks like several other device trees still define the deprecated
phy-supply property, such as in
arch/arm64/boot/dts/qcom/lemans-ride-common.dtsi:

&serdes0 {
	phy-supply = <&vreg_l5a>;
	status = "okay";
};

And similarly in arch/arm64/boot/dts/qcom/qcs8300-ride.dts, 
arch/arm64/boot/dts/qcom/monaco-monza-som.dtsi, and 
arch/arm64/boot/dts/qcom/monaco-evk.dts.

Booting these unmodified boards could result in the PHY driver either failing
to probe or falling back to dummy regulators and failing calibration, breaking
SGMII Ethernet connectivity.

Could the fix be extended to cover these other boards as well to ensure they
receive both required voltage supplies?

>  
>  	status = "okay";
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260804-b4-sgmiieth_serdes_regulator-v2-0-c4bc688177dd@oss.qualcomm.com?part=3