Re: [PATCH v2 5/6] arm64: dts: qcom: monaco-evk: fix SerDes PHY regulator supplies

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Incomplete device tree migration causes a functional regression on qcs8300-ride and monaco-monza-som boards, where the SerDes PHY will fail to power up because its 0.9V regulator rail is not enabled.
--

--- Patch [5]: [PATCH v2 5/6] arm64: dts: qcom: monaco-evk: fix SerDes PHY regulator supplies ---
commit 77126601ae0cd79ff3e3276e8f35420b21a2d2f5
Author: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>

arm64: dts: qcom: monaco-evk: fix SerDes PHY regulator supplies

The commit updates the SerDes PHY node in the monaco-evk device tree to use
explicit named regulator supplies (vdda-0p9-supply and vdda-1p2-supply)
instead of the deprecated phy-supply property. This ensures both required
rails are properly described and enabled.

> diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> index 9d17ef7d2caf1..f787e78b35ce4 100644
> --- a/arch/arm64/boot/dts/qcom/monaco-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> @@ -706,7 +706,8 @@ &sdhc_1 {
>  };
>  
>  &serdes0 {
> -	phy-supply = <&vreg_l4a>;
> +	vdda-0p9-supply = <&vreg_l4a>;
> +	vdda-1p2-supply = <&vreg_l5a>;

[Severity: High]
Does this migration to vdda-0p9-supply and vdda-1p2-supply need to be applied
to other boards as well?

Looking at arch/arm64/boot/dts/qcom/qcs8300-ride.dts and
arch/arm64/boot/dts/qcom/monaco-monza-som.dtsi, they still use the deprecated
phy-supply property for serdes0:

arch/arm64/boot/dts/qcom/qcs8300-ride.dts:serdes0 {
	phy-supply = <&vreg_l5a>;
	status = "okay";
};

If the qcom-dwmac-sgmii-phy driver was updated in this series to require
explicit vdda-0p9 and vdda-1p2 supplies, devm_regulator_bulk_get_const() will
fall back to dummy regulators for these missing named supplies.

This would leave the 0.9V physical rail unpowered on these other boards, which
causes the PHY calibration to time out and the Ethernet interface to fail to
initialize.

Should these device trees also be updated to ensure their SerDes PHYs do not
fail to power up?

>  
>  	status = "okay";
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260804-b4-sgmiieth_serdes_regulator-v2-0-c4bc688177dd@oss.qualcomm.com?part=5