Re: [PATCH 10/12] iommu: qcom_iommu: program BFP (prefetch) settings

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing clock disable/unprepare on error paths in qcom_iommu_resume() leading to reference leaks.
--

--- Patch [10]: [PATCH 10/12] iommu: qcom_iommu: program BFP (prefetch) settings ---
commit 7f97a52dc093659d163957e201f4e9c73067ebaf
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

iommu: qcom_iommu: program BFP (prefetch) settings

MSM8974 QSMMU instances require additional programming of the prefetch
settings in the instance-specific space, with the tables being specific
to a particular instance. Implement support for programming BFB tables.

> diff --git a/drivers/iommu/arm/arm-smmu/qcom_iommu.c b/drivers/iommu/arm/arm-smmu/qcom_iommu.c
> index 2b2cf665c39db..9523ae95fa125 100644
> --- a/drivers/iommu/arm/arm-smmu/qcom_iommu.c
> +++ b/drivers/iommu/arm/arm-smmu/qcom_iommu.c

[ ... ]

> @@ -1131,6 +1157,8 @@ static int __maybe_unused qcom_iommu_resume(struct device *dev)
>  			return ret;

[Severity: Medium]
Does this code leak the clock reference?

If qcom_iommu_reset_ns() or qcom_scm_restore_sec_cfg() fails during device
resume, this error path returns directly without calling
clk_bulk_disable_unprepare() to clean up the clocks that were enabled
earlier in qcom_iommu_resume() via clk_bulk_prepare_enable().

>  	}
>  
> +	qcom_iommu_bfb_setup(qcom_iommu);
> +
>  	if (qcom_iommu->cfg && qcom_iommu->cfg->ctx_restore) {
>  		/* Restore context banks lost over power collapse */
>  		for (i = 0; i <= qcom_iommu->max_asid; i++) {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260809-msm8974-iommu-upstream-v1-0-87f5cd492560@oss.qualcomm.com?part=10