[PATCH 0/7] arm64: dts: rockchip: give HDMI sound cards SoC-specific names

[PATCH 0/7] arm64: dts: rockchip: give HDMI sound cards SoC-specific names

[Detlev Casanova]

Hello !

Some Rockchip SoC that exposes HDMI audio through simple-audio-card
currently expose a generic and inconsistent 'simple-audio-card,name':
- HDMI on rk3066a, rk3288, rk3328, rk356x and rk3576
- hdmi-sound on rk3399
- hdmi[01] on rk3588

That string is user-visible and it shows up in aplay -l,
/proc/asound/cards and is what ALSA UCM, WirePlumber and PulseAudio
match on when picking a profile for a card.

As the names are not unique across boards (5 of them use HDMI), any
userspace rule matching on the current name is ambiguous.
alsa-ucm-conf.git has no upstream UCM profile matching "HDMI", 
"hdmi-sound", "hdmi0" or "hdmi1" for Rockchip, precisely
because such a name could match on the wrong hardware.
It also prevents alsa-ucm to hav specific profiles per SoC.

This series renames each card to "RK<SOC> HDMI[N]". The new names:
- are unique inside the Rockchip family and self-describing,
- fit the 16-char ALSA driver field after normalization
  ("RK3588 HDMI1" -> driver "RK3588_HDMI1"),
- give distributions a stable, unambiguous name to match UCM /
  WirePlumber / PulseAudio rules on, which the current names cannot
  provide.

Because no upstream userspace configuration can match on the current
names without misfiring on a different board, this rename does not
regress any known userspace setup and allows reliable matching on the
different SoCs.
It also gives naming examples for future Rockchip SoC enablement work,
which should avoid naming issues from now on.

As similar rename was already previously accepted in commit 309598fca339
("arm64: dts: rockchip: Use a readable audio card name on NanoPi M5"),
which changed 'simple-audio-card,name' simply for aesthetic reasons.

Detlev.

Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
---
Detlev Casanova (7):
      arm64: dts: rockchip: Rename rk3066a HDMI audio card
      arm64: dts: rockchip: Rename rk3288 HDMI audio card
      arm64: dts: rockchip: Rename rk3328 HDMI audio card
      arm64: dts: rockchip: Rename rk3399 HDMI audio card
      arm64: dts: rockchip: Rename rk356x HDMI audio card
      arm64: dts: rockchip: Rename rk3576 HDMI audio card
      arm64: dts: rockchip: Rename rk3588 HDMI audio cards

 arch/arm/boot/dts/rockchip/rk3066a.dtsi        | 2 +-
 arch/arm/boot/dts/rockchip/rk3288-miqi.dts     | 2 +-
 arch/arm64/boot/dts/rockchip/rk3328.dtsi       | 2 +-
 arch/arm64/boot/dts/rockchip/rk3399-base.dtsi  | 2 +-
 arch/arm64/boot/dts/rockchip/rk356x-base.dtsi  | 2 +-
 arch/arm64/boot/dts/rockchip/rk3576.dtsi       | 2 +-
 arch/arm64/boot/dts/rockchip/rk3588-base.dtsi  | 2 +-
 arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi | 2 +-
 8 files changed, 8 insertions(+), 8 deletions(-)
---
base-commit: cee9395acd8043be0644b25c34bfa86623f2b935
change-id: 20260831-fix-rockchip-hdmi-audio-names-8c10ad64f58a

Best regards,
--  
Detlev Casanova <detlev.casanova@collabora.com>

[PATCH 1/7] arm64: dts: rockchip: Rename rk3066a HDMI audio card

[Detlev Casanova]

Rename the card from "HDMI" to "RK3066a HDMI" so it identifies the
SoC in user-visible ALSA fields (shortname / longname / driver) and
no longer collides with the identical "HDMI" string used by rk3288,
rk3328, rk356x and rk3576.

Fixes: 041f240e4df6c ("ARM: dts: rockchip: add hdmi-sound node to rk3066a")
Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
---
 arch/arm/boot/dts/rockchip/rk3066a.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/rockchip/rk3066a.dtsi b/arch/arm/boot/dts/rockchip/rk3066a.dtsi
index 3f6d49459734..12a3cbdfb481 100644
--- a/arch/arm/boot/dts/rockchip/rk3066a.dtsi
+++ b/arch/arm/boot/dts/rockchip/rk3066a.dtsi
@@ -55,7 +55,7 @@ display-subsystem {
 
 	hdmi_sound: hdmi-sound {
 		compatible = "simple-audio-card";
-		simple-audio-card,name = "HDMI";
+		simple-audio-card,name = "RK3066a HDMI";
 		simple-audio-card,format = "i2s";
 		simple-audio-card,mclk-fs = <256>;
 		status = "disabled";

-- 
2.55.0

[PATCH 2/7] arm64: dts: rockchip: Rename rk3288 HDMI audio card

[Detlev Casanova]

Rename the card from "HDMI" to "RK3288 HDMI" so it identifies the SoC
in user-visible ALSA fields and no longer collides with the identical
"HDMI" string used by other Rockchip SoCs.

Fixes: 2a91dcd5be9d ("ARM: dts: rockchip: add HDMI audio to rk3288-miqi")
Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
---
 arch/arm/boot/dts/rockchip/rk3288-miqi.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/rockchip/rk3288-miqi.dts b/arch/arm/boot/dts/rockchip/rk3288-miqi.dts
index a5f5c6d38f80..090255244c86 100644
--- a/arch/arm/boot/dts/rockchip/rk3288-miqi.dts
+++ b/arch/arm/boot/dts/rockchip/rk3288-miqi.dts
@@ -82,7 +82,7 @@ vcc_sys: regulator-vsys {
 	sound {
 		compatible = "simple-audio-card";
 		simple-audio-card,format = "i2s";
-		simple-audio-card,name = "HDMI";
+		simple-audio-card,name = "RK3288 HDMI";
 		simple-audio-card,mclk-fs = <512>;
 
 		simple-audio-card,codec {

-- 
2.55.0

[PATCH 3/7] arm64: dts: rockchip: Rename rk3328 HDMI audio card

[Detlev Casanova]

Rename the card from "HDMI" to "RK3328 HDMI" so it identifies the SoC
in user-visible ALSA fields and no longer collides with the identical
"HDMI" string used by other Rockchip SoCs.

Fixes: 29e8976e604f1 ("arm64: dts: rockchip: Add RK3328 audio pipelines")
Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
---
 arch/arm64/boot/dts/rockchip/rk3328.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
index 03b7c4313750..26c9f4558ed9 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
@@ -207,7 +207,7 @@ hdmi_sound: hdmi-sound {
 		compatible = "simple-audio-card";
 		simple-audio-card,format = "i2s";
 		simple-audio-card,mclk-fs = <128>;
-		simple-audio-card,name = "HDMI";
+		simple-audio-card,name = "RK3328 HDMI";
 		status = "disabled";
 
 		simple-audio-card,cpu {

-- 
2.55.0

[PATCH 4/7] arm64: dts: rockchip: Rename rk3399 HDMI audio card

[Detlev Casanova]

Rename the card from "hdmi-sound" to "RK3399 HDMI" so it identifies
the SoC in user-visible ALSA fields and matches the naming scheme
used across the rest of the Rockchip family.

Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
---
 arch/arm64/boot/dts/rockchip/rk3399-base.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-base.dtsi
index 49c68fe65de6..c46e58d4af0d 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-base.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-base.dtsi
@@ -2008,7 +2008,7 @@ hdmi_sound: hdmi-sound {
 		compatible = "simple-audio-card";
 		simple-audio-card,format = "i2s";
 		simple-audio-card,mclk-fs = <256>;
-		simple-audio-card,name = "hdmi-sound";
+		simple-audio-card,name = "RK3399 HDMI";
 		status = "disabled";
 
 		simple-audio-card,cpu {

-- 
2.55.0

[PATCH 5/7] arm64: dts: rockchip: Rename rk356x HDMI audio card

[Detlev Casanova]

Rename the card from "HDMI" to "RK356x HDMI" so it identifies the SoC
in user-visible ALSA fields and no longer collides with the identical
"HDMI" string used by other Rockchip SoCs.

Fixes: 697ee8546e241 ("arm64: dts: rockchip: Add HDMI audio nodes to rk356x")
Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
---
 arch/arm64/boot/dts/rockchip/rk356x-base.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
index a5832895bd39..98785c812fc4 100644
--- a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
@@ -150,7 +150,7 @@ scmi_clk: protocol@14 {
 
 	hdmi_sound: hdmi-sound {
 		compatible = "simple-audio-card";
-		simple-audio-card,name = "HDMI";
+		simple-audio-card,name = "RK356x HDMI";
 		simple-audio-card,format = "i2s";
 		simple-audio-card,mclk-fs = <256>;
 		status = "disabled";

-- 
2.55.0

[PATCH 6/7] arm64: dts: rockchip: Rename rk3576 HDMI audio card

[Detlev Casanova]

Rename the card from "HDMI" to "RK3576 HDMI" so it identifies the SoC
in user-visible ALSA fields and no longer collides with the identical
"HDMI" string used by other Rockchip SoCs.

Fixes: 7f1561d82e3d3 ("arm64: dts: rockchip: Add RK3576 HDMI audio")
Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
---
 arch/arm64/boot/dts/rockchip/rk3576.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3576.dtsi b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
index b0c0d3c8b1b1..ca9cbf035265 100644
--- a/arch/arm64/boot/dts/rockchip/rk3576.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
@@ -410,7 +410,7 @@ scmi_clk: protocol@14 {
 
 	hdmi_sound: hdmi-sound {
 		compatible = "simple-audio-card";
-		simple-audio-card,name = "HDMI";
+		simple-audio-card,name = "RK3576 HDMI";
 		simple-audio-card,format = "i2s";
 		simple-audio-card,mclk-fs = <256>;
 		status = "disabled";

-- 
2.55.0

[PATCH 7/7] arm64: dts: rockchip: Rename rk3588 HDMI audio cards

[Detlev Casanova]

Rename the two cards from "hdmi0"/"hdmi1" to "RK3588 HDMI0"/"RK3588
HDMI1" so they identify the SoC in user-visible ALSA fields and match
the naming scheme used across the rest of the Rockchip family.

Fixes: b8c6c136971c0 ("arm64: dts: rockchip: Add HDMI audio outputs for rk3588")
Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
---
 arch/arm64/boot/dts/rockchip/rk3588-base.dtsi  | 2 +-
 arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
index 376ad04e0786..7892e18a7835 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
@@ -376,7 +376,7 @@ hdmi0_sound: hdmi0-sound {
 		compatible = "simple-audio-card";
 		simple-audio-card,format = "i2s";
 		simple-audio-card,mclk-fs = <128>;
-		simple-audio-card,name = "hdmi0";
+		simple-audio-card,name = "RK3588 HDMI0";
 		status = "disabled";
 
 		simple-audio-card,codec {
diff --git a/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi
index b251bb129cdb..2bcf30d8a338 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi
@@ -11,7 +11,7 @@ hdmi1_sound: hdmi1-sound {
 		compatible = "simple-audio-card";
 		simple-audio-card,format = "i2s";
 		simple-audio-card,mclk-fs = <128>;
-		simple-audio-card,name = "hdmi1";
+		simple-audio-card,name = "RK3588 HDMI1";
 		status = "disabled";
 
 		simple-audio-card,codec {

-- 
2.55.0

Re: [PATCH 5/7] arm64: dts: rockchip: Rename rk356x HDMI audio card

[Diederik de Haas]

On Mon Aug 31, 2026 at 4:20 PM CEST, Detlev Casanova wrote:
> Rename the card from "HDMI" to "RK356x HDMI" so it identifies the SoC
> in user-visible ALSA fields and no longer collides with the identical
> "HDMI" string used by other Rockchip SoCs.
>
> Fixes: 697ee8546e241 ("arm64: dts: rockchip: Add HDMI audio nodes to rk356x")
> Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk356x-base.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
> index a5832895bd39..98785c812fc4 100644
> --- a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
> @@ -150,7 +150,7 @@ scmi_clk: protocol@14 {
>  
>  	hdmi_sound: hdmi-sound {
>  		compatible = "simple-audio-card";
> -		simple-audio-card,name = "HDMI";
> +		simple-audio-card,name = "RK356x HDMI";

Move the name property to rk3566.dtsi and rk3568.dtsi and use their actual
SoC name, thus RK3566 and RK3568?

Cheers,
  Diederik
>  		simple-audio-card,format = "i2s";
>  		simple-audio-card,mclk-fs = <256>;
>  		status = "disabled";

Re: [PATCH 2/7] arm64: dts: rockchip: Rename rk3288 HDMI audio card

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] Changing the ALSA sound card name breaks userspace ABI and backward compatibility.
- [Low] The commit subject uses the `arm64:` subsystem prefix, but modifies an ARM 32-bit device tree file.
--

commit 3a52d07446ba896b26f24f7276cf2ade84038b3b
Author: Detlev Casanova <detlev.casanova@collabora.com>

arm64: dts: rockchip: Rename rk3288 HDMI audio card

This commit renames the HDMI audio card in the rk3288-miqi device tree
from "HDMI" to "RK3288 HDMI" to avoid name collisions with other Rockchip
SoCs.

> arm64: dts: rockchip: Rename rk3288 HDMI audio card

[Severity: Low]
Does this commit subject use the correct architecture prefix?

The file being modified is `arch/arm/boot/dts/rockchip/rk3288-miqi.dts`, 
which belongs to the 32-bit ARM architecture, but the subject uses the 
arm64 prefix.

> diff --git a/arch/arm/boot/dts/rockchip/rk3288-miqi.dts b/arch/arm/boot/dts/rockchip/rk3288-miqi.dts
> index a5f5c6d38f801..090255244c86f 100644
> --- a/arch/arm/boot/dts/rockchip/rk3288-miqi.dts
> +++ b/arch/arm/boot/dts/rockchip/rk3288-miqi.dts
> @@ -82,7 +82,7 @@ vcc_sys: regulator-vsys {
>  	sound {
>  		compatible = "simple-audio-card";
>  		simple-audio-card,format = "i2s";
> -		simple-audio-card,name = "HDMI";
> +		simple-audio-card,name = "RK3288 HDMI";

[Severity: High]
Does this modification break userspace ABI and backward compatibility?

The simple-audio-card,name property defines the ALSA sound card name 
exposed to userspace. Audio servers like PulseAudio and PipeWire, as well 
as configuration tools like ALSA UCM and asound.state, rely on this name 
to identify the hardware, apply routing profiles, and restore volume levels.

Upgrading the kernel on an RK3288 MiQi board changes the ALSA card name 
from 'HDMI' to 'RK3288 HDMI'. Userspace configurations looking for the 
'HDMI' card (which has been present since commit 2a91dcd5be9d) will fail 
to match the new name, resulting in broken audio routing or lost volume 
states.

>  		simple-audio-card,mclk-fs = <512>;
>  
>  		simple-audio-card,codec {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831-fix-rockchip-hdmi-audio-names-v1-0-5b155ae05293@collabora.com?part=2

Re: [PATCH 3/7] arm64: dts: rockchip: Rename rk3328 HDMI audio card

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Critical] Changing the ALSA card name breaks existing userspace audio configurations.
--

commit 81852803c5b1ff9241b2ba92674226713005891f
Author: Detlev Casanova <detlev.casanova@collabora.com>

arm64: dts: rockchip: Rename rk3328 HDMI audio card

This commit renames the audio card for RK3328 from "HDMI" to "RK3328 HDMI"
in the device tree. The stated goal is to avoid colliding with identical
"HDMI" strings used by other Rockchip SoCs in user-visible ALSA fields.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> @@ -207,7 +207,7 @@ hdmi_sound: hdmi-sound {
>  		compatible = "simple-audio-card";
>  		simple-audio-card,format = "i2s";
>  		simple-audio-card,mclk-fs = <128>;
> -		simple-audio-card,name = "HDMI";
> +		simple-audio-card,name = "RK3328 HDMI";

[Severity: Critical]
Does this change break existing userspace audio configurations?

When the system boots with the updated device tree in hdmi_sound, the ALSA
core registers the card with the new "RK3328 HDMI" name. ALSA state
restoration tools (alsactl), Use Case Manager (UCM) profiles, and audio
servers like PulseAudio and PipeWire rely on this exact string to identify
the hardware, load appropriate rules, and restore mixer states.

Since this sound card name has been established in previous releases,
userspace tools attempting to match the old "HDMI" name will fail to apply
their configurations. Modifying an established user-visible identifier can
constitute an ABI breakage, causing audio regressions for any system using
the RK3328 SoC that upgrades to this device tree.

>  		status = "disabled";
>  
>  		simple-audio-card,cpu {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831-fix-rockchip-hdmi-audio-names-v1-0-5b155ae05293@collabora.com?part=3

Re: [PATCH 4/7] arm64: dts: rockchip: Rename rk3399 HDMI audio card

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] Changing the ALSA sound card name breaks userspace audio configurations and constitutes an ABI regression.
- [Medium] The commit message claims the new name matches the Rockchip family naming scheme, which is demonstrably false.
--

commit d9591718c98e7ed37b2a63128b5ae03809c98902
Author: Detlev Casanova <detlev.casanova@collabora.com>

arm64: dts: rockchip: Rename rk3399 HDMI audio card

This commit renames the HDMI audio card in the RK3399 device tree from
"hdmi-sound" to "RK3399 HDMI". The stated goal is to better identify the SoC
in ALSA fields and match naming conventions across the rest of the Rockchip
family.

>     Rename the card from "hdmi-sound" to "RK3399 HDMI" so it identifies
>     the SoC in user-visible ALSA fields and matches the naming scheme
>     used across the rest of the Rockchip family.

[Severity: Medium]
Is this description accurate?

Looking at the baseline tree, all other Rockchip base device trees use generic
HDMI names without an SoC prefix (e.g., "HDMI" in rk3328, rk356x, and rk3576;
"hdmi0" in rk3588).

Since the series itself introduces the SoC prefix to these other files in
subsequent patches, it seems no such naming scheme existed across the rest of
the family at the time of this commit. Could the commit message be more
precise about the motivation?

> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-base.dtsi
> index 49c68fe65de66..c46e58d4af0d4 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-base.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-base.dtsi
> @@ -2008,7 +2008,7 @@ hdmi_sound: hdmi-sound {
>  		compatible = "simple-audio-card";
>  		simple-audio-card,format = "i2s";
>  		simple-audio-card,mclk-fs = <256>;
> -		simple-audio-card,name = "hdmi-sound";
> +		simple-audio-card,name = "RK3399 HDMI";

[Severity: High]
Does changing the user-visible ALSA card name constitute an ABI regression?

Userspace audio frameworks like PulseAudio or ALSA UCM use the ALSA card name
to identify the device and apply correct mixer and routing profiles. Changing
simple-audio-card,name alters this user-visible identifier.

Existing userspace configurations on the widely deployed RK3399 platform that
match on "hdmi-sound" will fail on boot, resulting in broken audio
out-of-the-box and violating the kernel's rules regarding userspace ABI
regressions.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831-fix-rockchip-hdmi-audio-names-v1-0-5b155ae05293@collabora.com?part=4

Re: [PATCH 5/7] arm64: dts: rockchip: Rename rk356x HDMI audio card

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Critical] ABI Breakage: Renaming ALSA sound card breaks existing user-space audio configurations
--

commit 09adc9bbc18df386e17d8391018eada18c2a6d2a
Author: Detlev Casanova <detlev.casanova@collabora.com>

arm64: dts: rockchip: Rename rk356x HDMI audio card

This commit modifies the ALSA sound card name exposed by the device tree 
from "HDMI" to "RK356x HDMI" to avoid collisions with other Rockchip SoCs.

> diff --git a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
> index a5832895bd392..98785c812fc40 100644
> --- a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
> @@ -150,7 +150,7 @@ scmi_clk: protocol@14 {
>  
>  	hdmi_sound: hdmi-sound {
>  		compatible = "simple-audio-card";
> -		simple-audio-card,name = "HDMI";
> +		simple-audio-card,name = "RK356x HDMI";

[Severity: Critical]
Is it safe to change the ALSA card name exposed to userspace? 

The simple-audio-card,name property in hdmi_sound defines the exact sound
card name seen by userspace via ALSA. Changing this string from HDMI to
RK356x HDMI might break backwards compatibility with existing userspace audio
configurations, such as ALSA UCM profiles, PipeWire rules, or PulseAudio
matchers that rely on the established generic name. 

A user booting an updated kernel on an rk356x platform using existing UCM
profiles could experience broken audio unconditionally upon boot. Does this
change violate the kernel's policy against breaking userspace ABI?

>  		simple-audio-card,format = "i2s";
>  		simple-audio-card,mclk-fs = <256>;
>  		status = "disabled";

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831-fix-rockchip-hdmi-audio-names-v1-0-5b155ae05293@collabora.com?part=5

Re: [PATCH 7/7] arm64: dts: rockchip: Rename rk3588 HDMI audio cards

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Critical] Renaming the ALSA sound card breaks existing userspace configurations that rely on the old name.
--

commit ee162ed61bb57db0487beb65c4dfb703f1987e94
Author: Detlev Casanova <detlev.casanova@collabora.com>
arm64: dts: rockchip: Rename rk3588 HDMI audio cards

This commit renames the ALSA sound cards in the devicetree from "hdmi0" and
"hdmi1" to "RK3588 HDMI0" and "RK3588 HDMI1". The stated goal is to better
identify the SoC in user-visible ALSA fields and match other naming schemes
used across the Rockchip family.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
> index 376ad04e07869..7892e18a7835a 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
> @@ -376,7 +376,7 @@ hdmi0_sound: hdmi0-sound {
>  		compatible = "simple-audio-card";
>  		simple-audio-card,format = "i2s";
>  		simple-audio-card,mclk-fs = <128>;
> -		simple-audio-card,name = "hdmi0";
> +		simple-audio-card,name = "RK3588 HDMI0";

[Severity: Critical]
Does this change introduce a userspace regression? Changing the ALSA sound
card name alters the user-visible userspace ABI. Userspace audio daemons
such as PipeWire, PulseAudio, and ALSA Use Case Manager (UCM) profiles
often match against the exact card name (in this case, "hdmi0") to apply
specific routing and hardware configurations.

Will upgrading the kernel cause existing userspace configurations to fail
to identify the audio card, resulting in a loss of audio functionality?

> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi
> index b251bb129cdbf..2bcf30d8a338d 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi
> @@ -11,7 +11,7 @@ hdmi1_sound: hdmi1-sound {
>  		compatible = "simple-audio-card";
>  		simple-audio-card,format = "i2s";
>  		simple-audio-card,mclk-fs = <128>;
> -		simple-audio-card,name = "hdmi1";
> +		simple-audio-card,name = "RK3588 HDMI1";

[Severity: Critical]
Similarly for the hdmi1-sound node, does renaming this card break
compatibility for existing userspace environments relying on the original
"hdmi1" name? The kernel generally enforces a strict no-regressions
policy for userspace interfaces.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831-fix-rockchip-hdmi-audio-names-v1-0-5b155ae05293@collabora.com?part=7

Re: [PATCH 5/7] arm64: dts: rockchip: Rename rk356x HDMI audio card

[Detlev Casanova]

On Monday, 31 August 2026 13:29:00 EDT Diederik de Haas wrote:
> On Mon Aug 31, 2026 at 4:20 PM CEST, Detlev Casanova wrote:
> > Rename the card from "HDMI" to "RK356x HDMI" so it identifies the SoC
> > in user-visible ALSA fields and no longer collides with the identical
> > "HDMI" string used by other Rockchip SoCs.
> > 
> > Fixes: 697ee8546e241 ("arm64: dts: rockchip: Add HDMI audio nodes to
> > rk356x") Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
> > ---
> > 
> >  arch/arm64/boot/dts/rockchip/rk356x-base.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
> > b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi index
> > a5832895bd39..98785c812fc4 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
> > +++ b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
> > @@ -150,7 +150,7 @@ scmi_clk: protocol@14 {
> > 
> >  	hdmi_sound: hdmi-sound {
> >  	
> >  		compatible = "simple-audio-card";
> > 
> > -		simple-audio-card,name = "HDMI";
> > +		simple-audio-card,name = "RK356x HDMI";
> 
> Move the name property to rk3566.dtsi and rk3568.dtsi and use their actual
> SoC name, thus RK3566 and RK3568?

I hesitated on this one but I agree with you, it's better to have more 
granularity. Will update in v2.

Detlev.

> Cheers,
>   Diederik
> 
> >  		simple-audio-card,format = "i2s";
> >  		simple-audio-card,mclk-fs = <256>;
> >  		status = "disabled";