Re: [PATCH 09/11] arm64: dts: qcom: pm660l: add analog audio codec

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] dts: qcom: board properties hardcoded in generic pm660l.dtsi
- [Low] dts: qcom: pm660l: sound-name-prefix violates binding schema
--

commit 331a31ea9c73f1abc1441342a8c3c461afc91cb0
Author: Richard Acayan <mailingradian@gmail.com>

arm64: dts: qcom: pm660l: add analog audio codec

The PM660L analog audio codec (PMIC revision 4) controls the headphone
jack, and optionally the earpiece and speaker, at the vendor's decision.
Add the analog audio codec.

> diff --git a/arch/arm64/boot/dts/qcom/pm660l.dtsi b/arch/arm64/boot/dts/qcom/pm660l.dtsi
> index 3f8b9eafe1641..5b406b83043c2 100644
> --- a/arch/arm64/boot/dts/qcom/pm660l.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm660l.dtsi
[ ... ]
> @@ -87,6 +87,46 @@ pm660l_wled: leds@d800 {
>  			status = "disabled";
>  		};
>  
> +		pm660l_codec: audio-codec@f000 {
> +			compatible = "qcom,pm660l-wcd-analog-codec",
> +				     "qcom,pm8953-wcd-analog-codec";
> +			reg = <0xf000>;
[ ... ]
> +			qcom,hphl-jack-type-normally-open;
> +			qcom,gnd-jack-type-normally-open;
> +			qcom,micbias2-ext-cap;

[Severity: Low]
Are these properties appropriate for a generic PMIC device tree include?

These properties describe external, board-specific physical hardware rather
than internal states of the PM660L PMIC. Including them in the shared .dtsi
applies these board specifics to all devices using this PMIC, which forces
boards with different headphone jack types or micbias wiring to use the Device
Tree /delete-property/ anti-pattern to unset them.

> +			sound-name-prefix = "Analog";

[Severity: Low]
Does this property violate the binding schema?

The device tree schema for qcom,pm8916-wcd-analog-codec.yaml has
additionalProperties: false, but it does not define sound-name-prefix
nor does it import a common schema (e.g. dai-common.yaml) that would permit
it. This will likely trigger a dtbs_check schema validation error.

> +			#sound-dai-cells = <1>;
> +			status = "disabled";
> +		};
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260922015801.32373-1-mailingradian@gmail.com?part=9