Re: [PATCH 06/11] arm64: dts: qcom: sdm670: add adsp

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: qcom: sdm670: missing qcom,non-secure-domain in ADSP fastrpc
--

commit 9ab90abda949e62df6000bf0659ede91a3c191bb
Author: Richard Acayan <mailingradian@gmail.com>

arm64: dts: qcom: sdm670: add adsp

This commit adds the Audio DSP (ADSP) node and SMP2P nodes for SDM670 to
handle audio and sensors. It includes the sleep state to prevent crashes
and configures the GLINK edge with APR and FastRPC subnodes.

> diff --git a/arch/arm64/boot/dts/qcom/sdm670.dtsi b/arch/arm64/boot/dts/qcom/sdm670.dtsi
> --- a/arch/arm64/boot/dts/qcom/sdm670.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm670.dtsi

[ ... ]

> +		adsp_pas: remoteproc@62400000 {
> +			compatible = "qcom,sdm670-adsp-pas";
> +			reg = <0 0x62400000 0 0x100>;

[ ... ]

> +			glink-edge {
> +				interrupts = <GIC_SPI 170 IRQ_TYPE_EDGE_RISING>;
> +				label = "lpass";
> +				qcom,remote-pid = <2>;
> +				mboxes = <&apss_shared 24>;

[ ... ]

> +				fastrpc {
> +					compatible = "qcom,fastrpc";
> +					qcom,glink-channels = "fastrpcglink-apps-dsp";
> +					label = "adsp";
> +					#address-cells = <1>;
> +					#size-cells = <0>;

[Severity: Medium]
Does this fastrpc node need the qcom,non-secure-domain property?

Without this property, the secure_dsp flag evaluates to true during driver
probe in drivers/misc/fastrpc.c. For the ADSP domain,
fastrpc_device_register() will then create only the fastrpc-adsp-secure
device node instead of fastrpc-adsp.

Will this cause standard userspace libraries to fail to open the DSP device
if they expect the non-secure node?

> +
> +					compute-cb@3 {
> +						compatible = "qcom,fastrpc-compute-cb";
> +						reg = <3>;
> +						iommus = <&apps_smmu 0x1803 0x0>;
> +					};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260922015801.32373-1-mailingradian@gmail.com?part=6