Devicetree
 help / color / mirror / Atom feed
From: Richard Acayan <mailingradian@gmail.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Jassi Brar <jassisinghbrar@gmail.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Abel Vesa <abelvesa@kernel.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Andy Gross <agross@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH 05/11] remoteproc: qcom: pas: Add SDM670 ADSP support
Date: Mon, 28 Sep 2026 10:55:34 -0400	[thread overview]
Message-ID: <arp_5ts21rAgcr-P@rdacayan> (raw)
In-Reply-To: <58ced827-d6ec-49e1-9a2d-a4d5c4111721@oss.qualcomm.com>

On Tue, Sep 22, 2026 at 12:44:36PM +0200, Konrad Dybcio wrote:
> On 9/22/26 3:57 AM, Richard Acayan wrote:
> > The ADSP is used to control audio and sensors on the SDM670 SoC. Add the
> > compatible for it, with the same data as SDM845 since the driver
> > requires the load_state.
> > 
> > Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> > ---
> >  drivers/remoteproc/qcom_q6v5_pas.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> > index ca8e61254c44..5272a462fc49 100644
> > --- a/drivers/remoteproc/qcom_q6v5_pas.c
> > +++ b/drivers/remoteproc/qcom_q6v5_pas.c
> > @@ -1865,6 +1865,7 @@ static const struct of_device_id qcom_pas_of_match[] = {
> >  	{ .compatible = "qcom,sc8280xp-nsp1-pas", .data = &sc8280xp_nsp1_resource },
> >  	{ .compatible = "qcom,sdm660-adsp-pas", .data = &adsp_resource_init },
> >  	{ .compatible = "qcom,sdm660-cdsp-pas", .data = &cdsp_resource_init },
> > +	{ .compatible = "qcom,sdm670-adsp-pas", .data = &sdm845_adsp_resource_init },
> 
> Would a fallback compatible be suitable here?

I'll do this next revision to avoid adding the constraints in the
bindings, but I think SDM845 will only have one specific compatible.
MSM8998 and SM8150 use different data than SDM845.

  reply	other threads:[~2026-09-28 14:55 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-22  1:57 [PATCH 00/11] ADSP for SDM670 and sound on Google Pixel 3a Richard Acayan
2026-09-22  1:57 ` [PATCH 01/11] dt-bindings: soc: qcom,smp2p: add sleepstate support Richard Acayan
2026-09-27 18:08   ` Krzysztof Kozlowski
2026-09-22  1:57 ` [PATCH 02/11] dt-bindings: mailbox: qcom: Add SDM670 APCS compatible Richard Acayan
2026-09-27 18:09   ` Krzysztof Kozlowski
2026-09-22  1:57 ` [PATCH 03/11] dt-bindings: soc: qcom: aoss: Add compatible for SDM670 Richard Acayan
2026-09-27 18:10   ` Krzysztof Kozlowski
2026-09-22  1:57 ` [PATCH 04/11] dt-bindings: remoteproc: qcom: adsp: Add SDM670 ADSP compatible Richard Acayan
2026-09-27 18:10   ` Krzysztof Kozlowski
2026-09-22  1:57 ` [PATCH 05/11] remoteproc: qcom: pas: Add SDM670 ADSP support Richard Acayan
2026-09-22 10:44   ` Konrad Dybcio
2026-09-28 14:55     ` Richard Acayan [this message]
2026-09-22  1:57 ` [PATCH 06/11] arm64: dts: qcom: sdm670: add adsp Richard Acayan
2026-09-22  2:08   ` sashiko-bot
2026-10-01  8:38   ` Konrad Dybcio
2026-09-22  1:57 ` [PATCH 07/11] arm64: dts: qcom: sdm670-google: enable adsp Richard Acayan
2026-10-01  8:38   ` Konrad Dybcio
2026-09-22  1:57 ` [PATCH 08/11] arm64: dts: qcom: sdm670-google: add sound card Richard Acayan
2026-09-22  1:57 ` [PATCH 09/11] arm64: dts: qcom: pm660l: add analog audio codec Richard Acayan
2026-09-22  2:05   ` sashiko-bot
2026-09-22  1:58 ` [PATCH 10/11] arm64: dts: qcom: sdm670: add digital " Richard Acayan
2026-10-01  8:39   ` Konrad Dybcio
2026-09-22  1:58 ` [PATCH 11/11] arm64: dts: qcom: sdm670-google: configure analog and digital codecs Richard Acayan
2026-09-22  2:11   ` sashiko-bot
2026-09-22 10:47   ` Konrad Dybcio
2026-09-25 17:48     ` Richard Acayan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=arp_5ts21rAgcr-P@rdacayan \
    --to=mailingradian@gmail.com \
    --cc=abelvesa@kernel.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jassisinghbrar@gmail.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox