Re: [PATCH 06/11] arm64: dts: qcom: sdm670: add adsp

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 9/22/26 3:57 AM, Richard Acayan wrote:
> The Audio DSP (Digital Signal Processor) is responsible for audio and
> sensors on SDM670. Add this, along with the SMP2P nodes used to
> communicate with it.
> 
> The sleep state is included to prevent the following crash:
> 
>     qcom_q6v5_pas remoteproc-adsp: fatal error received: err_qdi.c:450:EF:sensor_process:1:sar.cc:27:chre_utils fatal
> 
> Otherwise, it is unused.
> 
> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> ---

[...]

> +		/*
> +		 * The ADSP crashes if this is not present. Simply probing this
> +		 * magically prevents the crash. It does not need any driver to
> +		 * interact with it. It is labelled in case proper support is
> +		 * added for it.
> +		 */
> +		adsp_smp2p_sleepstate: sleepstate {
> +			qcom,entry-name = "sleepstate";
> +			#qcom,smem-state-cells = <1>;
> +		};

It's not magic, the driver registers it in the SMEM item, and the
ADSP likely looks it up and complains if it's missing. You can
drop this comment, since you already explained it in the commit
message.

[...]

> +		adsp_pas: remoteproc@62400000 {
> +			compatible = "qcom,sdm670-adsp-pas";
> +			reg = <0 0x62400000 0 0x100>;

len=0x4040

[...]					compute-cb@6 {
> +						compatible = "qcom,fastrpc-compute-cb";
> +						reg = <6>;
> +						iommus = <&apps_smmu 0x1806 0x0>;
> +						qcom,nsessions = <2>;

This property is going away, please remove it

Konrad