[PATCH v1] arm64: dts: qcom: glymur-crd: Enable DMIC4 and DMIC5 on CRD

[PATCH v1] arm64: dts: qcom: glymur-crd: Enable DMIC4 and DMIC5 on CRD

[Mohammad Rafi Shaik]

Add the LPASS LPI pinctrl state for the third DMIC clock line, which
drives DMIC4 and DMIC5.

CRD has additional digital microphones connected to this clock line, so
reference the new pinctrl state from the VA macro and route the
microphone bias supply to DMIC4 and DMIC5 to make them usable.

Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/glymur-crd.dtsi |  6 ++++--
 arch/arm64/boot/dts/qcom/glymur.dtsi     | 16 ++++++++++++++++
 2 files changed, 20 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
index ccdc322157e0..02e342ecfe4a 100644
--- a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
+++ b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
@@ -247,7 +247,9 @@ sound {
 				"VA DMIC0", "vdd-micb",
 				"VA DMIC1", "vdd-micb",
 				"VA DMIC2", "vdd-micb",
-				"VA DMIC3", "vdd-micb";
+				"VA DMIC3", "vdd-micb",
+				"VA DMIC4", "vdd-micb",
+				"VA DMIC5", "vdd-micb";
 
 		wsa-dai-link {
 			link-name = "WSA Playback";
@@ -695,7 +697,7 @@ touchscreen@38 {
 };
 
 &lpass_vamacro {
-	pinctrl-0 = <&dmic01_default>, <&dmic23_default>;
+	pinctrl-0 = <&dmic01_default>, <&dmic23_default>, <&dmic45_default>;
 	pinctrl-names = "default";
 	qcom,dmic-sample-rate = <4800000>;
 	vdd-micb-supply = <&vreg_l1b_e0_1p8>;
diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qcom/glymur.dtsi
index de7c395d9c35..c941b473ce25 100644
--- a/arch/arm64/boot/dts/qcom/glymur.dtsi
+++ b/arch/arm64/boot/dts/qcom/glymur.dtsi
@@ -4768,6 +4768,22 @@ data-pins {
 				};
 			};
 
+			dmic45_default: dmic45-default-state {
+				clk-pins {
+					pins = "gpio17";
+					function = "dmic4_clk";
+					drive-strength = <8>;
+					output-high;
+				};
+
+				data-pins {
+					pins = "gpio18";
+					function = "dmic4_data";
+					drive-strength = <8>;
+					input-enable;
+				};
+			};
+
 			wsa_swr_active: wsa-swr-active-state {
 				clk-pins {
 					pins = "gpio10";
-- 
2.34.1

Re: [PATCH v1] arm64: dts: qcom: glymur-crd: Enable DMIC4 and DMIC5 on CRD

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] sound: qcom: DMIC pinctrl and DAPM route mismatch leaves mics unclocked
--

commit acf2021d4b3109886871e1b20f566cf0a1e65f99
Author: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>

arm64: dts: qcom: glymur-crd: Enable DMIC4 and DMIC5 on CRD

Add the LPASS LPI pinctrl state for the third DMIC clock line, which
drives DMIC4 and DMIC5.

> diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
> index e27c697e31702..3f600b924a31d 100644
> --- a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
> +++ b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
> @@ -247,7 +247,9 @@ sound {
>  				"VA DMIC0", "vdd-micb",
>  				"VA DMIC1", "vdd-micb",
>  				"VA DMIC2", "vdd-micb",
> -				"VA DMIC3", "vdd-micb";
> +				"VA DMIC3", "vdd-micb",
> +				"VA DMIC4", "vdd-micb",
> +				"VA DMIC5", "vdd-micb";

[Severity: Medium]
Will this DAPM route configuration mismatch the pinctrl configuration below?

Requesting DAPM audio routes for VA DMIC4 and VA DMIC5 causes the VA Macro
codec to enable the 3rd DMIC clock line. However, the pinctrl state configured
in glymur.dtsi targets the 4th clock line. As a result, the newly added
microphones might fail to capture audio, returning only silence.

[ ... ]

> diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qcom/glymur.dtsi
> index f04058d2e0891..891377f38dcb5 100644
> --- a/arch/arm64/boot/dts/qcom/glymur.dtsi
> +++ b/arch/arm64/boot/dts/qcom/glymur.dtsi
> @@ -4437,6 +4437,22 @@ data-pins {
>  				};
>  			};
>  
> +			dmic45_default: dmic45-default-state {
> +				clk-pins {
> +					pins = "gpio17";
> +					function = "dmic4_clk";

[Severity: Medium]
Should this function be dmic3_clk instead?

The commit message states the intent is to enable the third DMIC clock line
for DMIC4 and DMIC5. Configuring dmic4_clk on gpio17 here assigns it to
the fourth DMIC clock line, which mismatches the VA Macro codec that expects
the third clock line. In other Qualcomm devicetrees, dmic45_default correctly
configures the dmic3_clk function.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260922101550.2216689-1-mohammad.rafi.shaik@oss.qualcomm.com?part=1