Re: [PATCH ath-next 02/16] dt-bindings: net: wireless: ath11k: Add bindings for IPQ5018

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] dt-bindings: ath11k: invalid use of interrupts-extended as hardware discriminator
- [Medium] dt-bindings: ath11k: missing required interrupt-names for ipq5018
--

commit 154ed5878ee19ca9ad768bee509f9bd7164a287a
Author: George Moussalem <george.moussalem@outlook.com>

dt-bindings: net: wireless: ath11k: Add bindings for IPQ5018

This commit adds Device Tree bindings for the IPQ5018 Wi-Fi configurations,
covering both the standalone and the multi-PD (MPD) setups with QCN6122
companion chips. It documents the necessary interrupts, shared memory
points, and memory regions for firmware loading and dumping.

> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
> index a846cd704b193..621ad6d4ddadb 100644
> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml
> @@ -29,8 +29,13 @@ properties:
>      minItems: 32
>      maxItems: 52
>  
> +  interrupts-extended:
> +    minItems: 56
> +    maxItems: 56
> +

[Severity: Medium]
Does explicitly defining interrupts-extended here override the built-in
normalization provided by dt-schema? Overriding this normalization is a known
dt-bindings anti-pattern.

[ ... ]

> +      allOf:
> +        - anyOf:
> +            - required:
> +                - interrupts
> +            - required:
> +                - interrupts-extended
> +        - if:
> +            required:
> +              - interrupts-extended

[Severity: Medium]
Does this conditional use a syntactic Device Tree property to infer the
hardware configuration (MPD vs standalone)? 

The properties interrupts and interrupts-extended are semantically equivalent
in Device Tree, and developers can use either syntax for any configuration.
Because dt-schema automatically normalizes interrupts-extended to interrupts,
won't this condition always evaluate to false during validation?

This would force MPD configurations into the else block where interrupt-names
is limited to 52 items, causing valid 56-interrupt MPD device trees to fail
static validation.

> +          then:
> +            properties:
> +              interrupt-names:
> +                minItems: 56
> +            required:
> +              - interrupts-extended
> +              - memory-region
> +              - memory-region-names
> +              - qcom,smem-states
> +              - qcom,smem-state-names

[Severity: Medium]
Is interrupt-names missing from this required list for the MPD configuration?

The ath11k driver strictly relies on platform_get_irq_byname() for AHB
devices like IPQ5018. If a downstream device tree is missing interrupt-names,
it appears it will pass schema validation but unconditionally fail during
driver probing.

> +          else:
> +            properties:
> +              interrupt-names:
> +                minItems: 52
> +                maxItems: 52
> +

[Severity: Medium]
Similarly, is interrupt-names also missing from the required list here for
the standalone configuration? This would cause the same disconnect between
schema validation and runtime requirements for the standalone case.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260923-ipq5018-qcn6122-mpd-v1-0-86729521a75c@outlook.com?part=2