Re: [PATCH ath-next 13/16] wifi: ath11k: add hw ring mask for QCN6122

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] ath11k: unhandled IRQ storms/spurious wakeups due to TX ring mask mismatch
--

commit 3b2799aad0073fb22a0ae0ac93a828666b2e2126
Author: George Moussalem <george.moussalem@outlook.com>

wifi: ath11k: add hw ring mask for QCN6122

This commit adds the hardware ring mask configuration for the QCN6122 chipset
and registers it in the hardware parameters.

> diff --git a/drivers/net/wireless/ath/ath11k/hw.c b/drivers/net/wireless/ath/ath11k/hw.c
> --- a/drivers/net/wireless/ath/ath11k/hw.c
> +++ b/drivers/net/wireless/ath/ath11k/hw.c
[ ... ]
> @@ -2070,6 +2070,43 @@ const struct ath11k_hw_ring_mask ath11k_hw_ring_mask_wcn6750 = {
>  	},
>  };
>  
> +const struct ath11k_hw_ring_mask ath11k_hw_ring_mask_qcn6122 = {
> +	.tx  = {
> +		ATH11K_TX_RING_MASK_0,
> +		ATH11K_TX_RING_MASK_1,
> +		ATH11K_TX_RING_MASK_2,
> +	},

[Severity: High]
Does this TX mask configuration cause unhandled interrupts or spurious wakeups?

QCN6122 uses ath11k_hw_hal_params_ipq5018 which specifies num_tx_rings = 1.
However, this mask enables three TX ring masks.

When an MSI vector fires for these extra groups and schedules NAPI,
ath11k_dp_service_srng() bounds its polling loop to num_tx_rings:

drivers/net/wireless/ath/ath11k/dp.c:ath11k_dp_service_srng() {
    for (i = 0; i < ab->hw_params.hal_params->num_tx_rings; i++) {
        if (BIT(ab->hw_params.hal_params->tcl2wbm_rbm_map[i].wbm_ring_num) &
            ab->hw_params.ring_mask->tx[grp_id])
            ath11k_dp_tx_completion_handler(ab, i);
    }
    ...
}

Since num_tx_rings is 1, the extra rings defined in the mask 
(ATH11K_TX_RING_MASK_1 and ATH11K_TX_RING_MASK_2) will not be processed. Could 
this lead to an unhandled interrupt storm or persistent performance degradation 
from spurious NAPI executions if the hardware actually signals these extra 
rings?

> +	.rx_mon_status = {
> +		0, 0, 0,
> +		ATH11K_RX_MON_STATUS_RING_MASK_0,
> +	},
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260923-ipq5018-qcn6122-mpd-v1-0-86729521a75c@outlook.com?part=13