Re: [PATCH ath-next 16/16] wifi: ath11k: add QCN6122 device support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt: hardcoded index used to parse interrupts-extended property
--

commit a671c63204dc1d7f92a92604acce5ee3fdc7bce5
Author: George Moussalem <george.moussalem@outlook.com>

wifi: ath11k: add QCN6122 device support

This commit adds support for the QCN6122 2x2 11AX PCIe chipset which is
enumerated by the WPSS Q6 processor. It introduces Q6 firmware segments
and device information configuration, including fetching details over QMI.

> diff --git a/drivers/net/wireless/ath/ath11k/ahb.c b/drivers/net/wireless/ath/ath11k/ahb.c
> --- a/drivers/net/wireless/ath/ath11k/ahb.c
> +++ b/drivers/net/wireless/ath/ath11k/ahb.c
[ ... ]
> @@ -1395,6 +1398,10 @@ static int ath11k_ahb_setup_msi_resources(struct ath11k_base *ab)
>  	ab->pci.msi.addr_hi = upper_32_bits(msi_addr_iova);
>  
>  	ret = of_property_read_u32_index(ab->dev->of_node, "interrupts", 1, &int_prop);
> +	if (ret == -EINVAL)
> +		ret = of_property_read_u32_index(ab->dev->of_node,
> +						 "interrupts-extended", 2,
> +						 &int_prop);

[Severity: Low]
Does this logic safely handle device trees where the interrupt controller
does not use exactly 3 interrupt cells?

Looking at ath11k_ahb_setup_msi_resources(), this bypasses standard Open
Firmware interrupt parsing by hardcoding index 2 for the interrupts-extended
property.

If the device tree uses an interrupt controller with #interrupt-cells
other than 3 (for instance, 2 or 4 cells), won't reading index 2 fetch either
the interrupt flags or part of the next specifier instead of the correct
hardware interrupt number used for MSI configuration?

Could the driver extract the hardware irq more robustly here, perhaps by using
irq_get_irq_data(platform_get_irq(pdev, 0))->hwirq instead of raw property
parsing?

>  	if (ret)
>  		return ret;
>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260923-ipq5018-qcn6122-mpd-v1-0-86729521a75c@outlook.com?part=16