Re: [PATCH ath-next 15/16] wifi: ath11k: define userPDs for QCN6122

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] ath11k: invalid QCN6122 userpd_id silent failure during probe
--

commit 4463bfc0a33ebb5b811e53822f3dfc8436afe153
Author: George Moussalem <george.moussalem@outlook.com>

wifi: ath11k: define userPDs for QCN6122

The IPQ5018 platform can come with one or two optional QCN6122 wifi cards.
To differentiate the two, the user PD instance number is added to the QMI
service instance ID. This lets the firmware know which radio instance to
use and on what PCIe rail it is on.

> diff --git a/drivers/net/wireless/ath/ath11k/ahb.c b/drivers/net/wireless/ath/ath11k/ahb.c
> index 03936f574c8d4..26110c9275776 100644
> --- a/drivers/net/wireless/ath/ath11k/ahb.c
> +++ b/drivers/net/wireless/ath/ath11k/ahb.c
> @@ -969,6 +969,14 @@ static int ath11k_ahb_init_userpd(struct ath11k_base *ab, int userpd_id)
>  
>  		ab_ahb->userpd_id = userpd_id;
>  		break;
> +	case ATH11K_HW_QCN6122_HW10:
> +		if (userpd_id != ATH11K_AHB_USERPD_ID_2 &&
> +		    userpd_id != ATH11K_AHB_USERPD_ID_3)
> +			return -EINVAL;

[Severity: Medium]
This correctly returns an error for invalid IDs, but it uses -EINVAL, which
overlaps with the error code returned for missing properties.

In ath11k_ahb_configure_rproc(), the -EINVAL returned by this function
(via ath11k_ahb_config_userpd_irq()) is explicitly masked:

ath11k_ahb_configure_rproc() {
...
	ret = ath11k_ahb_config_userpd_irq(ab);
	if (ret && ret != -EINVAL && ret != -ENXIO)
		return dev_err_probe(&ab->pdev->dev, ret,
				     "failed to configure userpd interrupts\n");

	return 0;
...
}

Does this cause a misconfigured Device Tree specifying an invalid userpd_id
for QCN6122 to silently fail and report a successful probe, while leaving the
device uninitialized?

> +
> +		ab_ahb->userpd_id = userpd_id;
> +		ab->qmi.service_ins_id += (ab_ahb->userpd_id - 1);
> +		break;
>  	default:
>  		return -EINVAL;
>  	}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260923-ipq5018-qcn6122-mpd-v1-0-86729521a75c@outlook.com?part=15