Re: [PATCH v1 02/11] dt-bindings: net: micrel: Fix RMII clock select property type

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] net: phy: micrel: of_property_read_bool() triggers warning when reading enum value
--

commit cad5067d21d36b9ce88edbe220886c31a7f2803b
Author: Stefano Radaelli <stefano.r@variscite.com>

dt-bindings: net: micrel: Fix RMII clock select property type

This commit modifies the micrel,rmii-reference-clock-select-25-mhz device
tree property from a boolean to an enum containing an integer value. This
change satisfies dt-schema requirements for properties ending in -mhz.

> diff --git a/Documentation/devicetree/bindings/net/micrel.yaml b/Documentation/devicetree/bindings/net/micrel.yaml
> index 6fa568057b927..a1f876dc00de2 100644
> --- a/Documentation/devicetree/bindings/net/micrel.yaml
> +++ b/Documentation/devicetree/bindings/net/micrel.yaml
> @@ -63,6 +63,14 @@ properties:
>      minimum: 0
>      maximum: 3
>  
> +  micrel,rmii-reference-clock-select-25-mhz:
> +    enum: [ 1 ]

[Severity: Medium]
Will changing this property to require an integer value cause the driver
to emit kernel warnings during probe?

The micrel driver currently parses this property using:

drivers/net/phy/micrel.c:kszphy_probe() {
        ...
        rmii_ref_clk_sel_25_mhz = of_property_read_bool(np,
                                "micrel,rmii-reference-clock-select-25-mhz");
        ...
}

Because of_property_read_bool() explicitly checks if a boolean property has
a payload and triggers a pr_warn() if it does, updating device trees to 
use "= <1>;" based on this binding will cause a warning to be emitted on
every probe.

Does the driver code also need to be updated to parse this property as an 
integer instead of a boolean to prevent these warnings?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1790344389.git.stefano.r@variscite.com?part=2