Re: [PATCH v1 06/11] ARM: dts: imx6ul: Add Variscite carrier board files

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 4 potential issue(s) to consider:
- [High] fec1 Ethernet broken on i.MX6ULZ due to shared MDIO bus disabled with fec2
- [Medium] extcon SNVS pin configured in main IOMUXC on i.MX6ULL/ULZ Symphony boards
- [Low] SD card fixed regulator defined but not assigned via vmmc-supply
- [Low] Backlight disablement override fails on i.MX6ULZ Concerto due to node name mismatch
--

commit 4d8151d793ce057a2bcfb49c31175fc33cfe60f1
Author: Stefano Radaelli <stefano.r@variscite.com>

ARM: dts: imx6ul: Add Variscite carrier board files

Add DTSI files for the Concerto-Board, Symphony-Board and VAR-6ULCustomBoard
carriers used with VAR-SOM-6UL and DART-6UL. This shares common carrier wiring
across the SoC variants and keeps SoC-specific connections in separate wrapper
files.

> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ul-imx6ull-var-dart-6ulcustomboard-sd-card.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ul-imx6ull-var-dart-6ulcustomboard-sd-card.dtsi
> new file mode 100644
> index 0000000000000..f6cec58f5a4e4
> --- /dev/null
> +++ b/arch/arm/boot/dts/nxp/imx/imx6ul-imx6ull-var-dart-6ulcustomboard-sd-card.dtsi
[ ... ]
> +/ {
> +	reg_sd1_vmmc: regulator-sd1-vmmc {
> +		compatible = "regulator-fixed";
> +		regulator-name = "VSD_3V3";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +	};
> +};
> +
> +&usdhc1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_usdhc1>, <&pinctrl_usdhc1_gpio>;
> +	cd-gpios = <&gpio4 19 GPIO_ACTIVE_LOW>;
> +	no-1-8-v;
> +	keep-power-in-suspend;
> +	wakeup-source;
> +	status = "okay";
> +};

[Severity: Low]
Does this node miss a vmmc-supply property referencing the reg_sd1_vmmc
regulator defined above? Without it, the MMC controller is unaware of the
voltage constraints.

> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ul-imx6ull-var-som-concerto-board-sd-card.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ul-imx6ull-var-som-concerto-board-sd-card.dtsi
> new file mode 100644
> index 0000000000000..a6a3f417ca5e6
> --- /dev/null
> +++ b/arch/arm/boot/dts/nxp/imx/imx6ul-imx6ull-var-som-concerto-board-sd-card.dtsi
[ ... ]
> +/ {
> +	reg_sd1_vmmc: regulator-sd1-vmmc {
> +		compatible = "regulator-fixed";
> +		regulator-name = "VSD_3V3";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +	};
> +};
> +
> +&usdhc1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_usdhc1>, <&pinctrl_usdhc1_gpio>;
> +	cd-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>;
> +	no-1-8-v;
> +	keep-power-in-suspend;
> +	wakeup-source;
> +	status = "okay";
> +};

[Severity: Low]
Is this usdhc1 node also missing the vmmc-supply property to utilize the
reg_sd1_vmmc regulator?

> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ul-imx6ull-var-som-symphony-board.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ul-imx6ull-var-som-symphony-board.dtsi
> new file mode 100644
> index 0000000000000..070011d37205f
> --- /dev/null
> +++ b/arch/arm/boot/dts/nxp/imx/imx6ul-imx6ull-var-som-symphony-board.dtsi
[ ... ]
> +	pinctrl_extcon: extcon-grp {
> +		fsl,pins = <
> +			MX6UL_PAD_SNVS_TAMPER3__GPIO5_IO03		0x1b0b0
> +		>;
> +	};

[Severity: Medium]
Will this SNVS pinmux group inadvertently write to the main IOMUXC controller
instead of the iomuxc_snvs controller on i.MX6ULL/ULZ Symphony boards? Since
it is placed in the common &iomuxc node, it could leave the SNVS TAMPER3 pin
unconfigured and break Type-C extcon interrupts.

> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ulz-var-dart-6ulcustomboard.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ulz-var-dart-6ulcustomboard.dtsi
> new file mode 100644
> index 0000000000000..a421888663a51
> --- /dev/null
> +++ b/arch/arm/boot/dts/nxp/imx/imx6ulz-var-dart-6ulcustomboard.dtsi
[ ... ]
> +&fec2 {
> +	status = "disabled";
> +};

[Severity: High]
Does disabling the fec2 interface here also disable its child mdio bus? If so,
could this prevent fec1 from probing properly on the i.MX6ULZ DART board since
its ethphy0 relies on that mdio bus?

> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ulz-var-som-concerto-board.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ulz-var-som-concerto-board.dtsi
> new file mode 100644
> index 0000000000000..377715fb4d78e
> --- /dev/null
> +++ b/arch/arm/boot/dts/nxp/imx/imx6ulz-var-som-concerto-board.dtsi
> @@ -0,0 +1,44 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2026 Variscite Ltd. - https://www.variscite.com
> + */
> +
> +#include "imx6ul-imx6ull-var-som-concerto-board.dtsi"
> +
> +/ {
> +	backlight {
> +		status = "disabled";
> +	};
> +};

[Severity: Low]
Will this override fail to disable the backlight because the original node in
imx6ul-imx6ull-var-som-concerto-board.dtsi is named "lcd-backlight"? It appears
this creates an empty unused "backlight" node while leaving the PWM backlight
enabled.

> +
> +&can1 {
> +	status = "disabled";
> +};
> +
> +&fec2 {
> +	status = "disabled";
> +};

[Severity: High]
Does disabling fec2 here break the fec1 Ethernet interface on the i.MX6ULZ
Concerto board by also disabling the shared mdio bus that hosts ethphy0?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1790344389.git.stefano.r@variscite.com?part=6