Re: [PATCH v1 10/11] ARM: dts: imx6ulz: Add Variscite i.MX6ULZ board variants

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt: missing vmmc-supply assignment for SD card regulator
--

commit c035a6871fb70fa19b07a2597c2770e8e0afc0e1
Author: Stefano Radaelli <stefano.r@variscite.com>

ARM: dts: imx6ulz: Add Variscite i.MX6ULZ board variants

Add i.MX6ULZ board DTS files for VAR-SOM-6UL and DART-6UL with their
carrier, storage, wireless and audio options.

Reuse the shared option and carrier descriptions with the i.MX6ULZ
SoC and module wrappers.

> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ulz-var-dart-emmc-sd-card-6ulcustomboard.dts b/arch/arm/boot/dts/nxp/imx/imx6ulz-var-dart-emmc-sd-card-6ulcustomboard.dts
> new file mode 100644
> index 0000000000000..35b62a4fc7f53
> --- /dev/null
> +++ b/arch/arm/boot/dts/nxp/imx/imx6ulz-var-dart-emmc-sd-card-6ulcustomboard.dts
[ ... ]
> @@ -0,0 +1,21 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2026 Variscite Ltd. - https://www.variscite.com
> + */
> +
> +/dts-v1/;
> +
> +#include "imx6ulz.dtsi"
> +#include "imx6ulz-var-dart.dtsi"
> +#include "imx6ul-imx6ull-var-dart-emmc.dtsi"
> +#include "imx6ul-imx6ull-var-dart-wm8904.dtsi"
> +#include "imx6ulz-var-dart-6ulcustomboard.dtsi"
> +#include "imx6ul-imx6ull-var-dart-6ulcustomboard-sd-card.dtsi"

[Severity: Low]
Does this board variant also need a vmmc-supply assignment for the SD card
regulator?

In the included imx6ul-imx6ull-var-dart-6ulcustomboard-sd-card.dtsi file, the
&usdhc1 definition lacks the vmmc-supply = <&reg_sd1_vmmc>; property:

&usdhc1 {
	pinctrl-names = "default";
	pinctrl-0 = <&pinctrl_usdhc1>, <&pinctrl_usdhc1_gpio>;
	cd-gpios = <&gpio4 19 GPIO_ACTIVE_LOW>;
	no-1-8-v;
	keep-power-in-suspend;
	wakeup-source;
	status = "okay";
};

The reg_sd1_vmmc fixed regulator is explicitly defined to power the SD card,
but because it is never assigned to the usdhc1 controller via vmmc-supply,
it is left orphaned and unused by the MMC subsystem.

Could this assignment be missing from the shared .dtsi file, or should it be
overridden here in the new board .dts files?

> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ulz-var-som-emmc-sd-card-concerto-board.dts b/arch/arm/boot/dts/nxp/imx/imx6ulz-var-som-emmc-sd-card-concerto-board.dts
> new file mode 100644
> index 0000000000000..ac0c2657e6564
> --- /dev/null
> +++ b/arch/arm/boot/dts/nxp/imx/imx6ulz-var-som-emmc-sd-card-concerto-board.dts
[ ... ]
> @@ -0,0 +1,21 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2026 Variscite Ltd. - https://www.variscite.com
> + */
> +
> +/dts-v1/;
> +
> +#include "imx6ulz.dtsi"
> +#include "imx6ulz-var-som.dtsi"
> +#include "imx6ul-imx6ull-var-som-emmc.dtsi"
> +#include "imx6ul-imx6ull-var-som-wm8904.dtsi"
> +#include "imx6ulz-var-som-concerto-board.dtsi"
> +#include "imx6ul-imx6ull-var-som-concerto-board-sd-card.dtsi"

[Severity: Low]
Similarly, does this board variant also need a vmmc-supply assignment?

The included imx6ul-imx6ull-var-som-concerto-board-sd-card.dtsi file also
leaves the reg_sd1_vmmc regulator orphaned for the &usdhc1 controller.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1790344389.git.stefano.r@variscite.com?part=10