Re: [PATCH v9 07/11] arm64: dts: renesas: rzg2l(c)/rzv2l hb-iiot: add dsi panel dt overlay

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: workaround for driver bug via incorrect GPIO polarity
--

commit 6728207701dcae1710f79cd19dde291399712ed9
Author: Josua Mayer <josua@solid-run.com>

arm64: dts: renesas: rzg2l(c)/rzv2l hb-iiot: add dsi panel dt overlay

This commit adds a device tree overlay for the Winstar WJ70N3TYJHMNG0 1024x600
DSI panel used on the SolidRun HummingBoard IIoT. The overlay is enabled in the
build system for multiple RZ SoMs.

> diff --git a/arch/arm64/boot/dts/renesas/rzg2l-hummingboard-iiot-panel-dsi-WJ70N3TYJHMNG0.dtso b/arch/arm64/boot/dts/renesas/rzg2l-hummingboard-iiot-panel-dsi-WJ70N3TYJHMNG0.dtso
> new file mode 100644
> index 0000000000000..f8584c473fafe
> --- /dev/null
> +++ b/arch/arm64/boot/dts/renesas/rzg2l-hummingboard-iiot-panel-dsi-WJ70N3TYJHMNG0.dtso
[ ... ]
> +&dsi {
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +	status = "okay";
> +
> +	panel@0 {
> +		/* This is a Winstar panel, but the ronbo panel uses same controls. */
> +		compatible = "ronbo,rb070d30";
> +		reg = <0>;
> +		/* reset is active-low but driver inverts it internally */
> +		reset-gpios = <&tca6408_u48 1 GPIO_ACTIVE_HIGH>;

[Severity: Low]
Does this overlay rely on a workaround for a driver bug by specifying an
incorrect GPIO polarity?

The comment explicitly notes that the physical hardware reset is active-low,
but it is described as active-high (GPIO_ACTIVE_HIGH) here in panel@0. Device
trees should accurately describe the physical hardware rather than software
configurations or driver bugs.

If the underlying ronbo,rb070d30 driver is eventually fixed to handle
standard gpiod semantics correctly, won't this hardcoded polarity break the
overlay?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260928-rzg2-sr-boards-v9-0-5901e0fc9e44@solid-run.com?part=7