Re: [PATCH v9 08/11] arm64: dts: renesas: add support for solidrun hb-ripple with rzg2l som

[Josua Mayer <josua@solid-run.com>]

Am 28.09.26 um 16:51 schrieb sashiko-bot@kernel.org:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] dts: redundant duplicate include of hdmi dtsi
> --
>
> commit 242378324c377114192c5cacd4bed84adbf80882
> Author: Josua Mayer <josua@solid-run.com>
>
> arm64: dts: renesas: add support for solidrun hb-ripple with rzg2l som
>
> This commit adds support for the SolidRun HummingBoard Ripple board with
> the RZ/G2L SoM. It creates new device tree configurations and extracts
> common components like micro-HDMI into shared include files.
>
>> diff --git a/arch/arm64/boot/dts/renesas/r9a07g044l2-hummingboard-ripple.dts b/arch/arm64/boot/dts/renesas/r9a07g044l2-hummingboard-ripple.dts
>> new file mode 100644
>> index 0000000000000..493a2b9b51d25
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/renesas/r9a07g044l2-hummingboard-ripple.dts
>> @@ -0,0 +1,17 @@
>> +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +/*
>> + * Copyright 2025 Josua Mayer <josua@solid-run.com>
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include "r9a07g044l2.dtsi"
>> +#include "rzg2l-sr-som.dtsi"
>> +#include "rzg2l-hummingboard-ripple.dtsi"
>> +#include "rzg2l-hummingboard-pulse-micro-hdmi.dtsi"
> [Severity: Low]
> Is this include of rzg2l-hummingboard-pulse-micro-hdmi.dtsi redundant?
>
> It looks like this hdmi dtsi is already included by
> rzg2l-hummingboard-ripple.dtsi, which is included just one line above.
> This results in the device tree compiler parsing the same hdmi nodes
> twice when compiling r9a07g044l2-hummingboard-ripple.dts.
>
> [ ... ]
>
>> diff --git a/arch/arm64/boot/dts/renesas/rzg2l-hummingboard-ripple.dtsi b/arch/arm64/boot/dts/renesas/rzg2l-hummingboard-ripple.dtsi
>> new file mode 100644
>> index 0000000000000..d5bd9b7de4282
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/renesas/rzg2l-hummingboard-ripple.dtsi
>> @@ -0,0 +1,125 @@
>> +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +/*
>> + * Copyright 2025 Josua Mayer <josua@solid-run.com>
>> + */
>> +
>> +#include "rzg2l-hummingboard-pulse-common.dtsi"
>> +#include "rzg2l-hummingboard-pulse-micro-hdmi.dtsi"
> [Severity: Low]
> Here is the other inclusion inside rzg2l-hummingboard-ripple.dtsi. Would
> it make sense to drop the duplicate include from the top-level dts file
> to keep the includes organized?
>
So I added a regression :(
sorry about that, v9 is not ready to be merged.

I will drop the duplicate include for v10.