From: Mayuresh Chitale <mayuresh.chitale@oss.qualcomm.com>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <pjw@kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Ian Rogers <irogers@google.com>
Cc: Anup Patel <anup.patel@oss.qualcomm.com>,
Alexandre Ghiti <alex@ghiti.fr>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Mayuresh Chitale <mchitale@gmail.com>,
Anup Patel <anup@brainfault.org>,
Atish Patra <atish.patra@linux.dev>,
Andrew Jones <andrew.jones@oss.qualcomm.com>,
Sunil V L <sunilvl@oss.qualcomm.com>,
linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mayuresh Chitale <mayuresh.chitale@oss.qualcomm.com>,
Zane Leung <liangzhen@linux.spacemit.com>
Subject: [PATCH v6 04/14] gtrace: Add functions to create/destroy a trace component path
Date: Thu, 1 Oct 2026 10:52:15 +0530 [thread overview]
Message-ID: <20261001052243.3042627-5-mayuresh.chitale@oss.qualcomm.com> (raw)
In-Reply-To: <20261001052243.3042627-1-mayuresh.chitale@oss.qualcomm.com>
From: Anup Patel <anup.patel@oss.qualcomm.com>
Trace needs to be configured on a chain of trace components which are
connected to each other. These chain of components is also referred
to as trace component path. Add functions to create/destroy a trace
component path which will be later used by gtrace perf support.
Signed-off-by: Anup Patel <anup.patel@oss.qualcomm.com>
Co-developed-by: Mayuresh Chitale <mayuresh.chitale@oss.qualcomm.com>
Signed-off-by: Mayuresh Chitale <mayuresh.chitale@oss.qualcomm.com>
---
drivers/hwtracing/gtrace/gtrace-core.c | 241 +++++++++++++++++++++++++
include/linux/gtrace.h | 24 +++
2 files changed, 265 insertions(+)
diff --git a/drivers/hwtracing/gtrace/gtrace-core.c b/drivers/hwtracing/gtrace/gtrace-core.c
index d374c679a649..f750025104ec 100644
--- a/drivers/hwtracing/gtrace/gtrace-core.c
+++ b/drivers/hwtracing/gtrace/gtrace-core.c
@@ -26,6 +26,7 @@ struct gtrace_comp_priv {
struct gtrace_component comp;
u32 type_idx;
bool ready;
+ bool visited;
};
#define to_gtrace_comp_priv(__comp) \
@@ -224,6 +225,62 @@ int gtrace_reset_component(struct gtrace_component *comp)
}
EXPORT_SYMBOL_GPL(gtrace_reset_component);
+static int __gtrace_walk_output_components(struct gtrace_component *comp,
+ bool *stop, void *priv,
+ int (*fn)(struct gtrace_component *comp, bool *stop,
+ struct gtrace_connection *stop_conn,
+ void *priv))
+{
+ struct gtrace_comp_priv *cpriv = to_gtrace_comp_priv(comp);
+ struct gtrace_connection *conn, *stop_conn = NULL;
+ struct gtrace_platform_data *pdata = comp->pdata;
+ int i, ret;
+
+ if (cpriv->visited) {
+ dev_err(&comp->dev, "loop detected, please fix the firmware\n");
+ return -ELOOP;
+ }
+ cpriv->visited = true;
+
+ for (i = 0; i < pdata->nr_outconns; i++) {
+ conn = pdata->outconns[i];
+ ret = __gtrace_walk_output_components(conn->dest_comp, stop, priv, fn);
+ if (ret) {
+ cpriv->visited = false;
+ return ret;
+ }
+
+ if (*stop) {
+ stop_conn = conn;
+ break;
+ }
+ }
+
+ ret = fn(comp, stop, stop_conn, priv);
+ cpriv->visited = false;
+
+ return ret;
+}
+
+int gtrace_walk_output_components(struct gtrace_component *comp, void *priv,
+ int (*fn)(struct gtrace_component *comp, bool *stop,
+ struct gtrace_connection *stop_conn,
+ void *priv))
+{
+ bool stop = false;
+ int ret;
+
+ if (!comp || !fn)
+ return -EINVAL;
+
+ mutex_lock(>race_mutex);
+ ret = __gtrace_walk_output_components(comp, &stop, priv, fn);
+ mutex_unlock(>race_mutex);
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(gtrace_walk_output_components);
+
struct gtrace_component *gtrace_cpu_source(unsigned int cpu)
{
if (!cpu_present(cpu))
@@ -431,6 +488,190 @@ void gtrace_unregister_component(struct gtrace_component *comp)
}
EXPORT_SYMBOL_GPL(gtrace_unregister_component);
+struct gtrace_path_node {
+ struct list_head head;
+ struct gtrace_component *comp;
+ struct gtrace_connection *conn;
+};
+
+struct gtrace_component *gtrace_path_source(struct gtrace_path *path)
+{
+ struct gtrace_path_node *node;
+
+ node = list_first_entry(&path->comp_list, struct gtrace_path_node, head);
+ return node->comp;
+}
+EXPORT_SYMBOL_GPL(gtrace_path_source);
+
+struct gtrace_component *gtrace_path_sink(struct gtrace_path *path)
+{
+ struct gtrace_path_node *node;
+
+ node = list_last_entry(&path->comp_list, struct gtrace_path_node, head);
+ return node->comp;
+}
+EXPORT_SYMBOL_GPL(gtrace_path_sink);
+
+static int gtrace_assign_trace_id(struct gtrace_path *path)
+{
+ const struct gtrace_driver *gtdrv;
+ struct gtrace_component *comp;
+ struct gtrace_path_node *node;
+ int trace_id;
+
+ list_for_each_entry(node, &path->comp_list, head) {
+ comp = node->comp;
+ gtdrv = to_gtrace_driver(comp->dev.driver);
+
+ if (!gtdrv || !gtdrv->get_trace_id)
+ continue;
+
+ trace_id = gtdrv->get_trace_id(comp, path->mode);
+ if (trace_id > 0) {
+ path->trace_id = trace_id;
+ return 0;
+ } else if (trace_id < 0) {
+ return trace_id;
+ }
+ }
+
+ return 0;
+}
+
+static void gtrace_unassign_trace_id(struct gtrace_path *path)
+{
+ const struct gtrace_driver *gtdrv;
+ struct gtrace_component *comp;
+ struct gtrace_path_node *node;
+
+ list_for_each_entry(node, &path->comp_list, head) {
+ comp = node->comp;
+ gtdrv = to_gtrace_driver(comp->dev.driver);
+
+ if (!gtdrv || !gtdrv->put_trace_id)
+ continue;
+
+ gtdrv->put_trace_id(comp, path->mode, path->trace_id);
+ }
+}
+
+static bool gtrace_path_ready(struct gtrace_path *path)
+{
+ struct gtrace_comp_priv *cpriv;
+ struct gtrace_path_node *node;
+
+ list_for_each_entry(node, &path->comp_list, head) {
+ cpriv = to_gtrace_comp_priv(node->comp);
+ if (!cpriv->ready)
+ return false;
+ }
+
+ return true;
+}
+
+struct build_path_walk_priv {
+ struct gtrace_path *path;
+ struct gtrace_component *sink;
+};
+
+static int build_path_walk_fn(struct gtrace_component *comp, bool *stop,
+ struct gtrace_connection *stop_conn,
+ void *priv)
+{
+ struct build_path_walk_priv *ppriv = priv;
+ struct gtrace_path *path = ppriv->path;
+ struct gtrace_path_node *node;
+
+ if ((!ppriv->sink && gtrace_is_sink(comp->pdata)) ||
+ (ppriv->sink && ppriv->sink == comp))
+ *stop = true;
+
+ if (*stop) {
+ node = kzalloc_obj(*node);
+ if (!node)
+ return -ENOMEM;
+ INIT_LIST_HEAD(&node->head);
+ gtrace_get_component(comp);
+ node->comp = comp;
+ node->conn = stop_conn;
+ list_add(&node->head, &path->comp_list);
+ }
+
+ return 0;
+}
+
+static void gtrace_release_path_nodes(struct gtrace_path *path)
+{
+ struct gtrace_path_node *node, *node1;
+
+ list_for_each_entry_safe(node, node1, &path->comp_list, head) {
+ list_del(&node->head);
+ gtrace_put_component(node->comp);
+ kfree(node);
+ }
+}
+
+struct gtrace_path *gtrace_create_path(struct gtrace_component *source,
+ struct gtrace_component *sink,
+ enum gtrace_component_mode mode)
+{
+ struct build_path_walk_priv priv;
+ struct gtrace_path *path;
+ int ret = 0;
+
+ if (!source || mode >= GTRACE_COMPONENT_MODE_MAX) {
+ ret = -EINVAL;
+ goto err_out;
+ }
+
+ path = kzalloc(sizeof(*path), GFP_KERNEL);
+ if (!path) {
+ ret = -ENOMEM;
+ goto err_out;
+ }
+ INIT_LIST_HEAD(&path->comp_list);
+ path->mode = mode;
+ path->trace_id = GTRACE_INVALID_TRACE_ID;
+
+ priv.path = path;
+ priv.sink = sink;
+ ret = gtrace_walk_output_components(source, &priv, build_path_walk_fn);
+ if (ret < 0)
+ goto err_release_path_nodes;
+
+ /* Before proceeding, check that a valid path was built. */
+ if (list_empty(&path->comp_list)) {
+ ret = -ENODEV;
+ goto err_release_path_nodes;
+ }
+
+ if (!gtrace_path_ready(path)) {
+ ret = -EOPNOTSUPP;
+ goto err_release_path_nodes;
+ }
+
+ ret = gtrace_assign_trace_id(path);
+ if (ret < 0)
+ goto err_release_path_nodes;
+
+ return path;
+
+err_release_path_nodes:
+ gtrace_release_path_nodes(path);
+ kfree(path);
+err_out:
+ return ERR_PTR(ret);
+}
+EXPORT_SYMBOL_GPL(gtrace_create_path);
+
+void gtrace_destroy_path(struct gtrace_path *path)
+{
+ gtrace_unassign_trace_id(path);
+ gtrace_release_path_nodes(path);
+ kfree(path);
+}
+EXPORT_SYMBOL_GPL(gtrace_destroy_path);
+
int __gtrace_register_driver(struct module *owner, struct gtrace_driver *gtdrv)
{
gtdrv->driver.owner = owner;
diff --git a/include/linux/gtrace.h b/include/linux/gtrace.h
index 5368dca0e936..2c3be4d161c6 100644
--- a/include/linux/gtrace.h
+++ b/include/linux/gtrace.h
@@ -229,6 +229,10 @@ int gtrace_enable_component(struct gtrace_component *comp);
int gtrace_disable_component(struct gtrace_component *comp);
int gtrace_reset_component(struct gtrace_component *comp);
+int gtrace_walk_output_components(struct gtrace_component *comp, void *priv,
+ int (*fn)(struct gtrace_component *comp, bool *stop,
+ struct gtrace_connection *stop_conn,
+ void *priv));
struct gtrace_component *gtrace_cpu_source(unsigned int cpu);
struct gtrace_component *gtrace_register_component(struct gtrace_component_id *id,
@@ -239,6 +243,26 @@ void gtrace_unregister_component(struct gtrace_component *comp);
int gtrace_of_parse_outconns(struct gtrace_platform_data *pdata);
int gtrace_of_parse_inconns(struct gtrace_platform_data *pdata);
+/**
+ * struct gtrace_path - Representation of a trace path from source to sink.
+ * @comp_list: List of trace components in the path.
+ * @mode: Usage mode for trace components.
+ * @trace_id: ID of the trace source (typically hart/CPU id).
+ */
+struct gtrace_path {
+ struct list_head comp_list;
+ enum gtrace_component_mode mode;
+ u32 trace_id;
+#define GTRACE_INVALID_TRACE_ID 0
+};
+
+struct gtrace_component *gtrace_path_source(struct gtrace_path *path);
+struct gtrace_component *gtrace_path_sink(struct gtrace_path *path);
+struct gtrace_path *gtrace_create_path(struct gtrace_component *source,
+ struct gtrace_component *sink,
+ enum gtrace_component_mode mode);
+void gtrace_destroy_path(struct gtrace_path *path);
+
/**
* struct gtrace_driver - Representation of a trace driver.
* @id_table: Table to match components handled by the driver.
--
2.43.0
next prev parent reply other threads:[~2026-10-01 5:23 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 5:22 [PATCH v6 00/14] Linux RISC-V trace framework and drivers Mayuresh Chitale
2026-10-01 5:22 ` [PATCH v6 01/14] dt-bindings: Add RISC-V trace component bindings Mayuresh Chitale
2026-10-01 5:33 ` sashiko-bot
2026-10-01 5:22 ` [PATCH v6 02/14] hwtracing: gtrace: Initial implementation of gtrace framework Mayuresh Chitale
2026-10-01 5:37 ` sashiko-bot
2026-10-01 5:22 ` [PATCH v6 03/14] gtrace: Add RISC-V platform driver for the " Mayuresh Chitale
2026-10-01 5:36 ` sashiko-bot
2026-10-01 5:22 ` Mayuresh Chitale [this message]
2026-10-01 5:36 ` [PATCH v6 04/14] gtrace: Add functions to create/destroy a trace component path sashiko-bot
2026-10-01 5:22 ` [PATCH v6 05/14] gtrace: Add functions to start/stop tracing on a " Mayuresh Chitale
2026-10-01 5:36 ` sashiko-bot
2026-10-01 5:22 ` [PATCH v6 06/14] gtrace: Add RISC-V Trace encoder driver Mayuresh Chitale
2026-10-01 5:34 ` sashiko-bot
2026-10-01 5:22 ` [PATCH v6 07/14] gtrace: Add function to copy into perf AUX buffer Mayuresh Chitale
2026-10-01 5:40 ` sashiko-bot
2026-10-01 5:22 ` [PATCH v6 08/14] perf: Add gtrace AUX buffer trace format type Mayuresh Chitale
2026-10-01 5:22 ` [PATCH v6 09/14] gtrace: Add RISC-V Trace ramsink driver Mayuresh Chitale
2026-10-01 5:42 ` sashiko-bot
2026-10-01 5:22 ` [PATCH v6 10/14] riscv: Enable DMA_RESTRICTED_POOL in defconfig Mayuresh Chitale
2026-10-01 5:22 ` [PATCH v6 11/14] gtrace: Add perf driver for tracing using perf tool Mayuresh Chitale
2026-10-01 5:44 ` sashiko-bot
2026-10-01 5:22 ` [PATCH v6 12/14] perf tools: Add RISC-V trace PMU record capabilities Mayuresh Chitale
2026-10-01 5:22 ` [PATCH v6 13/14] perf tools: Initial support for gtrace decoder Mayuresh Chitale
2026-10-01 5:35 ` sashiko-bot
2026-10-01 5:22 ` [PATCH v6 14/14] MAINTAINERS: Add entry for RISC-V trace framework Mayuresh Chitale
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261001052243.3042627-5-mayuresh.chitale@oss.qualcomm.com \
--to=mayuresh.chitale@oss.qualcomm.com \
--cc=adrian.hunter@intel.com \
--cc=alex@ghiti.fr \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrew.jones@oss.qualcomm.com \
--cc=anup.patel@oss.qualcomm.com \
--cc=anup@brainfault.org \
--cc=atish.patra@linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=liangzhen@linux.spacemit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mchitale@gmail.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=palmer@dabbelt.com \
--cc=peterz@infradead.org \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
--cc=sunilvl@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox