From: Mayuresh Chitale <mayuresh.chitale@oss.qualcomm.com>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <pjw@kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Ian Rogers <irogers@google.com>
Cc: Mayuresh Chitale <mayuresh.chitale@oss.qualcomm.com>,
Alexandre Ghiti <alex@ghiti.fr>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Mayuresh Chitale <mchitale@gmail.com>,
Anup Patel <anup@brainfault.org>,
Atish Patra <atish.patra@linux.dev>,
Andrew Jones <andrew.jones@oss.qualcomm.com>,
Sunil V L <sunilvl@oss.qualcomm.com>,
linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Anup Patel <anup.patel@oss.qualcomm.com>,
Zane Leung <liangzhen@linux.spacemit.com>
Subject: [PATCH v6 05/14] gtrace: Add functions to start/stop tracing on a component path
Date: Thu, 1 Oct 2026 10:52:16 +0530 [thread overview]
Message-ID: <20261001052243.3042627-6-mayuresh.chitale@oss.qualcomm.com> (raw)
In-Reply-To: <20261001052243.3042627-1-mayuresh.chitale@oss.qualcomm.com>
The perf driver framework needs to be able to start / stop all components
in a trace component path during its operation. Add gtrace_path_start()
and gtrace_path_stop() functions for this purpose.
Co-developed-by: Anup Patel <anup.patel@oss.qualcomm.com>
Signed-off-by: Anup Patel <anup.patel@oss.qualcomm.com>
Signed-off-by: Mayuresh Chitale <mayuresh.chitale@oss.qualcomm.com>
---
drivers/hwtracing/gtrace/gtrace-core.c | 104 +++++++++++++++++++++++++
include/linux/gtrace.h | 7 ++
2 files changed, 111 insertions(+)
diff --git a/drivers/hwtracing/gtrace/gtrace-core.c b/drivers/hwtracing/gtrace/gtrace-core.c
index f750025104ec..d7f1df90aa31 100644
--- a/drivers/hwtracing/gtrace/gtrace-core.c
+++ b/drivers/hwtracing/gtrace/gtrace-core.c
@@ -10,6 +10,7 @@
#include <linux/module.h>
#include <linux/mutex.h>
#include <linux/percpu.h>
+#include <linux/spinlock.h>
#include <linux/xarray.h>
#include <linux/gtrace.h>
@@ -24,7 +25,15 @@ static DEFINE_PER_CPU(struct gtrace_component *, gtrace_cpu_source_comp);
/* gtrace comp specific data, to be used by core functions only */
struct gtrace_comp_priv {
struct gtrace_component comp;
+ /*
+ * Protects start_count and owner. Serializes start/stop against other paths
+ * sharing this component and, for a sink, against gtrace_path_copyto_auxbuf().
+ * Raw because the PMU start/stop callbacks are called with the rq_lock held.
+ */
+ raw_spinlock_t lock;
u32 type_idx;
+ u32 start_count;
+ pid_t owner;
bool ready;
bool visited;
};
@@ -418,6 +427,7 @@ struct gtrace_component *gtrace_register_component(struct gtrace_component_id *i
ret = -ENOMEM;
goto err_out;
}
+ raw_spin_lock_init(&cpriv->lock);
comp = &cpriv->comp;
comp->pdata = pdata;
comp->id = *id;
@@ -611,6 +621,100 @@ static void gtrace_release_path_nodes(struct gtrace_path *path)
}
}
+static int __gtrace_comp_start(struct gtrace_component *comp, pid_t owner)
+{
+ struct gtrace_comp_priv *cpriv = to_gtrace_comp_priv(comp);
+ const struct gtrace_driver *gtdrv = to_gtrace_driver(comp->dev.driver);
+ unsigned long flags;
+ int ret = 0;
+
+ if (!gtdrv)
+ return -ENODEV;
+
+ raw_spin_lock_irqsave(&cpriv->lock, flags);
+ if (cpriv->start_count) {
+ if (cpriv->owner != owner) {
+ ret = -EBUSY;
+ goto out;
+ }
+ } else {
+ if (gtdrv->start) {
+ ret = gtdrv->start(comp);
+ if (ret)
+ goto out;
+ }
+ cpriv->owner = owner;
+ }
+
+ cpriv->start_count++;
+out:
+ raw_spin_unlock_irqrestore(&cpriv->lock, flags);
+ return ret;
+}
+
+static int __gtrace_comp_stop(struct gtrace_component *comp)
+{
+ struct gtrace_comp_priv *cpriv = to_gtrace_comp_priv(comp);
+ const struct gtrace_driver *gtdrv = to_gtrace_driver(comp->dev.driver);
+ unsigned long flags;
+ int ret = 0;
+
+ raw_spin_lock_irqsave(&cpriv->lock, flags);
+ if (!cpriv->start_count) {
+ ret = -EINVAL;
+ goto out;
+ }
+
+ cpriv->start_count--;
+ if (!cpriv->start_count) {
+ if (!gtdrv) {
+ ret = -ENODEV;
+ goto out;
+ }
+
+ if (gtdrv->stop)
+ ret = gtdrv->stop(comp);
+ }
+out:
+ raw_spin_unlock_irqrestore(&cpriv->lock, flags);
+ return ret;
+}
+
+int gtrace_path_start(struct gtrace_path *path)
+{
+ struct gtrace_path_node *node;
+ int ret = 0;
+
+ list_for_each_entry_reverse(node, &path->comp_list, head) {
+ ret = __gtrace_comp_start(node->comp, path->owner);
+ if (ret)
+ break;
+ }
+
+ /* If a component failed to start, stop all the components that were started before it */
+ if (ret)
+ list_for_each_entry_continue(node, &path->comp_list, head)
+ __gtrace_comp_stop(node->comp);
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(gtrace_path_start);
+
+int gtrace_path_stop(struct gtrace_path *path)
+{
+ struct gtrace_path_node *node;
+ int ret = 0, err;
+
+ list_for_each_entry(node, &path->comp_list, head) {
+ err = __gtrace_comp_stop(node->comp);
+ if (err && !ret)
+ ret = err;
+ }
+
+ return ret;
+}
+EXPORT_SYMBOL_GPL(gtrace_path_stop);
+
struct gtrace_path *gtrace_create_path(struct gtrace_component *source,
struct gtrace_component *sink,
enum gtrace_component_mode mode)
diff --git a/include/linux/gtrace.h b/include/linux/gtrace.h
index 2c3be4d161c6..a4b99c87d250 100644
--- a/include/linux/gtrace.h
+++ b/include/linux/gtrace.h
@@ -254,6 +254,7 @@ struct gtrace_path {
enum gtrace_component_mode mode;
u32 trace_id;
#define GTRACE_INVALID_TRACE_ID 0
+ pid_t owner;
};
struct gtrace_component *gtrace_path_source(struct gtrace_path *path);
@@ -262,10 +263,14 @@ struct gtrace_path *gtrace_create_path(struct gtrace_component *source,
struct gtrace_component *sink,
enum gtrace_component_mode mode);
void gtrace_destroy_path(struct gtrace_path *path);
+int gtrace_path_start(struct gtrace_path *path);
+int gtrace_path_stop(struct gtrace_path *path);
/**
* struct gtrace_driver - Representation of a trace driver.
* @id_table: Table to match components handled by the driver.
+ * @start: Callback to start tracing.
+ * @stop: Callback to stop tracing.
* @probe: Driver probe() function.
* @remove: Driver remove() function.
* @get_trace_id: Get/allocate a trace ID.
@@ -274,6 +279,8 @@ void gtrace_destroy_path(struct gtrace_path *path);
*/
struct gtrace_driver {
const struct gtrace_component_id *id_table;
+ int (*start)(struct gtrace_component *comp);
+ int (*stop)(struct gtrace_component *comp);
int (*probe)(struct gtrace_component *comp);
void (*remove)(struct gtrace_component *comp);
int (*get_trace_id)(struct gtrace_component *comp,
--
2.43.0
next prev parent reply other threads:[~2026-10-01 5:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 5:22 [PATCH v6 00/14] Linux RISC-V trace framework and drivers Mayuresh Chitale
2026-10-01 5:22 ` [PATCH v6 01/14] dt-bindings: Add RISC-V trace component bindings Mayuresh Chitale
2026-10-01 5:33 ` sashiko-bot
2026-10-01 5:22 ` [PATCH v6 02/14] hwtracing: gtrace: Initial implementation of gtrace framework Mayuresh Chitale
2026-10-01 5:37 ` sashiko-bot
2026-10-01 5:22 ` [PATCH v6 03/14] gtrace: Add RISC-V platform driver for the " Mayuresh Chitale
2026-10-01 5:36 ` sashiko-bot
2026-10-01 5:22 ` [PATCH v6 04/14] gtrace: Add functions to create/destroy a trace component path Mayuresh Chitale
2026-10-01 5:36 ` sashiko-bot
2026-10-01 5:22 ` Mayuresh Chitale [this message]
2026-10-01 5:36 ` [PATCH v6 05/14] gtrace: Add functions to start/stop tracing on a " sashiko-bot
2026-10-01 5:22 ` [PATCH v6 06/14] gtrace: Add RISC-V Trace encoder driver Mayuresh Chitale
2026-10-01 5:34 ` sashiko-bot
2026-10-01 5:22 ` [PATCH v6 07/14] gtrace: Add function to copy into perf AUX buffer Mayuresh Chitale
2026-10-01 5:40 ` sashiko-bot
2026-10-01 5:22 ` [PATCH v6 08/14] perf: Add gtrace AUX buffer trace format type Mayuresh Chitale
2026-10-01 5:22 ` [PATCH v6 09/14] gtrace: Add RISC-V Trace ramsink driver Mayuresh Chitale
2026-10-01 5:42 ` sashiko-bot
2026-10-01 5:22 ` [PATCH v6 10/14] riscv: Enable DMA_RESTRICTED_POOL in defconfig Mayuresh Chitale
2026-10-01 5:22 ` [PATCH v6 11/14] gtrace: Add perf driver for tracing using perf tool Mayuresh Chitale
2026-10-01 5:44 ` sashiko-bot
2026-10-01 5:22 ` [PATCH v6 12/14] perf tools: Add RISC-V trace PMU record capabilities Mayuresh Chitale
2026-10-01 5:22 ` [PATCH v6 13/14] perf tools: Initial support for gtrace decoder Mayuresh Chitale
2026-10-01 5:35 ` sashiko-bot
2026-10-01 5:22 ` [PATCH v6 14/14] MAINTAINERS: Add entry for RISC-V trace framework Mayuresh Chitale
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261001052243.3042627-6-mayuresh.chitale@oss.qualcomm.com \
--to=mayuresh.chitale@oss.qualcomm.com \
--cc=adrian.hunter@intel.com \
--cc=alex@ghiti.fr \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrew.jones@oss.qualcomm.com \
--cc=anup.patel@oss.qualcomm.com \
--cc=anup@brainfault.org \
--cc=atish.patra@linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=liangzhen@linux.spacemit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mchitale@gmail.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=palmer@dabbelt.com \
--cc=peterz@infradead.org \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
--cc=sunilvl@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox