* [PATCH v2 1/4] clk: qcom: gcc-sm6115: Set HW_CTRL_TRIGGER for video GDSC
2026-05-15 11:59 [PATCH v2 0/4] media: iris: bring up driver on SM6115-based platforms Dmitry Baryshkov
@ 2026-05-15 11:59 ` Dmitry Baryshkov
2026-05-15 12:12 ` Konrad Dybcio
2026-05-15 11:59 ` [PATCH v2 2/4] media: dt-bindings: qcom,qcm2290-venus: add Venus on SM6115 Dmitry Baryshkov
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Dmitry Baryshkov @ 2026-05-15 11:59 UTC (permalink / raw)
To: Bjorn Andersson, Michael Turquette, Stephen Boyd, Vikash Garodia,
Dikshita Agarwal, Bryan O'Donoghue, Mauro Carvalho Chehab,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jorge Ramirez-Ortiz, Konrad Dybcio
Cc: linux-arm-msm, linux-clk, linux-kernel, linux-media, devicetree
The venus video driver will uses dev_pm_genpd_set_hwmode() API to switch
the video GDSC to HW and SW control modes at runtime. This requires domain
to have the HW_CTRL_TRIGGER flag.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
drivers/clk/qcom/gcc-sm6115.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/qcom/gcc-sm6115.c b/drivers/clk/qcom/gcc-sm6115.c
index 4c3804701e24..c5251aff9886 100644
--- a/drivers/clk/qcom/gcc-sm6115.c
+++ b/drivers/clk/qcom/gcc-sm6115.c
@@ -3218,6 +3218,7 @@ static struct gdsc gcc_vcodec0_gdsc = {
.pd = {
.name = "gcc_vcodec0",
},
+ .flags = HW_CTRL_TRIGGER,
.pwrsts = PWRSTS_OFF_ON,
};
--
2.47.3
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v2 1/4] clk: qcom: gcc-sm6115: Set HW_CTRL_TRIGGER for video GDSC
2026-05-15 11:59 ` [PATCH v2 1/4] clk: qcom: gcc-sm6115: Set HW_CTRL_TRIGGER for video GDSC Dmitry Baryshkov
@ 2026-05-15 12:12 ` Konrad Dybcio
0 siblings, 0 replies; 9+ messages in thread
From: Konrad Dybcio @ 2026-05-15 12:12 UTC (permalink / raw)
To: Dmitry Baryshkov, Bjorn Andersson, Michael Turquette,
Stephen Boyd, Vikash Garodia, Dikshita Agarwal,
Bryan O'Donoghue, Mauro Carvalho Chehab, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Jorge Ramirez-Ortiz,
Konrad Dybcio
Cc: linux-arm-msm, linux-clk, linux-kernel, linux-media, devicetree
On 5/15/26 1:59 PM, Dmitry Baryshkov wrote:
> The venus video driver will uses dev_pm_genpd_set_hwmode() API to switch
> the video GDSC to HW and SW control modes at runtime. This requires domain
> to have the HW_CTRL_TRIGGER flag.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 2/4] media: dt-bindings: qcom,qcm2290-venus: add Venus on SM6115
2026-05-15 11:59 [PATCH v2 0/4] media: iris: bring up driver on SM6115-based platforms Dmitry Baryshkov
2026-05-15 11:59 ` [PATCH v2 1/4] clk: qcom: gcc-sm6115: Set HW_CTRL_TRIGGER for video GDSC Dmitry Baryshkov
@ 2026-05-15 11:59 ` Dmitry Baryshkov
2026-05-15 12:25 ` sashiko-bot
2026-05-15 11:59 ` [PATCH v2 3/4] arm64: dts: qcom: sm6115: add venus device Dmitry Baryshkov
2026-05-15 11:59 ` [PATCH v2 4/4] arm64: dts: qcom: qrb4210-rb2: enable " Dmitry Baryshkov
3 siblings, 1 reply; 9+ messages in thread
From: Dmitry Baryshkov @ 2026-05-15 11:59 UTC (permalink / raw)
To: Bjorn Andersson, Michael Turquette, Stephen Boyd, Vikash Garodia,
Dikshita Agarwal, Bryan O'Donoghue, Mauro Carvalho Chehab,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jorge Ramirez-Ortiz, Konrad Dybcio
Cc: linux-arm-msm, linux-clk, linux-kernel, linux-media, devicetree
The Qualcomm SM6115 platform contains the AR50_Lite core similar to the
one found on the QCM2290. Define new platform-specific compatible, while
using QCM2290 as a fallback.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml b/Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml
index 7e6dc410c2d2..ab4c56ee9182 100644
--- a/Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml
@@ -18,7 +18,11 @@ allOf:
properties:
compatible:
- const: qcom,qcm2290-venus
+ oneOf:
+ - items:
+ - const: qcom,sm6115-venus
+ - const: qcom,qcm2290-venus
+ - const: qcom,qcm2290-venus
power-domains:
maxItems: 3
--
2.47.3
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v2 2/4] media: dt-bindings: qcom,qcm2290-venus: add Venus on SM6115
2026-05-15 11:59 ` [PATCH v2 2/4] media: dt-bindings: qcom,qcm2290-venus: add Venus on SM6115 Dmitry Baryshkov
@ 2026-05-15 12:25 ` sashiko-bot
0 siblings, 0 replies; 9+ messages in thread
From: sashiko-bot @ 2026-05-15 12:25 UTC (permalink / raw)
To: Dmitry Baryshkov; +Cc: robh, devicetree, krzk+dt, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The sequence under `items:` is incorrectly indented, which will cause a `dt_binding_check` failure due to `yamllint` strict indentation rules.
--
commit 43193b8fcb4051c6ff00308477a91cbef91be80b
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
media: dt-bindings: qcom,qcm2290-venus: add Venus on SM6115
This commit adds a new compatible string for the Venus core on the Qualcomm
SM6115 platform, using QCM2290 as a fallback.
> diff --git a/Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml b/Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml
> --- a/Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml
> @@ -18,7 +18,11 @@ allOf:
>
> properties:
> compatible:
> - const: qcom,qcm2290-venus
> + oneOf:
> + - items:
> + - const: qcom,sm6115-venus
> + - const: qcom,qcm2290-venus
Will this pass the yamllint checks during make dt_binding_check?
The sequence under the items: key appears to be incorrectly indented.
The file Documentation/devicetree/bindings/.yamllint configures yamllint with
indent-sequences: true. This configuration requires the sequence indicators (-)
to be indented further than the parent items: key.
> + - const: qcom,qcm2290-venus
>
> power-domains:
> maxItems: 3
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260515-iris-sm6115-v2-0-2ab75229de61@oss.qualcomm.com?part=2
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 3/4] arm64: dts: qcom: sm6115: add venus device
2026-05-15 11:59 [PATCH v2 0/4] media: iris: bring up driver on SM6115-based platforms Dmitry Baryshkov
2026-05-15 11:59 ` [PATCH v2 1/4] clk: qcom: gcc-sm6115: Set HW_CTRL_TRIGGER for video GDSC Dmitry Baryshkov
2026-05-15 11:59 ` [PATCH v2 2/4] media: dt-bindings: qcom,qcm2290-venus: add Venus on SM6115 Dmitry Baryshkov
@ 2026-05-15 11:59 ` Dmitry Baryshkov
2026-05-15 11:59 ` [PATCH v2 4/4] arm64: dts: qcom: qrb4210-rb2: enable " Dmitry Baryshkov
3 siblings, 0 replies; 9+ messages in thread
From: Dmitry Baryshkov @ 2026-05-15 11:59 UTC (permalink / raw)
To: Bjorn Andersson, Michael Turquette, Stephen Boyd, Vikash Garodia,
Dikshita Agarwal, Bryan O'Donoghue, Mauro Carvalho Chehab,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jorge Ramirez-Ortiz, Konrad Dybcio
Cc: linux-arm-msm, linux-clk, linux-kernel, linux-media, devicetree
Define the video en/decoding device present on the SM6115 platform. The
core, AR50LT, is mostly compatible with the one present on the Agatti
devices, so it uses qcom,qcm2290-venus as a fallback.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/sm6115.dtsi | 65 ++++++++++++++++++++++++++++++++++++
1 file changed, 65 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi
index bd94eb87d6f9..3520802d1fed 100644
--- a/arch/arm64/boot/dts/qcom/sm6115.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi
@@ -1853,6 +1853,71 @@ adreno_smmu: iommu@59a0000 {
#iommu-cells = <2>;
};
+ venus: video-codec@5a00000 {
+ compatible = "qcom,sm6115-venus",
+ "qcom,qcm2290-venus";
+ reg = <0x0 0x5a00000 0x0 0xf0000>;
+ interrupts = <GIC_SPI 225 IRQ_TYPE_LEVEL_HIGH>;
+
+ power-domains = <&gcc GCC_VENUS_GDSC>,
+ <&gcc GCC_VCODEC0_GDSC>,
+ <&rpmpd SM6115_VDDCX>;
+ power-domain-names = "venus",
+ "vcodec0",
+ "cx";
+ operating-points-v2 = <&venus_opp_table>;
+
+ clocks = <&gcc GCC_VIDEO_VENUS_CTL_CLK>,
+ <&gcc GCC_VIDEO_AHB_CLK>,
+ <&gcc GCC_VENUS_CTL_AXI_CLK>,
+ <&gcc GCC_VIDEO_THROTTLE_CORE_CLK>,
+ <&gcc GCC_VIDEO_VCODEC0_SYS_CLK>,
+ <&gcc GCC_VCODEC0_AXI_CLK>;
+ clock-names = "core",
+ "iface",
+ "bus",
+ "throttle",
+ "vcodec0_core",
+ "vcodec0_bus";
+
+ memory-region = <&pil_video_mem>;
+ iommus = <&apps_smmu 0x860 0x0>,
+ <&apps_smmu 0x880 0x0>;
+
+ interconnects = <&mmnrt_virt MASTER_VIDEO_P0 RPM_ALWAYS_TAG
+ &bimc SLAVE_EBI_CH0 RPM_ALWAYS_TAG>,
+ <&bimc MASTER_AMPSS_M0 RPM_ACTIVE_TAG
+ &config_noc SLAVE_VENUS_CFG RPM_ACTIVE_TAG>;
+ interconnect-names = "video-mem",
+ "cpu-cfg";
+
+ status = "disabled";
+
+ venus_opp_table: opp-table {
+ compatible = "operating-points-v2";
+
+ opp-133333333 {
+ opp-hz = /bits/ 64 <133333333>;
+ required-opps = <&rpmpd_opp_low_svs>;
+ };
+
+ opp-240000000 {
+ opp-hz = /bits/ 64 <240000000>;
+ required-opps = <&rpmpd_opp_svs>;
+ };
+
+ opp-300000000 {
+ opp-hz = /bits/ 64 <300000000>;
+ required-opps = <&rpmpd_opp_svs_plus>;
+ };
+
+ opp-384000000 {
+ opp-hz = /bits/ 64 <384000000>;
+ required-opps = <&rpmpd_opp_nom>;
+ };
+ };
+ };
+
mdss: display-subsystem@5e00000 {
compatible = "qcom,sm6115-mdss";
reg = <0x0 0x05e00000 0x0 0x1000>;
--
2.47.3
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v2 4/4] arm64: dts: qcom: qrb4210-rb2: enable venus device
2026-05-15 11:59 [PATCH v2 0/4] media: iris: bring up driver on SM6115-based platforms Dmitry Baryshkov
` (2 preceding siblings ...)
2026-05-15 11:59 ` [PATCH v2 3/4] arm64: dts: qcom: sm6115: add venus device Dmitry Baryshkov
@ 2026-05-15 11:59 ` Dmitry Baryshkov
2026-05-15 12:18 ` Konrad Dybcio
2026-05-15 12:57 ` sashiko-bot
3 siblings, 2 replies; 9+ messages in thread
From: Dmitry Baryshkov @ 2026-05-15 11:59 UTC (permalink / raw)
To: Bjorn Andersson, Michael Turquette, Stephen Boyd, Vikash Garodia,
Dikshita Agarwal, Bryan O'Donoghue, Mauro Carvalho Chehab,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jorge Ramirez-Ortiz, Konrad Dybcio
Cc: linux-arm-msm, linux-clk, linux-kernel, linux-media, devicetree
Enable the Venus en/decoding device on the Qualcomm RB2 board. The HFI
Gen2 firmware for AR50Lt platforms doesn't work on RB2, so fix the
firmware in the DT for now.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
index 1203172729fa..a6236b09cdbd 100644
--- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
+++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
@@ -739,6 +739,12 @@ &usb_qmpphy_out {
remote-endpoint = <&pmi632_ss_in>;
};
+&venus {
+ firmware-name = "qcom/venus-6.0/venus.mbn";
+
+ status = "okay";
+};
+
&wifi {
/* SoC */
vdd-0.8-cx-mx-supply = <&vreg_l8a_0p664>;
--
2.47.3
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v2 4/4] arm64: dts: qcom: qrb4210-rb2: enable venus device
2026-05-15 11:59 ` [PATCH v2 4/4] arm64: dts: qcom: qrb4210-rb2: enable " Dmitry Baryshkov
@ 2026-05-15 12:18 ` Konrad Dybcio
2026-05-15 12:57 ` sashiko-bot
1 sibling, 0 replies; 9+ messages in thread
From: Konrad Dybcio @ 2026-05-15 12:18 UTC (permalink / raw)
To: Dmitry Baryshkov, Bjorn Andersson, Michael Turquette,
Stephen Boyd, Vikash Garodia, Dikshita Agarwal,
Bryan O'Donoghue, Mauro Carvalho Chehab, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Jorge Ramirez-Ortiz,
Konrad Dybcio
Cc: linux-arm-msm, linux-clk, linux-kernel, linux-media, devicetree
On 5/15/26 1:59 PM, Dmitry Baryshkov wrote:
> Enable the Venus en/decoding device on the Qualcomm RB2 board. The HFI
> Gen2 firmware for AR50Lt platforms doesn't work on RB2, so fix the
> firmware in the DT for now.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 4/4] arm64: dts: qcom: qrb4210-rb2: enable venus device
2026-05-15 11:59 ` [PATCH v2 4/4] arm64: dts: qcom: qrb4210-rb2: enable " Dmitry Baryshkov
2026-05-15 12:18 ` Konrad Dybcio
@ 2026-05-15 12:57 ` sashiko-bot
1 sibling, 0 replies; 9+ messages in thread
From: sashiko-bot @ 2026-05-15 12:57 UTC (permalink / raw)
To: Dmitry Baryshkov; +Cc: conor+dt, krzk+dt, robh, devicetree
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The device tree override `firmware-name` has no functional effect, making the intended workaround a no-op.
--
commit 52a51e0f4e822b65926de689abb3bd0218261df9
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
arm64: dts: qcom: qrb4210-rb2: enable venus device
Enable the Venus en/decoding device on the Qualcomm RB2 board. The HFI
Gen2 firmware for AR50Lt platforms doesn't work on RB2, so fix the
firmware in the DT for now.
> diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> index 1203172729faa..a6236b09cdbd9 100644
> --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> @@ -739,6 +739,12 @@ &usb_qmpphy_out {
> remote-endpoint = <&pmi632_ss_in>;
> };
>
> +&venus {
> + firmware-name = "qcom/venus-6.0/venus.mbn";
Does this firmware-name property actually change the driver behavior?
Looking at qcm2290_res in drivers/media/platform/qcom/venus/core.c (which
handles the qcom,qcm2290-venus fallback compatible used by this platform),
the default fwname is also qcom/venus-6.0/venus.mbn.
In drivers/media/platform/qcom/venus/firmware.c, if the firmware-name property
is absent, the driver falls back to core->res->fwname. Since the string
provided here exactly matches the default fallback, the override appears to
have no functional effect.
Was a different firmware name intended to avoid the broken HFI Gen2 firmware?
> +
> + status = "okay";
> +};
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260515-iris-sm6115-v2-0-2ab75229de61@oss.qualcomm.com?part=4
^ permalink raw reply [flat|nested] 9+ messages in thread