Re: [PATCH v3 3/5] dt-bindings: clock: Move xlnx,zynqmp-clk to its own schema

[Michal Simek <michal.simek@amd.com>]

On 7/7/26 18:34, Michal Simek wrote:
> 
> 
> On 7/7/26 17:55, Rob Herring wrote:
>> On Wed, Jun 3, 2026 at 10:12 AM Michal Simek <michal.simek@amd.com> wrote:
>>>
>>> The ZynqMP clock controller binding shares only #clock-cells with the
>>> Versal bindings. Move it to a dedicated xlnx,zynqmp-clk.yaml schema.
>>> Also remove "(Optional clock)" from clock description because it is visible
>>> from schema itself.
>>>
>>> Suggested-by: Rob Herring <robh@kernel.org>
>>> Signed-off-by: Michal Simek <michal.simek@amd.com>
>>> ---
>>>
>>> Changes in v3:
>>> - Cover change in zynqmp-firmware.yaml
>>> - Move clock-cells to be the last in the example
>>> - Remove comment around (Optional clock) which is obvious from schema
>>>    itself
>>>
>>> Changes in v2:
>>> - New patch in series
>>> - Split zynqmp-clk from versal-clk
>>>
>>>   .../bindings/clock/xlnx,versal-clk.yaml       | 50 +-------------
>>>   .../bindings/clock/xlnx,zynqmp-clk.yaml       | 68 +++++++++++++++++++
>>>   .../firmware/xilinx/xlnx,zynqmp-firmware.yaml |  7 +-
>>>   3 files changed, 76 insertions(+), 49 deletions(-)
>>>   create mode 100644 Documentation/devicetree/bindings/clock/xlnx,zynqmp- 
>>> clk.yaml
>>
>> This is now causing warnings in linux-next:
>>
>> /builds/robherring/linux-dt/Documentation/devicetree/bindings/clock/ 
>> xlnx,versal-clk.example.dtb:
>> zynqmp-firmware (xlnx,zynqmp-firmware):
>> clock-controller:clock-names:0: 'pss_ref_clk' was expected
>>          from schema $id:
>> http://devicetree.org/schemas/firmware/xilinx/xlnx,zynqmp-firmware.yaml
>> /builds/robherring/linux-dt/Documentation/devicetree/bindings/clock/ 
>> xlnx,versal-clk.example.dtb:
>> zynqmp-firmware (xlnx,zynqmp-firmware):
>> clock-controller:clock-names:1: 'video_clk' was expected
>>          from schema $id:
>> http://devicetree.org/schemas/firmware/xilinx/xlnx,zynqmp-firmware.yaml
>> /builds/robherring/linux-dt/Documentation/devicetree/bindings/clock/ 
>> xlnx,versal-clk.example.dtb:
>> zynqmp-firmware (xlnx,zynqmp-firmware): clock-controller:clock-names:
>> ['ref', 'pl_alt_ref'] is too short
>>          from schema $id:
>> http://devicetree.org/schemas/firmware/xilinx/xlnx,zynqmp-firmware.yaml
>> /builds/robherring/linux-dt/Documentation/devicetree/bindings/clock/ 
>> xlnx,versal-clk.example.dtb:
>> zynqmp-firmware (xlnx,zynqmp-firmware): clock-controller:clocks:
>> [[4294967295], [4294967295]] is too short
>>          from schema $id:
>> http://devicetree.org/schemas/firmware/xilinx/xlnx,zynqmp-firmware.yaml
>> /builds/robherring/linux-dt/Documentation/devicetree/bindings/clock/ 
>> xlnx,versal-clk.example.dtb:
>> zynqmp-firmware (xlnx,zynqmp-firmware): clock-controller:compatible:0:
>> 'xlnx,zynqmp-clk' was expected
>>          from schema $id:
>> http://devicetree.org/schemas/firmware/xilinx/xlnx,zynqmp-firmware.yaml
> 
> I will look at it. Thanks for reporting it.

Today Linux-next won't have this series and I have also sent v4 with fixing this.

Thanks,
Michal