Devicetree
 help / color / mirror / Atom feed
From: Arpit Saini <arpit.saini@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Nabige Aala <nabige.aala@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel
Date: Fri, 10 Jul 2026 17:28:04 +0530	[thread overview]
Message-ID: <6f8d8cf5-1e35-4d45-b2c1-6f36ac51ad4a@oss.qualcomm.com> (raw)
In-Reply-To: <ec5017a5-8af7-433c-a011-9ad7c6cd33b7@oss.qualcomm.com>

Hi Konrad,

On 7/10/2026 2:31 PM, Arpit Saini wrote:
> Hi Konrad,
>
> On 7/6/2026 3:33 PM, Konrad Dybcio wrote:
>> On 7/6/26 8:04 AM, Nabige Aala wrote:
>>> From: Arpit Saini <arpit.saini@oss.qualcomm.com>
>>>
>>> Enable the Qualcomm Shikra MDSS display subsystem on the Shikra CQM EVK
>>> board and add the DLC0697 MIPI DSI display panel node. Pin pm4125_l5
>>> to 1.232V with regulator-allow-set-load for DSI PHY PLL stability.
>>>
>>> Signed-off-by: Arpit Saini <arpit.saini@oss.qualcomm.com>
>>> Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com>
>>> ---
>> [...]
>>
>>> +    panel_bl_en: panel-bl-en-state {
>>> +        pins = "gpio91";
>>> +        function = "gpio";
>>> +        drive-strength = <2>;
>>> +        bias-disable;
>>> +        output-high;
>>> +    };
>>> +
>>> +    panel_bl_en_suspend: panel-bl-en-suspend-state {
>>> +        pins = "gpio91";
>>> +        function = "gpio";
>>> +        drive-strength = <2>;
>>> +        bias-pull-down;
>>> +        output-low;
>>> +    };
>> output-foo isn't necessary, the panel driver will assert it as
>> necessary
>>
>> Konrad
>
> Ack, thanks for pointing out.
>
> Arpit
>
I just checked,

Normally the backlight EN pin is controlled by a backlight driver.

However, this panel uses MIPI DCS based backlight control with no

separate backlight driver. Since there is no driver to assert gpio91,

we control it via the panel's pinctrl default state..

So this is platform specific pin , we need this to enable/disable

the backlight.


Thanks,

Arpit


  reply	other threads:[~2026-07-10 11:58 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-06  6:04 [PATCH v2 0/4] arm64: qcom: dts: Add display support for Qualcomm Shikra Nabige Aala
2026-07-06  6:04 ` [PATCH v2 1/4] arm64: dts: qcom: shikra: Add MDSS display subsystem Nabige Aala
2026-07-06 12:59   ` Konrad Dybcio
2026-07-06  6:04 ` [PATCH v2 2/4] arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel Nabige Aala
2026-07-06  6:33   ` Krzysztof Kozlowski
2026-07-06  8:52     ` Arpit Saini
2026-07-06  9:19       ` Krzysztof Kozlowski
2026-07-06 13:48         ` Dmitry Baryshkov
2026-07-06 15:33           ` Krzysztof Kozlowski
2026-07-06 10:03   ` Konrad Dybcio
2026-07-10  9:01     ` Arpit Saini
2026-07-10 11:58       ` Arpit Saini [this message]
2026-07-10 12:10         ` Konrad Dybcio
2026-07-10 12:47           ` Dmitry Baryshkov
2026-07-10 12:57             ` Konrad Dybcio
2026-07-10 12:39         ` Dmitry Baryshkov
2026-07-10 12:49   ` Dmitry Baryshkov
2026-07-10 13:06     ` Arpit Saini
2026-07-06  6:04 ` [PATCH v2 3/4] arm64: defconfig: Enable ILI7807S DSI panel driver Nabige Aala
2026-07-06  6:04 ` [PATCH v2 4/4] arm64: dts: qcom: shikra-cqs-evk: Enable display and add ili7807s panel Nabige Aala
2026-07-06  6:34   ` Krzysztof Kozlowski
2026-07-06  8:54     ` Arpit Saini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f8d8cf5-1e35-4d45-b2c1-6f36ac51ad4a@oss.qualcomm.com \
    --to=arpit.saini@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nabige.aala@oss.qualcomm.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox