From: Andrew Lunn <andrew@lunn.ch>
To: Jonas Karlman <jonas@kwiboo.se>
Cc: Heiko Stuebner <heiko@sntech.de>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Yao Zi <ziyao@disroot.org>,
Chukun Pan <amadeus@jmu.edu.cn>,
devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: rockchip: Add Radxa E24C
Date: Sun, 27 Jul 2025 18:15:34 +0200 [thread overview]
Message-ID: <72d979e8-005a-4d4d-b5d2-3f59e78574de@lunn.ch> (raw)
In-Reply-To: <20250727144409.327740-4-jonas@kwiboo.se>
> +&gmac1 {
> + clock_in_out = "output";
> + phy-mode = "rgmii-id";
> + phy-supply = <&avdd_rtl8367rb>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&rgmii_miim>, <&rgmii_tx_bus2>, <&rgmii_rx_bus2>,
> + <&rgmii_rgmii_clk>, <&rgmii_rgmii_bus>, <&gmac1_rstn_l>;
> + status = "okay";
> +
> + fixed-link {
> + speed = <1000>;
> + full-duplex;
> + };
A fixed-link without an obvious reason gets me asking questions...
The schematic indicates there is a realtek 6387 switch on the other
end. rtl8365mb.c seems to support this. Is there a reason you did not
include this now?
Andrew
next prev parent reply other threads:[~2025-07-27 16:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-27 14:44 [PATCH 0/3] arm64: dts: rockchip: Add Radxa E24C Jonas Karlman
2025-07-27 14:44 ` [PATCH 1/3] arm64: dts: rockchip: Add SFC node for RK3528 Jonas Karlman
2025-07-28 7:00 ` Chukun Pan
2025-07-28 16:18 ` Jonas Karlman
2025-07-27 14:44 ` [PATCH 2/3] dt-bindings: arm: rockchip: Add Radxa E24C Jonas Karlman
2025-07-28 5:48 ` Krzysztof Kozlowski
2025-07-27 14:44 ` [PATCH 3/3] arm64: dts: " Jonas Karlman
2025-07-27 16:15 ` Andrew Lunn [this message]
2025-07-27 16:26 ` Jonas Karlman
2025-07-27 16:44 ` Andrew Lunn
2025-07-28 12:50 ` Chukun Pan
2025-07-28 17:09 ` Jonas Karlman
2025-07-29 13:20 ` Chukun Pan
2025-07-29 21:15 ` Jonas Karlman
2025-08-15 4:46 ` FUKAUMI Naoki
2025-08-15 10:01 ` Chukun Pan
2025-08-18 6:17 ` FUKAUMI Naoki
2025-09-09 12:28 ` FUKAUMI Naoki
2025-09-09 14:48 ` Jonas Karlman
2025-09-09 15:39 ` Heiko Stübner
2025-09-09 19:36 ` Jonas Karlman
2025-09-10 2:43 ` FUKAUMI Naoki
2025-09-10 8:07 ` Heiko Stübner
2025-09-10 9:50 ` FUKAUMI Naoki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72d979e8-005a-4d4d-b5d2-3f59e78574de@lunn.ch \
--to=andrew@lunn.ch \
--cc=amadeus@jmu.edu.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
--cc=ziyao@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox