From: Jonas Karlman <jonas@kwiboo.se>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"heiko@sntech.de" <heiko@sntech.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-rockchip@lists.infradead.org"
<linux-rockchip@lists.infradead.org>,
"ziyao@disroot.org" <ziyao@disroot.org>
Subject: Re: [PATCH 1/3] arm64: dts: rockchip: Add SFC node for RK3528
Date: Mon, 28 Jul 2025 18:18:29 +0200 [thread overview]
Message-ID: <bd253ee7-742b-4fdb-8ce2-4976d4578a3a@kwiboo.se> (raw)
In-Reply-To: <20250728070038.174726-1-amadeus@jmu.edu.cn>
Hi Chukun,
On 7/28/2025 9:00 AM, Chukun Pan wrote:
> Hi,
>
>> + sfc: spi@ffc00000 {
>> + compatible = "rockchip,sfc";
>> + reg = <0x0 0xffc00000 0x0 0x4000>;
>> + interrupts = <GIC_SPI 135 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cru SCLK_SFC>, <&cru HCLK_SFC>;
>> + clock-names = "clk_sfc", "hclk_sfc";
>
> The clock* should be placed before interrupts.
Thanks for catching this, will fix in v2.
> BTW, doesn't the sfc node need to configure pinctrl?
Not sure if it make sense to have a default here. fspi_pins is most
likely always used, however fspi_csn0 and/or fspi_csn1 is probably board
specific.
On the Radxa E24C only fspi_csn0 and fspi_pins are used.
Regards,
Jonas
>
> Thanks,
> Chukun
>
> --
> 2.25.1
>
>
next prev parent reply other threads:[~2025-07-28 16:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-27 14:44 [PATCH 0/3] arm64: dts: rockchip: Add Radxa E24C Jonas Karlman
2025-07-27 14:44 ` [PATCH 1/3] arm64: dts: rockchip: Add SFC node for RK3528 Jonas Karlman
2025-07-28 7:00 ` Chukun Pan
2025-07-28 16:18 ` Jonas Karlman [this message]
2025-07-27 14:44 ` [PATCH 2/3] dt-bindings: arm: rockchip: Add Radxa E24C Jonas Karlman
2025-07-28 5:48 ` Krzysztof Kozlowski
2025-07-27 14:44 ` [PATCH 3/3] arm64: dts: " Jonas Karlman
2025-07-27 16:15 ` Andrew Lunn
2025-07-27 16:26 ` Jonas Karlman
2025-07-27 16:44 ` Andrew Lunn
2025-07-28 12:50 ` Chukun Pan
2025-07-28 17:09 ` Jonas Karlman
2025-07-29 13:20 ` Chukun Pan
2025-07-29 21:15 ` Jonas Karlman
2025-08-15 4:46 ` FUKAUMI Naoki
2025-08-15 10:01 ` Chukun Pan
2025-08-18 6:17 ` FUKAUMI Naoki
2025-09-09 12:28 ` FUKAUMI Naoki
2025-09-09 14:48 ` Jonas Karlman
2025-09-09 15:39 ` Heiko Stübner
2025-09-09 19:36 ` Jonas Karlman
2025-09-10 2:43 ` FUKAUMI Naoki
2025-09-10 8:07 ` Heiko Stübner
2025-09-10 9:50 ` FUKAUMI Naoki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd253ee7-742b-4fdb-8ce2-4976d4578a3a@kwiboo.se \
--to=jonas@kwiboo.se \
--cc=amadeus@jmu.edu.cn \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=ziyao@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox