From: Varadarajan Narayanan <quic_varada@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: <bhelgaas@google.com>, <lpieralisi@kernel.org>, <kw@linux.com>,
<manivannan.sadhasivam@linaro.org>, <robh@kernel.org>,
<krzk+dt@kernel.org>, <conor+dt@kernel.org>,
<andersson@kernel.org>, <konradybcio@kernel.org>,
<linux-arm-msm@vger.kernel.org>, <linux-pci@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v13 1/4] dt-bindings: PCI: qcom: Add MHI registers for IPQ9574
Date: Thu, 13 Mar 2025 17:21:18 +0530 [thread overview]
Message-ID: <Z9LGti0cdg9Sj6xa@hu-varada-blr.qualcomm.com> (raw)
In-Reply-To: <1c88f01b-4414-4f02-91ed-572a9261543a@kernel.org>
On Thu, Mar 13, 2025 at 12:01:54PM +0100, Krzysztof Kozlowski wrote:
> On 13/03/2025 09:05, Varadarajan Narayanan wrote:
> > Append the MHI register range to IPQ9574. This is an optional range used
>
> Same question, you still did not answer - does hardware have this range?
> Which hardware has it?
Yes. All three (ipq6018, ipq8074, ipq9574) have this range.
> I pointed out that you affect at least two other variants. Your commit
> msg must explain that. For example what if they do not have this range?
> Then this change is just wrong.
>
> Start documenting the hardware, not your drivers.
Since all three have this range will this commit message be ok?
Append the MHI register range to ipq6018, ipq8074-gen3 & ipq9574. This
is an optional range used by the dwc controller driver to print debug
stats via the debugfs file 'link_transition_count'.
Additionally, should I update ipq6018.dtsi and ipq8074.dtsi also and include in
this patchset?
Thanks
Varada
next prev parent reply other threads:[~2025-03-13 11:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 8:05 [PATCH v13 0/4] Add PCIe support for Qualcomm IPQ5332 Varadarajan Narayanan
2025-03-13 8:05 ` [PATCH v13 1/4] dt-bindings: PCI: qcom: Add MHI registers for IPQ9574 Varadarajan Narayanan
2025-03-13 11:01 ` Krzysztof Kozlowski
2025-03-13 11:51 ` Varadarajan Narayanan [this message]
2025-03-14 7:57 ` Krzysztof Kozlowski
2025-03-13 8:05 ` [PATCH v13 2/4] arm64: dts: qcom: ipq9574: Add MHI to pcie nodes Varadarajan Narayanan
2025-03-13 8:05 ` [PATCH v13 3/4] arm64: dts: qcom: ipq5332: Add PCIe related nodes Varadarajan Narayanan
2025-03-13 8:06 ` [PATCH v13 4/4] arm64: dts: qcom: ipq5332-rdp441: Enable PCIe phys and controllers Varadarajan Narayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9LGti0cdg9Sj6xa@hu-varada-blr.qualcomm.com \
--to=quic_varada@quicinc.com \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox