Devicetree
 help / color / mirror / Atom feed
From: Ananthu C V <ananthu.cv@oss.qualcomm.com>
To: Bjorn Andersson <andersson@kernel.org>
Cc: Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH v4 2/3] arm64: dts: qcom: fix SoCCP memory mappings for Glymur
Date: Tue, 7 Jul 2026 01:46:18 -0700	[thread overview]
Message-ID: <aky82v5nWhamDRUO@hu-anancv-lv.qualcomm.com> (raw)
In-Reply-To: <akraIZWuQlYvPW8v@baldur>

Hi Bjorn,

On Sun, Jul 05, 2026 at 05:27:50PM -0500, Bjorn Andersson wrote:
> On Fri, Jul 03, 2026 at 05:31:12AM -0700, Ananthu C V wrote:
> > Fixup the SoCCP/SoCCP DTB memory regions to reflect the memory
> > region requirements of the SoCCP firmware, as described in the
> > Glymur v21 memory map release.
> 
> Please change your commit message to start with a problem description,
> not the action taken by the patch.

ACK, will update.

> > Signed-off-by: Ananthu C V <ananthu.cv@oss.qualcomm.com>
> > ---
> >  arch/arm64/boot/dts/qcom/glymur.dtsi | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qcom/glymur.dtsi
> > index 20b49af7298e..5f44f68efde2 100644
> > --- a/arch/arm64/boot/dts/qcom/glymur.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/glymur.dtsi
> > @@ -602,13 +602,13 @@ spss_region_mem: spss@88a00000 {
> >  			no-map;
> >  		};
> >  
> > -		soccpdtb_mem: soccpdtb@892e0000 {
> > -			reg = <0x0 0x892e0000 0x0 0x20000>;
> > +		soccpdtb_mem: soccpdtb@89200000 {
> > +			reg = <0x0 0x89200000 0x0 0x20000>;
> >  			no-map;
> >  		};
> >  
> > -		soccp_mem: soccp@89300000 {
> > -			reg = <0x0 0x89300000 0x0 0x400000>;
> > +		soccp_mem: soccp@88e00000 {
> 
> Now the sort order is wrong.

This also will be fixed in the next revision.

> Regards,
> Bjorn

Once again, thanks for the reviews.

Best,
Ananthu

  reply	other threads:[~2026-07-07  8:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-03 12:31 [PATCH v4 0/3] Add remoteproc PAS loader for SoCCP on Glymur DT Ananthu C V
2026-07-03 12:31 ` [PATCH v4 1/3] remoteproc: qcom: pas: add needs_tzmem flag to force shmbridge creation Ananthu C V
2026-07-03 12:42   ` sashiko-bot
2026-07-03 12:44   ` Krzysztof Kozlowski
2026-07-03 14:35     ` Ananthu C V
2026-07-03 14:47       ` Krzysztof Kozlowski
2026-07-05 22:26   ` Bjorn Andersson
2026-07-06  6:50     ` Ananthu C V
2026-07-03 12:31 ` [PATCH v4 2/3] arm64: dts: qcom: fix SoCCP memory mappings for Glymur Ananthu C V
2026-07-03 12:37   ` sashiko-bot
2026-07-03 14:39     ` Ananthu C V
2026-07-05 22:27   ` Bjorn Andersson
2026-07-07  8:46     ` Ananthu C V [this message]
2026-07-03 12:31 ` [PATCH v4 3/3] arm64: dts: qcom: add SoCCP DT node " Ananthu C V
2026-07-03 12:41   ` sashiko-bot
2026-07-03 14:42     ` Ananthu C V
2026-07-05 22:41   ` Bjorn Andersson
2026-07-06  6:52     ` Ananthu C V

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aky82v5nWhamDRUO@hu-anancv-lv.qualcomm.com \
    --to=ananthu.cv@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox