From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
To: sashiko-reviews@lists.linux.dev
Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 6/7] dtc: dt-check-style: Print proper line number of indentation detection place
Date: Thu, 9 Jul 2026 19:31:17 +0200 [thread overview]
Message-ID: <b4c58ca0-8844-4776-bb3e-53fa17068eda@oss.qualcomm.com> (raw)
In-Reply-To: <20260708145452.E9AF91F000E9@smtp.kernel.org>
On 08/07/2026 16:54, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
> - [Low] Outdated docstring for detect_indent_unit()
Ack
> - [Low] Unused variable `lineno` in `check_indent_consistent()`
False positive, IMO
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-07-09 17:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 14:40 [PATCH v4 0/7] dtc: dt-check-style: Improvement after using on DTS Krzysztof Kozlowski
2026-07-08 14:40 ` [PATCH v4 1/7] dtc: dt-check-style: Narrow disallowing of tab in DTS only to YAML Krzysztof Kozlowski
2026-07-08 14:40 ` [PATCH v4 2/7] dtc: dt-check-style: Allow space-aligning indentation in DTS Krzysztof Kozlowski
2026-07-08 14:50 ` sashiko-bot
2026-07-09 17:24 ` Krzysztof Kozlowski
2026-07-08 14:40 ` [PATCH v4 3/7] dtc: dt-check-style: Rework handling YAML/DTS in rules Krzysztof Kozlowski
2026-07-08 14:40 ` [PATCH v4 4/7] dtc: dt-check-style: Expect first device_type Krzysztof Kozlowski
2026-07-08 14:52 ` sashiko-bot
2026-07-09 17:26 ` Krzysztof Kozlowski
2026-07-08 14:40 ` [PATCH v4 5/7] dtc: dt-check-style: Handle properly DTC-style includes Krzysztof Kozlowski
2026-07-08 14:40 ` [PATCH v4 6/7] dtc: dt-check-style: Print proper line number of indentation detection place Krzysztof Kozlowski
2026-07-08 14:54 ` sashiko-bot
2026-07-09 17:31 ` Krzysztof Kozlowski [this message]
2026-07-08 14:40 ` [PATCH v4 7/7] dtc: dt-check-style: Add more DTS test cases Krzysztof Kozlowski
2026-07-08 14:58 ` sashiko-bot
2026-07-09 17:32 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4c58ca0-8844-4776-bb3e-53fa17068eda@oss.qualcomm.com \
--to=krzysztof.kozlowski@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox