From: Anvesh Jain P <anvesh.p@oss.qualcomm.com>
To: "Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com>,
"Sibi Sankar" <sibi.sankar@oss.qualcomm.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 1/8] dt-bindings: embedded-controller: qcom,hamoa-crd-ec: Add qcom,tsens
Date: Thu, 20 Aug 2026 10:20:13 +0530 [thread overview]
Message-ID: <b6e174b8-be0c-4d7b-9078-75a0ba5a220b@oss.qualcomm.com> (raw)
In-Reply-To: <1146dacb-ca5d-4ee6-b7df-e731bbcb56fc@oss.qualcomm.com>
On 8/19/2026 10:08 PM, Konrad Dybcio wrote:
>>>> Each tsens provider has more physical sensors (16) than the count used
>>>> here. The leading N we take exactly matches the number of sensors
>>>> already wired to board thermal-zones for other purposes (CPU clusters,
>>>> GPU, camera, etc.) on that provider — e.g. on hamoa, tsens2 has 11 such
>>>> zones and tsens3 has 15, matching qcom,tsens = <&tsens2 11>, <&tsens3
>>>> 15>;. The remaining sensor IDs aren't referenced by any thermal-zone on
>>>> this platform, so there's no per-purpose reading to include in the SoC
>>>> Tj average.
>>> What you said is true
>>>
>>> It also doesn't answer the question why that isn't the case
>>>
>>> Konrad
>> What I meant is, the driver looks up a thermal zone for each sensor id,
>> and skips the ones that don't have a zone in DT. Sensor ids past 11/15
>> on this board don't have a zone assigned, so there's nothing to read there.
> You can keep repeating what you said and I can keep repeating you're not
> answering the question "why do we only choose to read the data from
> certain sensors and ignore others"
>
> Konrad
We only read sensors that are physically wired into the board's thermal
zones, those actually measure relevant parts of the SoC. The rest aren't
connected to anything, so we are ignoring those. This is what I am
trying to say.
--
Best Regards,
Anvesh
next prev parent reply other threads:[~2026-08-20 4:50 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 17:44 [PATCH 0/8] Extend Qualcomm reference device EC driver with fan LUT, profile and SoC Tj support Anvesh Jain P
2026-07-28 17:44 ` [PATCH 1/8] dt-bindings: embedded-controller: qcom,hamoa-crd-ec: Add qcom,tsens Anvesh Jain P
2026-07-28 17:54 ` sashiko-bot
2026-08-05 9:54 ` Anvesh Jain P
2026-07-29 11:08 ` Krzysztof Kozlowski
2026-07-29 11:54 ` Anvesh Jain P
2026-07-29 12:32 ` Krzysztof Kozlowski
2026-07-29 13:00 ` Anvesh Jain P
2026-07-29 11:13 ` Konrad Dybcio
2026-07-29 12:13 ` Anvesh Jain P
2026-07-30 17:11 ` Konrad Dybcio
2026-07-31 5:55 ` Anvesh Jain P
2026-08-19 16:38 ` Konrad Dybcio
2026-08-20 4:50 ` Anvesh Jain P [this message]
2026-07-28 17:44 ` [PATCH 2/8] platform: arm64: qcom-hamoa-ec: Add SoC junction temperature reporting Anvesh Jain P
2026-07-28 18:02 ` sashiko-bot
2026-08-05 10:40 ` Anvesh Jain P
2026-07-29 10:59 ` Konrad Dybcio
2026-07-29 13:03 ` Anvesh Jain P
2026-07-30 17:04 ` Konrad Dybcio
2026-07-31 5:47 ` Anvesh Jain P
2026-07-28 17:44 ` [PATCH 3/8] platform: arm64: qcom-hamoa-ec: Switch fan profile based on power supply state Anvesh Jain P
2026-07-28 18:05 ` sashiko-bot
2026-08-05 13:12 ` Anvesh Jain P
2026-07-29 11:02 ` Konrad Dybcio
2026-07-30 6:21 ` Anvesh Jain P
2026-08-19 5:19 ` Anvesh Jain P
2026-07-28 17:44 ` [PATCH 4/8] platform: arm64: qcom-hamoa-ec: Add fan RPM query and LUT calibration Anvesh Jain P
2026-07-28 18:15 ` sashiko-bot
2026-08-05 13:15 ` Anvesh Jain P
2026-07-29 11:07 ` Konrad Dybcio
2026-07-30 6:35 ` Anvesh Jain P
2026-07-30 17:08 ` Konrad Dybcio
2026-07-31 6:25 ` Anvesh Jain P
2026-08-19 16:41 ` Konrad Dybcio
2026-08-20 5:04 ` Anvesh Jain P
2026-08-19 5:13 ` Anvesh Jain P
2026-08-19 16:34 ` Konrad Dybcio
2026-07-28 17:44 ` [PATCH 5/8] platform: arm64: qcom-hamoa-ec: Verify required I2C adapter functionality Anvesh Jain P
2026-07-28 18:14 ` sashiko-bot
2026-08-05 14:20 ` Anvesh Jain P
2026-07-29 11:08 ` Konrad Dybcio
2026-07-30 6:37 ` Anvesh Jain P
2026-07-28 17:44 ` [PATCH 6/8] platform: arm64: qcom-hamoa-ec: Retry I2C transfers on NACK Anvesh Jain P
2026-07-28 18:26 ` sashiko-bot
2026-08-05 15:10 ` Anvesh Jain P
2026-07-29 11:11 ` Konrad Dybcio
2026-07-30 6:40 ` Anvesh Jain P
2026-07-28 17:44 ` [PATCH 7/8] arm64: dts: qcom: x1p42100-crd: Add qcom,tsens for EC fan thermal management Anvesh Jain P
2026-07-28 18:26 ` sashiko-bot
2026-08-06 4:29 ` Anvesh Jain P
2026-07-28 17:44 ` [PATCH 8/8] arm64: dts: qcom: x1e80100-crd: " Anvesh Jain P
2026-07-28 18:36 ` sashiko-bot
2026-08-06 4:37 ` Anvesh Jain P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6e174b8-be0c-4d7b-9078-75a0ba5a220b@oss.qualcomm.com \
--to=anvesh.p@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sibi.sankar@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox