* [PATCH v3] PCI: rcar-gen4: Add missing PM ops
@ 2026-09-07 16:35 Marek Vasut
2026-09-07 16:49 ` sashiko-bot
2026-09-08 1:05 ` Koichiro Den
0 siblings, 2 replies; 6+ messages in thread
From: Marek Vasut @ 2026-09-07 16:35 UTC (permalink / raw)
To: linux-pci
Cc: Marek Vasut, Geert Uytterhoeven, Krzysztof Wilczyński,
Bjorn Helgaas, Conor Dooley, Koichiro Den, Krzysztof Kozlowski,
Lorenzo Pieralisi, Magnus Damm, Manivannan Sadhasivam,
Rob Herring, Yoshihiro Shimoda, devicetree, linux-kernel,
linux-renesas-soc
The R-Car Gen4 PCIe controller is part of a power domain. On R-Car S4
and V4H, this is an always-on power domain which is not shut down in
suspend. On R-Car V4M, this is a dedicated A2PCIPHY power domain,
which is shut down during suspend, and the controller loses state,
which prevents the PCIe from working after resume.
Fix this by adding generic suspend/resume noirq ops for the controller,
which tear the link down on suspend, and restart it on resume. Use the
same PM ops on all of R-Car Gen4 to gracefully suspend and resume the
PCIe link on V4H and S4 too.
Test case which demonstrates the problem on R-Car V4M:
"
$ hexdump -vC /sys/bus/pci/devices/0000:00:00.0/config > /tmp/pre
$ echo s2idle > /sys/power/mem_sleep
$ echo platform > /sys/power/pm_test
$ echo mem > /sys/power/state
$ hexdump -vC /sys/bus/pci/devices/0000:00:00.0/config > /tmp/post
$ diff -Naru /tmp/pre /tmp/post
...
-00000000 12 19 32 00 07 05 10 00 00 00 04 06 00 00 01 00
+00000000 12 19 32 00 07 05 10 00 00 00 00 ff 00 00 80 00
^^^^^
Class 0604->00ff
"
Fixes: 0d0c551011df ("PCI: rcar-gen4: Add R-Car Gen4 PCIe controller support for host mode")
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
---
Cc: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Koichiro Den <den@valinux.co.jp>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>
Cc: Magnus Damm <magnus.damm@gmail.com>
Cc: Manivannan Sadhasivam <mani@kernel.org>
Cc: Rob Herring <robh@kernel.org>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-pci@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org
---
V2: - Add TB from Geert for RC mode
- Use pm_sleep_ptr()
- Call HOST suspend/resume ops only in case the controller is in RC mode
V3: - Add RB from Geert
- Make rcar_gen4_pcie_pm_ops() static
- Pull the mode from driver data
---
NOTE: Depends on series
https://lore.kernel.org/linux-pci/20260903205153.283553-1-marek.vasut+renesas@mailbox.org/
---
drivers/pci/controller/dwc/pcie-rcar-gen4.c | 25 +++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/drivers/pci/controller/dwc/pcie-rcar-gen4.c b/drivers/pci/controller/dwc/pcie-rcar-gen4.c
index 5690dc32f47e0..8b6a6cab1b83e 100644
--- a/drivers/pci/controller/dwc/pcie-rcar-gen4.c
+++ b/drivers/pci/controller/dwc/pcie-rcar-gen4.c
@@ -909,6 +909,26 @@ static int rcar_gen4_pcie_ltssm_control(struct rcar_gen4_pcie *rcar, bool enable
return 0;
}
+static int rcar_gen4_pcie_suspend_noirq(struct device *dev)
+{
+ struct rcar_gen4_pcie *rcar = dev_get_drvdata(dev);
+
+ if (rcar->drvdata->mode != DW_PCIE_RC_TYPE)
+ return 0;
+
+ return dw_pcie_suspend_noirq(&rcar->dw);
+}
+
+static int rcar_gen4_pcie_resume_noirq(struct device *dev)
+{
+ struct rcar_gen4_pcie *rcar = dev_get_drvdata(dev);
+
+ if (rcar->drvdata->mode != DW_PCIE_RC_TYPE)
+ return 0;
+
+ return dw_pcie_resume_noirq(&rcar->dw);
+}
+
static struct rcar_gen4_pcie_drvdata drvdata_r8a779f0_pcie = {
.ltssm_control = r8a779f0_pcie_ltssm_control,
.mode = DW_PCIE_RC_TYPE,
@@ -952,10 +972,15 @@ static const struct of_device_id rcar_gen4_pcie_of_match[] = {
};
MODULE_DEVICE_TABLE(of, rcar_gen4_pcie_of_match);
+static DEFINE_NOIRQ_DEV_PM_OPS(rcar_gen4_pcie_pm_ops,
+ rcar_gen4_pcie_suspend_noirq,
+ rcar_gen4_pcie_resume_noirq);
+
static struct platform_driver rcar_gen4_pcie_driver = {
.driver = {
.name = "pcie-rcar-gen4",
.of_match_table = rcar_gen4_pcie_of_match,
+ .pm = pm_sleep_ptr(&rcar_gen4_pcie_pm_ops),
.probe_type = PROBE_PREFER_ASYNCHRONOUS,
},
.probe = rcar_gen4_pcie_probe,
--
2.53.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v3] PCI: rcar-gen4: Add missing PM ops
2026-09-07 16:35 [PATCH v3] PCI: rcar-gen4: Add missing PM ops Marek Vasut
@ 2026-09-07 16:49 ` sashiko-bot
2026-09-08 1:05 ` Koichiro Den
1 sibling, 0 replies; 6+ messages in thread
From: sashiko-bot @ 2026-09-07 16:49 UTC (permalink / raw)
To: Marek Vasut; +Cc: devicetree, linux-pci, wsa+renesas, robh, conor+dt
Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
New issues:
- [High] PCIe host controller fails to re-initialize on R-Car V4M after resume if any endpoint does not support D3cold.
- [High] Endpoint mode (EP) does not recover from suspend on R-Car V4M due to explicitly skipping PM state restoration.
Pre-existing issues:
- [High] The `msi_node` device node obtained from `of_msi_xlate()` is leaked because its refcount is never decremented.
--
commit 924c8a29b2859d29f5190b0088001c235ae190fa
Author: Marek Vasut <marek.vasut+renesas@mailbox.org>
PCI: rcar-gen4: Add missing PM ops
Adds generic suspend/resume noirq ops to tear down and restart the PCIe link
during suspend/resume for R-Car Gen4. This supports power domains that shut
down in suspend, such as on R-Car V4M.
> diff --git a/drivers/pci/controller/dwc/pcie-rcar-gen4.c b/drivers/pci/controller/dwc/pcie-rcar-gen4.c
> index fbe465a29068f..2926660f1b537 100644
> --- a/drivers/pci/controller/dwc/pcie-rcar-gen4.c
> +++ b/drivers/pci/controller/dwc/pcie-rcar-gen4.c
> @@ -849,6 +849,26 @@ static int rcar_gen4_pcie_ltssm_control(struct rcar_gen4_pcie *rcar, bool enable
> return 0;
> }
>
> +static int rcar_gen4_pcie_suspend_noirq(struct device *dev)
> +{
> + struct rcar_gen4_pcie *rcar = dev_get_drvdata(dev);
> +
> + if (rcar->drvdata->mode != DW_PCIE_RC_TYPE)
> + return 0;
[Severity: High]
Does returning 0 here cause the endpoint (EP) mode to not recover from
suspend on R-Car V4M?
If the V4M A2PCIPHY power domain shuts down, removing power from the EP
controller, explicitly skipping PM state restoration will leave the EP
hardware dead after system resume.
> +
> + return dw_pcie_suspend_noirq(&rcar->dw);
[Severity: High]
Can the host controller fail to re-initialize on system resume if an attached
endpoint does not support D3cold?
If an attached endpoint does not support D3cold, the generic helper
dw_pcie_suspend_noirq() returns 0 early:
drivers/pci/controller/dwc/pcie-designware-host.c:dw_pcie_suspend_noirq() {
...
if (!pci_host_common_d3cold_possible(pci->pp.bridge, &pme_capable))
return 0;
...
}
Because it returns 0 without setting pci->suspended = true, the subsequent
resume will skip initialization:
drivers/pci/controller/dwc/pcie-designware-host.c:dw_pcie_resume_noirq() {
...
if (!pci->suspended)
return 0;
...
}
Since the A2PCIPHY power domain is unconditionally shut down by the generic
PM core, the hardware loses state. Does skipping re-initialization here leave
the PCIe bus permanently unusable?
> +}
> +
> +static int rcar_gen4_pcie_resume_noirq(struct device *dev)
> +{
> + struct rcar_gen4_pcie *rcar = dev_get_drvdata(dev);
> +
> + if (rcar->drvdata->mode != DW_PCIE_RC_TYPE)
> + return 0;
[Severity: High]
Does this explicit bypass also prevent the EP controller from being
reconfigured after power loss, as mentioned above?
> +
> + return dw_pcie_resume_noirq(&rcar->dw);
[Severity: High]
This isn't a bug introduced by this patch, but does calling the generic resume
helper introduce a recurring device_node leak?
On every resume, dw_pcie_resume_noirq() will call pci->pp.ops->init(), which
invokes rcar_gen4_pcie_host_msi_addr(). Inside that function, of_msi_xlate()
acquires a reference to the msi_node:
drivers/pci/controller/dwc/pcie-rcar-gen4.c:rcar_gen4_pcie_host_msi_addr() {
...
of_msi_xlate(dev, &msi_node, 0);
if (!msi_node)
return -ENODEV;
...
}
The function returns without ever calling of_node_put(msi_node). Because this
patch now causes init to run on every suspend/resume cycle instead of just at
probe time, does this leak the msi_node reference on every system resume?
> +}
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260907163554.725127-1-marek.vasut+renesas@mailbox.org?part=1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v3] PCI: rcar-gen4: Add missing PM ops
2026-09-07 16:35 [PATCH v3] PCI: rcar-gen4: Add missing PM ops Marek Vasut
2026-09-07 16:49 ` sashiko-bot
@ 2026-09-08 1:05 ` Koichiro Den
2026-09-08 16:29 ` Marek Vasut
1 sibling, 1 reply; 6+ messages in thread
From: Koichiro Den @ 2026-09-08 1:05 UTC (permalink / raw)
To: Marek Vasut
Cc: linux-pci, Geert Uytterhoeven, Krzysztof Wilczyński,
Bjorn Helgaas, Conor Dooley, Krzysztof Kozlowski,
Lorenzo Pieralisi, Magnus Damm, Manivannan Sadhasivam,
Rob Herring, Yoshihiro Shimoda, devicetree, linux-kernel,
linux-renesas-soc
On Mon, Sep 07, 2026 at 06:35:22PM +0200, Marek Vasut wrote:
> The R-Car Gen4 PCIe controller is part of a power domain. On R-Car S4
> and V4H, this is an always-on power domain which is not shut down in
> suspend. On R-Car V4M, this is a dedicated A2PCIPHY power domain,
> which is shut down during suspend, and the controller loses state,
> which prevents the PCIe from working after resume.
>
> Fix this by adding generic suspend/resume noirq ops for the controller,
> which tear the link down on suspend, and restart it on resume. Use the
> same PM ops on all of R-Car Gen4 to gracefully suspend and resume the
> PCIe link on V4H and S4 too.
>
> Test case which demonstrates the problem on R-Car V4M:
> "
> $ hexdump -vC /sys/bus/pci/devices/0000:00:00.0/config > /tmp/pre
> $ echo s2idle > /sys/power/mem_sleep
> $ echo platform > /sys/power/pm_test
> $ echo mem > /sys/power/state
> $ hexdump -vC /sys/bus/pci/devices/0000:00:00.0/config > /tmp/post
> $ diff -Naru /tmp/pre /tmp/post
> ...
> -00000000 12 19 32 00 07 05 10 00 00 00 04 06 00 00 01 00
> +00000000 12 19 32 00 07 05 10 00 00 00 00 ff 00 00 80 00
> ^^^^^
> Class 0604->00ff
> "
>
> Fixes: 0d0c551011df ("PCI: rcar-gen4: Add R-Car Gen4 PCIe controller support for host mode")
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
> ---
The s2idle test with pm_test=platform now passes in EP mode on S4 Spider even
with CONFIG_PCIE_DW_HOST=y. Thanks! Feel free to use the tag for it if it helps.
Tested-by: Koichiro Den <den@valinux.co.jp>
> Cc: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Koichiro Den <den@valinux.co.jp>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>
> Cc: Magnus Damm <magnus.damm@gmail.com>
> Cc: Manivannan Sadhasivam <mani@kernel.org>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Cc: devicetree@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-pci@vger.kernel.org
> Cc: linux-renesas-soc@vger.kernel.org
> ---
> V2: - Add TB from Geert for RC mode
> - Use pm_sleep_ptr()
> - Call HOST suspend/resume ops only in case the controller is in RC mode
> V3: - Add RB from Geert
> - Make rcar_gen4_pcie_pm_ops() static
> - Pull the mode from driver data
> ---
> NOTE: Depends on series
> https://lore.kernel.org/linux-pci/20260903205153.283553-1-marek.vasut+renesas@mailbox.org/
> ---
> drivers/pci/controller/dwc/pcie-rcar-gen4.c | 25 +++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/drivers/pci/controller/dwc/pcie-rcar-gen4.c b/drivers/pci/controller/dwc/pcie-rcar-gen4.c
> index 5690dc32f47e0..8b6a6cab1b83e 100644
> --- a/drivers/pci/controller/dwc/pcie-rcar-gen4.c
> +++ b/drivers/pci/controller/dwc/pcie-rcar-gen4.c
> @@ -909,6 +909,26 @@ static int rcar_gen4_pcie_ltssm_control(struct rcar_gen4_pcie *rcar, bool enable
> return 0;
> }
>
> +static int rcar_gen4_pcie_suspend_noirq(struct device *dev)
> +{
> + struct rcar_gen4_pcie *rcar = dev_get_drvdata(dev);
> +
> + if (rcar->drvdata->mode != DW_PCIE_RC_TYPE)
> + return 0;
> +
> + return dw_pcie_suspend_noirq(&rcar->dw);
> +}
> +
> +static int rcar_gen4_pcie_resume_noirq(struct device *dev)
> +{
> + struct rcar_gen4_pcie *rcar = dev_get_drvdata(dev);
> +
> + if (rcar->drvdata->mode != DW_PCIE_RC_TYPE)
> + return 0;
> +
> + return dw_pcie_resume_noirq(&rcar->dw);
> +}
> +
> static struct rcar_gen4_pcie_drvdata drvdata_r8a779f0_pcie = {
> .ltssm_control = r8a779f0_pcie_ltssm_control,
> .mode = DW_PCIE_RC_TYPE,
> @@ -952,10 +972,15 @@ static const struct of_device_id rcar_gen4_pcie_of_match[] = {
> };
> MODULE_DEVICE_TABLE(of, rcar_gen4_pcie_of_match);
>
> +static DEFINE_NOIRQ_DEV_PM_OPS(rcar_gen4_pcie_pm_ops,
> + rcar_gen4_pcie_suspend_noirq,
> + rcar_gen4_pcie_resume_noirq);
> +
> static struct platform_driver rcar_gen4_pcie_driver = {
> .driver = {
> .name = "pcie-rcar-gen4",
> .of_match_table = rcar_gen4_pcie_of_match,
> + .pm = pm_sleep_ptr(&rcar_gen4_pcie_pm_ops),
> .probe_type = PROBE_PREFER_ASYNCHRONOUS,
> },
> .probe = rcar_gen4_pcie_probe,
> --
> 2.53.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v3] PCI: rcar-gen4: Add missing PM ops
2026-09-08 1:05 ` Koichiro Den
@ 2026-09-08 16:29 ` Marek Vasut
2026-09-09 2:17 ` Koichiro Den
0 siblings, 1 reply; 6+ messages in thread
From: Marek Vasut @ 2026-09-08 16:29 UTC (permalink / raw)
To: Koichiro Den
Cc: linux-pci, Geert Uytterhoeven, Krzysztof Wilczyński,
Bjorn Helgaas, Conor Dooley, Krzysztof Kozlowski,
Lorenzo Pieralisi, Magnus Damm, Manivannan Sadhasivam,
Rob Herring, Yoshihiro Shimoda, devicetree, linux-kernel,
linux-renesas-soc
Hello Den-san,
On 9/8/26 3:05 AM, Koichiro Den wrote:
> On Mon, Sep 07, 2026 at 06:35:22PM +0200, Marek Vasut wrote:
>> The R-Car Gen4 PCIe controller is part of a power domain. On R-Car S4
>> and V4H, this is an always-on power domain which is not shut down in
>> suspend. On R-Car V4M, this is a dedicated A2PCIPHY power domain,
>> which is shut down during suspend, and the controller loses state,
>> which prevents the PCIe from working after resume.
>>
>> Fix this by adding generic suspend/resume noirq ops for the controller,
>> which tear the link down on suspend, and restart it on resume. Use the
>> same PM ops on all of R-Car Gen4 to gracefully suspend and resume the
>> PCIe link on V4H and S4 too.
>>
>> Test case which demonstrates the problem on R-Car V4M:
>> "
>> $ hexdump -vC /sys/bus/pci/devices/0000:00:00.0/config > /tmp/pre
>> $ echo s2idle > /sys/power/mem_sleep
>> $ echo platform > /sys/power/pm_test
>> $ echo mem > /sys/power/state
>> $ hexdump -vC /sys/bus/pci/devices/0000:00:00.0/config > /tmp/post
>> $ diff -Naru /tmp/pre /tmp/post
>> ...
>> -00000000 12 19 32 00 07 05 10 00 00 00 04 06 00 00 01 00
>> +00000000 12 19 32 00 07 05 10 00 00 00 00 ff 00 00 80 00
>> ^^^^^
>> Class 0604->00ff
>> "
>>
>> Fixes: 0d0c551011df ("PCI: rcar-gen4: Add R-Car Gen4 PCIe controller support for host mode")
>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
>> ---
>
> The s2idle test with pm_test=platform now passes in EP mode on S4 Spider even
> with CONFIG_PCIE_DW_HOST=y. Thanks! Feel free to use the tag for it if it helps.
>
> Tested-by: Koichiro Den <den@valinux.co.jp>
Thank you for your test. I would like to ask -- is the EP side of PCIe
link behaving correctly during suspend/resume cycle on your S4 setup ?
Does the EP require any special handling during suspend/resume ?
Thank you for your help !
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v3] PCI: rcar-gen4: Add missing PM ops
2026-09-08 16:29 ` Marek Vasut
@ 2026-09-09 2:17 ` Koichiro Den
2026-09-09 2:22 ` Marek Vasut
0 siblings, 1 reply; 6+ messages in thread
From: Koichiro Den @ 2026-09-09 2:17 UTC (permalink / raw)
To: Marek Vasut
Cc: linux-pci, Geert Uytterhoeven, Krzysztof Wilczyński,
Bjorn Helgaas, Conor Dooley, Krzysztof Kozlowski,
Lorenzo Pieralisi, Magnus Damm, Manivannan Sadhasivam,
Rob Herring, Yoshihiro Shimoda, devicetree, linux-kernel,
linux-renesas-soc
On Tue, Sep 08, 2026 at 06:29:24PM +0200, Marek Vasut wrote:
> Hello Den-san,
>
> On 9/8/26 3:05 AM, Koichiro Den wrote:
> > On Mon, Sep 07, 2026 at 06:35:22PM +0200, Marek Vasut wrote:
> > > The R-Car Gen4 PCIe controller is part of a power domain. On R-Car S4
> > > and V4H, this is an always-on power domain which is not shut down in
> > > suspend. On R-Car V4M, this is a dedicated A2PCIPHY power domain,
> > > which is shut down during suspend, and the controller loses state,
> > > which prevents the PCIe from working after resume.
> > >
> > > Fix this by adding generic suspend/resume noirq ops for the controller,
> > > which tear the link down on suspend, and restart it on resume. Use the
> > > same PM ops on all of R-Car Gen4 to gracefully suspend and resume the
> > > PCIe link on V4H and S4 too.
> > >
> > > Test case which demonstrates the problem on R-Car V4M:
> > > "
> > > $ hexdump -vC /sys/bus/pci/devices/0000:00:00.0/config > /tmp/pre
> > > $ echo s2idle > /sys/power/mem_sleep
> > > $ echo platform > /sys/power/pm_test
> > > $ echo mem > /sys/power/state
> > > $ hexdump -vC /sys/bus/pci/devices/0000:00:00.0/config > /tmp/post
> > > $ diff -Naru /tmp/pre /tmp/post
> > > ...
> > > -00000000 12 19 32 00 07 05 10 00 00 00 04 06 00 00 01 00
> > > +00000000 12 19 32 00 07 05 10 00 00 00 00 ff 00 00 80 00
> > > ^^^^^
> > > Class 0604->00ff
> > > "
> > >
> > > Fixes: 0d0c551011df ("PCI: rcar-gen4: Add R-Car Gen4 PCIe controller support for host mode")
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
> > > ---
> >
> > The s2idle test with pm_test=platform now passes in EP mode on S4 Spider even
> > with CONFIG_PCIE_DW_HOST=y. Thanks! Feel free to use the tag for it if it helps.
> >
> > Tested-by: Koichiro Den <den@valinux.co.jp>
> Thank you for your test. I would like to ask -- is the EP side of PCIe link
> behaving correctly during suspend/resume cycle on your S4 setup ? Does the
> EP require any special handling during suspend/resume ?
To be clear, what I confirmed was the following:
- The panic I observed with v1 no longer occurs with this newer revision.
- I could create a vNTB EPF after running the test.
- With vNTB/ntb_netdev already connected before the test. ping resumed normally
afterwards.
Note: I used the suspend test from the commit message on the EP:
echo s2idle > /sys/power/mem_sleep && \
echo platform > /sys/power/pm_test && \
echo mem > /sys/power/state
Based on these, I believe this patch introduces no regression in EP mode on S4.
Any pre-existing EP suspend/resume issues could be addressed separately.
Best regards,
Koichiro
>
> Thank you for your help !
>
> --
> Best regards,
> Marek Vasut
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v3] PCI: rcar-gen4: Add missing PM ops
2026-09-09 2:17 ` Koichiro Den
@ 2026-09-09 2:22 ` Marek Vasut
0 siblings, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2026-09-09 2:22 UTC (permalink / raw)
To: Koichiro Den
Cc: linux-pci, Geert Uytterhoeven, Krzysztof Wilczyński,
Bjorn Helgaas, Conor Dooley, Krzysztof Kozlowski,
Lorenzo Pieralisi, Magnus Damm, Manivannan Sadhasivam,
Rob Herring, Yoshihiro Shimoda, devicetree, linux-kernel,
linux-renesas-soc
On 9/9/26 4:17 AM, Koichiro Den wrote:
Hello Den-san,
>>> The s2idle test with pm_test=platform now passes in EP mode on S4 Spider even
>>> with CONFIG_PCIE_DW_HOST=y. Thanks! Feel free to use the tag for it if it helps.
>>>
>>> Tested-by: Koichiro Den <den@valinux.co.jp>
>> Thank you for your test. I would like to ask -- is the EP side of PCIe link
>> behaving correctly during suspend/resume cycle on your S4 setup ? Does the
>> EP require any special handling during suspend/resume ?
>
> To be clear, what I confirmed was the following:
>
> - The panic I observed with v1 no longer occurs with this newer revision.
> - I could create a vNTB EPF after running the test.
> - With vNTB/ntb_netdev already connected before the test. ping resumed normally
> afterwards.
>
> Note: I used the suspend test from the commit message on the EP:
> echo s2idle > /sys/power/mem_sleep && \
> echo platform > /sys/power/pm_test && \
> echo mem > /sys/power/state
>
> Based on these, I believe this patch introduces no regression in EP mode on S4.
> Any pre-existing EP suspend/resume issues could be addressed separately.
Understood.
Thank you for your help !
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-09-09 4:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-07 16:35 [PATCH v3] PCI: rcar-gen4: Add missing PM ops Marek Vasut
2026-09-07 16:49 ` sashiko-bot
2026-09-08 1:05 ` Koichiro Den
2026-09-08 16:29 ` Marek Vasut
2026-09-09 2:17 ` Koichiro Den
2026-09-09 2:22 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox