Re: [PATCH 3/6] arm64: dts: qcom: sm8250-hdk: Add FSA4480 USB-C protocol chip

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] arm64: dts: qcom: missing co-author sign-off and mismatched author email
--

commit 1a1ede276cc0d97ceb67bad5a51673b00f7ce0c3
Author: ShiTou Hong <redstone.dcity@gmail.com>

arm64: dts: qcom: sm8250-hdk: Add FSA4480 USB-C protocol chip

This commit adds the FSA4480 USB-C switch node and configures the PM8150B
type-c module, USB OTG role switch, and DisplayPort altmode in
arch/arm64/boot/dts/qcom/sm8250-hdk.dts.

>     arm64: dts: qcom: sm8250-hdk: Add FSA4480 USB-C protocol chip
>
>     The sm8250-hdk has a USB-C port supporting OTG and DP altmode.
>     This is implemented with the FSA4480 chip,
>     which hasn't been added in the dts file.
>
>     Change the USB controller mode to OTG.
>     Enable the i2c controller for the chip and the dp controller.
>     Configure the PM8150b type-c module and vbus regulator.
>
>     Co-developed-by: KancyJoe <kancy2333@outlook.com>
>     Signed-off-by: ShiTou Hong <dc_redstone@outlook.com>

[Severity: Low]
As documented in Documentation/process/submitting-patches.rst:

    Co-developed-by: denotes authorship, every Co-developed-by: must be immediately
    followed by a Signed-off-by: of the associated co-author.

Should the Co-developed-by tag for KancyJoe <kancy2333@outlook.com> be
immediately followed by a matching Signed-off-by tag from KancyJoe?

Also, the commit Author header uses redstone.dcity@gmail.com while the
Signed-off-by line uses dc_redstone@outlook.com. Should these two email
addresses match?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261023072832.2642647-1-dc_redstone@outlook.com?part=3