Re: [PATCH v2 12/13] arm64: dts: synaptics: add SL2610 family SoCs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential
issues to consider:
- [Low] arm64: dts: synaptics: missing root compatible property in
  sl2619.dtsi
- [Low] arm64: dts: synaptics: duplicated cpu1 and pmu nodes in
  sl2617/sl2619.dtsi
- [Low] arm64: dts: synaptics: optee node placed under root instead of
  /firmware
--

commit 9dec2dc5b8adc9799e77b0f1baf814fa359dd8c4
Author: Jisheng Zhang <jszhang@kernel.org>

arm64: dts: synaptics: add SL2610 family SoCs

This commit adds devicetree files for the Synaptics SL2610 family SoCs
(SL2611, SL2613, SL2615, SL2617, and SL2619), describing CPUs, GIC,
system controllers, and serial, I2C, I3C, SPI, and GPIO peripherals.

> diff --git a/arch/arm64/boot/dts/synaptics/sl2611.dtsi b/arch/arm64/boot/dts/synaptics/sl2611.dtsi
> new file mode 100644
> index 0000000000000..663fe6034ba05
> --- /dev/null
> +++ b/arch/arm64/boot/dts/synaptics/sl2611.dtsi
> @@ -0,0 +1,457 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +/*
> + * Copyright (C) 2024 Synaptics Incorporated
> + *
> + * Author: Jisheng Zhang <jszhang@kernel.org>
> + */
> +
> +#include <dt-bindings/clock/syna,sl2610.h>
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/reset/syna,sl2610-reset.h>
> +
> +/ {
> +	compatible = "syna,sl2611";
> +	interrupt-parent = <&gic>;
> +	#address-cells = <2>;
> +	#size-cells = <2>;
> +
> +	psci {
> +		compatible = "arm,psci-1.0";
> +		method = "smc";
> +	};
> +
> +	optee {
> +		compatible = "linaro,optee-tz";
> +		method = "smc";
> +	};

[Severity: Low]
Should the optee node be placed under a /firmware container node?

Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.yaml
places optee under /firmware, which of_platform_default_populate_init()
looks up directly via of_find_node_by_path("/firmware") before populating
the rest of the tree.

[ ... ]

> diff --git a/arch/arm64/boot/dts/synaptics/sl2617.dtsi b/arch/arm64/boot/dts/synaptics/sl2617.dtsi
> new file mode 100644
> index 0000000000000..a0de686d1fae5
> --- /dev/null
> +++ b/arch/arm64/boot/dts/synaptics/sl2617.dtsi
> @@ -0,0 +1,46 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +/*
> + * Copyright (C) 2025 Synaptics Incorporated
> + *
> + * Author: Jisheng Zhang <jszhang@kernel.org>
> + */
> +
> +#include "sl2613.dtsi"
> +
> +/ {
> +	compatible = "syna,sl2617";
> +
> +	cpus {
> +		cpu1: cpu@100 {

[Severity: Low]
This isn't a bug, but sl2617.dtsi and sl2619.dtsi duplicate the entire
cpu1 and pmu definitions from sl2615.dtsi.  Could they include
sl2615.dtsi and override the root compatible property, the same way
sl2613.dtsi includes sl2611.dtsi?

[ ... ]

> diff --git a/arch/arm64/boot/dts/synaptics/sl2619.dtsi b/arch/arm64/boot/dts/synaptics/sl2619.dtsi
> new file mode 100644
> index 0000000000000..96bd58bbed3e1
> --- /dev/null
> +++ b/arch/arm64/boot/dts/synaptics/sl2619.dtsi
> @@ -0,0 +1,44 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +/*
> + * Copyright (C) 2025 Synaptics Incorporated
> + *
> + * Author: Jisheng Zhang <jszhang@kernel.org>
> + */
> +
> +#include "sl2613.dtsi"
> +
> +/ {
> +	cpus {

[Severity: Low]
Is the root node missing compatible = "syna,sl2619"; here?

Unlike sl2615.dtsi and sl2617.dtsi, sl2619.dtsi does not override the
root compatible property and inherits compatible = "syna,sl2613"; from
sl2613.dtsi.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261115102401.3520-1-jszhang@kernel.org?part=12