Devicetree
 help / color / mirror / Atom feed
* [PATCH 0/2] ARM: dts: bcm2835: replace deprecated LED fragment
@ 2026-11-22  9:52 Artem Novak
  2026-11-22  9:52 ` [PATCH 1/2] ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Zero Artem Novak
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Artem Novak @ 2026-11-22  9:52 UTC (permalink / raw)
  To: florian.fainelli
  Cc: bcm-kernel-feedback-list, conor+dt, devicetree, krzk+dt,
	linux-arm-kernel, linux-kernel, linux-rpi-kernel, robh,
	Artem Novak

The Raspberry Pi Zero and Model B device trees include the deprecated
bcm283x-rpi-led-deprecated.dtsi fragment to define their ACT LEDs.

Replace the fragment with board-local gpio-leds nodes, preserving the
existing GPIO assignments, polarity, default state, and heartbeat
trigger.

The changes are split into separate patches for each board.

Artem Novak (2):
  ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi
    Zero
  ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi
    Model B

 arch/arm/boot/dts/broadcom/bcm2835-rpi-b.dts    | 14 +++++++++++---
 arch/arm/boot/dts/broadcom/bcm2835-rpi-zero.dts | 14 +++++++++++---
 2 files changed, 22 insertions(+), 6 deletions(-)

-- 
2.56.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 1/2] ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Zero
  2026-11-22  9:52 [PATCH 0/2] ARM: dts: bcm2835: replace deprecated LED fragment Artem Novak
@ 2026-11-22  9:52 ` Artem Novak
  2026-11-22 10:02   ` sashiko-bot
  2026-11-22  9:52 ` [PATCH 2/2] ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Model B Artem Novak
  2026-11-22 10:17 ` [PATCH v2 0/2] ARM: dts: bcm2835: replace deprecated LED fragment Artem Novak
  2 siblings, 1 reply; 10+ messages in thread
From: Artem Novak @ 2026-11-22  9:52 UTC (permalink / raw)
  To: florian.fainelli
  Cc: bcm-kernel-feedback-list, conor+dt, devicetree, krzk+dt,
	linux-arm-kernel, linux-kernel, linux-rpi-kernel, robh,
	Artem Novak

Replace the deprecated LED fragment with a board-local gpio-leds
node, preserving the ACT LED GPIO assignment and configuration.

Signed-off-by: Artem Novak <artem122novak@gmail.com>
---
 arch/arm/boot/dts/broadcom/bcm2835-rpi-zero.dts | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/broadcom/bcm2835-rpi-zero.dts b/arch/arm/boot/dts/broadcom/bcm2835-rpi-zero.dts
index 539c19c10946..9364695055b4 100644
--- a/arch/arm/boot/dts/broadcom/bcm2835-rpi-zero.dts
+++ b/arch/arm/boot/dts/broadcom/bcm2835-rpi-zero.dts
@@ -7,7 +7,6 @@
 #include "bcm2835.dtsi"
 #include "bcm2835-rpi.dtsi"
 #include "bcm2835-rpi-common.dtsi"
-#include "bcm283x-rpi-led-deprecated.dtsi"
 #include "bcm283x-rpi-usb-otg.dtsi"
 
 / {
@@ -101,8 +100,17 @@ &hdmi {
 	status = "okay";
 };
 
-&led_act {
-	gpios = <&gpio 47 GPIO_ACTIVE_HIGH>;
+/ {
+	leds {
+		compatible = "gpio-leds";
+
+		led-act {
+			label = "ACT";
+			gpios = <&gpio 47 GPIO_ACTIVE_HIGH>;
+			default-state = "keep";
+			linux,default-trigger = "heartbeat";
+		};
+	};
 };
 
 &sdhost {
-- 
2.56.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 2/2] ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Model B
  2026-11-22  9:52 [PATCH 0/2] ARM: dts: bcm2835: replace deprecated LED fragment Artem Novak
  2026-11-22  9:52 ` [PATCH 1/2] ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Zero Artem Novak
@ 2026-11-22  9:52 ` Artem Novak
  2026-11-22 10:02   ` sashiko-bot
  2026-11-22 10:17 ` [PATCH v2 0/2] ARM: dts: bcm2835: replace deprecated LED fragment Artem Novak
  2 siblings, 1 reply; 10+ messages in thread
From: Artem Novak @ 2026-11-22  9:52 UTC (permalink / raw)
  To: florian.fainelli
  Cc: bcm-kernel-feedback-list, conor+dt, devicetree, krzk+dt,
	linux-arm-kernel, linux-kernel, linux-rpi-kernel, robh,
	Artem Novak

Replace the deprecated LED fragment with a board-local gpio-leds
node, preserving the ACT LED GPIO assignment and configuration.

Signed-off-by: Artem Novak <artem122novak@gmail.com>
---
 arch/arm/boot/dts/broadcom/bcm2835-rpi-b.dts | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/broadcom/bcm2835-rpi-b.dts b/arch/arm/boot/dts/broadcom/bcm2835-rpi-b.dts
index 72764be75a79..040ba7f45216 100644
--- a/arch/arm/boot/dts/broadcom/bcm2835-rpi-b.dts
+++ b/arch/arm/boot/dts/broadcom/bcm2835-rpi-b.dts
@@ -3,7 +3,6 @@
 #include "bcm2835.dtsi"
 #include "bcm2835-rpi.dtsi"
 #include "bcm2835-rpi-common.dtsi"
-#include "bcm283x-rpi-led-deprecated.dtsi"
 #include "bcm283x-rpi-smsc9512.dtsi"
 #include "bcm283x-rpi-usb-host.dtsi"
 
@@ -93,8 +92,17 @@ &hdmi {
 	status = "okay";
 };
 
-&led_act {
-	gpios = <&gpio 16 GPIO_ACTIVE_LOW>;
+/ {
+	leds {
+		compatible = "gpio-leds";
+
+		led-act {
+			label = "ACT";
+			gpios = <&gpio 16 GPIO_ACTIVE_LOW>;
+			default-state = "keep";
+			linux,default-trigger = "heartbeat";
+		};
+	};
 };
 
 &pwm {
-- 
2.56.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/2] ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Zero
  2026-11-22  9:52 ` [PATCH 1/2] ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Zero Artem Novak
@ 2026-11-22 10:02   ` sashiko-bot
  0 siblings, 0 replies; 10+ messages in thread
From: sashiko-bot @ 2026-11-22 10:02 UTC (permalink / raw)
  To: Artem Novak; +Cc: devicetree, robh, conor+dt

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Medium] ARM: dts: bcm2835: loss of leds and led_act symbols in
  bcm2835-rpi-zero.dtb
- [Low] ARM: dts: bcm2835: redundant inlining of
  bcm283x-rpi-led-deprecated.dtsi
--

commit 739b5e27f1887a8552cb53d11c780143b2a0ef69
Author: Artem Novak <artem122novak@gmail.com>

ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Zero

This commit replaces the included bcm283x-rpi-led-deprecated.dtsi fragment
in bcm2835-rpi-zero.dts with an inline gpio-leds node for the ACT LED.

> diff --git a/arch/arm/boot/dts/broadcom/bcm2835-rpi-zero.dts b/arch/arm/boot/dts/broadcom/bcm2835-rpi-zero.dts
> index 539c19c10946c..9364695055b4e 100644
> --- a/arch/arm/boot/dts/broadcom/bcm2835-rpi-zero.dts
> +++ b/arch/arm/boot/dts/broadcom/bcm2835-rpi-zero.dts
> @@ -7,7 +7,6 @@
>  #include "bcm2835.dtsi"
>  #include "bcm2835-rpi.dtsi"
>  #include "bcm2835-rpi-common.dtsi"
> -#include "bcm283x-rpi-led-deprecated.dtsi"
>  #include "bcm283x-rpi-usb-otg.dtsi"
>  
>  / {
> @@ -101,8 +100,17 @@ &hdmi {
>  	status = "okay";
>  };
>  
> -&led_act {
> -	gpios = <&gpio 47 GPIO_ACTIVE_HIGH>;
> +/ {
> +	leds {
> +		compatible = "gpio-leds";
> +
> +		led-act {

[Severity: Medium]
Does dropping the leds: and led_act: node labels here remove the leds and
led_act entries from /__symbols__ in bcm2835-rpi-zero.dtb?

arch/arm/boot/dts/broadcom/Makefile compiles bcm2835-rpi-zero.dtb with -@
(DTC_FLAGS_bcm2835-rpi-zero := -@), and bcm283x-rpi-led-deprecated.dtsi
defined leds: leds and led_act: led-act.  Without those labels, Device
Tree overlays and bootloader dtparam overrides targeting &leds or &led_act
will fail to resolve on Raspberry Pi Zero.

> +			label = "ACT";
> +			gpios = <&gpio 47 GPIO_ACTIVE_HIGH>;
> +			default-state = "keep";
> +			linux,default-trigger = "heartbeat";
> +		};
> +	};
>  };

[Severity: Low]
Does open-coding bcm283x-rpi-led-deprecated.dtsi here defeat the purpose
of 1156e3a78bcc ("ARM: dts: bcm283x: Move ACT LED into separate dtsi")?

What is deprecated in Documentation/devicetree/bindings/leds/common.yaml
is the label = "ACT" property (in favor of function and color), which has
to be kept on existing boards to preserve the /sys/class/leds/ACT
userspace interface.  Commit 1156e3a78bcc ("ARM: dts: bcm283x: Move ACT
LED into separate dtsi") moved that legacy node into
bcm283x-rpi-led-deprecated.dtsi so existing boards share one definition
while new boards do not inherit it; inlining the same label = "ACT"
definition into a second root / { ... }; block in the middle of the
phandle overrides duplicates the shared fragment without removing the
deprecated property.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261122095225.200916-1-artem122novak@gmail.com?part=1

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/2] ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Model B
  2026-11-22  9:52 ` [PATCH 2/2] ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Model B Artem Novak
@ 2026-11-22 10:02   ` sashiko-bot
  0 siblings, 0 replies; 10+ messages in thread
From: sashiko-bot @ 2026-11-22 10:02 UTC (permalink / raw)
  To: Artem Novak; +Cc: devicetree, robh, conor+dt

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Medium] ARM: dts: bcm2835: dropped leds and led_act overlay symbols
  in bcm2835-rpi-b
- [Low] ARM: dts: bcm2835: inlining deprecated LED dtsi duplicates
  legacy label node
--

commit 49ba1cd9cda13f0341e152094b002fc2c5f37a35
Author: Artem Novak <artem122novak@gmail.com>

ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Model B

This commit removes the bcm283x-rpi-led-deprecated.dtsi include from
bcm2835-rpi-b.dts and defines a board-local gpio-leds node for the ACT LED.

> diff --git a/arch/arm/boot/dts/broadcom/bcm2835-rpi-b.dts b/arch/arm/boot/dts/broadcom/bcm2835-rpi-b.dts
> index 72764be75a799..040ba7f452163 100644
> --- a/arch/arm/boot/dts/broadcom/bcm2835-rpi-b.dts
> +++ b/arch/arm/boot/dts/broadcom/bcm2835-rpi-b.dts
> @@ -3,7 +3,6 @@
>  #include "bcm2835.dtsi"
>  #include "bcm2835-rpi.dtsi"
>  #include "bcm2835-rpi-common.dtsi"
> -#include "bcm283x-rpi-led-deprecated.dtsi"
>  #include "bcm283x-rpi-smsc9512.dtsi"
>  #include "bcm283x-rpi-usb-host.dtsi"
>  
> @@ -93,8 +92,17 @@ &hdmi {
>  	status = "okay";
>  };
>  
> -&led_act {
> -	gpios = <&gpio 16 GPIO_ACTIVE_LOW>;
> +/ {
> +	leds {
> +		compatible = "gpio-leds";
> +
> +		led-act {

[Severity: Medium]
Does dropping the leds: and led_act: node labels here remove those symbols
from /__symbols__ in the compiled DTB?

arch/arm/boot/dts/broadcom/Makefile builds bcm2835-rpi-b.dtb with -@ for
device-tree overlay support, and bcm283x-rpi-led-deprecated.dtsi defined
leds: leds and led_act: led-act.  Omitting both labels removes leds and
led_act from /__symbols__, breaking overlays and bootloader dtparam fixups
that target &leds or &led_act.

> +			label = "ACT";
> +			gpios = <&gpio 16 GPIO_ACTIVE_LOW>;
> +			default-state = "keep";
> +			linux,default-trigger = "heartbeat";
> +		};
> +	};
>  };

[Severity: Low]
Why inline bcm283x-rpi-led-deprecated.dtsi into bcm2835-rpi-b.dts while
keeping the deprecated label = "ACT" property?

Commit 1156e3a78bcc ("ARM: dts: bcm283x: Move ACT LED into separate dtsi")
moved this node into bcm283x-rpi-led-deprecated.dtsi specifically so existing
boards could preserve the legacy /sys/class/leds/ACT userspace ABI in one
shared fragment without new boards inheriting the deprecated gpio-leds label
property.  Open-coding the same definition here also introduces a second
/ { ... }; root node block in the middle of the board's phandle overrides.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261122095225.200916-1-artem122novak@gmail.com?part=2

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v2 0/2] ARM: dts: bcm2835: replace deprecated LED fragment
  2026-11-22  9:52 [PATCH 0/2] ARM: dts: bcm2835: replace deprecated LED fragment Artem Novak
  2026-11-22  9:52 ` [PATCH 1/2] ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Zero Artem Novak
  2026-11-22  9:52 ` [PATCH 2/2] ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Model B Artem Novak
@ 2026-11-22 10:17 ` Artem Novak
  2026-11-22 10:17   ` [PATCH v2 1/2] ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Zero Artem Novak
  2026-11-22 10:17   ` [PATCH v2 2/2] ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Model B Artem Novak
  2 siblings, 2 replies; 10+ messages in thread
From: Artem Novak @ 2026-11-22 10:17 UTC (permalink / raw)
  To: florian.fainelli
  Cc: bcm-kernel-feedback-list, conor+dt, devicetree, krzk+dt,
	linux-arm-kernel, linux-kernel, linux-rpi-kernel, robh,
	Artem Novak

The Raspberry Pi Zero and Model B device trees include the deprecated
bcm283x-rpi-led-deprecated.dtsi fragment to define their ACT LEDs.

Replace the fragment with board-local gpio-leds nodes, preserving the
existing GPIO assignments, polarity, default state, and heartbeat
trigger.

Restore the leds and led_act labels to preserve the device tree
symbols used by overlays.

Changes in v2:

Restore the leds and led_act labels on both boards to preserve
overlay compatibility.

&
 
Add commit descriptions explaining the purpose of the changes.


Artem Novak (2):
  ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi
    Zero
  ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi
    Model B

 arch/arm/boot/dts/broadcom/bcm2835-rpi-b.dts    | 14 +++++++++++---
 arch/arm/boot/dts/broadcom/bcm2835-rpi-zero.dts | 14 +++++++++++---
 2 files changed, 22 insertions(+), 6 deletions(-)

-- 
2.56.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v2 1/2] ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Zero
  2026-11-22 10:17 ` [PATCH v2 0/2] ARM: dts: bcm2835: replace deprecated LED fragment Artem Novak
@ 2026-11-22 10:17   ` Artem Novak
  2026-11-22 10:27     ` sashiko-bot
  2026-11-22 10:17   ` [PATCH v2 2/2] ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Model B Artem Novak
  1 sibling, 1 reply; 10+ messages in thread
From: Artem Novak @ 2026-11-22 10:17 UTC (permalink / raw)
  To: florian.fainelli
  Cc: bcm-kernel-feedback-list, conor+dt, devicetree, krzk+dt,
	linux-arm-kernel, linux-kernel, linux-rpi-kernel, robh,
	Artem Novak

Preserve the leds and led_act labels when replacing the deprecated
LED fragment with a board-local gpio-leds node.

These labels are exported as device tree symbols and may be referenced
by overlays.

Signed-off-by: Artem Novak <artem122novak@gmail.com>
---
 arch/arm/boot/dts/broadcom/bcm2835-rpi-zero.dts | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/broadcom/bcm2835-rpi-zero.dts b/arch/arm/boot/dts/broadcom/bcm2835-rpi-zero.dts
index 539c19c10946..e01f668cb9e0 100644
--- a/arch/arm/boot/dts/broadcom/bcm2835-rpi-zero.dts
+++ b/arch/arm/boot/dts/broadcom/bcm2835-rpi-zero.dts
@@ -7,7 +7,6 @@
 #include "bcm2835.dtsi"
 #include "bcm2835-rpi.dtsi"
 #include "bcm2835-rpi-common.dtsi"
-#include "bcm283x-rpi-led-deprecated.dtsi"
 #include "bcm283x-rpi-usb-otg.dtsi"
 
 / {
@@ -101,8 +100,17 @@ &hdmi {
 	status = "okay";
 };
 
-&led_act {
-	gpios = <&gpio 47 GPIO_ACTIVE_HIGH>;
+/ {
+	leds: leds {
+		compatible = "gpio-leds";
+
+		led_act: led-act {
+			label = "ACT";
+			gpios = <&gpio 47 GPIO_ACTIVE_HIGH>;
+			default-state = "keep";
+			linux,default-trigger = "heartbeat";
+		};
+	};
 };
 
 &sdhost {
-- 
2.56.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH v2 2/2] ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Model B
  2026-11-22 10:17 ` [PATCH v2 0/2] ARM: dts: bcm2835: replace deprecated LED fragment Artem Novak
  2026-11-22 10:17   ` [PATCH v2 1/2] ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Zero Artem Novak
@ 2026-11-22 10:17   ` Artem Novak
  2026-11-22 10:26     ` sashiko-bot
  1 sibling, 1 reply; 10+ messages in thread
From: Artem Novak @ 2026-11-22 10:17 UTC (permalink / raw)
  To: florian.fainelli
  Cc: bcm-kernel-feedback-list, conor+dt, devicetree, krzk+dt,
	linux-arm-kernel, linux-kernel, linux-rpi-kernel, robh,
	Artem Novak

Preserve the leds and led_act labels when replacing the deprecated
LED fragment with a board-local gpio-leds node.

These labels are exported as device tree symbols and may be referenced
by overlays.

Signed-off-by: Artem Novak <artem122novak@gmail.com>
---
 arch/arm/boot/dts/broadcom/bcm2835-rpi-b.dts | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/broadcom/bcm2835-rpi-b.dts b/arch/arm/boot/dts/broadcom/bcm2835-rpi-b.dts
index 72764be75a79..660814ce851b 100644
--- a/arch/arm/boot/dts/broadcom/bcm2835-rpi-b.dts
+++ b/arch/arm/boot/dts/broadcom/bcm2835-rpi-b.dts
@@ -3,7 +3,6 @@
 #include "bcm2835.dtsi"
 #include "bcm2835-rpi.dtsi"
 #include "bcm2835-rpi-common.dtsi"
-#include "bcm283x-rpi-led-deprecated.dtsi"
 #include "bcm283x-rpi-smsc9512.dtsi"
 #include "bcm283x-rpi-usb-host.dtsi"
 
@@ -93,8 +92,17 @@ &hdmi {
 	status = "okay";
 };
 
-&led_act {
-	gpios = <&gpio 16 GPIO_ACTIVE_LOW>;
+/ {
+	leds: leds {
+		compatible = "gpio-leds";
+
+		led_act: led-act {
+			label = "ACT";
+			gpios = <&gpio 16 GPIO_ACTIVE_LOW>;
+			default-state = "keep";
+			linux,default-trigger = "heartbeat";
+		};
+	};
 };
 
 &pwm {
-- 
2.56.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 2/2] ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Model B
  2026-11-22 10:17   ` [PATCH v2 2/2] ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Model B Artem Novak
@ 2026-11-22 10:26     ` sashiko-bot
  0 siblings, 0 replies; 10+ messages in thread
From: sashiko-bot @ 2026-11-22 10:26 UTC (permalink / raw)
  To: Artem Novak; +Cc: devicetree, robh, conor+dt

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ARM: dts: bcm2835: inlining deprecated LED dtsi duplicates
  legacy label node
--

commit 63b377a339b5c423a1e61107aa45808a3f4ef120
Author: Artem Novak <artem122novak@gmail.com>

ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Model B

This commit replaces the bcm283x-rpi-led-deprecated.dtsi include in
bcm2835-rpi-b.dts with an inline gpio-leds node defining the ACT LED.

> diff --git a/arch/arm/boot/dts/broadcom/bcm2835-rpi-b.dts b/arch/arm/boot/dts/broadcom/bcm2835-rpi-b.dts
> index 72764be75a799..660814ce851b9 100644
> --- a/arch/arm/boot/dts/broadcom/bcm2835-rpi-b.dts
> +++ b/arch/arm/boot/dts/broadcom/bcm2835-rpi-b.dts
> @@ -3,7 +3,6 @@
>  #include "bcm2835.dtsi"
>  #include "bcm2835-rpi.dtsi"
>  #include "bcm2835-rpi-common.dtsi"
> -#include "bcm283x-rpi-led-deprecated.dtsi"
>  #include "bcm283x-rpi-smsc9512.dtsi"
>  #include "bcm283x-rpi-usb-host.dtsi"
>  
> @@ -93,8 +92,17 @@ &hdmi {
>  	status = "okay";
>  };
>  
> -&led_act {
> -	gpios = <&gpio 16 GPIO_ACTIVE_LOW>;
> +/ {
> +	leds: leds {
> +		compatible = "gpio-leds";
> +
> +		led_act: led-act {
> +			label = "ACT";
> +			gpios = <&gpio 16 GPIO_ACTIVE_LOW>;
> +			default-state = "keep";
> +			linux,default-trigger = "heartbeat";
> +		};
> +	};
>  };
>  
>  &pwm {

[Severity: Low]
Why inline bcm283x-rpi-led-deprecated.dtsi back into bcm2835-rpi-b.dts while
keeping the deprecated label = "ACT" property?

Commit 1156e3a78bcc ("ARM: dts: bcm283x: Move ACT LED into separate dtsi")
factored this node out into bcm283x-rpi-led-deprecated.dtsi specifically so
existing Raspberry Pi boards can share the legacy label definition (Needed
to preserve the /sys/class/leds/ACT userspace ABI) without duplicating it in
every board file.  Replacing the shared include with an open-coded copy produces
an identical DTB while reverting that consolidation and adding a second
root node block (/ { ... };) in the middle of the phandle overrides.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261122101759.206056-1-artem122novak@gmail.com?part=2

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 1/2] ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Zero
  2026-11-22 10:17   ` [PATCH v2 1/2] ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Zero Artem Novak
@ 2026-11-22 10:27     ` sashiko-bot
  0 siblings, 0 replies; 10+ messages in thread
From: sashiko-bot @ 2026-11-22 10:27 UTC (permalink / raw)
  To: Artem Novak; +Cc: devicetree, robh, conor+dt

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ARM: dts: bcm2835: redundant inlining of
  bcm283x-rpi-led-deprecated.dtsi
--

commit 6102946db777d06293b2fcb5e3eab012124a2da6
Author: Artem Novak <artem122novak@gmail.com>

ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Zero

This commit replaces the bcm283x-rpi-led-deprecated.dtsi include in
bcm2835-rpi-zero.dts with an inline gpio-leds node.

> diff --git a/arch/arm/boot/dts/broadcom/bcm2835-rpi-zero.dts b/arch/arm/boot/dts/broadcom/bcm2835-rpi-zero.dts
> index 539c19c10946c..e01f668cb9e04 100644
> --- a/arch/arm/boot/dts/broadcom/bcm2835-rpi-zero.dts
> +++ b/arch/arm/boot/dts/broadcom/bcm2835-rpi-zero.dts
> @@ -7,7 +7,6 @@
>  #include "bcm2835.dtsi"
>  #include "bcm2835-rpi.dtsi"
>  #include "bcm2835-rpi-common.dtsi"
> -#include "bcm283x-rpi-led-deprecated.dtsi"
>  #include "bcm283x-rpi-usb-otg.dtsi"
>  
>  / {
> @@ -101,8 +100,17 @@ &hdmi {
>  	status = "okay";
>  };
>  
> -&led_act {
> -	gpios = <&gpio 47 GPIO_ACTIVE_HIGH>;
> +/ {
> +	leds: leds {
> +		compatible = "gpio-leds";
> +
> +		led_act: led-act {
> +			label = "ACT";
> +			gpios = <&gpio 47 GPIO_ACTIVE_HIGH>;
> +			default-state = "keep";
> +			linux,default-trigger = "heartbeat";
> +		};
> +	};
>  };

[Severity: Low]
Why inline bcm283x-rpi-led-deprecated.dtsi here?

Commit 1156e3a78bcc ("ARM: dts: bcm283x: Move ACT LED into separate dtsi")
factored the legacy leds and led_act node into
bcm283x-rpi-led-deprecated.dtsi so existing Raspberry Pi boards could share
the deprecated label = "ACT" property (needed to preserve /sys/class/leds/ACT
for userspace) without new boards inheriting it from bcm2835-rpi.dtsi.

Open-coding the same node in bcm2835-rpi-zero.dts retains the deprecated
label = "ACT" property while duplicating the shared fragment used by the
other Raspberry Pi boards, and introduces a second / { ... }; root node block
in the middle of the phandle overrides.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261122101759.206056-1-artem122novak@gmail.com?part=1

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2026-11-22 10:27 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-22  9:52 [PATCH 0/2] ARM: dts: bcm2835: replace deprecated LED fragment Artem Novak
2026-11-22  9:52 ` [PATCH 1/2] ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Zero Artem Novak
2026-11-22 10:02   ` sashiko-bot
2026-11-22  9:52 ` [PATCH 2/2] ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Model B Artem Novak
2026-11-22 10:02   ` sashiko-bot
2026-11-22 10:17 ` [PATCH v2 0/2] ARM: dts: bcm2835: replace deprecated LED fragment Artem Novak
2026-11-22 10:17   ` [PATCH v2 1/2] ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Zero Artem Novak
2026-11-22 10:27     ` sashiko-bot
2026-11-22 10:17   ` [PATCH v2 2/2] ARM: dts: bcm2835: replace deprecated LED fragment on Raspberry Pi Model B Artem Novak
2026-11-22 10:26     ` sashiko-bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox