From: "Duane Griffin" <duaneg@dghda.com>
To: akpm@linux-foundation.org
Cc: Andreas Dilger <adilger@sun.com>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
Duane Griffin <duaneg@dghda.com>
Subject: [PATCH 2/6] ext3: don't inherit inappropriate inode flags from parent
Date: Wed, 11 Jun 2008 01:04:05 +0100 [thread overview]
Message-ID: <1213142649-32685-3-git-send-email-duaneg@dghda.com> (raw)
In-Reply-To: <1213142649-32685-2-git-send-email-duaneg@dghda.com>
At present INDEX is the only flag that new ext3 inodes do NOT inherit from
their parent. In addition prevent the flags DIRTY, ECOMPR, IMAGIC and
TOPDIR from being inherited. List inheritable flags explicitly to prevent
future flags from accidentally being inherited.
Signed-off-by: Duane Griffin <duaneg@dghda.com>
--
This is v2 with inheritable flags now explicitly specified, as per Andreas'
request.
---
fs/ext3/ialloc.c | 2 +-
include/linux/ext3_fs.h | 7 +++++++
2 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/fs/ext3/ialloc.c b/fs/ext3/ialloc.c
index 7712682..1d9fe3f 100644
--- a/fs/ext3/ialloc.c
+++ b/fs/ext3/ialloc.c
@@ -559,7 +559,7 @@ got:
ei->i_dir_start_lookup = 0;
ei->i_disksize = 0;
- ei->i_flags = EXT3_I(dir)->i_flags & ~EXT3_INDEX_FL;
+ ei->i_flags = EXT3_I(dir)->i_flags & EXT3_FL_INHERITED;
if (S_ISLNK(mode))
ei->i_flags &= ~(EXT3_IMMUTABLE_FL|EXT3_APPEND_FL);
/* dirsync only applies to directories */
diff --git a/include/linux/ext3_fs.h b/include/linux/ext3_fs.h
index 36c5403..140190d 100644
--- a/include/linux/ext3_fs.h
+++ b/include/linux/ext3_fs.h
@@ -178,6 +178,13 @@ struct ext3_group_desc
#define EXT3_FL_USER_VISIBLE 0x0003DFFF /* User visible flags */
#define EXT3_FL_USER_MODIFIABLE 0x000380FF /* User modifiable flags */
+/* Flags that should be inherited by new inodes from their parent. */
+#define EXT3_FL_INHERITED (EXT3_SECRM_FL | EXT3_UNRM_FL | EXT3_COMPR_FL |\
+ EXT3_SYNC_FL | EXT3_IMMUTABLE_FL | EXT3_APPEND_FL |\
+ EXT3_NODUMP_FL | EXT3_NOATIME_FL | EXT3_COMPRBLK_FL|\
+ EXT3_NOCOMPR_FL | EXT3_JOURNAL_DATA_FL |\
+ EXT3_NOTAIL_FL | EXT3_DIRSYNC_FL)
+
/*
* Inode dynamic state flags
*/
--
1.5.3.7
next prev parent reply other threads:[~2008-06-11 0:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-11 0:04 [PATCH 0/6][v2] ext{2,3,4}: tighten inheritance and setting of inode flags Duane Griffin
2008-06-11 0:04 ` [PATCH 1/6] ext2: don't inherit inappropriate inode flags from parent Duane Griffin
2008-06-11 0:04 ` Duane Griffin [this message]
2008-06-11 0:04 ` [PATCH 3/6] ext4: " Duane Griffin
2008-06-11 0:04 ` [PATCH 4/6] ext2: tighten restrictions on inode flags Duane Griffin
2008-06-11 0:04 ` [PATCH 5/6] ext3: " Duane Griffin
2008-06-11 0:04 ` [PATCH 6/6] ext4: " Duane Griffin
2008-06-11 11:31 ` Aneesh Kumar K.V
2008-06-11 11:49 ` Duane Griffin
2008-06-12 19:27 ` Dave Kleikamp
2008-06-12 20:35 ` Duane Griffin
2008-06-12 9:06 ` [PATCH 4/6] ext2: " Andreas Dilger
2008-06-12 9:38 ` Duane Griffin
-- strict thread matches above, loose matches on Subject: below --
2008-06-19 15:41 [PATCH 0/6][v3] ext{2,3,4}: tighten inheritance and setting of " Duane Griffin
2008-06-19 15:42 ` [PATCH 1/6] ext2: don't inherit inappropriate inode flags from parent Duane Griffin
2008-06-19 15:42 ` [PATCH 2/6] ext3: " Duane Griffin
2008-12-03 19:54 [PATCH 0/6][REPOST] ext{2,3,4}: tighten inheritance and setting of inode flags Duane Griffin
2008-12-03 19:54 ` [PATCH 1/6] ext2: don't inherit inappropriate inode flags from parent Duane Griffin
2008-12-03 19:54 ` [PATCH 2/6] ext3: " Duane Griffin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1213142649-32685-3-git-send-email-duaneg@dghda.com \
--to=duaneg@dghda.com \
--cc=adilger@sun.com \
--cc=akpm@linux-foundation.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox