From: "Duane Griffin" <duaneg@dghda.com>
To: akpm@linux-foundation.org
Cc: Andreas Dilger <adilger@sun.com>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
Duane Griffin <duaneg@dghda.com>
Subject: [PATCH 3/6] ext4: don't inherit inappropriate inode flags from parent
Date: Wed, 11 Jun 2008 01:04:06 +0100 [thread overview]
Message-ID: <1213142649-32685-4-git-send-email-duaneg@dghda.com> (raw)
In-Reply-To: <1213142649-32685-3-git-send-email-duaneg@dghda.com>
At present INDEX and EXTENTS are the only flags that new ext4 inodes do
NOT inherit from their parent. In addition prevent the flags DIRTY, ECOMPR,
IMAGIC, TOPDIR, HUGE_FILE and EXT_MIGRATE from being inherited. List
inheritable flags explicitly to prevent future flags from accidentally being
inherited.
Signed-off-by: Duane Griffin <duaneg@dghda.com>
--
This is v2 with inheritable flags now explicitly specified, as per Andreas'
request.
---
fs/ext4/ext4.h | 8 ++++++++
fs/ext4/ialloc.c | 2 +-
2 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index 8158083..1a4faa5 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -235,6 +235,14 @@ struct ext4_group_desc
#define EXT4_FL_USER_VISIBLE 0x000BDFFF /* User visible flags */
#define EXT4_FL_USER_MODIFIABLE 0x000380FF /* User modifiable flags */
+/* Flags that should be inherited by new inodes from their parent. */
+#define EXT4_FL_INHERITED (EXT4_SECRM_FL | EXT4_UNRM_FL | EXT4_COMPR_FL |\
+ EXT4_SYNC_FL | EXT4_IMMUTABLE_FL | EXT4_APPEND_FL |\
+ EXT4_NODUMP_FL | EXT4_NOATIME_FL |\
+ EXT4_COMPRBLK_FL | EXT4_NOCOMPR_FL |\
+ EXT4_JOURNAL_DATA_FL | EXT4_NOTAIL_FL|\
+ EXT4_DIRSYNC_FL)
+
/*
* Inode dynamic state flags
*/
diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
index c6efbab..ff25d57 100644
--- a/fs/ext4/ialloc.c
+++ b/fs/ext4/ialloc.c
@@ -702,7 +702,7 @@ got:
* newly created directory and file only if -o extent mount option is
* specified
*/
- ei->i_flags = EXT4_I(dir)->i_flags & ~(EXT4_INDEX_FL|EXT4_EXTENTS_FL);
+ ei->i_flags = EXT4_I(dir)->i_flags & EXT4_FL_INHERITED;
if (S_ISLNK(mode))
ei->i_flags &= ~(EXT4_IMMUTABLE_FL|EXT4_APPEND_FL);
/* dirsync only applies to directories */
--
1.5.3.7
next prev parent reply other threads:[~2008-06-11 0:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-11 0:04 [PATCH 0/6][v2] ext{2,3,4}: tighten inheritance and setting of inode flags Duane Griffin
2008-06-11 0:04 ` [PATCH 1/6] ext2: don't inherit inappropriate inode flags from parent Duane Griffin
2008-06-11 0:04 ` [PATCH 2/6] ext3: " Duane Griffin
2008-06-11 0:04 ` Duane Griffin [this message]
2008-06-11 0:04 ` [PATCH 4/6] ext2: tighten restrictions on inode flags Duane Griffin
2008-06-11 0:04 ` [PATCH 5/6] ext3: " Duane Griffin
2008-06-11 0:04 ` [PATCH 6/6] ext4: " Duane Griffin
2008-06-11 11:31 ` Aneesh Kumar K.V
2008-06-11 11:49 ` Duane Griffin
2008-06-12 19:27 ` Dave Kleikamp
2008-06-12 20:35 ` Duane Griffin
2008-06-12 9:06 ` [PATCH 4/6] ext2: " Andreas Dilger
2008-06-12 9:38 ` Duane Griffin
-- strict thread matches above, loose matches on Subject: below --
2008-06-19 15:41 [PATCH 0/6][v3] ext{2,3,4}: tighten inheritance and setting of " Duane Griffin
2008-06-19 15:42 ` [PATCH 1/6] ext2: don't inherit inappropriate inode flags from parent Duane Griffin
2008-06-19 15:42 ` [PATCH 2/6] ext3: " Duane Griffin
2008-06-19 15:42 ` [PATCH 3/6] ext4: " Duane Griffin
2008-12-03 19:54 [PATCH 0/6][REPOST] ext{2,3,4}: tighten inheritance and setting of inode flags Duane Griffin
2008-12-03 19:54 ` [PATCH 1/6] ext2: don't inherit inappropriate inode flags from parent Duane Griffin
2008-12-03 19:54 ` [PATCH 2/6] ext3: " Duane Griffin
2008-12-03 19:55 ` [PATCH 3/6] ext4: " Duane Griffin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1213142649-32685-4-git-send-email-duaneg@dghda.com \
--to=duaneg@dghda.com \
--cc=adilger@sun.com \
--cc=akpm@linux-foundation.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox