From: Andreas Dilger <adilger@sun.com>
To: Duane Griffin <duaneg@dghda.com>
Cc: akpm@linux-foundation.org, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] ext2: tighten restrictions on inode flags
Date: Thu, 12 Jun 2008 03:06:29 -0600 [thread overview]
Message-ID: <20080612090629.GX3726@webber.adilger.int> (raw)
In-Reply-To: <1213142649-32685-5-git-send-email-duaneg@dghda.com>
On Jun 11, 2008 01:04 +0100, Duane Griffin wrote:
> At the moment there are few restrictions on which flags may be set on which
> inodes. Specifically DIRSYNC may only be set on directories and IMMUTABLE
> and APPEND may not be set on links. Tighten that to disallow TOPDIR being
> set on non-directories and SECRM, UNRM, COMPR, SYNC, DIRTY, COMPRBLK,
> NOCOMP, ECOMPR, INDEX, JOURNAL_DATA and NOTAIL being set on anything but
> regular files or directories.
>
> Introduce a flags masking function which masks flags based on mode and use
> it during inode creation and when flags are set via the ioctl to facilitate
> future consistency.
This second set of patches is missing out on the presence of the
"EXT2_FL_USER_MODIFIABLE" mask in ext2_ioctl(EXT2_IOC_SETFLAGS). This is
what prevents "unsettable" flags from being set from userspace.
I don't have any objection to additional filtering to avoid setting the
USER_MODIFIABLE flags on special files.
Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.
next prev parent reply other threads:[~2008-06-12 9:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-11 0:04 [PATCH 0/6][v2] ext{2,3,4}: tighten inheritance and setting of inode flags Duane Griffin
2008-06-11 0:04 ` [PATCH 1/6] ext2: don't inherit inappropriate inode flags from parent Duane Griffin
2008-06-11 0:04 ` [PATCH 2/6] ext3: " Duane Griffin
2008-06-11 0:04 ` [PATCH 3/6] ext4: " Duane Griffin
2008-06-11 0:04 ` [PATCH 4/6] ext2: tighten restrictions on inode flags Duane Griffin
2008-06-11 0:04 ` [PATCH 5/6] ext3: " Duane Griffin
2008-06-11 0:04 ` [PATCH 6/6] ext4: " Duane Griffin
2008-06-11 11:31 ` Aneesh Kumar K.V
2008-06-11 11:49 ` Duane Griffin
2008-06-12 19:27 ` Dave Kleikamp
2008-06-12 20:35 ` Duane Griffin
2008-06-12 9:06 ` Andreas Dilger [this message]
2008-06-12 9:38 ` [PATCH 4/6] ext2: " Duane Griffin
-- strict thread matches above, loose matches on Subject: below --
2008-06-19 15:41 [PATCH 0/6][v3] ext{2,3,4}: tighten inheritance and setting of " Duane Griffin
2008-06-19 15:42 ` [PATCH 1/6] ext2: don't inherit inappropriate inode flags from parent Duane Griffin
2008-06-19 15:42 ` [PATCH 2/6] ext3: " Duane Griffin
2008-06-19 15:42 ` [PATCH 3/6] ext4: " Duane Griffin
2008-06-19 15:42 ` [PATCH 4/6] ext2: tighten restrictions on inode flags Duane Griffin
2008-12-03 19:54 [PATCH 0/6][REPOST] ext{2,3,4}: tighten inheritance and setting of " Duane Griffin
2008-12-03 19:54 ` [PATCH 1/6] ext2: don't inherit inappropriate inode flags from parent Duane Griffin
2008-12-03 19:54 ` [PATCH 2/6] ext3: " Duane Griffin
2008-12-03 19:55 ` [PATCH 3/6] ext4: " Duane Griffin
2008-12-03 19:55 ` [PATCH 4/6] ext2: tighten restrictions on inode flags Duane Griffin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080612090629.GX3726@webber.adilger.int \
--to=adilger@sun.com \
--cc=akpm@linux-foundation.org \
--cc=duaneg@dghda.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox