public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: Nathan Grennan <jack@cygnusx-1.org>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	linux-ext4@vger.kernel.org
Subject: Re: Ordered mode rewrite patch
Date: Tue, 8 Apr 2008 08:19:37 -0400	[thread overview]
Message-ID: <20080408121937.GA26650@infradead.org> (raw)
In-Reply-To: <20080408121149.GB6901@duck.suse.cz>

On Tue, Apr 08, 2008 at 02:11:49PM +0200, Jan Kara wrote:
> -		} else if (!buffer_mapped(bh) && buffer_dirty(bh)) {
> +		} else if (!buffer_mapped(bh) && buffer_dirty(bh)
> +			   && !wbc->skip_unmapped) {

As mentioned last time unmapped buffer shouldn't happen anymore with
filesystem updated to have a ->page_mkwrite operations.  As you've
included the ext3 patch in yours the above condition shoujldn't git
anymore.


  reply	other threads:[~2008-04-08 12:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-08 12:11 Ordered mode rewrite patch Jan Kara
2008-04-08 12:19 ` Christoph Hellwig [this message]
2008-04-09 14:48   ` Jan Kara
2008-04-08 15:47 ` Josef Bacik
2008-04-08 21:10   ` Jan Kara
2008-04-08 20:12 ` Nathan Grennan
2008-04-08 21:16   ` Jan Kara
2008-04-11 18:42 ` Josef Bacik
2008-04-14 17:47   ` Jan Kara
2008-04-14 17:50     ` Josef Bacik
2008-04-25 14:23 ` Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080408121937.GA26650@infradead.org \
    --to=hch@infradead.org \
    --cc=jack@cygnusx-1.org \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox