public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Jan Kara <jack@suse.cz>
Cc: Nathan Grennan <jack@cygnusx-1.org>, linux-ext4@vger.kernel.org
Subject: Re: Ordered mode rewrite patch
Date: Fri, 25 Apr 2008 11:23:21 -0300	[thread overview]
Message-ID: <20080425142321.GA6843@dmt> (raw)
In-Reply-To: <20080408121149.GB6901@duck.suse.cz>

Hi Jan,

On Tue, Apr 08, 2008 at 02:11:49PM +0200, Jan Kara wrote:
>   Hello,
> 
>   attached is a jumbo patch that reverses locking order of transaction
> start and page lock in ext3 and rewrites handling of ordered data mode in
> JBD and ext3. Note that the patch will break compilation of ext4 and OCFS2.
> The patch survives LTP run on my test machine so it shouldn't eat your data
> immediately but bugs are of course possible...
>   I'm very interested in any results (both positive and negative) you could
> get with it :). Thanks for testing it.
> 
> 									Honza
> 
> PS: CCing also linux-ext4 list in case there are some other interested
> testers. Next on my todo list is to port this for ext4...

No luck for my testcase, similar fsync behaviour taking several seconds:

vim           D 0000000000000000     0  4088   4036
 ffff81017a143da8 0000000000000086 0000000000000000 ffffffff80236808
 ffff81022f272830 ffff81022f1ca730 ffff81022f272a70 0000000600000001
 00000000ffffffff 0000000000000003 0000000000000000 0000000000000000
Call Trace:
 [<ffffffff80236808>] lock_timer_base+0x26/0x4b
 [<ffffffff802f8c00>] log_wait_commit+0x9f/0xed
 [<ffffffff8023f7b1>] autoremove_wake_function+0x0/0x2e
 [<ffffffff802f4dbf>] journal_stop+0x165/0x18d
 [<ffffffff8029a7d9>] __writeback_single_inode+0x17f/0x29d
 [<ffffffff8023f7b1>] autoremove_wake_function+0x0/0x2e
 [<ffffffff8029b10a>] sync_inode+0x24/0x32
 [<ffffffff802e5602>] ext3_sync_file+0x8a/0x9c
 [<ffffffff8029d532>] do_fsync+0x52/0xa4
 [<ffffffff8029d5a7>] __do_fsync+0x23/0x36
 [<ffffffff8020b0ab>] system_call_after_swapgs+0x7b/0x80


      parent reply	other threads:[~2008-04-25 14:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-08 12:11 Ordered mode rewrite patch Jan Kara
2008-04-08 12:19 ` Christoph Hellwig
2008-04-09 14:48   ` Jan Kara
2008-04-08 15:47 ` Josef Bacik
2008-04-08 21:10   ` Jan Kara
2008-04-08 20:12 ` Nathan Grennan
2008-04-08 21:16   ` Jan Kara
2008-04-11 18:42 ` Josef Bacik
2008-04-14 17:47   ` Jan Kara
2008-04-14 17:50     ` Josef Bacik
2008-04-25 14:23 ` Marcelo Tosatti [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080425142321.GA6843@dmt \
    --to=mtosatti@redhat.com \
    --cc=jack@cygnusx-1.org \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox