From: Jan Kara <jack@suse.cz>
To: Nathan Grennan <jack@cygnusx-1.org>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, linux-ext4@vger.kernel.org
Subject: Re: Ordered mode rewrite patch
Date: Tue, 8 Apr 2008 23:16:41 +0200 [thread overview]
Message-ID: <20080408211641.GD21869@duck.suse.cz> (raw)
In-Reply-To: <47FBD1A4.80606@cygnusx-1.org>
On Tue 08-04-08 13:12:20, Nathan Grennan wrote:
> Jan Kara wrote:
>> Hello,
>>
>> attached is a jumbo patch that reverses locking order of transaction
>> start and page lock in ext3 and rewrites handling of ordered data mode in
>> JBD and ext3. Note that the patch will break compilation of ext4 and
>> OCFS2.
>> The patch survives LTP run on my test machine so it shouldn't eat your
>> data
>> immediately but bugs are of course possible...
>> I'm very interested in any results (both positive and negative) you
>> could
>> get with it :). Thanks for testing it.
>>
>> Honza
>>
>> PS: CCing also linux-ext4 list in case there are some other interested
>> testers. Next on my todo list is to port this for ext4...
>>
> I am trying to apply the patch to Fedora 8's kernel-2.6.24.4-64, and it
> fails on all the files.
>
> + '[' '!' -f
> /home/builder/rpmbuild/SOURCES/kernel-2.6.24.4/ext3-jbd-2.6.25-ordered_mode.patch
> ']'
> + case "$patch" in
> + patch -p1 -F1 -s
> 1 out of 26 hunks FAILED -- saving rejects to file fs/ext3/inode.c.rej
> 1 out of 11 hunks FAILED -- saving rejects to file fs/jbd/commit.c.rej
> 1 out of 12 hunks FAILED -- saving rejects to file fs/jbd/transaction.c.rej
> 1 out of 1 hunk FAILED -- saving rejects to file
> include/linux/writeback.h.rej
Hmm, strange so many chunks failed but anyway, the patch is against
recent Linus's git - I think 2.6.25-rc7 will do just fine.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2008-04-08 21:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-08 12:11 Ordered mode rewrite patch Jan Kara
2008-04-08 12:19 ` Christoph Hellwig
2008-04-09 14:48 ` Jan Kara
2008-04-08 15:47 ` Josef Bacik
2008-04-08 21:10 ` Jan Kara
2008-04-08 20:12 ` Nathan Grennan
2008-04-08 21:16 ` Jan Kara [this message]
2008-04-11 18:42 ` Josef Bacik
2008-04-14 17:47 ` Jan Kara
2008-04-14 17:50 ` Josef Bacik
2008-04-25 14:23 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080408211641.GD21869@duck.suse.cz \
--to=jack@suse.cz \
--cc=jack@cygnusx-1.org \
--cc=linux-ext4@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox