Re: Ordered mode rewrite patch

[Jan Kara <jack@suse.cz>]

On Tue 08-04-08 08:19:37, Christoph Hellwig wrote:
> On Tue, Apr 08, 2008 at 02:11:49PM +0200, Jan Kara wrote:
> > -		} else if (!buffer_mapped(bh) && buffer_dirty(bh)) {
> > +		} else if (!buffer_mapped(bh) && buffer_dirty(bh)
> > +			   && !wbc->skip_unmapped) {
> 
> As mentioned last time unmapped buffer shouldn't happen anymore with
> filesystem updated to have a ->page_mkwrite operations.  As you've
> included the ext3 patch in yours the above condition shoujldn't git
> anymore.
  True. I've used wbc->skip_unmapped to detect inside
ext3_ordered_writepage() that we are committing a transaction and therefore
we should not add inode into the running transaction's list. But later
I've realized that we never need to add inode into transaction's list
from ext3_ordered_writepage() once we have ext3_page_mkwrite(). So now I
don't need wbc->skip_unmapped at all and I've compeletely removed it.
Thanks for pointing this out.

								Honza
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR