Re: [RESEND] [PATCH 2/2 v2] e2fsck: Do not forget to discard last block group

[Ted Ts'o <tytso@mit.edu>]

On Fri, Feb 24, 2012 at 09:34:50AM +0100, Lukas Czerner wrote:
> Previously when running e2fsck with '-E discard' argument the end of
> the last group has not been discarded. This patch fixes it so we
> always discard the end of the last group if needed.
> 
> This commit also removes unneeded argument from the
> e2fsck_discard_blocks(). Simultaneously the commit causes the block
> groups with BLOCK_UNINIT flag not to be discarded, which makes
> since because we do not need to reclaim the space since so far
> there has not been written anything.

Let me ask the question Phillip is asking a different way.  What's the
*benefit* in not issuing a discard for blocks in block groups where
the block bitmap is marked as unitialized, as opposed to simply
issuing discard for all blocks that are not marked as in use?  Are you
trying to optimize the amount of time that the storage device spends
processing the trim commands?  Do you think issuing discards on space
that is already discarded will somehow cause more wear on SSD's?

     			       	       	     	  - Ted