Re: [RESEND] [PATCH 2/2 v2] e2fsck: Do not forget to discard last block group

[Ted Ts'o <tytso@mit.edu>]

On Mon, Feb 27, 2012 at 06:57:48PM +0100, Lukas Czerner wrote:
> 
> exactly. I am trying to benefit from the same optimization e2fsck does.
> If the BLOCK_UNINIT is set then we can easily leave that group be and
> save some time. Even though that might not be a huge problem with small
> file systems, or some *really* fast SSD's, you'll certainly notice it on
> huge thin-provisioned storage, or generally any bigger discard capable
> device.

Well, maybe then the right answer is that we make it an option.  There
*are* times when you might want to issue a discard for every single
unused block, even if you think it may have already been discarded.

For example, there are some brain-damaged thin-provisioned storage
boxes that ignore discards that are smaller than 4 megabytes, and then
only discard on 4 megabyte aligned boundaries.  So even though the
space might have been previously discarded, one of the reasons why you
might want e2fsck -E discard to force a discard of the entire block
group is because the space might not have been released if the
previous TRIM commands (perhaps issued as various 1mb files were
deleted) didn't obey whatever arbitrary restrictions that are imposed
by the storage device.

I'll agree that as a default, the optimization might make sense.  But
it would be good if there's a way to really to bypass the optimization
and issue the discard for every single unused block.

    	      	      	  	       - Ted