From: Phillip Susi <psusi@ubuntu.com>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu, sandeen@redhat.com
Subject: Re: [RESEND] [PATCH 2/2 v2] e2fsck: Do not forget to discard last block group
Date: Fri, 24 Feb 2012 10:56:27 -0500 [thread overview]
Message-ID: <4F47B32B.5020006@ubuntu.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1202241550520.13074@dhcp-27-109.brq.redhat.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 2/24/2012 9:57 AM, Lukas Czerner wrote:
>> I do not see how the group would become UNINIT again, so there is
>> not reason to discard it. Previously we could count free block
>> through out several groups (accounting or BLOCK_UNINIT groups as
>> well. We do not do that now, because we discard every group
>> separately.
Simple; delete some files. Once all blocks in the block group are
free again, it can go back to UNINIT. Also the fs may have been
formatted without discard, or moved with dd, or any number of ways
that the bock allocation bitmap could still use a discard despite
being uninitialized.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQEcBAEBAgAGBQJPR7MrAAoJEJrBOlT6nu751oMIAN4YsKxC5XjHOTyif0U4Pffj
x0TCcXW+0BS6bOfwvGq/3DLO9oCJXOh6mCIPxNNJZJ0NQt0t6yLmpnuZIw7AXzJT
+WCxduNxnu9e/bIy1vzKlwcUkzd+lb8XIljEcO9RBDj+3LUFT4YYlCE8yiITze8V
EZiE81U1IJtguhWzqFQmOsJrH0KP5kb7BE36yn5I+yfs5YYc3CyMrqi4SVpdv4gX
/+YoroJCEa89nsk6pluk+uAGPd/gxeSC6w32YjJqaM5bVLpiD6yhKsqIXNQK8HzB
uXNxZvvrHLBBQtp31+r0yy90K3eQmc2ycwn54DKkK+vOioH7Q2AB+s8YTxr/Hq0=
=DOVr
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2012-02-24 15:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 8:34 [RESEND] [PATCH 1/2 v2] e2fsck: Discard only unused parts of inode table Lukas Czerner
2012-02-24 8:34 ` [RESEND] [PATCH 2/2 v2] e2fsck: Do not forget to discard last block group Lukas Czerner
2012-02-24 14:46 ` Phillip Susi
2012-02-24 14:57 ` Lukas Czerner
2012-02-24 15:56 ` Phillip Susi [this message]
2012-02-24 16:13 ` Lukas Czerner
2012-02-24 16:48 ` Phillip Susi
2012-02-27 7:39 ` Lukas Czerner
2012-02-27 16:35 ` Phillip Susi
2012-02-27 17:00 ` Ted Ts'o
2012-02-27 17:57 ` Lukas Czerner
2012-02-27 18:05 ` Ted Ts'o
2012-02-27 18:33 ` Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F47B32B.5020006@ubuntu.com \
--to=psusi@ubuntu.com \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox