From: Phillip Susi <psusi@ubuntu.com>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu, sandeen@redhat.com
Subject: Re: [RESEND] [PATCH 2/2 v2] e2fsck: Do not forget to discard last block group
Date: Fri, 24 Feb 2012 09:46:20 -0500 [thread overview]
Message-ID: <4F47A2BC.50307@ubuntu.com> (raw)
In-Reply-To: <1330072490-26833-2-git-send-email-lczerner@redhat.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 2/24/2012 3:34 AM, Lukas Czerner wrote:
> Previously when running e2fsck with '-E discard' argument the end
> of the last group has not been discarded. This patch fixes it so
> we always discard the end of the last group if needed.
>
> This commit also removes unneeded argument from the
> e2fsck_discard_blocks(). Simultaneously the commit causes the
> block groups with BLOCK_UNINIT flag not to be discarded, which
> makes since because we do not need to reclaim the space since so
> far there has not been written anything.
I don't see where this patch changes anything to do with uninitialized
block bitmaps. It also is still a good idea to discard them since
they may have been initialized at some point in the past and become
uninitialized again.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQEcBAEBAgAGBQJPR6K8AAoJEJrBOlT6nu75Ad8H/A4sfRF7GGqNMpfKOHMOxwE3
gjHAQNP3anFJ8aa5vkHwDEsDPBMSYlOtNWYBSY1DmaBPm0AHyrFUyWN1Q9FtcOp3
bDdsx7SXHa0NIzcguTsjw33Ln+3jiqI3vPk7gJkZyOkRw3JNcmM1MMlu/83Vaeaa
p2uQc8OzNfsuFoN62kkBj502p4/pFhfN1TCFf2EEFgw7HlS0Z4xqx0Mq3JTDJH0u
2GrYMz8ulwuYfRa2WUy5A11Oi/iLFVm0J+mI+gR94Li1zRqnwBaF99TGvEhzB0SF
MS6kykvgPU2D+n2YL9fFChQDLvyyW+zSXxYjgqrrU0DjCjVkycTQ5GsvnKoEu6c=
=FeTy
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2012-02-24 14:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 8:34 [RESEND] [PATCH 1/2 v2] e2fsck: Discard only unused parts of inode table Lukas Czerner
2012-02-24 8:34 ` [RESEND] [PATCH 2/2 v2] e2fsck: Do not forget to discard last block group Lukas Czerner
2012-02-24 14:46 ` Phillip Susi [this message]
2012-02-24 14:57 ` Lukas Czerner
2012-02-24 15:56 ` Phillip Susi
2012-02-24 16:13 ` Lukas Czerner
2012-02-24 16:48 ` Phillip Susi
2012-02-27 7:39 ` Lukas Czerner
2012-02-27 16:35 ` Phillip Susi
2012-02-27 17:00 ` Ted Ts'o
2012-02-27 17:57 ` Lukas Czerner
2012-02-27 18:05 ` Ted Ts'o
2012-02-27 18:33 ` Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F47A2BC.50307@ubuntu.com \
--to=psusi@ubuntu.com \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox