[PATCH] ext4: return error on syncfs after shutdown

[PATCH] ext4: return error on syncfs after shutdown

[Amir Goldstein]

This is the logic behavior and one that we would like to verify
using a generic fstest similar to xfs/546.

Link: https://lore.kernel.org/fstests/20240830152648.GE6216@frogsfrogsfrogs/
Suggested-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---

Ted,

Please see the discussion about moving test xfs/546 to generic.

WDYT?

Thanks,
Amir.

 fs/ext4/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index e72145c4ae5a..b9cf18819e11 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -6279,7 +6279,7 @@ static int ext4_sync_fs(struct super_block *sb, int wait)
 	struct ext4_sb_info *sbi = EXT4_SB(sb);
 
 	if (unlikely(ext4_forced_shutdown(sb)))
-		return 0;
+		return -EIO;
 
 	trace_ext4_sync_fs(sb, wait);
 	flush_workqueue(sbi->rsv_conversion_wq);
-- 
2.34.1

Re: [PATCH] ext4: return error on syncfs after shutdown

[Jan Kara]

On Wed 04-09-24 10:46:57, Amir Goldstein wrote:
> This is the logic behavior and one that we would like to verify
> using a generic fstest similar to xfs/546.
> 
> Link: https://lore.kernel.org/fstests/20240830152648.GE6216@frogsfrogsfrogs/
> Suggested-by: Darrick J. Wong <djwong@kernel.org>
> Signed-off-by: Amir Goldstein <amir73il@gmail.com>

Yeah, makes sense to me. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
> 
> Ted,
> 
> Please see the discussion about moving test xfs/546 to generic.
> 
> WDYT?
> 
> Thanks,
> Amir.
> 
>  fs/ext4/super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index e72145c4ae5a..b9cf18819e11 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -6279,7 +6279,7 @@ static int ext4_sync_fs(struct super_block *sb, int wait)
>  	struct ext4_sb_info *sbi = EXT4_SB(sb);
>  
>  	if (unlikely(ext4_forced_shutdown(sb)))
> -		return 0;
> +		return -EIO;
>  
>  	trace_ext4_sync_fs(sb, wait);
>  	flush_workqueue(sbi->rsv_conversion_wq);
> -- 
> 2.34.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Re: [PATCH] ext4: return error on syncfs after shutdown

[Theodore Ts'o]

On Wed, 04 Sep 2024 10:46:57 +0200, Amir Goldstein wrote:
> This is the logic behavior and one that we would like to verify
> using a generic fstest similar to xfs/546.
> 
> 

Applied, thanks!

[1/1] ext4: return error on syncfs after shutdown
      commit: e80597b47c4a8ed28471cc59acce850f3a401e8c

Best regards,
-- 
Theodore Ts'o <tytso@mit.edu>