* [PATCH] ext4: return error on syncfs after shutdown
@ 2024-09-04 8:46 Amir Goldstein
2024-09-04 10:37 ` Jan Kara
2024-11-07 15:12 ` Theodore Ts'o
0 siblings, 2 replies; 3+ messages in thread
From: Amir Goldstein @ 2024-09-04 8:46 UTC (permalink / raw)
To: Theodore Tso; +Cc: Darrick J . Wong, Jan Kara, Zorro Lang, linux-ext4, fstests
This is the logic behavior and one that we would like to verify
using a generic fstest similar to xfs/546.
Link: https://lore.kernel.org/fstests/20240830152648.GE6216@frogsfrogsfrogs/
Suggested-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
Ted,
Please see the discussion about moving test xfs/546 to generic.
WDYT?
Thanks,
Amir.
fs/ext4/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index e72145c4ae5a..b9cf18819e11 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -6279,7 +6279,7 @@ static int ext4_sync_fs(struct super_block *sb, int wait)
struct ext4_sb_info *sbi = EXT4_SB(sb);
if (unlikely(ext4_forced_shutdown(sb)))
- return 0;
+ return -EIO;
trace_ext4_sync_fs(sb, wait);
flush_workqueue(sbi->rsv_conversion_wq);
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4: return error on syncfs after shutdown
2024-09-04 8:46 [PATCH] ext4: return error on syncfs after shutdown Amir Goldstein
@ 2024-09-04 10:37 ` Jan Kara
2024-11-07 15:12 ` Theodore Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Jan Kara @ 2024-09-04 10:37 UTC (permalink / raw)
To: Amir Goldstein
Cc: Theodore Tso, Darrick J . Wong, Jan Kara, Zorro Lang, linux-ext4,
fstests
On Wed 04-09-24 10:46:57, Amir Goldstein wrote:
> This is the logic behavior and one that we would like to verify
> using a generic fstest similar to xfs/546.
>
> Link: https://lore.kernel.org/fstests/20240830152648.GE6216@frogsfrogsfrogs/
> Suggested-by: Darrick J. Wong <djwong@kernel.org>
> Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Yeah, makes sense to me. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
>
> Ted,
>
> Please see the discussion about moving test xfs/546 to generic.
>
> WDYT?
>
> Thanks,
> Amir.
>
> fs/ext4/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index e72145c4ae5a..b9cf18819e11 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -6279,7 +6279,7 @@ static int ext4_sync_fs(struct super_block *sb, int wait)
> struct ext4_sb_info *sbi = EXT4_SB(sb);
>
> if (unlikely(ext4_forced_shutdown(sb)))
> - return 0;
> + return -EIO;
>
> trace_ext4_sync_fs(sb, wait);
> flush_workqueue(sbi->rsv_conversion_wq);
> --
> 2.34.1
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4: return error on syncfs after shutdown
2024-09-04 8:46 [PATCH] ext4: return error on syncfs after shutdown Amir Goldstein
2024-09-04 10:37 ` Jan Kara
@ 2024-11-07 15:12 ` Theodore Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Theodore Ts'o @ 2024-11-07 15:12 UTC (permalink / raw)
To: Amir Goldstein
Cc: Theodore Ts'o, Darrick J . Wong, Jan Kara, Zorro Lang,
linux-ext4, fstests
On Wed, 04 Sep 2024 10:46:57 +0200, Amir Goldstein wrote:
> This is the logic behavior and one that we would like to verify
> using a generic fstest similar to xfs/546.
>
>
Applied, thanks!
[1/1] ext4: return error on syncfs after shutdown
commit: e80597b47c4a8ed28471cc59acce850f3a401e8c
Best regards,
--
Theodore Ts'o <tytso@mit.edu>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-11-07 15:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-04 8:46 [PATCH] ext4: return error on syncfs after shutdown Amir Goldstein
2024-09-04 10:37 ` Jan Kara
2024-11-07 15:12 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox